TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-18 07:51:55 +03:00
Code Issues Projects Releases Wiki Activity

Fixed updateOffer API method

Browse Source 
no-issue

- Property names were out of sync with API
- Async methods were not awaited
- Transaction was erroneously commited
This commit is contained in:
Fabien O'Carroll 2021-10-06 12:07:03 +02:00
parent 6397438e73
commit dbc7d73be7
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ghost/offers/lib/OffersAPI.js
View File

@ -48,8 +48,8 @@ class OffersAPI {
* @param {object} data
* @param {string} data.id
* @param {string} [data.name]
* @param {string} [data.title]
* @param {string} [data.description]
* @param {string} [data.display_title]
* @param {string} [data.display_description]
* @param {string} [data.code]
*
* @returns {Promise<OfferMapper.OfferDTO>}
@ -62,25 +62,23 @@ class OffersAPI {
const offer = await this.repository.getById(data.id, options);
if (data.name) {
offer.updateName(data.name, uniqueChecker);
await offer.updateName(data.name, uniqueChecker);
}
if (data.code) {
offer.updateCode(data.code, uniqueChecker);
await offer.updateCode(data.code, uniqueChecker);
}
if (data.title) {
offer.displayTitle = data.title;
if (data.display_title) {
offer.displayTitle = data.display_title;
}
if (data.description) {
offer.displayDescription = data.description;
if (data.display_description) {
offer.displayDescription = data.display_description;
}
await this.repository.save(offer, options);
transaction.commit();
return OfferMapper.toDTO(offer);
});
}