TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 14:43:08 +03:00
Code Issues Projects Releases Wiki Activity

Dropped nullable from subscribe events' newsletter id (#14598)

Browse Source 
refs https://github.com/TryGhost/Team/issues/1478

- Depends on https://github.com/TryGhost/Ghost/pull/14597
- Column shouldn't be nullable now it is filled correctly
This commit is contained in:
Simon Backx 2022-04-27 17:52:31 +02:00 committed by GitHub
parent d05c6f84ca
commit dc12e6490a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/server/data/migrations/versions/4.46/2022-04-27-08-16-drop-nullable-subscribe-event-newsletter-id.js Normal file
View File

@ -0,0 +1,3 @@
const {createDropNullableMigration} = require('../../utils');
module.exports = createDropNullableMigration('members_subscribe_events', 'newsletter_id');

2
core/server/data/schema/schema.js
View File

@ -601,7 +601,7 @@ module.exports = {
subscribed: {type: 'bool', nullable: false, defaultTo: true},
created_at: {type: 'dateTime', nullable: false},
source: {type: 'string', maxlength: 50, nullable: true},
newsletter_id: {type: 'string', maxlength: 24, nullable: true, references: 'newsletters.id', cascadeDelete: false}
newsletter_id: {type: 'string', maxlength: 24, nullable: false, references: 'newsletters.id', cascadeDelete: false}
},
stripe_products: {
id: {type: 'string', maxlength: 24, nullable: false, primary: true},

2
test/unit/server/data/schema/integrity.test.js
View File

@ -35,7 +35,7 @@ const validateRouteSettings = require('../../../../../core/server/services/route
*/
describe('DB version integrity', function () {
// Only these variables should need updating
const currentSchemaHash = 'cad4a9890ab928de593e4c682a2cd326';
const currentSchemaHash = '2524eac55c153eca7ee300e094fbd3fe';
const currentFixturesHash = '4924616fbc51dd0ccef62ae04b4708f9';
const currentSettingsHash = 'ffd899a82b0ad2886e92d8244bcbca6a';
const currentRoutesHash = '3d180d52c663d173a6be791ef411ed01';