Added Tips&Donations link to portal links (#17580)

refs https://github.com/TryGhost/Product/issues/3677

- Added Tips&Donations link to Portal links in Membership settings for
easy access
- Updated other links to pass `no-action` lint rule

---------

Co-authored-by: Sag <guptazy@gmail.com>
This commit is contained in:
Djordje Vlaisavljevic 2023-08-04 15:15:57 +01:00 committed by GitHub
parent 356256067c
commit dce2e68c9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 77 additions and 13 deletions

View File

@ -572,3 +572,16 @@ add|ember-template-lint|require-input-label|10|12|10|12|8c3c0ea315ff4da828363989
remove|ember-template-lint|no-invalid-interactive|3|4|3|4|1fcf990141becf2a97482e17ba7205413916e11d|1688342400000|1698714000000|1703898000000|app/components/gh-editor-feature-image.hbs
remove|ember-template-lint|require-input-label|61|20|61|20|213bf91395d670b2af5fc667fca46d3d20238465|1688342400000|1698714000000|1703898000000|app/components/gh-editor-feature-image.hbs
remove|ember-template-lint|require-valid-alt-text|47|16|47|16|079fc89fa5c7c47f6b0b219820cdda3819c44e26|1688342400000|1698714000000|1703898000000|app/components/gh-editor-feature-image.hbs
remove|ember-template-lint|no-action|47|46|47|46|317b0cce151252b8cb54fb112fef62cf3c285ad7|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|82|46|82|46|0b06c9d99b2e88f3e5c134fa9452f3a3ee107649|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|114|46|114|46|542d2c922b1ddd938aabf03ce17fe33053749ec7|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|172|50|172|50|884d0df74365d794c99bb098e72dc267bd0fbc46|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|204|50|204|50|b51c80e0c3de828988f74017ab7e383552f48648|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|236|50|236|50|7f4e772017b88e0a2f39ecf899f0c506639bc675|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|269|50|269|50|eca87a98b0e8ad5a623de88a16aadedc9591ac22|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|301|50|301|50|e877a0feccc071327b56a0d7b8a8fcb84ee6d840|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|333|50|333|50|7f4e772017b88e0a2f39ecf899f0c506639bc675|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|369|46|369|46|1d7de8deaee7bfe5bd051e900e98817fedabc529|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|401|46|401|46|df19e5858021b80de54052c953e70e3b4606a8f5|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|433|46|433|46|3afa41e4d86dd7e5c049a762f0f761c2464a5f96|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs
remove|ember-template-lint|no-action|465|46|465|46|f2f0f3f512f141fdd821333c873f5052813bb491|1688342400000|1698714000000|1703898000000|app/components/gh-portal-links.hbs

View File

@ -44,7 +44,8 @@
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink '')}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) '')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice ""))}}
@ -79,7 +80,8 @@
aria-label="Sign in Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "signin")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'signin')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signin"))}}
@ -111,7 +113,8 @@
aria-label="Sign up Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "signup")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'signup')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup"))}}
@ -169,7 +172,8 @@
aria-label="Monthly sign up Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyTierSignupLink "monthly")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyTierSignupLink) 'monthly')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyTierSignupLink.isRunning (eq this.copiedSignupInterval "monthly"))}}
@ -201,7 +205,8 @@
aria-label="Yearly sign up Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyTierSignupLink "yearly")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyTierSignupLink) 'yearly')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyTierSignupLink.isRunning (eq this.copiedSignupInterval "yearly"))}}
@ -233,7 +238,8 @@
aria-label="Free sign up Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "signup/free")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'signup/free')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/free"))}}
@ -266,7 +272,8 @@
aria-label="Monthly sign up Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "signup/monthly")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'signup/monthly')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/monthly"))}}
@ -298,7 +305,8 @@
aria-label="Yearly sign up Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "signup/yearly")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'signup/yearly')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/yearly"))}}
@ -330,7 +338,8 @@
aria-label="Free sign up Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "signup/free")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'signup/free')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/free"))}}
@ -343,6 +352,44 @@
</td>
</tr>
{{/if}}
{{#if (feature "tipsAndDonations")}}
<tr>
<td colspan="2"><hr class="gh-portal-links-group-divider" /></td>
</tr>
<tr>
<td class='pagename'>Tips & donations</td>
<td class='page-url'>
<div class="gh-portal-page-url-container">
{{#if this.isLink}}
<input class="gh-input page-url-field"
type="text"
data-test-input="portal-tier-link-support"
value="{{this.siteUrl}}/#/portal/support"
disabled="true"
aria-label="Tips & donations Portal link">
{{else}}
<input class="gh-input page-url-field"
type="text"
data-test-input="portal-tier-data-attr-support"
value='data-portal="support"'
disabled="true"
aria-label="Tips & donations data attribute">
{{/if}}
<button
type="button" {{on "click" (fn (perform this.copyStaticLink) 'support')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "support"))}}
{{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
{{else}}
<span data-tooltip="Copy">{{svg-jar "copy" class="w4 v-mid fill-darkgrey"}}</span>
{{/if}}
</button>
</div>
</td>
</tr>
{{/if}}
<tr>
<td colspan="2"><hr class="gh-portal-links-group-divider" /></td>
</tr>
@ -366,7 +413,8 @@
aria-label="Account Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "account")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'account')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "account"))}}
@ -398,7 +446,8 @@
aria-label="Account/Plans Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "account/plans")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'account/plans')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "account/plans"))}}
@ -430,7 +479,8 @@
aria-label="Account/Profile Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "account/profile")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'account/profile')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "account/profile"))}}
@ -462,7 +512,8 @@
aria-label="Account/Newsletters Portal data attribute">
{{/if}}
<button
type="button" {{action (perform this.copyStaticLink "account/newsletters")}} class="gh-portal-setting-copy"
type="button" {{on "click" (fn (perform this.copyStaticLink) 'account/newsletters')}}
class="gh-portal-setting-copy"
data-test-button="copy-url-attr"
>
{{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "account/newsletters"))}}