TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity

Fixed errors in publish flow for users who don't have email permission

Browse Source 
no issue

- roles that don't have email permissions also don't have permissions to read newsletters so we shouldn't attempt to fetch any during PublishOptions setup
This commit is contained in:
Kevin Ansfield 2022-05-11 21:05:31 +01:00
parent 6c079daafa
commit e1c7360075
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ghost/admin/app/utils/publish-options.js
View File

@ -239,26 +239,30 @@ export default class PublishOptions {
@task
*fetchRequiredDataTask() {
// total # of members - used to enable/disable email
let countTotalMembers = Promise.resolve();
const promises = [];
// only Admins/Owners have permission to browse members and get a count
// total # of members - used to enable/disable email
// Only Admins/Owners have permission to browse members and get a count
// for Editors/Authors set member count to 1 so email isn't disabled for not having any members
if (this.user.isAdmin) {
countTotalMembers = this.store.query('member', {limit: 1}).then((res) => {
promises.push(this.store.query('member', {limit: 1}).then((res) => {
this.totalMemberCount = res.meta.pagination.total;
});
}));
} else {
this.totalMemberCount = 1;
}
// only perform limit checks and newsletter fetches if the
// current user is allowed to email, otherwise we can hit API
// permission errors
if (this.user.canEmail) {
// email limits
const checkSendingLimit = this._checkSendingLimit();
promises.push(this._checkSendingLimit());
// newsletters
const fetchNewsletters = this.store.query('newsletter', {status: 'active', limit: 'all', include: 'count.members'});
promises.push(this.store.query('newsletter', {status: 'active', limit: 'all', include: 'count.members'}));
}
yield Promise.all([countTotalMembers, checkSendingLimit, fetchNewsletters]);
yield Promise.all(promises);
}
// saving ------------------------------------------------------------------