TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-23 22:11:09 +03:00
Code Issues Projects Releases Wiki Activity

🐛 Fixed External Image URLs being incorrectly prefixed (#20226)

Browse Source 
ref ENG-824

- the bug is causing resize prefixes being added to images served from
outside of Ghost.
- this now would only append the prefex to images served by Ghost and
other images urls' would get served as is.
- we can determine that by checking whether imageName doesn't exist,
meaning the source is a third party.
- this mostly affect edge case users, eg where a feature image url was
passed in via the API and doesn't get served by Ghost.
This commit is contained in:
Ronald Langeveld 2024-05-20 18:06:03 +08:00 committed by GitHub
parent a4dc6c5cf6
commit e5056d8d9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 49 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ghost/core/core/frontend/utils/images.js
View File

@ -92,6 +92,10 @@ module.exports.getImageWithSize = function getImageWithSize(imagePath, sizeOptio
const sizeDirectoryName = prefixIfPresent('w', width) + prefixIfPresent('h', height);
const formatPrefix = requestedFormat && imageTransform.canTransformToFormat(requestedFormat) ? `/format/${requestedFormat}` : '';
if (!imageName) {
return imgBlogUrl;
}
return [imgBlogUrl, urlUtils.STATIC_IMAGE_URL_PREFIX, `/size/${sizeDirectoryName}`, formatPrefix, imageName].join('');
};

45
ghost/core/test/unit/frontend/meta/image-dimensions.test.js
View File

@ -282,4 +282,49 @@ describe('getImageDimensions', function () {
done();
}).catch(done);
});
it('does not append image size prefix to external images', function (done) {
const originalMetaData = {
coverImage: {
url: 'http://anothersite.com/some/storage/mypostcoverimage.jpg'
},
authorImage: {
url: 'http://anothersite.com/some/storage/me.jpg'
},
ogImage: {
url: 'http://anothersite.com/some/storage/super-facebook-image.jpg'
},
twitterImage: 'http://anothersite.com/some/storage/super-twitter-image.jpg',
site: {
logo: {
url: 'http://anothersite.com/some/storage/logo.jpg'
}
}
};
const metaData = _.cloneDeep(originalMetaData);
sizeOfStub.callsFake(() => ({
width: 2000,
height: 1200,
type: 'jpg'
}));
getImageDimensions.__set__('imageSizeCache', {
getCachedImageSizeFromUrl: sizeOfStub
});
getImageDimensions(metaData).then(function (result) {
should.exist(result);
result.coverImage.should.have.property('url');
result.coverImage.url.should.eql('http://anothersite.com/some/storage/mypostcoverimage.jpg');
result.authorImage.should.have.property('url');
result.authorImage.url.should.eql('http://anothersite.com/some/storage/me.jpg');
result.ogImage.should.have.property('url');
result.ogImage.url.should.eql('http://anothersite.com/some/storage/super-facebook-image.jpg');
result.site.logo.should.have.property('url');
result.site.logo.url.should.eql('http://anothersite.com/some/storage/logo.jpg');
done();
}).catch(done);
});
});