From e65d335c76aa2bd0832a041bdf647dbe6368c018 Mon Sep 17 00:00:00 2001 From: Fabien 'egg' O'Carroll Date: Thu, 5 May 2022 15:01:22 +0100 Subject: [PATCH] Fixed types for migration utils (#14709) `import('knex')` does not refer to the type of an instantiated Knex instance. --- core/server/data/migrations/utils.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/core/server/data/migrations/utils.js b/core/server/data/migrations/utils.js index 55b0c90fad..052b1243d3 100644 --- a/core/server/data/migrations/utils.js +++ b/core/server/data/migrations/utils.js @@ -274,8 +274,8 @@ function addPermissionWithRoles(config, roles) { } /** - * @param {(connection: import('knex')) => Promise} up - * @param {(connection: import('knex')) => Promise} down + * @param {(connection: import('knex').Knex) => Promise} up + * @param {(connection: import('knex').Knex) => Promise} down * * @returns {Migration} */ @@ -294,7 +294,7 @@ function createNonTransactionalMigration(up, down) { } /** - * @param {(connection: import('knex')) => Promise} up + * @param {(connection: import('knex').Knex) => Promise} up * * @returns {Migration} */ @@ -313,8 +313,8 @@ function createIrreversibleMigration(up) { } /** - * @param {(connection: import('knex')) => Promise} up - * @param {(connection: import('knex')) => Promise} down + * @param {(connection: import('knex').Knex) => Promise} up + * @param {(connection: import('knex').Knex) => Promise} down * * @returns {Migration} */ @@ -601,7 +601,7 @@ module.exports = { /** * @typedef {Object} TransactionalMigrationFunctionOptions * - * @prop {import('knex')} transacting + * @prop {import('knex').Knex} transacting */ /**