From ef50c6a14905782e95e023f54ea008000ca2b70c Mon Sep 17 00:00:00 2001 From: kirrg001 Date: Tue, 13 Sep 2016 22:13:52 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20=20=F0=9F=94=A6=20=20theme=20url?= =?UTF-8?q?=20is=20no=20longer=20defined=20in=20config?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit refs #6982 - it's for now defined where all theme properties get set: in api/settings.js - it's not the best place, but for now the place where i think it makes the most sense - see https://github.com/TryGhost/Ghost/blob/playground/core/server/api/settings.js#L63 [ci skip] --- core/test/unit/config_spec.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/core/test/unit/config_spec.js b/core/test/unit/config_spec.js index eee9119cb9..de59ccb18a 100644 --- a/core/test/unit/config_spec.js +++ b/core/test/unit/config_spec.js @@ -47,14 +47,13 @@ describe('Config', function () { var themeConfig = config.get('theme'); // This will fail if there are any extra keys - themeConfig.should.have.keys('url', 'title', 'description', 'logo', 'cover', 'timezone'); + themeConfig.should.have.keys('title', 'description', 'logo', 'cover', 'timezone'); }); it('should have the correct values for each key', function () { var themeConfig = config.get('theme'); // Check values are as we expect - themeConfig.should.have.property('url', 'http://my-ghost-blog.com'); themeConfig.should.have.property('title', 'casper'); themeConfig.should.have.property('description', 'casper'); themeConfig.should.have.property('logo', 'casper'); @@ -69,7 +68,6 @@ describe('Config', function () { // Check values are as we expect themeConfig.should.have.property('timezone', 'Etc/UTC'); - themeConfig.should.have.property('url'); configUtils.set({ theme: { @@ -77,8 +75,7 @@ describe('Config', function () { } }); - config.theme.should.have.property('timezone', 'Africa/Cairo'); - config.theme.should.have.property('url'); + config.get('theme').should.have.property('timezone', 'Africa/Cairo'); }); it('should set theme object with timezone by default', function () { @@ -87,7 +84,6 @@ describe('Config', function () { // Check values are as we expect themeConfig.should.have.property('theme'); themeConfig.theme.should.have.property('timezone', 'Etc/UTC'); - themeConfig.theme.should.have.property('url'); }); });