TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-01 23:37:43 +03:00
Code Issues Projects Releases Wiki Activity

✨ Added post feature image alt and caption support to editor (#2026)

Browse Source 
refs https://github.com/TryGhost/Team/issues/839

The feature image uploader in the post settings menu did not lend itself well to having additional fields so we've moved it into the main editor canvas. This allowed us to use the familiar caption/alt fields from image cards and to let the feature image feel more connected to the post's contents and part of the editing workflow.

---

- removed `featureImageMeta` labs flag
This commit is contained in:
Kevin Ansfield 2021-07-01 17:56:39 +01:00 committed by GitHub
parent 335a78555e
commit f752e24f7a
5 changed files with 10 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ghost/admin/app/components/gh-koenig-editor.hbs
View File

@ -5,18 +5,16 @@
{{on "mousedown" this.trackMousedown}}
{{on "mouseup" this.focusEditor}}
>
{{#if (feature "featureImageMeta")}}
<GhEditorFeatureImage
@image={{@featureImage}}
@updateImage={{@setFeatureImage}}
@clearImage={{@clearFeatureImage}}
@alt={{@featureImageAlt}}
@updateAlt={{@setFeatureImageAlt}}
@caption={{@featureImageCaption}}
@updateCaption={{@setFeatureImageCaption}}
@forceButtonDisplay={{or this.titleIsHovered this.titleIsFocused}}
/>
{{/if}}
<GhEditorFeatureImage
@image={{@featureImage}}
@updateImage={{@setFeatureImage}}
@clearImage={{@clearFeatureImage}}
@alt={{@featureImageAlt}}
@updateAlt={{@setFeatureImageAlt}}
@caption={{@featureImageCaption}}
@updateCaption={{@setFeatureImageCaption}}
@forceButtonDisplay={{or this.titleIsHovered this.titleIsFocused}}
/>
<GhTextarea
@class="gh-editor-title"

9
ghost/admin/app/components/gh-post-settings-menu-labs.hbs
View File

@ -9,15 +9,6 @@
<h4>{{capitalize this.post.displayName}} settings</h4>
</div>
<div class="settings-menu-content labs">
{{#unless (feature "featureImageMeta")}}
<GhImageUploaderWithPreview
@image={{this.post.featureImage}}
@text={{concat "Upload " this.post.displayName " image"}}
@allowUnsplash={{true}}
@update={{action "setCoverImage"}}
@remove={{action "clearCoverImage"}}
/>
{{/unless}}
<form>
<div class="form-group">
<label for="url">{{capitalize this.post.displayName}} URL</label>

9
ghost/admin/app/components/gh-post-settings-menu.hbs
View File

@ -8,15 +8,6 @@
</button>
</div>
<div class="settings-menu-content">
{{#unless (feature "featureImageMeta")}}
<GhImageUploaderWithPreview
@image={{this.post.featureImage}}
@text={{concat "Upload " this.post.displayName " image"}}
@allowUnsplash={{true}}
@update={{action "setCoverImage"}}
@remove={{action "clearCoverImage"}}
/>
{{/unless}}
<form>
<div class="form-group">
<label for="url">{{capitalize this.post.displayName}} URL</label>

1
ghost/admin/app/services/feature.js
View File

@ -55,7 +55,6 @@ export default Service.extend({
launchComplete: feature('launchComplete', {user: true}),
matchHelper: feature('matchHelper'),
multipleProducts: feature('multipleProducts', {developer: true}),
featureImageMeta: feature('featureImageMeta', {developer: true}),
psmRedesign: feature('psmRedesign', {developer: true}),
_user: null,

13
ghost/admin/app/templates/settings/labs.hbs
View File

@ -267,19 +267,6 @@
</div>
</div>
</div>
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>
<h4 class="gh-expandable-title">Feature image redesign with caption support</h4>
<p class="gh-expandable-description">
Moves feature image uploader to top of editor screen and adds alt/caption input.
</p>
</div>
<div class="for-switch">
<GhFeatureFlag @flag="featureImageMeta" />
</div>
</div>
</div>
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>