TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 22:43:30 +03:00
Code Issues Projects Releases Wiki Activity

🐛 Fixed "Cannot destructure property" error when overwriting active theme

Browse Source 
refs https://github.com/TryGhost/action-deploy-theme/issues/45

- added missing `throw error` in the `setFromZip()` catch which was hiding the underlying error when a theme uploaded and saved successfully but other code had failed
- fixed incorrect method name `activator.activateFromOverride` -> `activator.activateFromAPIOverride`
This commit is contained in:
Kevin Ansfield 2021-07-09 19:27:49 +01:00 committed by Sam Lord
parent fa231a1995
commit f9a3f7d955
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/server/services/themes/storage.js
View File

@ -81,7 +81,7 @@ module.exports = {
// CASE: if this is the active theme, we are overriding
if (overrideTheme) {
debug('setFromZip Theme is active alreadu');
activator.activateFromOverride(themeName, loadedTheme, checkedTheme);
activator.activateFromAPIOverride(themeName, loadedTheme, checkedTheme);
}
// @TODO: unify the name across gscan and Ghost!
@ -98,6 +98,8 @@ module.exports = {
throw error;
});
}
throw error;
});
}