Refined all sources list on dashboard

refs https://github.com/orgs/TryGhost/projects/77

- shows single selected column on the all referrer sources list in dashboard
This commit is contained in:
Rishabh 2022-09-29 23:47:12 +05:30
parent 5eae093b3c
commit fa2292806a
2 changed files with 21 additions and 14 deletions

View File

@ -7,10 +7,12 @@
<div class="modal-body pa"> <div class="modal-body pa">
<div> <div>
<div class="gh-dashboard-list-header"> <div class="gh-dashboard-list-header">
<div class="gh-dashboard-list-title">Sources</div> {{#if (eq @data.sortColumn "signups")}} <div class="gh-dashboard-list-title">Sources</div> {{/if}}
<div class="gh-dashboard-list-title">Free signups</div> <div class="gh-dashboard-list-title">Free signups</div>
{{#if this.membersUtils.paidMembersEnabled}} {{#if (eq @data.sortColumn "paid")}}
<div class="gh-dashboard-list-title"><span class="hide-when-small">Paid </span>Conversions</div> {{#if this.membersUtils.paidMembersEnabled}}
<div class="gh-dashboard-list-title"><span class="hide-when-small">Paid </span>Conversions</div>
{{/if}}
{{/if}} {{/if}}
</div> </div>
<div class="gh-dashboard-list-body"> <div class="gh-dashboard-list-body">
@ -20,6 +22,7 @@
<div class="gh-dashboard-list-item-sub gh-dashboard-list-item-sub-source"> <div class="gh-dashboard-list-item-sub gh-dashboard-list-item-sub-source">
<span class="gh-dashboard-list-text">{{sourceData.source}}</span> <span class="gh-dashboard-list-text">{{sourceData.source}}</span>
</div> </div>
{{#if (eq @data.sortColumn "signups")}}
<div class="gh-dashboard-list-item-sub"> <div class="gh-dashboard-list-item-sub">
<span class="gh-dashboard-metric-minivalue"> <span class="gh-dashboard-metric-minivalue">
{{#if sourceData.signups}} {{#if sourceData.signups}}
@ -29,16 +32,19 @@
{{/if}} {{/if}}
</span> </span>
</div> </div>
{{#if this.membersUtils.paidMembersEnabled}} {{/if}}
<div class="gh-dashboard-list-item-sub"> {{#if (eq @data.sortColumn "paid")}}
<span class="gh-dashboard-metric-minivalue"> {{#if this.membersUtils.paidMembersEnabled}}
{{#if sourceData.paidConversions}} <div class="gh-dashboard-list-item-sub">
{{format-number sourceData.paidConversions}} <span class="gh-dashboard-metric-minivalue">
{{else}} {{#if sourceData.paidConversions}}
&mdash; {{format-number sourceData.paidConversions}}
{{/if}} {{else}}
</span> &mdash;
</div> {{/if}}
</span>
</div>
{{/if}}
{{/if}} {{/if}}
</div> </div>
{{else}} {{else}}

View File

@ -13,7 +13,8 @@ export default class SourceAttributionTable extends Component {
const allSources = this.unavailableSource ? [...this.sortedSources, this.unavailableSource] : this.sortedSources; const allSources = this.unavailableSource ? [...this.sortedSources, this.unavailableSource] : this.sortedSources;
this.modals.open(AllSourcesModal, { this.modals.open(AllSourcesModal, {
sources: allSources sources: allSources,
sortColumn: this.args.sortColumn
}); });
} }