TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-13 01:17:27 +03:00
Code Issues Projects Releases Wiki Activity

Fixed linting error

Browse Source 
- trying to call new RequestNotAcceptableError with a variable triggers a lint warning in newer versions of eslint-plugin-ghost
- this workaround is worth it for the safety of not allowing single strings to be passed in!
This commit is contained in:
Hannah Wolfe 2022-05-02 13:46:23 +01:00
parent a6e204b829
commit fc9e61ff35
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ghost/mw-error-handler/lib/mw-error-handler.js
View File

@ -129,7 +129,8 @@ const jsonErrorRendererV2 = (err, req, res, next) => { // eslint-disable-line no
property: err.property || null,
help: err.help || null,
code: err.code || null,
id: err.id || null
id: err.id || null,
ghostErrorCode: err.ghostErrorCode || null
}]
});
};
@ -193,9 +194,9 @@ module.exports.resourceNotFound = (req, res, next) => {
semver.coerce(res.locals.safeVersion)
);
let errorOptions;
let notAcceptableError;
if (versionComparison === 1) {
errorOptions = {
notAcceptableError = new errors.RequestNotAcceptableError({
message: tpl(
messages.methodNotAcceptableVersionAhead.message
),
@ -205,9 +206,9 @@ module.exports.resourceNotFound = (req, res, next) => {
}),
help: tpl(messages.methodNotAcceptableVersionAhead.help),
code: 'UPDATE_GHOST'
};
});
} else {
errorOptions = {
notAcceptableError = new errors.RequestNotAcceptableError({
message: tpl(
messages.methodNotAcceptableVersionBehind.message
),
@ -217,10 +218,10 @@ module.exports.resourceNotFound = (req, res, next) => {
}),
help: tpl(messages.methodNotAcceptableVersionBehind.help),
code: 'UPDATE_CLIENT'
};
});
}
next(new errors.RequestNotAcceptableError(errorOptions));
next(notAcceptableError);
} else {
next(new errors.NotFoundError({message: tpl(messages.resourceNotFound)}));
}
@ -267,4 +268,3 @@ module.exports.handleHTMLResponse = sentry => [
// Format the stack for the user
module.exports.prepareStack
];