TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 11:55:03 +03:00
Code Issues Projects Releases Wiki Activity

Added scroll-into-view behavior for highlighted gifs

Browse Source 
refs https://github.com/TryGhost/Team/issues/1225

- added `scroll-into-view` modifier that will scroll an element into view putting it at the top or bottom of the viewport depending on which direction scroll is required
- used the `scroll-into-view` modifier to scroll the highlighted gif into view
This commit is contained in:
Kevin Ansfield 2021-11-29 19:33:35 +00:00
parent 66e6502cd2
commit fccfcc3320
3 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ghost/admin/app/modifiers/scroll-into-view.js Normal file
View File

@ -0,0 +1,21 @@
import getScrollParent from 'ghost-admin/utils/get-scroll-parent';
import {modifier} from 'ember-modifier';
export default modifier((element, [shouldScroll = true], {offset = 0}) => {
if (shouldScroll) {
const scrollParent = getScrollParent(element);
const isOffTop = element.offsetTop < scrollParent.scrollTop;
const isOffBottom = scrollParent.scrollTop + scrollParent.offsetHeight < element.offsetTop + element.offsetHeight;
if (isOffTop) {
const top = element.offsetTop - offset;
scrollParent.scrollTo({top, behavior: 'smooth'});
}
if (isOffBottom) {
const top = element.offsetTop - scrollParent.offsetHeight + element.offsetHeight + offset;
scrollParent.scrollTo({top, behavior: 'smooth'});
}
}
});

3
ghost/admin/lib/koenig-editor/addon/components/koenig-card-image/selector-tenor.hbs
View File

@ -32,7 +32,8 @@
<KoenigCardImage::SelectorTenor::Gif
@gif={{gif}}
@select={{fn this.select gif}}
@isHighlighted={{eq gif this.highlightedGif}} />
@isHighlighted={{eq gif this.highlightedGif}}
{{scroll-into-view (eq gif this.highlightedGif) offset=20}} />
{{/each}}
</div>
{{/each}}

2
ghost/admin/lib/koenig-editor/addon/components/koenig-card-image/selector-tenor/gif.hbs
View File

@ -1,4 +1,4 @@
<a class="gh-tenor-gif {{if @isHighlighted "gh-tenor-gif-highlighted"}}" href="#" {{on "click" @select}} data-test-tenor-gif={{@gif.id}} style={{this.style}}>
<a class="gh-tenor-gif {{if @isHighlighted "gh-tenor-gif-highlighted"}}" href="#" {{on "click" @select}} data-test-tenor-gif={{@gif.id}} style={{this.style}} ...attributes>
<div class="gh-unsplash-photo-container" style={{this.containerStyle}} data-test-tenor-gif-container>
<img src={{this.imageUrl}} alt={{@gif.description}} width={{this.width}} height={{this.height}} data-test-tenor-gif-image />
</div>