TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 14:43:08 +03:00
Code Issues Projects Releases Wiki Activity

Fixed flaky announcement test for Admin X (#18130)

Browse Source 
no issue

- Attempts to resolve a flaky test.
---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 1a7d420</samp>

Refactor announcement bar preview test to use a helper function for
checking text in iframes. This improves code quality and readability.
This commit is contained in:
Ronald Langeveld 2023-09-14 14:28:05 +07:00 committed by GitHub
parent a9f9f6121a
commit fd4c3d1e53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
apps/admin-x-settings/test/e2e/site/announcementbar.test.ts
View File

@ -24,41 +24,35 @@ test.describe('Announcement Bar', async () => {
await section.getByRole('button', {name: 'Customize'}).click();
// // Homepage and post preview
await page.waitForSelector('[data-testid="announcement-bar-preview-iframe"]');
const iframeCount = await page.$$eval('[data-testid="announcement-bar-preview-iframe"] > iframe', frames => frames.length);
expect(iframeCount).toEqual(2);
const checkTextInIframes = async (iframesHandles, textToSearch) => {
let textExists = false;
for (const iframeHandle of iframesHandles) {
const frame = await iframeHandle.contentFrame();
const textFound = await frame?.$eval('body', (body, text) => {
return body.innerText.includes(text);
}, textToSearch);
if (textFound) {
textExists = true;
break;
}
}
return textExists;
};
const iframesHandleHome = await page.$$('[data-testid="announcement-bar-preview-iframe"] > iframe');
const textExistsInHomeIframes = await checkTextInIframes(iframesHandleHome, 'homepage preview');
expect(textExistsInHomeIframes).toBeTruthy();
const modal = page.getByTestId('announcement-bar-modal');
await page.waitForSelector('[data-testid="announcement-bar-preview-iframe"]');
// Get the iframes inside the modal
const iframesHandleHome = await page.$$('[data-testid="announcement-bar-preview-iframe"] > iframe');
const homeiframeHandler = iframesHandleHome[1]; // index 1 since that's the visible iframe
const frameHome = await homeiframeHandler.contentFrame();
const textExistsInFirstIframe = await frameHome?.$eval('body', (body, textToSearch) => {
return body.innerText.includes(textToSearch);
}, 'homepage preview');
expect(textExistsInFirstIframe).toBeTruthy();
await modal.getByTestId('design-toolbar').getByRole('tab', {name: 'Post'}).click();
await page.waitForSelector('[data-testid="announcement-bar-preview-iframe"]');
const iframesHandlePost = await page.$$('[data-testid="announcement-bar-preview-iframe"] > iframe');
const postiframeHandler = iframesHandlePost[0]; // index 0 since that's the visible iframe
const framePost = await postiframeHandler.contentFrame();
const textExistsInSecondIframe = await framePost?.$eval('body', (body, textToSearch) => {
return body.innerText.includes(textToSearch);
}, 'post preview');
expect(textExistsInSecondIframe).toBeTruthy();
const textExistsInPostIframes = await checkTextInIframes(iframesHandlePost, 'post preview');
expect(textExistsInPostIframes).toBeTruthy();
});
// TODO - lexical isn't loading in the preview