1
0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-23 10:53:34 +03:00
Commit Graph

9 Commits

Author SHA1 Message Date
Fabien "egg" O'Carroll
104f84f252 Added eslint rule for file naming convention
As discussed with the product team we want to enforce kebab-case file names for
all files, with the exception of files which export a single class, in which
case they should be PascalCase and reflect the class which they export.

This will help find classes faster, and should push better naming for them too.

Some files and packages have been excluded from this linting, specifically when
a library or framework depends on the naming of a file for the functionality
e.g. Ember, knex-migrator, adapter-manager
2023-05-09 12:34:34 -04:00
Fabien 'egg' O'Carroll
35bc5fa08a
Fixed no-shadow lint warnings ()
We're planning to change this from a warning to an error and need to
clean the codebase up before we do so.

In all of these cases the shadowing was known about and was not
causing unexpected behaviour, so the refactor consists entirely of
renaming, rather than refactoring/bug fixes.
2022-10-03 15:50:28 +01:00
Rishabh Garg
45a301277d
Updated empty referrer source to null ()
refs https://github.com/TryGhost/Team/issues/1939

- changes empty referrer source to null instead of explicit `Unavailable` in API
- makes it easier for clients/frontend to ignore empty referrers
2022-09-22 20:58:45 +05:30
Rishabh Garg
b048b02f67
Added new referrer source stats API ()
closes https://github.com/TryGhost/Team/issues/1939

- adds new endpoint that returns count of referrer sources by date for admin dashboard
2022-09-22 16:34:26 +05:30
Simon Backx
9c90379892 Fixed tests not working in timezones other than UTC 2022-07-13 12:26:02 +02:00
Simon Backx
51e3b0ac11 Added separate signups and cancellations to subscriptions stats
refs https://github.com/TryGhost/Team/issues/1673

- We don't want to show updated subscriptions in the dashboard
- We need to send add fields to accomplish this
- Includes updated tests
2022-07-13 12:20:50 +02:00
Fabien 'egg' O'Carroll
c56f281b26 Added missing positive_delta for subscription reactivations ()
* Added breaking test for canceled and reactivated events
* Added missing positive_delta for subscription reactivations
2022-05-19 16:59:48 +01:00
Fabien 'egg' O'Carroll
2575e10ec4 Added subscription stats service ()
refs https://github.com/TryGhost/Team/issues/1505
refs https://github.com/TryGhost/Team/issues/1466

This gives us historic data for subscriptions broken down by tier and cadence

* Cleaned up tests
Fixed up usage of knex, making sure to destroy the connection after tests

* Removed Node 12 from testing matrix
Get outta my pub!
2022-04-21 15:42:02 +01:00
Fabien "egg" O'Carroll
77819d261a Moved Stats Service from Ghost
The functionality hasn't changed this has just moved the code
and updated the tests to provide better coverage
2022-04-21 13:10:33 +01:00