Commit Graph

5376 Commits

Author SHA1 Message Date
Nazar Gargol
47a4b9c433 Refactored check with regexp to error type checking
- Changed as per review here: https://github.com/TryGhost/Ghost-Admin/pull/1560#discussion_r420040384
2020-05-06 00:05:19 +12:00
Peter Zimon
39addff34f Added special view for "locked" users when they fail signin (#1561)
refs https://github.com/TryGhost/Ghost/pull/11790

- After user fails to signin due to "locked" being locked a new view with automatic email message and more instructions will be shown to make the password reset process easier.
- Refined instructions screen
- Added icon + animation
- Refined copy

Co-authored-by: Nazar Gargol <nazargargol@gmail.com>
2020-05-05 23:27:19 +12:00
Kevin Ansfield
76cbdbaee7 🐛 Improved scrolling of members screen in Firefox
refs https://github.com/TryGhost/Ghost/issues/11755

- adjusted estimated height to match actual rendered size and enabled `staticHeight` to switch to a simpler algorithm inside vertical-collection
- prevents some jank seen when scrolling where rows jump
2020-05-01 18:17:47 +01:00
Nazar Gargol
14122fdb39 Added response parameter to postMessage data
no issue

- The 'response' property is needed to make the receiving client generic in regards of what data format has to be returned as a result of the call. For example with this change the 'response: subscription' meant there should be an incoming 'message' event as a response to this call with 'subscription' key into it's data
2020-05-01 17:34:55 +12:00
Renovate Bot
0ec853299e Update dependency @tryghost/kg-parser-plugins to v0.10.1 2020-04-30 13:20:31 +00:00
Renovate Bot
7678938984 Update dependency @tryghost/kg-clean-basic-html to v0.1.9 2020-04-30 11:05:45 +00:00
Renovate Bot
2a2d14a74e Update dependency broccoli-concat to v4.2.4 2020-04-30 09:50:42 +01:00
Daniel Lockyer
6584123b97 Removed broccoli-concat from Renovate blacklist
no issue

- originally added because of https://github.com/broccolijs/broccoli-concat/issues/149, but this _should_ be fixed now
2020-04-30 09:35:58 +01:00
Kevin Ansfield
9582b9ea2f Fixed embed card sizing for Vimeo embeds with larger thumbnails
no issue

- we're adjusting the oembed endpoint to fetch larger thumbnails if possible and that results in Vimeo embed iframes being larger than the editor width which created large blank spaces above/below the video due to the iframe height not adjusting correctly
- in the embed card's resize routine, if we look for an embedded iframe and find a width/height attribute then we can use the aspect ratio to assign the correct height for the outer and inner iframes
2020-04-30 09:07:04 +01:00
renovate[bot]
453c6e777f Update dependency ember-data to v3.18.0 (#1553)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-29 10:48:58 +01:00
Kevin Ansfield
4ba1bb0e16 Added oembed metadata to embed card payloads
refs https://github.com/TryGhost/Ghost/issues/11756

- we'd like to render fallbacks for embed cards in constrained environments such as emails where the `html` contents may not be suitable
- oembed gives us data to be able to create fallbacks this such as a `thumbnail_url`, author information, and sizing but we were not storing it
- this change removes the `html` and `type` data from the response object as the existing top-level payload properties then stores the remainder of the response under a `metadata` property
2020-04-29 10:43:03 +01:00
Renovate Bot
9de0f1f4c1 Update dependency ember-data to v3.17.1 2020-04-28 17:31:55 +00:00
Kevin Ansfield
b5a2053618 Lock file maintenance 2020-04-28 16:49:08 +01:00
Peter Zimon
be99251f7f 💄 Improved members chart Y range
no issue.

- improved the Y axis of members list chart to only take the visible range into consideration. This way the change in a period is more understandable
- added labels to Y axis so that the range is clearer
2020-04-28 13:59:45 +02:00
Kevin Ansfield
fa9445d1ab Fixed invisible button text when toggling image card alt button
no issue

- `bg-white` was a default style but has a higher specificity than `bg-blue` used when active so the blue background wasn't taking effect
2020-04-28 09:48:00 +01:00
renovate[bot]
fd07e4a87f Update dependency testem to v3.1.0 (#1550)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-28 08:47:16 +01:00
Peter Zimon
21f7013c38 Set auto reset for impersonate copy link button
no issue.
- updated copy link button in member impersonate modal to auto reset after clicked so that people understand they can click the button again plus it's consistent with all other task buttons
2020-04-27 16:49:15 +02:00
Daniel Lockyer
34d530ab86 v3.14.0 2020-04-27 13:27:51 +01:00
Kevin Ansfield
842c3ffd93 Added "Email" card for inserting content that only appears when emailing posts to members
no issue

- any content inside the email card will not appear on the site, instead it will only be shown when using the members system to email the post to your members
- can `{first_name}` or `{first_name, "fallback"}` to personalise the email content for each member
2020-04-27 13:13:00 +01:00
Peter Zimon
ab8ef7f422 Updated email card help link
no issues.
- updated email card to point the help icon to its final page
2020-04-27 11:02:23 +02:00
Rish
08458f74a9 💄 Added reset behavior for test email newsletter button
no issue

This change adds auto-reset behavior to test email newsletter button by resetting it to default state - "Send test email" - after sending an email newsletter. Previously the button stayed in "Email sent" state after sending email which can be misleading when trying to send another test mail.
2020-04-27 11:39:18 +05:30
Kevin Ansfield
f26b27a44f Fixed publish menu tests
refs 9074181461

- the publish menu button text will now reset and because tests wait for all timers to finish before continuing the button text we're checking against has changed
2020-04-23 21:11:04 +01:00
Kevin Ansfield
837753e225 Sped up tests by reducing reset button timeout whilst testing
no issue

- tests will wait for everything to settle before continuing or ending so the 2.5sec timeout on task button resets was adding a lot of extra time
- use Ember's environment to see if we're testing and reduce the reset timeout from 2500ms to 50ms
2020-04-23 20:20:19 +01:00
Kevin Ansfield
9074181461 Fixed publish menu button state not reverting
closes https://github.com/TryGhost/Ghost/issues/11757

- add `autoReset=true` option to task button so that success buttons after switching publish menu state will reset after a few seconds
2020-04-23 19:51:19 +01:00
Kevin Ansfield
e887af36d7 🐛 Fixed ability to schedule emailed post when date is incorrect
refs https://github.com/TryGhost/Ghost/issues/11757

- moved schedule date validation to occur before we short-circuit for display of the email confirmation modal
2020-04-23 19:43:10 +01:00
Peter Zimon
274babc6e3 Refined email card help styles
no issue

- refine email card help copy, icon and container styles
2020-04-23 14:46:44 +02:00
Kevin Ansfield
625dd9a471 Added help text to email card
no issue

- show help at bottom of email card in edit mode with text explaining that the email card will only be included in emails
- set default content of the email card that includes the `{first_name}` replacement string
- changed behaviour to place cursor at end of the card contents when entering edit mode
2020-04-23 12:11:23 +01:00
Nazar Gargol
f1986b443b Fixed default BMA iframe state
- Upgrade flow should only be set to truthy through a direct setter
2020-04-22 18:14:58 +12:00
Nazar Gargol
e5ff5c2869 Added billing controller for explicitness
refs d691b15

- Additionally removed redundant super call
2020-04-22 16:44:34 +12:00
Naz
d691b15f82 Added handling for /billing route with query param passing to BMA (#1551)
no issue

- This change allows to open BMA popup using external link and pass in information using query parameters. Main use case being redirects from external sites
2020-04-22 15:35:56 +12:00
Renovate Bot
09df32ef7c Update dependency ember-exam to v5.0.1 2020-04-22 02:57:15 +00:00
Peter Zimon
20b113909c Fixed slash menu positioning bug
no refs.

- fixed visual bug that made Slash menu appear on top of the text
2020-04-21 11:12:47 +02:00
Kevin Ansfield
bdf7a1ba8a Hid slash menu when there are no items to display
no issue

- doesn't make sense to show a plain white box with a shadow
2020-04-21 09:16:13 +01:00
Rish
cd832a15bb Fixed members loading spinner alignment
refs https://github.com/TryGhost/Ghost/issues/11755

Loading spinner on members screen was not vertically centered, this updates the spinner position.
2020-04-21 13:42:34 +05:30
Nazar Gargol
4d23d0f0ca Added billing "update" CTA button
no issue

- Added billing update button to navigation menu. Ghost-Admin communicates with billing iframe and displays this button based on the plan data that iframe returns
- Ghost-Admin communicates with an iframe using same mechanism as with token exchange - throu `window.postMessage` API
2020-04-21 18:54:29 +12:00
Peter Zimon
e6998afb40 Icon fixes on integrations night shift
refs. https://github.com/TryGhost/Ghost/issues/11342

- replaced Zapier and Amp logos for SVGs with transparent background so that there's no white background in night shift
- inverted Unsplash icon in night shift (similarly to Mailchimp, Typeform etc.)
- replaced ellipsis icon for SVG and handled night shift color change
- removed unnecessary icon container drop shadow in integration detail pages for night shift
2020-04-20 17:51:56 +02:00
Daniel Lockyer
932032c792 v3.13.4 2020-04-20 16:30:34 +01:00
Kevin Ansfield
4a596d232e Fixed formatting only being applied to first replacement string in email card
no issue
2020-04-20 12:15:11 +01:00
renovate[bot]
957fa52c54 Update dependency ember-composable-helpers to v4 (#1549)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-20 08:50:20 +01:00
renovate[bot]
0b70157e21 Update dependency ember-composable-helpers to v3.2.0 (#1548)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-20 08:44:51 +01:00
Renovate Bot
cd8eb2f31e Update dependency pretender to v3.4.1 2020-04-20 05:37:58 +00:00
Kevin Ansfield
06849869a2 Fixed linting 2020-04-17 17:59:08 +01:00
Kevin Ansfield
abcb9da445 Prevent {} text replacements from receiving any formatting
no issue

- we don't want to allow text replacement strings to be split in half by html tags so we disallow any formats to be applied to them
- in the `<KoenigTextReplacementHtmlInput>`'s mobiledoc editor's `didUpdatePost` hook handler we loop over all markers in the post and if they have a code markup (we use this to represent replacement strings) then we strip any other markups
2020-04-17 17:49:16 +01:00
Kevin Ansfield
01faf606a6 Fixed <code> being persisted to email card payload
no issue

- `<code>` formatting is internal to the text replacement html input and shouldn't be persisted in the payload html
- adjust `cleanTextReplacementHtml` to strip out all `<code>` tags
- adjust `<CleanTextReplacementHtmlInput>` to strip `<code>` formatting when outputting html via the `onChange` action and to also put the `<code>` formatting back when receiving html
- adjust `<KoenigEmailCard>` to add the `<code>` formatting back around any replacement strings so that they are visible in the editor
2020-04-17 16:00:19 +01:00
Kevin Ansfield
2da73cf8ea Fixed {} chars being removed when applying text replacement format
no issue

- we want to keep the `{` and `}` chars when applying/removing formatting from text replacement strings so that you can see the full string with formatting
- added ability to specify a non-replaced special format which is used by the <kbd>Backspace</kbd> handler
- added helper utility to the text expansions for applying formatting to a match without replacing the "markdown" characters
2020-04-17 14:49:54 +01:00
Kevin Ansfield
00ccf68764 Fixed "special markups" not being separate across different editors
no issue

- if the character used to define a special markup is different such as in the text replacement editor, pressing Backspace was not inserting the correct characters
2020-04-17 14:11:19 +01:00
Kevin Ansfield
e5acb34a81 Fixed mobiledoc-kit automatically upgrading document version
refs 6f5c2a9557

- we previously set a fixed mobiledoc spec version in blank documents but when the editor was serializing to a json string after editing it was bumping the spec version
- makes the specific version a constant to be used when serializing any mobiledoc
2020-04-16 22:12:01 +01:00
Renovate Bot
4afa33e936 Update dependency testem to v3.0.4 2020-04-15 22:15:02 +00:00
Daniel Lockyer
2b69bb6564 v3.13.3 2020-04-15 14:06:16 +01:00
Daniel Lockyer
d1e6877e7a v3.13.2 2020-04-15 11:40:33 +01:00
renovate[bot]
01cf9f2460 Update dependency walk-sync to v2.1.0 (#1547)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-14 17:37:47 +01:00
renovate[bot]
00d5dae216 Update dependency @tryghost/kg-parser-plugins to v0.10.0 (#1546)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-14 14:49:17 +01:00
Renovate Bot
504a43c887 Update dependency @tryghost/timezone-data to v0.2.24 2020-04-13 18:17:06 +00:00
Renovate Bot
f726eb0141 Update dependency @tryghost/helpers to v1.1.27 2020-04-13 16:21:21 +00:00
renovate[bot]
2bf48616bb Update dependency ember-cli-htmlbars to v4.3.1 (#1543)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-13 09:33:51 +01:00
renovate[bot]
94992204bf Update dependency ember-resolver to v8 (#1545)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-13 09:17:55 +01:00
Renovate Bot
38500794d7 Update dependency @tryghost/timezone-data to v0.2.23 2020-04-10 21:18:05 +00:00
Renovate Bot
c8482d27d2 Update dependency @tryghost/helpers to v1.1.26 2020-04-10 21:17:29 +00:00
Renovate Bot
05354db4d2 Update dependency @tryghost/string to v0.1.9 2020-04-10 18:47:26 +00:00
Nazar Gargol
11e59e1f7e Moved billing page to a popup
no issue

- To simplify styling and give a better separation feeling from UI perspective
2020-04-09 17:26:11 +12:00
Renovate Bot
9316b2c467 Update dependency @tryghost/kg-parser-plugins to v0.9.3 2020-04-08 15:21:12 +00:00
Renovate Bot
2c0952c49d Update dependency @tryghost/kg-clean-basic-html to v0.1.8 2020-04-08 13:57:05 +00:00
Peter Zimon
48bbb23174 Added email indicator icon, card menu style bugfix
no refs.
- added indicator icon to appropriately show which card is a newsletter email one
- fixed bug of card menu staying the same height when triggered via "/" menu
2020-04-08 14:01:04 +02:00
Peter Zimon
9ecc808c3a Added email icon to Koenig card menu
no refs.
- added appropriate icon to Koenig menu to support newsletter email cards
2020-04-08 13:52:48 +02:00
Daniel Lockyer
bcd4059ac5 v3.13.1 2020-04-07 16:03:38 +01:00
Daniel Lockyer
a730a990a5 v3.13.0 2020-04-07 11:12:52 +01:00
Renovate Bot
55cb6e1dbf Update dependency autoprefixer to v9.7.6 2020-04-06 21:22:32 +00:00
Rish
2e1fc80849 Fixed save test
no issue
2020-04-06 18:02:19 +05:30
Daniel Lockyer
4f8e9b9bd8 Switched to using built-in Node.js for tests
no issue

- setup-node was randomly failing to download because of an upstream Node issue
- this commit switches to using the build in Node version
2020-04-06 13:14:13 +01:00
Kevin Ansfield
40f2b11524 Removed errant console.log 2020-04-06 13:12:17 +01:00
Rishabh Garg
c3883d4c6f 💄Updated save buttons to reset state (#1522)
* Updated save buttons to reset state

no issue

Currently the save buttons across Admin don't auto-reset to idle state after success/failure on run which can give false impression once user changes any value. This PR auto-resets the button to idle state after a fixed timeout if no subsequent action is performed as a short term UX improvement.

* Fixed success check for auto reset

* Updated timeout value

* Added explicit save button reset for pages

* Updated save buttons to reset via shortcut

Auto-reset for save buttons wasn't working if not done through manual click on task button previously, this handles by splitting the original save task in controller to handle shortcut saves.

* Updated reset check for only successful tasks

* Added save reset to code-injection and design settings

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2020-04-06 16:17:28 +05:30
Daniel Lockyer
36bcae2205 Revert "Switched to Node.js container in Action"
- this reverts commit 3e3a2af71a.
- the tests require more components than Node, which the container
  doesn't have
2020-04-06 11:35:51 +01:00
Daniel Lockyer
3e3a2af71a Switched to Node.js container in Action
no issue

- using the setup-node action is currently failing because of an
  upstream issue - https://github.com/nodejs/node/issues/32683
- this commit switches to using a Docker container
2020-04-06 11:27:54 +01:00
Kevin Ansfield
a9b9b2f3ae Added first draft of email-only card
no issue

- adds "Email" card to the card menus when developer experiments is turned on
- adds `<KoenigTextReplacementHtmlInput>` implementing most of Koenig except:
  - uses html as it's input/output format
  - replaces backtick "code" formatting with `{replacement}`
  - no headings
  - no cards at all
  - minimal toolbar but all formatting is still available using markdown text expansions or keyboard shortcuts
2020-04-06 10:56:40 +01:00
Kevin Ansfield
07850fd319 🐛 Fixed Ctrl/Cmd+Enter toggling cards into edit mode
no issue

- the card wrapper component was registering an event handler for keyboard events when entering edit mode. This was a problem because those events were also picking up the initial ctrl/cmd+enter and then immediately toggling back out of edit mode
- added a 20ms timeout for registering the event handlers so that they're not working cross-purposes
2020-04-06 10:49:23 +01:00
Renovate Bot
0ec149e28c Update dependency chai-dom to v1.8.2 2020-04-03 16:35:09 +00:00
Renovate Bot
0eb208e131 Update dependency @tryghost/timezone-data to v0.2.22 2020-04-03 12:56:11 +00:00
Renovate Bot
cf7e982771 Update dependency @tryghost/string to v0.1.8 2020-04-03 10:18:25 +00:00
Renovate Bot
3ecdda8cf0 Update dependency @tryghost/helpers to v1.1.25 2020-04-03 08:17:15 +00:00
renovate[bot]
bb6474ba99 Update dependency broccoli-merge-trees to v4.2.0 (#1539)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-02 09:36:31 +01:00
Renovate Bot
fc67b60999 Update dependency ember-fetch to v8.0.1 2020-03-30 21:56:13 +00:00
renovate[bot]
b51a427ed9 Update dependency ember-fetch to v8 (#1538)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:58:05 +01:00
renovate[bot]
b8e75b9eb4 Update dependency ember-fetch to v7.1.0 (#1537)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:05:43 +01:00
renovate[bot]
d78c2a87df Update dependency ember-cli-babel to v7.19.0 (#1536)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:05:13 +01:00
renovate[bot]
33d30494f7 Update dependency blueimp-md5 to v2.13.0 (#1534)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:03:12 +01:00
Renovate Bot
fd62d82b00 Update dependency ember-concurrency to v1.1.7 2020-03-30 00:16:52 +00:00
Renovate Bot
f875d9de72 Update dependency reframe.js to v2.2.8 2020-03-27 07:40:28 +00:00
Renovate Bot
147abf61fb Update dependency @tryghost/timezone-data to v0.2.21 2020-03-27 00:43:12 +00:00
Renovate Bot
2ccd8adc1e Update dependency @tryghost/helpers to v1.1.24 2020-03-26 23:16:48 +00:00
Renovate Bot
75af61c4e7 Update dependency @tryghost/string to v0.1.7 2020-03-26 21:31:02 +00:00
Daniel Lockyer
13352fd542 Version bump to 3.12.1 2020-03-26 14:29:11 +00:00
Kevin Ansfield
6f5c2a9557 Switched to explicit mobiledoc version for new posts
no issue

- when the mobiledoc spec changes due to a mobiledoc-kit version bump, any posts created with that version will fail to load in the editor if a rollback to an earlier Ghost version occurs
- use an explicit version to avoid the problem - we should only be bumping the mobiledoc spec version if we start using features from that version and mark it as a breaking change
2020-03-26 14:27:41 +00:00
Kevin Ansfield
6497f5b7e3 Reverted ember-source to 3.16.1
closes https://github.com/TryGhost/Ghost/issues/11685

- `ember-source` 3.17.x has an incompatibility with `ember-power-select`
    - see https://github.com/cibernox/ember-power-select/issues/1338
- add `ember-source` to renovate ignore list to avoid unintentional bumps
2020-03-26 14:23:06 +00:00
Daniel Lockyer
f513f39340 Enabled CI on Renovate branches
no issue
2020-03-26 09:46:05 +00:00
renovate[bot]
46ffc15544 Update dependency ember-cli-postcss to v6 (#1531)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-26 09:18:48 +00:00
Daniel Lockyer
7039ff0f69 Fixed trailing comma
no issue
2020-03-26 07:53:49 +00:00
Daniel Lockyer
67aeaff83f Updated Renovate config with latest presets
no issue
2020-03-26 07:53:26 +00:00
Renovate Bot
a1d9fbec38 Update dependency @tryghost/kg-parser-plugins to v0.9.2 2020-03-25 21:15:38 +00:00
Daniel Lockyer
6b0218e5cb Configured Renovate to automerge patches from branches
no issue
2020-03-25 20:50:30 +00:00
Renovate Bot
59e5dd9ad6 Update dependency @tryghost/kg-clean-basic-html to v0.1.7 2020-03-25 20:15:44 +00:00