TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 22:43:30 +03:00
Code Issues Projects Releases Wiki Activity
29,484 Commits 237 Branches 1,679 Tags 383 MiB
06e4eb0c77
Commit Graph

12731 Commits

Author SHA1 Message Date
Simon Backx
06e4eb0c77 Created separate table templates for posts with emailClicks enabled 
refs https://github.com/TryGhost/Team/issues/1892
 2022-09-13 11:57:05 +02:00
Simon Backx
e8f4e106dd Added basic analytics page for posts 
refs https://github.com/TryGhost/Team/issues/1892
 2022-09-13 11:00:45 +02:00
Hakim Razalan
e376ef0242
🐛 Fixed Hidden error in "Add tier" modal (#15361) 
closes https://github.com/TryGhost/Ghost/issues/15290

- Capture error from model errors
- Add hasValidated for name property to properly mark field as error/success
- Add property to hasValidated after each failed validation
- Wrap saving on try-catch to suppress uncaught exception (validation error)
 2022-09-13 09:23:54 +01:00
renovate[bot]
2a3b4908e1
Update dependency ember-cli-htmlbars to v6.1.1 (#15389) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2022-09-13 09:20:09 +01:00
renovate[bot]
1b8dbb132f
Update Test & linting packages (#15338) 
* Update Test & linting packages
* Fixed new `no-quoteless-attributes` template lint errors

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
 2022-09-13 09:19:14 +01:00
renovate[bot]
da905b1dff Update dependency @types/nodemailer to v6.4.6 2022-09-13 08:39:26 +01:00
Daniel Lockyer
a766253a78
Merged v5.14.1 into main 
v5.14.1
 2022-09-12 16:06:43 +01:00
Ghost CI
ba732489d2 v5.14.1 2022-09-12 16:00:13 +01:00
Kevin Ansfield
e230370b33 🐛 Fixed Admin freeze when filtering long tag lists 
closes https://github.com/TryGhost/Ghost/issues/15391

- `vertical-collection` component was throwing errors during render when the tags list was filtered down causing slowdowns or full Admin crashes
- similar regression had popped up before and fixed in https://github.com/TryGhost/Ghost/pull/15207 but the dependency had been bumped again without realising it caused an error
- added a test that triggers the error-throwing behaviour in the tags input to help catch this in future dependency updates
 2022-09-12 15:49:59 +01:00
Peter Zimon
a5b2648c07
Added Solo theme to themes 
no refs.

- the new Solo theme is being released and wasn't listed on Design / Settings / Change theme
 2022-09-12 15:38:40 +01:00
Peter Zimon
f65a8b1a95 Added Solo theme to themes 
no refs.

- the new Solo theme is being released and wasn't listed on Design / Settings / Change theme
 2022-09-12 16:35:55 +02:00
Daniel Lockyer
5e4f930ee8
Fixed performance of column rename migration 
- the migration in 5.14 renames the `bio` columns on `members` to `expertise`
- unfortunately, the Knex helper we were using does a lot of interesting
  things with foreign keys that are slow on bigger MySQL clusters, and
  that we don't need here
- this commit refactors the migration to use raw SQL if the DB is MySQL,
  else we use the helper because SQLite SQL might be different here
- I've chosen to only run the renaming functionality if we're in the correct DB
  state to do so (instead of erroring or trying to correct the state)
 2022-09-12 15:14:36 +01:00
Daniel Lockyer
a6991746c3 Fixed performance of column rename migration 
- the migration in 5.14 renames the `bio` columns on `members` to `expertise`
- unfortunately, the Knex helper we were using does a lot of interesting
  things with foreign keys that are slow on bigger MySQL clusters, and
  that we don't need here
- this commit refactors the migration to use raw SQL if the DB is MySQL,
  else we use the helper because SQLite SQL might be different here
- I've chosen to only run the renaming functionality if we're in the correct DB
  state to do so (instead of erroring or trying to correct the state)
 2022-09-12 15:12:53 +01:00
Simon Backx
5a4019b45e Added emailClicks feature flag 
closes https://github.com/TryGhost/Team/issues/1883
 2022-09-12 13:32:43 +02:00
Daniel Lockyer
083391c995
Configured all Admin assets to contain fingerprint hash 
refs https://github.com/TryGhost/Toolbox/issues/403

- as we're moving towards independent Admin releases, we want to make
  sure that we can bust cache when an asset is updated
- right now, svg, ttf and ico images aren't fingerprinted, so if they
  change, it'll require a browser cache clear to update them
- instead, we should add them to the list of fingerprinted file
  extensions to fix this issue
 2022-09-12 10:54:10 +01:00
renovate[bot]
f53eac3043 Update dependency html-validate to v7.4.1 2022-09-12 09:42:13 +01:00
Rishabh
054833992e Wired events for triggering email alerts for subscription creation/cancellation 
refs https://github.com/TryGhost/Team/issues/1865

- refactors subscription creation/cancellation to dispatch proper events which are used for email alerts
- cleanup
 2022-09-10 11:06:34 +05:30
Rishabh
2fbaa7b9bc Moved member email alert trigger to member creation 
closes https://github.com/TryGhost/Team/issues/1864
refs https://github.com/TryGhost/Team/issues/1881

- triggers free member email alert via event dispatch from member create method
- passes subscription/stripe data to member creation for paid members so free member alert can be ignored for them
- moves subscription created event being called from webhook controller to `linkSubscription`, allows creating subscription events for all new subscriptions instead of ones just via webhooks
 2022-09-10 11:06:34 +05:30
Rishabh
8d07d6e93b Updated subscription created/canceled events data 
refs https://github.com/TryGhost/Team/issues/1865

- adds new subscription canceled event
- updates existing subscription created event to include tier id and source data
 2022-09-10 11:06:34 +05:30
Rishabh
4187f0da54 Updated staff service to trigger alerts via events 
refs https://github.com/TryGhost/Team/issues/1865

- refactors staff service to listen to member and subscription events
- triggers email alerts based on events instead of directly calling the service
- removes staff service dependency for members api
 2022-09-10 11:06:34 +05:30
Hannah Wolfe
e2f69f7a4e
Updated note on x_by columns to be clearer 
refs: https://github.com/TryGhost/Toolbox/issues/229
refs: https://github.com/TryGhost/Toolbox/issues/407

- x_by columns are deprecated in favour of actions
 2022-09-09 20:12:42 +01:00
Kevin Ansfield
bf134efa1f Moved members modals 
no issue

- relocated the screen-specific modals from `modals/` to `members/modals/` directory as part of a on-going reorganisation of components into screen-specific directories
 2022-09-09 18:12:03 +01:00
Kevin Ansfield
512a434738 Cleaned up .lint-todo file 
no issue

- rebuilt the lint-todo file to clean up fixed todos and reset the warning countdown
 2022-09-09 18:05:22 +01:00
Kevin Ansfield
dfa010f918 Removed unused leave-settings modal 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559

- all uses of the old-style modal have been removed so it's no longer needed
 2022-09-09 17:58:30 +01:00
Kevin Ansfield
a11554aaba Switched Portal settings unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:56:51 +01:00
Kevin Ansfield
8fde9a05d2 Switched User settings unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:12 +01:00
Kevin Ansfield
6e11a24002 Switched Unsplash integration unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:12 +01:00
Kevin Ansfield
5d5e77af85 Switched Slack integration unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:12 +01:00
Kevin Ansfield
f1c4f880a6 Switched FirstPromoter unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:12 +01:00
Kevin Ansfield
2c10e53774 Switched AMP unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:12 +01:00
Kevin Ansfield
a6f19ca807 Switched navigation unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:12 +01:00
Kevin Ansfield
416932e118 Switched membership unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:11 +01:00
Kevin Ansfield
c85690fb12 Switched integration unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:11 +01:00
Kevin Ansfield
2396c6d615 Switched general settings unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:11 +01:00
Kevin Ansfield
1cbf310a7d Switched code injection unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:11 +01:00
Kevin Ansfield
d208cc881a Cleaned up unused code in settings controller 
no issue

- removed old/unused unsaved-changes code
- cleaned up unused service injections
 2022-09-09 17:44:11 +01:00
Kevin Ansfield
7150a59abc Switched offer unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:11 +01:00
Kevin Ansfield
543c44415d Switched member unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:11 +01:00
Kevin Ansfield
e17d24358e Switched tag unsaved changes modal to new modal pattern 
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
 2022-09-09 17:44:11 +01:00
Hannah Wolfe
04f3ac37d3 Removed defunct applyPublicRules code 
closes: https://github.com/TryGhost/Toolbox/issues/369
refs: https://github.com/TryGhost/Toolbox/issues/229

- this code is defunct as we no longer accept a status parameter via the API for posts, pages, users or authors
 2022-09-09 17:14:15 +01:00
Hannah Wolfe
6741f139d5
Updated redirects todo to be a deprecation notice 
- When we have todos related to deprecations, we should use @deprecated instead
- @deprecated notices should say when a feature was deprecated, not when it was removed
 2022-09-09 17:11:27 +01:00
Ghost CI
352b4ad537 v5.14.0 2022-09-09 16:00:35 +01:00
Hannah Wolfe
cbc56d953a
Removed outdated todo referencing api versions 
refs: https://github.com/TryGhost/Toolbox/issues/229

- We got rid of the configs, so this todo is no longer valid
 2022-09-09 13:58:27 +01:00
Hannah Wolfe
b0234dd58e
Removed apiVersions from test urlUtils 
refs: https://github.com/TryGhost/Toolbox/issues/229

- These properties were removed from urlUtils in 5.0 and no longer do anything
 2022-09-09 13:32:30 +01:00
Kevin Ansfield
08b099e527 Refactored tags screens 
refs https://github.com/TryGhost/Ghost/issues/14101

- migrated to full native class and octane syntax
- cleaned up unnecessary use of "scratchTag"
 2022-09-09 13:27:13 +01:00
Ronald Langeveld
c9e6f42ca8 Bumped Portal to 2.12.0 
ref https://github.com/TryGhost/Team/issues/1800

- Adds v 2.12.0 of Portal
- Updates snapshots for tests
 2022-09-09 13:54:43 +02:00
Naz
235d716048
Refactored notifications e2e tests to use test framework 
no issue

- Bumped into these tests when doing cleanup in the notifications service. Having full snapshot of requests is useful to have as a sanity check, so migrated this test suite quickly.
 2022-09-09 19:51:50 +08:00
Ronald Langeveld
a001c63dbd Revert "Bumped to Portal to 2.11.2" 
This reverts commit 8276cad6f1.
 2022-09-09 13:33:29 +02:00
Ronald Langeveld
8276cad6f1
Bumped to Portal to 2.11.2 
ref https://github.com/TryGhost/Ghost/pull/15335
 2022-09-09 13:12:11 +02:00
Simon Backx
145a111e4c Updated admin auth frame to use versionless API 
refs https://ghost.slack.com/archives/C02G9E68C/p1662717296469599

The API no longer has versions, so this required a redirect every time.
 2022-09-09 12:01:23 +02:00