5 Commits

Author	SHA1	Message	Date
Naz	74c15c7b02	Refactored secret settings util functions ... refs https://github.com/TryGhost/Team/issues/694 refs https://linear.app/tryghost/issue/CORE-13 - The index file in services/settings was containning logic and started throwing an additional lint warning due to module length. - The extracted secret settings utils were used in multiple places and were a good candidate to live in it's own small module	2021-09-21 23:05:57 +12:00
Naz	ed56239523	Moved browse method from settings API controllers ... refs https://github.com/TryGhost/Team/issues/694 refs https://linear.app/tryghost/issue/CORE-13 - The browse method didn't throw a complexity warning but was a clear target to get extracted into settings bread service. This way we get rid of a settings cache dependency and reduce code duplication.	2021-09-21 23:05:57 +12:00
Naz	e7ec197da1	Removed duplicate logic from settings edit permissions stage ... refs https://github.com/TryGhost/Team/issues/694 refs https://linear.app/tryghost/issue/CORE-13 - The removed logic is done more thoroughly on the settings BREAD service layer.	2021-09-21 23:05:57 +12:00
Naz	6b25b91fa4	Removed method complexity in settings API controller ... refs https://github.com/TryGhost/Team/issues/694 refs https://linear.app/tryghost/issue/CORE-13 - The controller code is not meant to contain complex business logic. Removed complexity in settings.edit method - Have separated the regular editing from "Stripe Data" editing to keep the dependency on the members service still in the controller reducing coupling of the settings BREAD service to the minimum. - The stripeConnectData passed into `edit` method still feels out of place (maybe it should be passed as an array already that's ready to be merged with the rest of settings, but that was left for another refactor in the future)	2021-09-21 23:05:57 +12:00
Naz	85ee721157	Removed method complexity in settings API controller ... refs https://github.com/TryGhost/Team/issues/694 refs https://linear.app/tryghost/issue/CORE-13 - The controller code is not meant to contain complex business logic. Reduced complexity in the settings.read method - Broke the usual "xxxService" naming pattern here in favor of "xxxBREADService" pattern that members package has been experimenting with recently (0469707f2e/packages/members-api/lib/services/member-bread.js (L25)). This naming choice was made because we already had a "SettingsService" and it would've become quite convoluted distinguishing the naming or doing renames for the sake of having a new temporary location for read/edit/add methods - Also duplicated `hideValueIfSecret` method code with an intention to move it fully into the BREAD service once the refactoring is completed	2021-09-21 23:05:57 +12:00