Commit Graph

31333 Commits

Author SHA1 Message Date
Simon Backx
8af422c601
Updated email_track_clicks to current email_track_opens value (#15484)
fixes https://github.com/TryGhost/Team/issues/1990

We need to set the current track clicks setting to the current track opens setting, just before release.
2022-09-28 17:12:29 +02:00
James Morris
59b5cd59b2 Better matching posts and pages and fixing when no members
refs https://github.com/TryGhost/Team/issues/1995
2022-09-28 15:56:22 +01:00
Djordje Vlaisavljevic
584546cf1d Updated other sources button
refs https://github.com/TryGhost/Team/issues/1986
2022-09-28 16:47:29 +02:00
Djordje Vlaisavljevic
52af7c687d Added attribution help docs link placeholder
refs https://github.com/TryGhost/Team/issues/1986
2022-09-28 16:31:52 +02:00
Rishabh
f2430c34cc Updated attribution chart on post analytics page
refs https://github.com/TryGhost/Team/issues/1986

- added dropdown for paid vs signups selection on attribution chart
2022-09-28 19:50:29 +05:30
Simon Backx
1caa8f5b9a Hidden analytics page button for published post when attribution is disabled
fixes https://github.com/TryGhost/Team/issues/1998

- Should not show analytics button when post is not sent via email and attribution is disabled
- Improved checks for the analytics button
2022-09-28 16:15:03 +02:00
James Morris
dc9ef69547 Better matching up the pages table with the posts table
refs https://github.com/TryGhost/Team/issues/1995
2022-09-28 14:17:12 +01:00
James Morris
cd97341ed6 Fixed up the edit and stats buttons based on feedback
refs https://github.com/TryGhost/Team/issues/1994
2022-09-28 13:44:58 +01:00
Djordje Vlaisavljevic
b72b51b542 Made the attribution widget look better on smaller screens
refs https://github.com/TryGhost/Team/issues/1986
2022-09-28 14:20:40 +02:00
Rishabh
d63f4548c0 Removed attribution sources from UI if site is invite-only
refs https://github.com/TryGhost/Team/issues/1986

- removes attribution section from dashboard and post analytics if site is invite only
2022-09-28 17:26:38 +05:30
Rishabh
8c225ee9d0 Fixed lint
- updates `index` for susbcription detail box
2022-09-28 17:22:24 +05:30
Djordje Vlaisavljevic
9209a39c29 Added new attribution widget design
refs https://github.com/TryGhost/Team/issues/1986
2022-09-28 13:44:28 +02:00
Rishabh
79248cdde9 Fixed dropdown blink for subscription detail box
refs https://github.com/TryGhost/Team/issues/1986

- creates new component for subscription detail box that avoids re-render of whole block causing flicker
2022-09-28 17:08:28 +05:30
Rishabh
cf1f41d61c Updated attribution table design to show single column data
- adds new dropdown that allows switching between signups vs paid conversions
- updates chart data based on dropdown value, keeps the sort column till the design for this is polished
2022-09-28 16:27:44 +05:30
Rishabh Garg
b46258bbc6
Allowed storing attribution data on member events (#15487)
refs 90034577b8

- this change was missed in above commit and would have blocked capturing attribution data for sites without the flag
2022-09-28 15:42:04 +05:30
James Morris
994f0eea64 Tiny padding adjustment for boxes
refs https://github.com/TryGhost/Team/issues/1968
2022-09-28 11:11:15 +01:00
Rishabh
8b2db5c017 Refined attribution table on dashboard for list of sources
- updates table to always show top 5 sources, including the empty sources
- only adds `Other` to list on table if more than 5 sources exist
- updates mock to include `Unavailable` data
2022-09-28 15:31:41 +05:30
Simon Backx
160469d787 Improved analytics page loading states
refs https://github.com/TryGhost/Team/issues/1976

- Wait to show any module until everything has been loaded
2022-09-28 11:58:51 +02:00
Djordje Vlaisavljevic
49a922fbd5 Updated attribution widget empty state
refs https://github.com/TryGhost/Team/issues/1986
2022-09-28 11:05:28 +02:00
Simon Backx
03bfe2504e Fixed ref instead of rel when stripping querystring from tracked url
no issue
2022-09-28 11:03:00 +02:00
Simon Backx
e0965a6262 Readded hash to cleaned tracked links in admin
fixes https://github.com/TryGhost/Team/issues/1980
2022-09-28 10:31:18 +02:00
Naz
8cbf913582 Increased Vary granularity for versioned requests
refs https://github.com/TryGhost/Toolbox/issues/425
refs https://github.com/TryGhost/Toolbox/issues/280

- The versioned API responses vary based on requested version (passed in request's 'accept-version' header). shared caches that sit between Ghost's origin server and the browser would be putting responses with same Vary into the same caching bucket, which is incorrect.
- This change makes response's Vary more granular and tells caching mechanisms to take 'Accept-Version' request header into account when caching.
- Informative read on the topic - https://www.fastly.com/blog/getting-most-out-vary-fastly
2022-09-28 14:48:43 +08:00
renovate[bot]
b61c13e228 Update dependency @playwright/test to v1.26.1 2022-09-28 12:38:09 +07:00
Sanne de Vries
08656ea569 Updated lexical sandbox page structure
Refs https://github.com/TryGhost/Team/issues/1991
2022-09-28 11:06:32 +07:00
Naz
874d0bf81b Made Content API caching configurable
refs https://github.com/TryGhost/Toolbox/issues/411

- Having hardcoded cache control values in the codebase makes it impossible to experiment with new values without a version release.
- Having all values configurable by default will allow for easier caching experiments and customizations on self-hosting instances.
2022-09-28 07:32:27 +08:00
Naz
e45eb4d5dd Made robots.txt caching configurable
refs https://github.com/TryGhost/Toolbox/issues/411

- Having hardcoded cache control values in the codebase makes it impossible to experiment with new values without a version release.
- Having all values configurable by default will allow for easier caching experiments and customizations on self-hosting instances.
- Brings caching across both private and public robots file caching to same consistent and configurable value.
2022-09-28 07:32:27 +08:00
Naz
f6c7df4018 Fixed overly long robots.txt caching for private sites
refs https://github.com/TryGhost/Toolbox/issues/411
refs 78ac63d8ad (diff-fb6792aa9cc3b71f5b146129fb1b58765206ecf4c5f367b72e0826b4b2934508R74)

- The value should have been in SECONDS not MILLISECONDS from the very beginning (see referenced commit)
2022-09-28 07:32:27 +08:00
Naz
a26689c264 Added backend JWKS endpoint caching
refs https://github.com/TryGhost/Toolbox/issues/411
refs f58b5984cb

- Backend JWKS endpoint did not have any HTTP caching
- It is recommended to cache JWKS endpoints (ref.: https://docs.apigee.com/api-platform/reference/policies/jwt-policies-overview)
- This change also brings the endpoint up to speed with what members JWKS
endpoint does
- Above point gives another reminder to extract JWKS functionality into a
common module that should be reused
2022-09-28 07:32:27 +08:00
Naz
8c47819194 Made members JWKS endpoint caching configurable
refs https://github.com/TryGhost/Toolbox/issues/411
refs f58b5984cb

- Having hardcoded cache control values in the codebase makes it impossible to experiment with new values without a version release.
- Having all values configurable by default will allow for easier caching experiments and customizations on self-hosting instances.
- This change only changes the members endpoint caching configurability. The other JWKS endpoint will be modified separately (following commit), to keep changes concise
2022-09-28 07:32:27 +08:00
Naz
5331ba3999 Made public built assets caching configurable
refs https://github.com/TryGhost/Toolbox/issues/411

- Having hardcoded cache control values in the codebase makes it impossible to experiment with new values without a version release.
- Having all values configurable by default will allow for easier caching experiments and customizations on self-hosting instances.
-NOTE:  caching of `public/ghost.css` increases here from one HOUR to one YEAR (did not find any good reason to keep caching to short window for a built asset that has cache-busting mechanism)
2022-09-28 07:32:27 +08:00
Naz
381e419471 Made sitemap.xls caching configurable
refs https://github.com/TryGhost/Toolbox/issues/411

- Having hardcoded cache control values in the codebase makes it impossible to experiment with new values without a version release.
- Having all values configurable by default will allow for easier caching experiments and customizations on self-hosting instances.
2022-09-28 07:32:27 +08:00
Djordje Vlaisavljevic
2c2fd20a17 Removed inline styles
refs https://github.com/TryGhost/Team/issues/1986
2022-09-27 21:36:59 +02:00
Djordje Vlaisavljevic
ca7937d100 Removed inline styles
refs https://github.com/TryGhost/Team/issues/1986
2022-09-27 21:36:59 +02:00
Rishabh Garg
31733657a6
Updated naming for referrer attribution (#15486)
- renames `refSource`, `refMedium` and `refUrl` to `referrerSource`, `referrerMedium` and `referrerUrl` respectively for consistent naming across files and usages
2022-09-28 00:58:06 +05:30
Rishabh
3314dafa78 v2.13.1 2022-09-28 00:17:31 +05:30
Djordje Vlaisavljevic
b64e7b6da0 Fixed dashboard dark mode issues
refs https://github.com/TryGhost/Team/issues/1986
2022-09-27 20:47:10 +02:00
Rishabh
10e65f7fe8 Fixed incorrect import handling for data attributes
refs c3c503632b
2022-09-28 00:16:47 +05:30
Djordje Vlaisavljevic
8a3c696f9d Fixed subscription box dark mode issues
refs https://github.com/TryGhost/Team/issues/1986
2022-09-27 20:34:59 +02:00
Rishabh
d886bc4b0d Fixed tests for portal bump
refs 8848fd0f59

- last commit didn't update test snapshots for new portal version bump
2022-09-28 00:04:32 +05:30
Rishabh
8848fd0f59 Handled attribution history capture via portal data attributes
- updates portal to capture member attribution history when signing up via theme using data-attributes
2022-09-27 23:59:06 +05:30
Rishabh Garg
90034577b8
Added member attribution history frontend script (#15482)
- bumps member attribution script from alpha feature to now load for all sites. The script captures recent url history in localstorage to capture correct attribution for members.
- script is only loaded on the site if members is enabled
2022-09-27 23:45:41 +05:30
Rishabh
d558a185de v2.13.0 2022-09-27 23:43:00 +05:30
Rishabh
c3c503632b Added attribution history to api requests via data attributes
- we added attribution data from localstorage to api requests made via Portal UI, but was missed for requests directly from theme via data-attributes
- includes url history data for free or paid signups via theme to mark correct attribution
2022-09-27 23:42:09 +05:30
James Morris
81605f7f2a Added a basic loading state to modules in post analytics
refs https://github.com/TryGhost/Team/issues/1956
2022-09-27 18:02:20 +01:00
James Morris
c266971e04 Fixed the broken source attributiont table design in post analytics
refs https://github.com/TryGhost/Team/issues/1959
2022-09-27 18:02:20 +01:00
Simon Backx
f33e7a22fa
Added E2E test for whole link tracking flow (#15481)
refs https://github.com/TryGhost/Team/issues/1967

- Test is good to test if the whole flow works as expected, and works together
- We can test independent parts in separate tests that have better coverage of more edge cases
- Adds a basic helper to get an agent for the frontend (spent too much time on a better solution so I decided to keep the existing supertest agent)
2022-09-27 18:44:20 +02:00
Rishabh
2be3452c76 Refined attribution data on member details screen
refs https://github.com/TryGhost/Team/issues/1986

- hides attribution section if attribution data is null
- hides referrer section if referrer source is empty
2022-09-27 21:59:42 +05:30
Simon Backx
6489cb01b5
Disabled link replacement when link click tracking is disabled (#15483)
fixes https://github.com/TryGhost/Team/issues/1988

- We don't want to replace links when link click tracking is disabled (also not add ref)
- Cleaned up some comments and methods
2022-09-27 18:20:34 +02:00
Simon Backx
8c87bb8158 Fixed missing times in activity feed click events
fixes https://github.com/TryGhost/Team/issues/1983
2022-09-27 18:10:05 +02:00
Djordje Vlaisavljevic
f3f6e87378 Updated chart container size
refs https://github.com/TryGhost/Team/issues/1986
2022-09-27 16:52:21 +02:00