6 Commits

Author	SHA1	Message	Date
Fabien O'Carroll	0b9c9968d0	Added initial tests for Offers ... refs https://github.com/TryGhost/Team/issues/1198	2021-11-07 23:10:10 +02:00
Fabien O'Carroll	b6234d6e96	Allowed OfferTitle to be empty ... refs https://github.com/TryGhost/Team/issues/1163 This allows users to not provide a title for an Offer. We store the lack of a title as `NULL` in the DB, but we will always provide a string to the API so that the title can safely be used in HTML.	2021-10-22 13:41:09 +02:00
Fabien O'Carroll	08d3e6e99c	Allowed for OfferDescription to be null/empty ... refs https://github.com/TryGhost/Team/issues/1083 OfferDescription is not a required field, so we must not throw when it is falsy or not present.	2021-10-08 12:40:57 +02:00
Fabien O'Carroll	35f150bcf4	Moved errors to domain/errors ... no-issue More cleanup to pull files into their appropriate responsibility	2021-10-08 12:31:11 +02:00
Fabien O'Carroll	78be4b55c9	Moved ValueObject to domain/models/shared ... no-issue This is only ever used in this directory so it makes sense to be colocated.	2021-10-08 12:23:40 +02:00
Fabien O'Carroll	504fb1bfa1	Used Value Objects to validate outside of Offer factory ... no-issue This adds the concept of "Value Objects" to an Offers properties, allowing us to move validation out and ensure that an Offer will only ever have valid properties, without having to duplicate checks - or leave them to the persistent layer. This means we can fail early, as well as write unit tests for all of our validation.	2021-10-07 16:46:08 +02:00