Commit Graph

12264 Commits

Author SHA1 Message Date
Renovate Bot
1b0a8f5fbf Update actions/setup-node action to v2 2021-01-04 08:56:33 +00:00
Naz
33bdd2384b 🐛 Fixed incorrect locale loading when changing themes
closes #12271

- When previous active theme did not have locale data for certain language, loading a theme which has such data did not result in correct locale being loaded
- Underlying issue was in settings cache being outdated during theme change related i18n initialization
- Fix focuses on removing settings cache dependency and and rely on most up to date data about currently active theme
- The benefit of this approach is reduced coupling with settings cache
2021-01-04 17:26:22 +13:00
Sumedh
e756af65f2 Removed invalid default 'core' value in settings type
closes #12181
refs https://github.com/TryGhost/Ghost/pull/12265

- The 'core' value is invalid for settings 'type' column
- The 'core' default value for 'type' column in model is also invalid
- Both need to be removed as they are never used and only introduce confusion into the codebase
2021-01-04 15:32:57 +13:00
Renovate Bot
4c52c710b3
Update dependency eslint to v7.17.0 2021-01-04 00:07:54 +00:00
Renovate Bot
2daa87df5b
Update dependency eslint to v7.16.0 2020-12-18 23:06:06 +00:00
Renovate Bot
a0bfec6591
Update dependency @sentry/node to v5.29.2 2020-12-17 20:52:07 +00:00
Renovate Bot
ce6b8364c9
Update dependency sanitize-html to v2.3.0 2020-12-16 16:11:16 +00:00
Daniel Lockyer
2f2b71c2db
v3.40.2 2020-12-16 14:04:43 +00:00
Daniel Lockyer
ea3ebb4735
Updated Ghost-Admin to v3.40.2 2020-12-16 14:04:43 +00:00
Renovate Bot
39489bbc0b Update dependency @tryghost/constants to v0.1.3 2020-12-16 13:46:19 +00:00
Renovate Bot
810989dba8 Update dependency @tryghost/mw-session-from-token to v0.1.13 2020-12-16 13:46:07 +00:00
Renovate Bot
e04f913f1f Update dependency @tryghost/security to v0.2.3 2020-12-16 13:45:49 +00:00
Renovate Bot
b4bb1b46b3
Update dependency @sentry/node to v5.29.1 2020-12-16 11:45:44 +00:00
Naz
31a69d18f0 Improved JSDoc in default scheduler
no issue

- Previously used notation was not a valid JSDoc one. With this correction IDEs will provide more accurate information about all furnction parameters
2020-12-16 17:25:05 +13:00
Renovate Bot
79b723eee6 Update dependency @tryghost/adapter-manager to v0.2.5 2020-12-14 12:18:53 +00:00
Renovate Bot
d37f49508c Update dependency @tryghost/bootstrap-socket to v0.2.4 2020-12-14 12:18:44 +00:00
Renovate Bot
e6b6f74232 Update dependency @tryghost/errors to v0.2.6 2020-12-14 12:18:34 +00:00
Renovate Bot
1cf4d346f7 Update dependency @tryghost/promise to v0.1.3 2020-12-14 12:18:22 +00:00
Renovate Bot
e31c18c013 Update dependency @tryghost/session-service to v0.1.14 2020-12-14 12:17:57 +00:00
Renovate Bot
6383f1dbd7
Update dependency @tryghost/zip to v1.1.7 2020-12-14 05:08:18 +00:00
Naz
c1e3788570 Added central error handler to job manager
refs https://github.com/TryGhost/Ghost-Utils/issues/118

- Duplicating error handling across jobs is not best developer experience. Also, having custom error handling logic did not allow for recommended worker script behavior: allowing for unhandled exceptions to bubble up and be managed by parent process
2020-12-14 18:01:41 +13:00
Kevin Ansfield
8aa55feaf8
Added acceptance test for /member/:id/?include=email_recipients (#12477)
refs c1d66f0b01

- fixed base model allowing '@@INDEXES@@' as a permitted attribute/order
- fixed base model automatically setting `@@INDEXES@@` to null on the model when creating
- added `doAuth('members:emails')`
  - creates an `email_batch` record attached to the first email in the fixtures
  - creates an `email_recipients` record for each member
  - runs analytics aggregation so the email and member counts are as expected
- added acceptance test for `/member/:id/?include=email_recipients`
2020-12-11 18:45:35 +00:00
Renovate Bot
90adc9ed98
Update dependency sinon to v9.2.2 2020-12-11 12:43:36 +00:00
Daniel Lockyer
cbadaa762d
v3.40.1 2020-12-11 11:28:16 +00:00
Daniel Lockyer
0c0b5fb1e0
Updated Ghost-Admin to v3.40.1 2020-12-11 11:28:15 +00:00
Thibaut Patel
1677a05481 🐛 Fixed an issue with zip files parsing.
no issue

Updated gscan to 3.6.1
2020-12-11 12:15:29 +01:00
Daniel Lockyer
78013968e7
v3.40.0 2020-12-10 15:49:37 +00:00
Daniel Lockyer
31ba8029b0
Updated Ghost-Admin to v3.40.0 2020-12-10 15:49:37 +00:00
Fabien O'Carroll
939a54cc35 🐛 Fixed comped flag for members
no-issue

We now include all subscriptions as part of the member, so we need to
ensure the comped flag is only true if the member has an **active**
complimentary plan
2020-12-10 13:14:07 +00:00
Peter Zimon
c856d712ec
Import email refinements (#12473)
* Updated import email subject

* Updated import email title

* Fixed copy in import email to reflect if there was at least one member added
2020-12-10 12:19:26 +01:00
Thibaut Patel
63dde5a46c
Made the package-json module ready to be exported (#12451)
no issue
2020-12-10 11:37:43 +01:00
Kevin Ansfield
c1d66f0b01
Added email_recipients include option to members API read endpoint (#12471)
refs https://github.com/TryGhost/Ghost-Admin/pull/1796

We want to be able to display an email activity timeline in Ghost-Admin for each member. The quickest way to achieve that right now is to provide access to the `email_recipient` data for the member when fetching, this will allow clients to build up a timeline based on the event timestamps included with each email_recipient/email pair.

- sets up `email_recipients` relationship in `Member` model
- updates members API read endpoint to accept an `email_recipients` include parameter
  - appends `email_recipients.email` to the `withRelated` array when `email_recipients` is included so that we have data available for email subject and html/plaintext for previews
- updates members API output serializer to include the email_recipients object in the output
2020-12-10 10:04:05 +00:00
Kevin Ansfield
9586d1ce56 Fixed sqlite storing member email open rate as floats
no issue

- sqlite will store a float in an integer column due to it's type affinity resulting in long decimal numbers in the UI when we're expecting an integer
- use the `ROUND()` function to ensure we're storing integers in place of floats when performing open rate average calculations
2020-12-10 10:00:25 +00:00
Renovate Bot
c2bb7bd106 Update dependency @tryghost/mw-session-from-token to v0.1.12 2020-12-10 09:43:25 +00:00
Renovate Bot
7b4e041203 Update dependency @tryghost/adapter-manager to v0.2.4 2020-12-10 09:43:13 +00:00
Renovate Bot
89f77c8248 Update dependency @tryghost/job-manager to v0.5.0 2020-12-10 09:43:04 +00:00
Renovate Bot
0e6ee237ac Update dependency @tryghost/session-service to v0.1.13 2020-12-10 09:42:48 +00:00
Renovate Bot
712f78bc24
Update dependency @tryghost/helpers to v1.1.35 2020-12-09 21:48:48 +00:00
Kevin Ansfield
24bd2d78cb Fixed validation errors when saving members
no issue

- schema validation was erroring due extra properties on the member resource that were recently added to the output causing the client to send them back when saving
- updated @tryghost/admin-api-schema to include skips for the new read-only properties
2020-12-09 21:47:14 +00:00
Fabien O'Carroll
32fe260763 Updated canary members controller to use new Importer
no-issue

This completely replaces the old import functionality with the new
importer!
2020-12-09 19:25:57 +00:00
Fabien O'Carroll
ff12d7a89a Updated @tryghost/members-{api,csv} for importer
no-issue

- Updates members-api to throw errors when attempting to link to
  stripe customers if it is not configured, which allows us to include
  the errors in the CSV

- Updates members-csv to handle the header mappings as well as parsing
  the values so that we can read a CSV file and get back valid member
  objects
2020-12-09 19:25:57 +00:00
Fabien O'Carroll
cfad396652 Exported MembersCSVImporter from Members service
no-issue

This will allow the controller to be updated to use the new importer
2020-12-09 19:25:57 +00:00
Fabien O'Carroll
ff7773d1cf Added new members importer module
no-issue

This module encapsulates the work around performing imports, it
currently uses the concept of a "Job" which at the moment is not
persisted to the database, however when we want to look at resuming
imports after a server restart, this should give us the flexibility to
do it.
2020-12-09 19:25:57 +00:00
Fabien O'Carroll
c7359a083f Added email template for completion of background jobs
no-issue

This will be used to generate email content used for notifying users
that their import has been completed.
2020-12-09 19:25:57 +00:00
Fabien O'Carroll
73dc19e498 Removed Members CSV import validation endpoint
no-issue

The new import flow does not use prevalidation of the CSV file, so we
have no use for this anymore.
2020-12-09 19:25:57 +00:00
Fabien O'Carroll
83c5270217 Removed support for batched CSV importer
no-issue

We are rewriting the Members CSV importer to use background jobs, the
batched importer will no longer be used locally.
2020-12-09 19:25:57 +00:00
Kevin Ansfield
baf635e27b Updated email stats aggregator for new member count columns
refs https://github.com/TryGhost/Ghost/issues/12461

- added two default aggregations for overall email count and opened email count
- when number of tracked emails is sufficient add the open rate aggregation to the update query
2020-12-09 13:14:39 +00:00
Kevin Ansfield
b1aafd715d
Added members.email_{count,opened_count} column migrations (#12470)
refs https://github.com/TryGhost/Ghost/issues/12461

- adds `members.email_count` and `members.email_opened_count` columns to contain cached counts for faster queries when outputting member data via API
- adds migration to populate cached counts with existing data
  - tested locally on ~50k members which took ~4sec on mysql
- updates members output serializer to include the new fields in API output
2020-12-09 12:21:56 +00:00
Thibaut Patel
c25344d414
Refactored core/server/lib/image for Dependency Injection (#12463)
no issue
2020-12-09 13:19:22 +01:00
Renovate Bot
e91f740ade Update dependency jwks-rsa to v1.12.0 2020-12-09 09:57:24 +00:00