Commit Graph

8848 Commits

Author SHA1 Message Date
Rishabh
128a7299c7 Merged v4.41.2 into main
v4.41.2
2022-03-23 21:10:24 +05:30
Simon Backx
159f56b0d2 Wired all the dashboard 5.0 charts with the stats service
refs https://github.com/TryGhost/Team/issues/1442

All the data from the charts now come from the dashboard stats service
2022-03-23 16:38:57 +01:00
Sanne de Vries
101ebadc47 Updated .lint-todo file 2022-03-23 15:06:04 +00:00
Daniel Lockyer
419ddf5f9f v4.41.2 2022-03-23 15:06:02 +00:00
Sanne de Vries
81463954e4 Updated Email settings page to accommodate multiple newsletters
Refs https://github.com/TryGhost/Team/issues/1441

- Rearranged the page: publish-menu preview is removed because the publish flow will change.
- Email addresses setting removed because it will be set on an individual newsletter level
2022-03-23 14:41:24 +00:00
Simon Backx
cbc7429f69 Added separate dashboard 5.0 mocking service
refs https://github.com/TryGhost/Team/issues/1432

- All mocking logic is moved to the dashboard-mocks service
- Added @days property support and loading to first dashboard 4 graphs.
- 2 years state button added
2022-03-23 11:53:32 +01:00
Simon Backx
98c93b66c8 Added dashboard 5.0 stats service and days dropdown
refs https://github.com/TryGhost/Team/issues/1432

- Added very basic state selection at the bottom of dashboard 5.0
- Added a dashboard stats service, who is responsible for fetching and returning stats data
- Added POC for days dropdown with communication and reload between ember components
- Added proper automatic number and plural formatting for member counts
2022-03-23 10:05:47 +01:00
Rishabh
636a1b3588 Merged v4.41.1 into main
v4.41.1
2022-03-23 14:19:43 +05:30
Daniel Lockyer
2e652bbab1 v4.41.1 2022-03-23 08:24:59 +00:00
Rishabh Garg
7080505004 🐛 Fixed error on saving a paid member (#2312)
refs https://github.com/TryGhost/Team/issues/1435
refs a47b61c1d4

A recent change for showing all subscriptions of a member on detail screen introduced a circular json structure with subscription -> tiers -> subscriptions, which throws an error on saving any member with paid subscription on member detail screen.
2022-03-22 22:41:22 +05:30
James Morris
d05d22c177 Better faked graphs and various tweaks for Dashboard 5.0 prototype
refs: https://github.com/TryGhost/Team/issues/1436

- added in lots of demo graphs using EmberChart
- renamed some files in v5 folder for better conventions
- put each graph for new dashboard into separate components
2022-03-22 21:59:47 +05:30
Rishabh Garg
fcf7f516b8 🐛 Fixed error on saving a paid member (#2312)
refs https://github.com/TryGhost/Team/issues/1435
refs a47b61c1d4

A recent change for showing all subscriptions of a member on detail screen introduced a circular json structure with subscription -> tiers -> subscriptions, which throws an error on saving any member with paid subscription on member detail screen.
2022-03-22 21:58:21 +05:30
Simon Backx
8937e09436 Added placeholder components and skeleton for dashboard 5 prototype
refs https://github.com/TryGhost/Team/issues/1432
2022-03-22 12:11:14 +01:00
Simon Backx
96d02a208d Fixed linting issues in dashboard 5 component 2022-03-22 09:58:42 +01:00
Simon Backx
829fee29da Added better POC styling for dashboard 5
refs https://github.com/TryGhost/Team/issues/1432
2022-03-22 09:04:52 +01:00
Simon Backx
da9298b6f0 Added some basic prototype toggles
refs https://github.com/TryGhost/Team/issues/1432
2022-03-21 19:02:57 +01:00
Simon Backx
7c96a1d562 Added dashboard 5.0 component
refs https://github.com/TryGhost/Team/issues/1431
2022-03-21 18:08:13 +01:00
Simon Backx
b7689ffe9d Added dashboard 5.0 feature flag
refs https://github.com/TryGhost/Team/issues/1431
2022-03-21 17:35:14 +01:00
Peter Zimon
303506dcba Added multiple newsletters flag 2022-03-21 16:11:53 +01:00
Daniel Lockyer
1832e7dc93 v4.41.0 2022-03-21 11:38:12 +00:00
Renovate Bot
866ff27539 Update actions/setup-node action to v3 2022-03-21 11:00:12 +00:00
Renovate Bot
5761dae33a Update dependency @tryghost/helpers to v1.1.61 2022-03-21 09:55:57 +00:00
Renovate Bot
9eb75b4cb3 Update actions/checkout action to v3 2022-03-21 09:54:27 +00:00
Peter Zimon
4d81b40573 Added Headline theme to design settings 2022-03-21 10:45:32 +01:00
Daniel Lockyer
691f2fc64e Deduped dependencies via yarn-deduplicate
refs ce81d907b6
refs 8b5b0b12e8

- we've added some Renovate config to run this automatically but we
  should run this manually first so the first dependency bump won't
  contain extraneous cleanups
2022-03-21 09:20:44 +00:00
Daniel Lockyer
a6950c9f3f Updated lockfile v2
- not sure why these changes weren't picked up before
2022-03-21 09:20:03 +00:00
Daniel Lockyer
835fa044ec Updated lockfile 2022-03-20 19:21:37 +00:00
renovate[bot]
7d29b66ab6 Update dependency ember-simple-auth to v4.2.1 (#2305)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-18 18:43:40 +00:00
renovate[bot]
95217fc07b Update dependency @joeattardi/emoji-button to v4.6.4 (#2308)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-18 18:43:22 +00:00
renovate[bot]
e2e28c74a5 Update dependency papaparse to v5.3.2 (#2304)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-18 18:42:42 +00:00
renovate[bot]
622711038a Update dependency @tryghost/members-csv to v1.2.8 (#2302)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-18 18:42:15 +00:00
renovate[bot]
98e6ed6b5e Update dependency @tryghost/timezone-data to v0.2.60 (#2301)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-18 18:42:03 +00:00
renovate[bot]
3245edf710 Update dependency @tryghost/color-utils to v0.1.12 (#2299)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-18 18:41:43 +00:00
Thibaut Patel
a47b61c1d4 Added canceled subscriptions in member detail screen (#2287)
refs https://github.com/TryGhost/Team/issues/1141

Showing canceled subscriptions provide a more complete picture of the activity of a member.

- Given there is no `member.product` object when a subscription is canceled, use the `member.subscriptions.price.product` objects instead of `member.products`.
- applied boy-scout rule for linter errors and and code formatting
- removed `multipleTiers` flag conditionals as it's now GA
- set up subscriptions as a separate mirage resource so they are easier to work with
    - updated `PUT /members/:id/` endpoint to match real API's complimentary subscription behaviour
    - modified mirage member serializer to match API output

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2022-03-18 16:15:42 +00:00
Daniel Lockyer
2fd52f009d v4.40.0 2022-03-18 16:00:40 +00:00
Kevin Ansfield
091ae194bf 🐛 Fixed duplicate email open rate column when filtering members by open rate
no issue

- email open rate is shown by default so we don't need to add the column a second time when the list is filtered by that data
- added `email_open_rate` to the default columns list so it's ignored when adding any filtered-by columns
2022-03-17 09:29:15 +00:00
Matt Hanley
b0bd691d52 Merged v4.39.1 into main
v4.39.1
2022-03-16 14:48:44 +00:00
Daniel Lockyer
d2eee5b7a5 v4.39.1 2022-03-16 14:47:02 +00:00
Kevin Ansfield
129d202595 🐛 Fixed slow loading and high memory usage of members list screen
refs https://github.com/TryGhost/Team/issues/1423

- problem:
  - all members requests were automatically adding `?include=email_recipients` as the email recipients relationship was set up to be always embedded
  - embedded email_recipient records also embed the whole email record
  - on the members index screen this meant for each of the 50 members loaded on a page we were also loading every email they have ever received resulting in a huge API response
  - this was not a problem previously because the API was ignoring the `include` parameter on the browse endpoint and Admin wasn't formatting the include properly in snake_case
- solution:
  - the only place we need associated email recipients is on the member details screen where they are used to show the email activity feed
  - removing the `{embedded: 'always'}` option for the `member.emailRecipients` association stops `?include=email_recipients` being added automatically to every members request
  - the member details screen explicitly adds `?include=email_recipients` so no further changes are needed
  - activity feed will be changing to use proper event objects in the future and further optimisation can be made
2022-03-16 14:33:56 +00:00
Peter Zimon
004a483bb1 Fixed unsplash icon positioning in design settings 2022-03-16 08:51:14 +01:00
Kevin Ansfield
fcb27507d3 🐛 Fixed slow loading and high memory usage of members list screen
refs https://github.com/TryGhost/Team/issues/1423

- problem:
  - all members requests were automatically adding `?include=email_recipients` as the email recipients relationship was set up to be always embedded
  - embedded email_recipient records also embed the whole email record
  - on the members index screen this meant for each of the 50 members loaded on a page we were also loading every email they have ever received resulting in a huge API response
  - this was not a problem previously because the API was ignoring the `include` parameter on the browse endpoint and Admin wasn't formatting the include properly in snake_case
- solution:
  - the only place we need associated email recipients is on the member details screen where they are used to show the email activity feed
  - removing the `{embedded: 'always'}` option for the `member.emailRecipients` association stops `?include=email_recipients` being added automatically to every members request
  - the member details screen explicitly adds `?include=email_recipients` so no further changes are needed
  - activity feed will be changing to use proper event objects in the future and further optimisation can be made
2022-03-15 18:26:24 +00:00
Peter Zimon
c4644ca7a9 Changed default offer display title 2022-03-15 12:31:27 +01:00
Kevin Ansfield
4e1f292c74 Revert "Removed unused modal files"
This reverts commit 1b4126b6f0.

- this was in error, `settings/members/archive-tier` wasn't a modal file
2022-03-14 12:38:39 +00:00
Kevin Ansfield
85d7932e45 Resolved deprecation warnings for dynamic modal component binding (#2303)
refs https://github.com/TryGhost/Team/issues/559
refs 054a5f15f5

- with the update of `ember-promise-modals` we started to get deprecation warnings when using `modals.open('modal-component-name')`
  - upcoming Ember build updates will introduce tree shaking but using run-time lookup of modal components by name works against that because it's not statically analysable
- switched to importing components and passing the component class directly, eg. `modals.open(ModalComponent)`
- standardized modal component class names with a `MyModal` style to get better behaviour in code editors when it auto generates imports
- dropped the modal defaults from the modals service because we can now use a static `modalOptions` property on the modal components themselves when we want to override the defaults
2022-03-14 10:52:04 +00:00
Kevin Ansfield
32658c25c2 Fixed linter errors in <ModalProduct> template
no issue

- dropped unnecessary/invalid nested `<form>` elements
2022-03-14 10:51:19 +00:00
Kevin Ansfield
7374b0f8c6 Fixed errors thrown in tests that were causing random failures
no issue

- dropped `id` attribute added to `<GhBenefitItem>` because it was only using the index resulting in multiple `id="1"` on the page which is invalid HTML and caused Glimmer to complain
- added a check for `portalPreviewIframe` existence when the portal message listener in the offer controller is fired because it was occurring out of sync with the tests and throwing async errors that were picked up in random later tests
2022-03-14 10:28:58 +00:00
Kevin Ansfield
0be1f206a5 Removed unused modal-custom-view-form.js file
no issue

- the `custom-view-form` modal has been migrated to the newer modal style but the original modal's component file wasn't cleaned up
2022-03-14 10:00:40 +00:00
Kevin Ansfield
1b4126b6f0 Removed unused modal files
no issue

- we had two archive-tier modals with the version living in `modals/tiers/archive` being the only one used
2022-03-14 09:46:49 +00:00
Kevin Ansfield
4d8c12d2b8 Fixed sticky URL when using Escape to close view theme modal
no issue

- we were missing handling for the view-theme modal being closed outside of a route transition meaning the URL would stay on `/settings/design/view-theme/Theme` even though it's the index that was shown, preventing the same theme being viewable again and back/forward behaving as expected
2022-03-11 19:14:16 +00:00
Kevin Ansfield
4db4233b87 Fixed integration edit page not showing after creating new integration
refs 054a5f15f5

- `beforeClose` behaviour has changed slightly with the upgraded ember-promise-modals
- added a guard for the modal existing when transitioning back to the integrations index screen, this makes sure we're not transitioning back to the index screen after the modal has already initiated a transition to the integration edit screen
2022-03-11 19:10:44 +00:00