Commit Graph

343 Commits

Author SHA1 Message Date
cobbspur
2a55595191 Increased visibility of trash can in image uploader for broken url
closes #838

- adds a min height value to pre-image-uploader scss
2013-09-26 18:33:09 +01:00
John O'Nolan
58873a9fc3 Stripped obsolete CSS3 prefixes 2013-09-26 15:26:00 +01:00
John O'Nolan
d1957958e3 Cleanup indentation and quotes
Aligns all requirements vertically for easier reading + adds single quote standard consistently throughout Ghost, except in long strings.
2013-09-26 15:06:31 +01:00
Hannah Wolfe
b787cc6639 Image upload start event fired earlier
issue #882
2013-09-26 12:35:03 +01:00
cobbspur
90e4637ede Image Upload URl saves in the right place
closes #864

- adds trigger - uploadstart to url handler
2013-09-26 12:34:59 +01:00
Matthew Harrison-Jones
67132ff28b Bug Fix: Date Keyboard Shortcut no-longer crashes the browser 2013-09-26 11:22:02 +01:00
John O'Nolan
598915a125 Stripped obsolete CSS3 prefixes 2013-09-24 18:44:32 +02:00
Hannah Wolfe
32d1076d35 Correct validation message for short passwords
closes #833
2013-09-19 08:41:04 +01:00
Hannah Wolfe
5528423636 Client & Server side validation for posts per page
closes #839

- caused a 500 error
2013-09-19 07:55:37 +01:00
Hannah Wolfe
477c4c59fa Merge pull request #843 from cgiffard/500-errors
500 Series Error Handling & Stack Traces
2013-09-18 22:52:52 -07:00
Christopher Giffard
9c8b02949a 500 Series Error Handling & Stack Traces
Fixes #825

- Changes the way the error middleware is delivered in server.js, moving
  all the logic back into errorHandling.js
- Alters error logging to use console.error (probably more appropriate) instead
  of console.log
- Changes error tests to accomodate for these alterations
- Alters user-error and error hbs templates to incorporate stack traces
- Adds additional styling for error pages to accomodate stack traces
- Added logic to parse and deliver formatted stack traces

Notes:
======

- Jslint gets in the way of the regex I've got to use to parse the stack.
  (It cites 'security reasons' which are not relevant in this case.)
  I needed to add a condition to relax it at the top of errorHandling.js
- The stack trace should probably be added as a partial, but I figured it
  was out of scope for this PR.
2013-09-19 13:01:20 +10:00
William Dibbern
4ff6162d79 Expanded spelling of chars to characters
Fixes #834

- Updated error message for password length to use "characters" instead
of "chars".
2013-09-18 21:51:56 -05:00
John O'Nolan
a7a14fac22 New default user image 2013-09-18 22:34:01 +01:00
Hannah Wolfe
eb7a63bd1d Fixing tag save event
- lost in a bad merge somewhere
2013-09-18 20:04:39 +01:00
Hannah Wolfe
7193f05376 Default user image and cover
closes #812

- replace defaults with consistently named .png files
- change the settings saving code so that it doesn't double-save images and save the defaults to the db
2013-09-18 15:54:52 +01:00
Matthew Harrison-Jones
2cd763d7f5 Bug Fix: Images in the Settings no longer breakout of their container in Firefox 2013-09-18 10:20:34 +01:00
Hannah Wolfe
1fc7966a5c Merge pull request #808 from gotdibbs/Issue788
Corrected settings menu bugs
2013-09-17 19:14:59 -07:00
Hannah Wolfe
7be4362523 404 Page vertical centering
closes #791
2013-09-18 03:07:22 +01:00
William Dibbern
ebe70534c2 Corrected settings menu bugs
Fixes #788

- Toggles now close all any other open toggles.
- Added .active class for post settings menu to ensure highlight stays
on settings icon/button until it is closed, not just on hover.
2013-09-17 20:59:35 -05:00
Hannah Wolfe
00b60a7a74 Clear notifications before adding new ones
closes #783

 - I think there's probably a nicer solution than putting clearEverything() everywhere, but that would also probably involve significant refactoring.
2013-09-18 02:48:38 +01:00
John O'Nolan
60bb02ad6a Throttle scrolling. LIKE A BAWS.
See #481
2013-09-18 02:09:21 +01:00
Hannah Wolfe
a18f5e7181 Post settings menu success notifications
closes #786
2013-09-18 01:46:10 +01:00
ericterpstra
371f8ce0b1 Set post-settings date to 12:00 2013-09-17 18:54:01 -05:00
Hannah Wolfe
a4aefb2b8e Merge pull request #803 from nicoburns/fastclick
Fastclick
2013-09-17 16:34:53 -07:00
nicoburns
d7a47858ba Added FastClick to assumed globals for tests 2013-09-17 22:57:40 +01:00
Hannah Wolfe
b15b8d03da Clearing out images we don't use 2013-09-17 22:28:28 +01:00
nicoburns
f3a824bda5 Changed back button text
- Changed back button text from "Cancel" to "Back"
- Removed box-shadow from back buttons
2013-09-17 22:25:26 +01:00
nicoburns
3b3d7a7c34 Replaced Hammer.js with FastClick
Issue #149 Closes #519
- Uses FastClick to speed up click events instead of using Hammer.js tap
events
2013-09-17 22:11:13 +01:00
Hannah Wolfe
ae01e5eeae Editor notification cleanup
closes #666

- no more split messaging
2013-09-17 21:35:30 +01:00
James Inman
38ae87524d Notification cleanup
Closes #666.

* Adding new error notifications (removed post name, cleaned up statuses) when creating/updating a post
* Removing scheduled from the maps and changing the text of publish-on
* Made temporary "Scheduled publishing is not supported yet." message display in a proper error container, plus a slight grammar fix.
* Removed ; from the start of validation errors on post error, as the previous sentence finishes with a .
2013-09-17 21:19:07 +01:00
John O'Nolan
56620635db Merge pull request #800 from M165437/issue-149
Add back button to settings and content preview
2013-09-17 12:55:52 -07:00
Matthew Harrison-Jones
2305329041 Complete Modal Refactor
* Smoother animations
* Removed blurring in Chrome temporarily
* Centering is now done in CSS (the height is calculated in JS to work in FF and Opera)
* Modals now need close: true to be set to enable the close icon and shortcuts for closing (ESC key, background clicking)
2013-09-17 20:40:19 +01:00
Michael Schmidt-Voigt
08ed07372f Add back button to settings and content preview
Issue #149
- added back button to content preview and settings
- added hammer.js interactions
- needs some tweaking for mobile view
- problems with touch events (additional click event after 300ms)
2013-09-17 15:58:41 -03:00
cobbspur
757ed3a8f5 Added url functionality for image uploads
closes #701, closes #702

- if image upload is called from editor the url icon provides a text field and a save button
- if on settings pages (general and user) the save button will capture the entered url or uploaded url
- both modes have the reset button
- fixed bug that is created by url when image is dragged onto window
2013-09-17 19:15:32 +01:00
Matthew Harrison-Jones
4930c7c479 Updated Upload Modal Icon 2013-09-17 18:36:47 +01:00
John O'Nolan
438279a1a0 ONE. PIXEL. 2013-09-17 13:04:43 +01:00
John O'Nolan
14d07ef98a Restyled delete post-settings menu item 2013-09-17 13:02:20 +01:00
John O'Nolan
d674996dce Fix wonky settings icon alignment 2013-09-17 12:32:56 +01:00
Hannah Wolfe
83e655701c Post settings menu tweaks
closes #782, #783

- delete button hidden until ID
- publish date works before publish
2013-09-17 11:51:24 +01:00
John O'Nolan
b6b019621a Make user profile images always fit their circle
Closes #778
2013-09-17 11:03:55 +01:00
Hannah Wolfe
357cb9f201 Post settings gets published_at
closes #773

- listen for change events on published_at
- change all listeners in views to use this.listenTo
2013-09-17 10:26:28 +01:00
William Dibbern
9f4122d0cd Ability to spawn multiple notifications
Fixes #696

- Updated notifications logic to deal directly with the individual
notification, rather than the notification container.
2013-09-16 22:43:18 -05:00
Hannah Wolfe
ce57b46358 More trailing slashes 2013-09-17 02:52:29 +01:00
John O'Nolan
650bdce220 Merge pull request #777 from nicoburns/notification-color-fix
Fix notification link color
2013-09-16 18:48:52 -07:00
cobbspur
713e4c0d5c Adds slashes to urls
ref issue #448

- adds slashes to urls, templates and tests

TODO

Add function to add slash to urls automatically
2013-09-17 02:39:55 +01:00
nicoburns
09008672b2 Fix notification link color
Closes #772
- Changed notification link color inherit, and added underline
2013-09-17 01:32:59 +01:00
Hannah Wolfe
8c76706bb0 Merge pull request #758 from ErisDS/uploads-in-editor
Save image uploads in the editor
2013-09-16 13:37:49 -07:00
Hannah Wolfe
2c6dd77b1d Merge pull request #768 from matthojo/Image-Keyboard-Shortcut
Improved Image keyboard shortcut
2013-09-16 10:13:46 -07:00
Hannah Wolfe
0021fb7a95 Save image uploads in the editor
closes #295

- Maintain a list of markers for CodeMirror which reference image codes
- Upload start triggers a selection
- Upload success replaces the selection
- No ref-style image markdown handling
- Showdown image URL handling improved at the expense of titles
- Tests updated
2013-09-16 18:08:49 +01:00
Matthew Harrison-Jones
0dd1e72897 Improved Image keyboard shortcut
Image keyboard shortcut now inserts a new line when on a line with text
2013-09-16 15:18:33 +01:00
Hannah Wolfe
cefa0e14ef Merge pull request #764 from matthojo/Flash-Bar
Renamed the notifications container
2013-09-16 06:07:55 -07:00
Hannah Wolfe
cb38bb961a Merge pull request #710 from matthojo/Mobile-Tags
Improved Post tagging on Mobile devices
2013-09-16 02:34:28 -07:00
John O'Nolan
03419f12e0 Tweak icon mixin adjustments to reduce compiled filesize
See #509
2013-09-16 10:04:16 +01:00
U-nico-laptop\nico
957ca3c58b Fixed 'extend' compile errors in SASS 3.3
closes #509
- Replaced @extend directive with a functionally equivalent mixin
2013-09-16 10:04:16 +01:00
Hannah Wolfe
1ee0d51660 Merge pull request #730 from jgable/gruntClientFiles
Compile assets with grunt
2013-09-16 01:57:08 -07:00
Matthew Harrison-Jones
2fe7eda8e2 Renamed the notifications container
Renamed from `#flashbar` to `#notifications`
2013-09-16 09:46:29 +01:00
Hannah Wolfe
32be5aaf8b Merge pull request #763 from sebgie/issue#600
Improve error message
2013-09-16 01:32:53 -07:00
Sebastian Gierlinger
d5b197656b Improve error message
closes #600
- replaced '?' with 'Server was not available'
- added request.statusText
2013-09-16 10:16:42 +02:00
Hannah Wolfe
8af09e2dd1 Merge pull request #762 from ericterpstra/402-pub-date
Enabled post setting to change published date
2013-09-16 01:10:33 -07:00
Hannah Wolfe
281177d08e Merge pull request #757 from gotdibbs/Issue258
Infinite Scroll Pagination for content screen
2013-09-16 01:05:27 -07:00
Matthew Harrison-Jones
d5ea96eb20 Bug Fix: Clicking on a Tag on the Mobile Tag view screen will no longer shrink the view 2013-09-16 08:59:10 +01:00
Matthew Harrison-Jones
7f296c9886 Bug Fixes: Tags no longer overlap 'settings' icon and scroll bars have been removed 2013-09-16 08:34:38 +01:00
Matthew Harrison-Jones
9cfa053dd1 Improved Post tagging on non Mobile devices 2013-09-16 08:34:38 +01:00
Matthew Harrison-Jones
0c8f787186 Improved Post tagging on Mobile devices 2013-09-16 08:34:38 +01:00
ericterpstra
71c99913f6 Enabled post setting to change published date
closes #402
2013-09-15 22:19:53 -05:00
William Dibbern
4b8806ec1d Infinite Scroll Pagination for content screen
Fixes #258

- Modified post collection to have default values for paging.
- Added scroll handler to content view to check for more posts and load
as appropriate.
- Sanitized result from server-side post paging, ensure page # is
returned as an integer.
- Added a functional test stub.
2013-09-15 18:34:23 -05:00
Hannah Wolfe
881e861295 Merge pull request #754 from gotdibbs/Iss667
Publish button amendments
2013-09-15 15:16:41 -07:00
John O'Nolan
fe17e1f385 User profile refactor
Fixes #708
2013-09-15 22:42:30 +01:00
William Dibbern
07629dd9ab Publish button amendments
Fixes #667

- Removed superfluous as-of-yet-unused options in the publish menu.
- Adjusted display names of publish buttons according to differing
states the publish menu can be in (new post, saved draft, published
post).
- Added red highlight style to "important" status change options in the
publish menu (draft => published, published => unpublished).
- Added suite of functional tests around new labels and classes.
2013-09-15 14:52:09 -05:00
John O'Nolan
aa982c2d31 CSS code standards cleanup 2013-09-15 20:18:37 +01:00
Jacob Gable
63eb9581ea Compile assets with grunt
- Made a helper called ghostScriptTags that will spit out the relevant
  script tags with version parameter; 4 unminified files in development,
  1 minified file in production.
- Added grunt concat and uglify tasks to build files into core/built
- Fixed some unit tests by making them native date objects
2013-09-15 14:06:42 -05:00
John O'Nolan
c7fcdb625f Set input:focus to less extreme border / code standards cleanup 2013-09-15 19:33:40 +01:00
John O'Nolan
6abc9ea3c5 Introduce button active state
Fixes #740
2013-09-15 19:28:06 +01:00
Hannah Wolfe
0b0dc15c8e Handling HTML in notifications
closes #729
2013-09-15 18:19:56 +01:00
Hannah Wolfe
7635ddee78 Getting frontend notifications back
closes #738
2013-09-15 18:19:11 +01:00
Hannah Wolfe
117f70dcfd Merge pull request #752 from sebgie/settingsapi
Add setting filter
2013-09-15 09:53:23 -07:00
Hannah Wolfe
9338d93b26 Merge pull request #750 from cobbspur/images
Fixed settings general pane to display current blog cover in uploader
2013-09-15 09:15:24 -07:00
Hannah Wolfe
5128e1ce62 Merge pull request #751 from cobbspur/hover
Added hover state for blog-logo and blog-cover using existing ids
2013-09-15 09:14:54 -07:00
Hannah Wolfe
a4016b857c Automatically focus title on editor
closes #719
2013-09-15 17:10:57 +01:00
Sebastian Gierlinger
bd8db968ea Add setting filter
closes #172
- added type to ghost.settings()
- added /api/settings?type=<filter>
- added availableThemes to settingsCache
- removed cachedSettingsRequestHandler
- removed /api/themes (including front end)
- changed activePlugins to type "plugin" in default-settings.json
2013-09-15 18:04:01 +02:00
cobbspur
2e6e7afe93 Added hover state for blog-logo and blog-cover using existing ids
- blog-logo and blog-cover now have a hover state of cursor: pointer
2013-09-15 16:47:38 +01:00
cobbspur
d86d26b957 Fixed settings general pane to display current blog cover in uploader
- removed unused ids and options.id from uploadImage modal template
2013-09-15 15:54:12 +01:00
Hannah Wolfe
9fa659aeee Merge branch 'new-data-model' 2013-09-15 00:36:54 +01:00
John O'Nolan
bc3b3b8669 Tweak breakpoint 2013-09-14 23:51:49 +01:00
John O'Nolan
51df11c1a4 Fix #744 2013-09-14 23:50:04 +01:00
John O'Nolan
2aabad3c58 Bump settings save button up to navbar 2013-09-14 23:27:34 +01:00
Hannah Wolfe
d968495996 Mass renaming of things
Conflicts:
	core/client/views/settings.js
	core/server/models/user.js
2013-09-14 21:56:07 +01:00
Sebastian Gierlinger
35a32279d9 Clean up config (drop 'env')
closes #628
- removed .env from config.js
- ghost.config() returns correct config for NODE_ENV
- removed .env[process.env.NODE_ENV]
- updated tests
- deleted users.hbs, plugins.hbs, appearance.hbs (forgot to delete in PR #649)
2013-09-14 13:14:00 +01:00
Gabor Javorszky
6c99b67ab3 Added client side validation
Closes #581.

* Basically adds the client side of node validator, that we're already using
* Validator is plonked onto `Ghost.Validator`
* Usage is identical as to https://github.com/chriso/node-validator
* Has sanitizing values et al
* `Ghost.Validator.error` is redefined, it populates Ghost.Validator._errors (Array)
* `Ghost.Validator.handleErrors` is supposed to print out the multiple error messages, if there are multiple (this is broken due to how notifications are presented `.html` instead of `.append`), and also apply class to element
* The ajax calls are wrapped in an if to prevent network traffic if something's not right on client side
* Added validation to general settings and user settings screens.
* On validation error, optionally adds `.input-error` to whatever element you reference, see below (if `el` exists on the error object). This is the only place where usage is different to the original implementation. Redeclared `error()` function in `init.js`
* Usage: `Ghost.Validate.check(valueToCheck, {message: "the error message", el: $('#the element')}).isEmail()`
* The element above will receive the `.input-error` class. `isEmail()` is one of the stuff you can check against.
2013-09-14 10:52:27 +01:00
Hannah Wolfe
d00392973f Merge pull request #727 from sethlilly/issue-700
Replaced default user image for navbar
2013-09-13 14:32:36 -07:00
Seth Lilly
3ca843e962 Replaced default user image for navbar
Replaced default user image for navbar

closes #700
- Replaced photo of John (sorry, man) with a smaller version of the default heart user photo
2013-09-13 16:48:04 -04:00
ericterpstra
e2bc5257a6 Added post-settings menu with edit permalink field
closes #370
- Added new Backbone view for post settings menu
- Moved sass styles to global.scss for post settings menu items
- Added field to change post slug (permalink) using existing slug
  validation
2013-09-13 12:36:38 -05:00
John O'Nolan
60635991db Added option for large buttons 2013-09-12 18:34:21 +02:00
Hannah Wolfe
cc785cc981 Merge pull request #686 from matthojo/Sign-up-screen-UI
Improved Auth screen markup and validation checks
2013-09-12 06:25:27 -07:00
Hannah Wolfe
4cd9f79116 Merge pull request #703 from matthojo/Dashboard-Removal
Temporarily removed the Dashboard and all references
2013-09-12 06:19:59 -07:00
Matthew Harrison-Jones
2678de902d Improved Auth screen markup and validation checks
* Signup now focuses on 'name' on load
* Fixed fade in on auth forms to work with `display: table`
* The 'name' field is required on Sign up forms
* The length check on the Signup form is in order of inputs
* Added check for password length
* Changed the auth form class names to better represent individual pages
* Updated CasperJS tests
2013-09-12 09:59:58 +01:00
Sebastian Gierlinger
cfb83d6e40 Fix for image upload with clean database
no issue
- reversed workaround for PUT to model
- changed save function for image to unset availableThemes
2013-09-11 16:45:59 +00:00
Hannah Wolfe
eadc8b9371 Fixing minor bug in settings template 2013-09-11 16:27:54 +01:00
Matthew Harrison-Jones
a85e8e1efc Temporarily removed the Dashboard and all references
This also updates the CasperJS to match the new changes.
2013-09-11 15:38:09 +01:00
Hannah Wolfe
f84de01dc0 Merge pull request #698 from skattyadz/issue-642
Allow UPPERCASE in tag names
2013-09-11 06:53:24 -07:00