Commit Graph

378 Commits

Author SHA1 Message Date
Hannah Wolfe
025efe6d54 Merge pull request #5778 from kevinansfield/mobile-preview
Mobile markdown/preview tabs
2015-09-01 19:02:05 +01:00
Kevin Ansfield
353dc512bb Mobile markdown/preview tabs
refs #5652
- on mobile, add Markdown/Preview links to the editor footer that switch between the respective views
- temporary resolution to the inability to upload on mobile without access to the preview
2015-09-01 18:14:40 +01:00
Hannah Wolfe
09bcbb9463 Form field icons load in default 'grey' state
ref #5652

- validations can be in default, success or error state
- adds check for 'hasValidated' if the validations haven't fired yet, the field is in the default state
- hasValidated is an Ember.Array which tracks the state for each field
2015-09-01 13:02:27 +01:00
Hannah Wolfe
2da1a06196 Merge pull request #5772 from kevinansfield/minor-tag-input-updates
Don't show selectize dropdown when input field is blank
2015-09-01 12:23:04 +01:00
Kevin Ansfield
58c60f5662 Merge pull request #5764 from ErisDS/issue-5762-psm
Improve error handling for the PSM
2015-09-01 12:22:10 +01:00
Hannah Wolfe
fc4ef38db8 Add email validation back to signin
refs #5745

- signin form was not checking email address was valid
2015-09-01 11:31:57 +01:00
Kevin Ansfield
194bc209a9 Merge pull request #5769 from ErisDS/issue-5767
Fix double-click & enter/o editing shortcuts
2015-09-01 11:00:15 +01:00
Kevin Ansfield
169384c3c7 Don't show selectize dropdown when input field is blank
no issue
- modify behaviour of selectize's `openOnFocus` option by ensuring that the dropdown is not opened when the input field is blank
- fixes issue with dropdown opening when content is loaded async despite `openOnFocus=false`
- fixes issue with dropdown remaining open when user enters text then deletes it
2015-09-01 10:40:41 +01:00
Hannah Wolfe
e574edf240 Merge pull request #5759 from kevinansfield/basic-post-search
Basic post/user search
2015-09-01 10:27:05 +01:00
Kevin Ansfield
a91cd2210e Basic post/user search
refs #5343, #5652
- implements basic post and user search using selectize input
- queries minimal API endpoint and refreshes results on search input focus if results are older than 60 seconds
2015-08-31 22:47:26 +01:00
cobbspur
42b76a2778 Prevent gh-spin-button from infinite spin
closes #5768

- Always set showSpinnerTimeout back to null after 1 second.
2015-08-31 13:41:01 +01:00
Hannah Wolfe
16ca8c65a9 Fix double-click & enter/o editing shortcuts
closes #5767

- readd action for double click
- use model for openEditor
2015-08-31 10:58:34 +01:00
Kevin Ansfield
a1f8a5f81c Merge pull request #5766 from JohnONolan/colourrrr
Minor colour update
2015-08-31 09:06:22 +01:00
John O'Nolan
c22d23d355 Minor colour update 2015-08-31 08:04:09 +02:00
Hannah Wolfe
7dd0c0cf85 Improve error handling for the PSM
closes #5762

- changes date to use proper inline validation
- changes meta_title & desc to also use inline validation
- meta_title & desc also give proper errors on save
- title too long causes proper error on save
2015-08-30 17:26:52 +01:00
Hannah Wolfe
2476da2b2a Merge pull request #5760 from cobbspur/emptyValidations
No validations on setup for empty fields
2015-08-28 20:16:15 +01:00
Hannah Wolfe
e4d689b989 Merge pull request #5758 from cobbspur/invitecheck
Prevent invite action in step 3 of setup being triggered at wrong time
2015-08-28 19:18:06 +01:00
Hannah Wolfe
fad986673a Merge pull request #5709 from kevinansfield/tag-name-comma-validation
Validate leading commas in tag names
2015-08-28 19:03:31 +01:00
Hannah Wolfe
7f33ae0189 Merge pull request #5752 from kevinansfield/content-mgmt-mobile-nav
Fix broken content mgmt -> editor links on mobile
2015-08-28 19:00:20 +01:00
cobbspur
b14f918b71 No validations on setup for empty fields
refs #5652

 - new action on focusOut which only calls validate if the fields has a value
2015-08-28 18:55:37 +01:00
Hannah Wolfe
6e9c79fb9d Merge pull request #5755 from jomahoney/tabnav
Prevents partial tab view when using keyboard navigation in tag settings
2015-08-28 18:54:40 +01:00
Hannah Wolfe
0a924451eb Merge pull request #5739 from cobbspur/forgotPassword
Add loading spinner to forgot button on signin page
2015-08-28 18:47:14 +01:00
Hannah Wolfe
2f8b6e1f59 Merge pull request #5754 from cobbspur/flowstep3
Prevent setup loop on step 3
2015-08-28 17:38:23 +01:00
cobbspur
594ae6c7d9 Add loading spinner to forgot button on signin page
refs #5652

- replaces basic forgot? button on signin page with spin button
- replaces {{input with gh-input}}
2015-08-28 17:20:03 +01:00
cobbspur
dfbaeaf587 Prevent invite action in step 3 of setup being triggered at wrong time
closes #5757

- validates text on focusOut
- prevent invite action being triggered every time text field gets focus.
2015-08-28 17:16:30 +01:00
Kevin Ansfield
6989843b19 Fix auth token refresh failing on app-boot with expired access_token
issue #5751
- moves `makeRequest` override of simple-auth's OAuth authenticator into our own custom authenticator (previously our override was not taking effect until after ember-simple-auth's initial authentication routines, hence why it was working for post-login token refreshes but failing on app-boot)
2015-08-28 16:00:34 +01:00
John O'Mahoney
c47e10d60a Prevents partial tab view when using keyboard navigation in tag settings
refs #5652
- Mimics behaviour of post-settings-menu
- Surrounded the subnavpage with a conditional to check if the page is
  active before focusing on it
2015-08-28 14:50:53 +01:00
Hannah Wolfe
dd8da3bad7 Merge pull request #5742 from kevinansfield/spin-button-minimum-timeout
Set a minimum spin time of 1 second for gh-spin-button
2015-08-28 13:15:45 +01:00
Hannah Wolfe
74f26cbe23 Merge pull request #5733 from kevinansfield/fix-tag-input-creation-order
Fix post tag input so it keeps the tag order
2015-08-28 12:41:28 +01:00
cobbspur
1813388309 Prevent setup loop on step 3
closes #5747

- change transition event to regardless of user invite success/failure
2015-08-28 12:35:40 +01:00
Kevin Ansfield
2682e47478 Fix broken content mgmt -> editor links on mobile
refs #5652
- add `ember-resize` addon that registers a single resize event handler and exposes it as a service and mixin
- add a component that wraps the posts list and content preview and exposes a `previewIsHidden` property
- use the `previewIsHidden` property in `gh-posts-list-item` to switch the item's link between the editor and the preview
- add `display: none` to the preview pane when in mobile so that we can test it's visibility
2015-08-28 11:52:38 +01:00
Kevin Ansfield
63f27c229b Set a minimum spin time of 1 second for gh-spin-button
refs #5652, #5719
- adds a timeout to `gh-spin-button` so the spinner is always shown for at least 1 second

As a stopgap solution before #5719 can be implemented it was decided to keep the button spinning for a minimum time, even if the associated action completes quickly. Discussion can be found at https://ghost.slack.com/archives/dev/p1440670418004358
2015-08-27 22:16:01 +01:00
cobbspur
250500c0a3 Fix wording for failed invitations alert
refs #5652

- Use conditional string for single/plural failed invitations
2015-08-27 18:17:13 +01:00
Kevin Ansfield
3fdd8cd39d Fix invite user validation issues in signup
refs #5652
- wrap emails input in `{{gh-form-group}}` component to give element success/error classes
- pull validation messages into submit button
- clean up validation related aspects of step three controller
2015-08-27 14:05:52 +01:00
John O'Nolan
b8934f7a8a Consolidation of dropdown sizes 2015-08-27 13:27:49 +02:00
Hannah Wolfe
1c872df1cf Merge pull request #5736 from JohnONolan/newtags
Newtags
2015-08-27 11:36:56 +01:00
John O'Nolan
65939c2d86 Customised selectize theme for Ghost tags 2015-08-27 12:15:37 +02:00
John O'Nolan
bdfd972bad Minor visual bugfixes
- Line height on forgotten password butotn
- Regresson in button display mode
2015-08-27 12:14:59 +02:00
Kevin Ansfield
8b83b46664 Fix post tag input so it keeps the tag order
refs #5732
- patches ember-selectize to send the caret position to the create-item action handler
- updates `addTag` method in PSM controller to insert new tag in the correct place
2015-08-26 21:46:57 +01:00
Hannah Wolfe
b947f01d30 Merge pull request #5727 from kevinansfield/fix-disappearing-tags-on-save
Fix new tags disappearing in PSM when saving post
2015-08-26 19:58:31 +01:00
Hannah Wolfe
b2c11d587d Spin button consistency
refs #5652

- always put button text inside opening/closing helper tag
- only include type if it is 'submit' as button is default
- wrap attributes in double quotes
2015-08-26 16:21:42 +01:00
Hannah Wolfe
25ba3b0d22 Improve markup + tabindex etc on setup/two
refs #5652

- ensure gh-spin-button passes type & tabindex through to markup
- add gh-input class to auto focus input
- add tabindexes to setup/two + make first field autofocus and button submit
2015-08-26 16:20:52 +01:00
Hannah Wolfe
87b197ffc9 Merge pull request #5730 from JohnONolan/XELDA
Xelda
2015-08-26 15:19:56 +01:00
John O'Nolan
32b91ec397 Merge pull request #5729 from kevinansfield/selectize-styles
Copy selectize styles ready for customisation
2015-08-26 16:05:13 +02:00
Hannah Wolfe
e823ee17c0 Merge pull request #5721 from cobbspur/reset
Change reset page errors to match sign-in page
2015-08-26 14:54:30 +01:00
Kevin Ansfield
8658e98de3 Copy selectize styles ready for customisation
no issue
- prevent ember-cli-selectize addon auto-importing styles
- copy all previously imported selectize styles into the app styles
2015-08-26 14:32:39 +01:00
John O'Nolan
a455809cab Increase hit area on PSM controls
Closes #5714
2015-08-26 15:20:41 +02:00
John O'Nolan
cd6289ba0a Minor visual edits
- Adjust edit post button position
- Increase hit area on post settings cog
2015-08-26 15:12:04 +02:00
Kevin Ansfield
b40350b760 Merge pull request #5720 from ErisDS/password-flow
Don't clear password field until setup is complete
2015-08-26 12:41:18 +01:00
cobbspur
0987518859 Change reset page errors to match sign-in page
No Issue

- Takes the inline validation messages and displays below form
- Removes unnecessary gh-error-message components from signin and reset pages
 - Returns error messages to sign-in validations
2015-08-26 12:00:37 +01:00
Sebastian Gierlinger
72f8d405ed Merge pull request #5722 from ErisDS/download-count
Number formatting function for download counter
2015-08-26 10:36:12 +02:00
John O'Nolan
f7baac85ff Merge pull request #5715 from dbalders/About-Page-Header
Add Menu to About Ghost Page
2015-08-26 06:04:15 +02:00
Kevin Ansfield
de970a4aba Fix new tags disappearing in PSM when saving post
closes #5708
- when adding a tag give it a throwaway UUID so that every selected/available tag object has a unique identifier for use with selectize
2015-08-25 23:53:19 +01:00
John O'Nolan
58a86d17be Optimise mobile navigation
Make everything a little bit larger on small screens
2015-08-25 18:01:26 +02:00
Hannah Wolfe
36e0a6b74c Number formatting function for download counter
refs #5652

- safari doesn't support the nice toLocaleString function
- this adds a manual, cross-browser way of adding commas in the right places to long number strings
2015-08-25 15:04:58 +01:00
Hannah Wolfe
6cb45d6939 Don't clear password field until setup is complete
ref #5652

- resolves issues with setup flow for the time being
- password is cleared on deactivate, rather than during step 2
- using transitionToRoute instead of transitionTo to remove deprecation warning
2015-08-25 13:16:39 +01:00
John O'Nolan
f59aa45ea1 Fix splitbutton height regression
Caused by removing display:flexbox from buttons a while back
2015-08-25 13:58:24 +02:00
John O'Nolan
9d5ea5d9be Add white bg to forgotten password link
Lastpass injects its password-fill icon into password inputs, this shows up awkwardly with the forgot-password button. Adding a white BG hides this.

Followup on #5641
2015-08-25 10:20:34 +02:00
David Balderston
0d6fafc969 Add Menu to About Ghost Page
Header on About Page was still missing, so added it in
* Added the header to the about.hbs
2015-08-24 18:27:33 -07:00
Kevin Ansfield
643f712624 Validate tag names don't start with commas
closes #5685
- Adds client and server-side validation for tag names starting with commas
- Trim tag names before adding in PSM (tag attributes are already trimmed before saving in TSM)
2015-08-24 16:55:30 +01:00
Kevin Ansfield
d633bf315f Fix alerts disappearing when navigating
closes #5707
- fix disappearing alerts after transitions by not clearing all alerts/notifications when closing menus
- remove `notifications.closeNotifications()` calls left over from needing to clear validation notifications
2015-08-24 16:07:09 +01:00
Hannah Wolfe
566bc03f5f Merge pull request #5694 from kevinansfield/zelda-invite-fixes
Minor UI fixes for invitations
2015-08-24 12:41:43 +01:00
Hannah Wolfe
54f8c8e65f Merge pull request #5691 from acburdine/spin-fix
Fix auto width and height of spin button
2015-08-24 12:07:39 +01:00
John O'Nolan
6a7fa1a183 Merge pull request #5702 from kevinansfield/zelda-signin-updates
Fixes for sign-in error handling
2015-08-24 08:00:13 +02:00
Hannah Wolfe
2972080088 Merge pull request #5682 from kevinansfield/tags-v4
Replace the current tag input with a selectize based input
2015-08-21 21:34:06 +01:00
Hannah Wolfe
7545e4a655 Merge pull request #5699 from kevinansfield/close-nav-menu-on-transition
Mobile nav menu fixes
2015-08-21 21:32:26 +01:00
Hannah Wolfe
5f5f67d171 Merge pull request #5687 from kevinansfield/fix-tags-validation
Add inline error handling and tests for tag creation/editing
2015-08-21 21:31:40 +01:00
Kevin Ansfield
045e5054a0 Fixes for sign-in error handling
issue #5652, closes #5641
- removes inline errors for empty fields
- separate validation routines for sign-in and forgot password
- highlight fields with errors when trying to submit
2015-08-21 19:38:44 +01:00
Kevin Ansfield
93179c1e6a Add inline error handling when creating/editing tag
closes #5684
- add inline error checking and display to tag name & meta data fields
- add tests for tags screen
2015-08-21 18:06:52 +01:00
John O'Nolan
a319f349bb Merge pull request #5700 from kevinansfield/inline-error-styles
Style inline-error fields and response test
2015-08-21 16:55:48 +02:00
John O'Nolan
16d7a86810 Merge pull request #5698 from kevinansfield/fix-autonav-flicker-v2
Fix flickering autonav animation
2015-08-21 15:29:05 +02:00
John O'Nolan
659999b5aa Merge pull request #5697 from Gargol/a11y-improvement-for-menu-toggle
Adds 'button' role to toggle menu icon for better a11y
2015-08-21 10:23:43 +02:00
Kevin Ansfield
3dd612a4ee Style inline-error fields and response test
issue #5652
- highlight input border and response text in red
2015-08-20 17:04:37 +01:00
Kevin Ansfield
a6910de08a Mobile nav menu fixes
issue #5483 & #5652
- trigger the close menus action every time a route transition is successful
- close nav menu when clicking "collapse sidebar" button (action chain was incomplete)
2015-08-20 16:49:33 +01:00
Sebastian Gierlinger
a00cbf0f61 Merge pull request #5689 from kevinansfield/fix-property-val-of-undefined
Fix occasional `Cannot read property 'val' of undefined` errors in console
2015-08-20 16:53:47 +02:00
Kevin Ansfield
3efdfdf79f Replace the current tag input with a selectize based input
issue #3800, closes #5648
- uses ember-cli-selectize addon for the tag editing functionality in the PSM
2015-08-20 14:40:56 +01:00
Kevin Ansfield
3d3c6f8bbe Fix flickering autonav animation
- use `transition: left` instead of `transform: translate3d`
- fixes issue where translate3d moves the element immediately then animates resulting in invisible hit areas that cause unexpected hover behaviour whilst animation is in progress
- translate3d is sometimes faster as it doesn't need to constantly re-calculate layout, however in this case the element is positon:absolute and we're only animating opaque elements so the benefit is marginal. Tested on Late-2012 13" retina MBP and framerate was consistently 100fps or higher.
2015-08-20 13:04:26 +01:00
Nazar Gargol
2aed13dfcf Adds 'button' role to toggle icon for better a11y
closes #5696
- adds button role to toggle icon on new zelda menu
2015-08-20 12:51:44 +02:00
Kevin Ansfield
bc6d31701c Minor UI fixes for invitations
issue #5652
- display "Sending Invite..." text after clicking "RESEND" link
- change "Invitation sent" alert to notification
2015-08-20 10:36:36 +01:00
Austin Burdine
a7ed98cc3e fix auto width and height of spin button component
refs #5652
- changes the spin-button so that it only sets the size when the button is submitting instead of all of the time
2015-08-19 23:39:07 -04:00
Kevin Ansfield
a889844188 guard against missing $previewContent/ViewPort in gh-editor.scrollPosition
issue #5659
- fixes occasional issue with editor not rendering due to scrollPosition being requested before the relevant jquery elements have been set
2015-08-19 20:44:59 +01:00
Kevin Ansfield
b74b30ef99 guard against missing editor element in editor-base-controller.save
issue #5659
- Fixes occasional issue with `Uncaught TypeError: Cannot read property 'val' of undefined` errors appearing when navigating quickly to/from the editor. I traced the `save` action calls back to the `autoSave` method - it may warrant further investigation to find out why the throttled/debounced calls are sometimes made when the editor element is non-existent.
2015-08-19 20:43:30 +01:00
John O'Mahoney
dbeea0f9bd Update signup form to have profile image upload component
closes #5544
- Added profile image into `signup.hbs`
- Added image handling in `signup.js` controller
- Uses session authenticated user to upload image
2015-08-15 13:00:42 +01:00
John O'Nolan
8dd69ddaef Variety of style fixes
- Modal button position tweaked, removed extraneous margin
- Fix user profile full name field and mobile profile-picture
- Added chevron to tag settings men, corrected chevron colour
- Fixed regression in delete-tag button caused by removing flexbox from buttons
- Fixed regression in button positioning on about-ghost page caused by removing flexbox from buttons

See #5652
2015-08-13 10:04:45 +02:00
John O'Nolan
495536fbe3 Fixed publish menu positioning, cleaned up dropdown component
See #5652
2015-08-13 09:09:07 +02:00
John O'Nolan
0c2e6b617c Kill old tag styles 2015-08-13 08:55:41 +02:00
John O'Nolan
eb08826f3e Multiple minor visual style fixes
- Lighter dropdown shadow
- Removed display:flex from .btn because safari can't handle it on <button> elements, where it will immediately set all text-alignment to "left" with no way to change. I haven't been able to find any regressions for this change so far. Can't remember why buttons were supposed to be flexbox anyway. Maybe for icon alignment within buttons, but I can't find any such examples within the app.
- Safari thinks that user-select: all; means a single click should SELECT ALL THE THINGS. Removed/replaced with user-select: text; which makes it behave like Chrome; click and drag to select.
- Increased hit area for "?" button
- Removed :active style for post-edit button on content management screen, adjusted position
- Increased contrast on tag description, tag count, and view blog links

See #5652
2015-08-12 10:29:40 +02:00
John O'Nolan
411df4dbb1 Prevent view titles from being cut off in Safari
See #5652
2015-08-12 09:17:01 +02:00
Hannah Wolfe
6ac7f09043 Merge pull request #5658 from acburdine/tag-fixes
fixed focus and duplication tag issues
2015-08-11 19:42:52 +01:00
Hannah Wolfe
8e76da83b5 Merge pull request #5654 from cobbspur/bugfixes
Lock out email address on signup page
2015-08-11 18:06:12 +01:00
Austin Burdine
96c5d2a2de fixed focus and duplication tag issues
refs #5648
- adds default value to refocus in reloadTypeahead method to fix focus issues
- moves tag input clearing call up to avoid duplication.
2015-08-11 11:04:53 -06:00
cobbspur
e8024c9789 Fix spinner on settings page
refs #5652

- stops spinner from spinning forever on settings screen when saving
2015-08-11 15:26:24 +01:00
cobbspur
04130cf8c1 Lock out email address on signup page
refs #5653

- disables email field
- pull error message from api response
2015-08-11 14:25:30 +01:00
cobbspur
27122091b5 Fix errors for setup and signup
refs #5635

- adds enter action to signup fields
- adds validation text errors
2015-08-10 22:24:10 +01:00
Hannah Wolfe
c174dd27ce Merge pull request #5633 from acburdine/spin-buttons
Add spin buttons
2015-08-10 19:06:32 +01:00
Austin Burdine
2833675238 add spin-button component & implement it
closes #3928
- adds spin-button component & styles
- implements spin-button in places where buttons trigger async tasks
2015-08-10 09:43:50 -06:00
Austin Burdine
16d0965a9e reimplement tag editing component for posts
refs #3800
- remove old tag editor code
- reimplement tag editor as an ember component
- add tag editor component to PSM
2015-08-10 07:22:37 -06:00
Hannah Wolfe
0269f49358 Merge pull request #5640 from cobbspur/errors
Fix server errors for signin
2015-08-10 13:20:53 +01:00
Hannah Wolfe
c2a8d5254c Merge pull request #5634 from acburdine/onboard-fixes
Fixes in setup/three
2015-08-10 13:17:28 +01:00
cobbspur
c6531b491f Fix signin errors
refs #5635

- fixes format for server errors
- changes signin-api validation errors to be text rather than alerts
2015-08-10 12:26:45 +01:00