Commit Graph

17751 Commits

Author SHA1 Message Date
Kevin Ansfield
d5a547b6ad
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 15:20:22 +01:00
Kevin Ansfield
ed24899fa5
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 15:20:14 +01:00
Kevin Ansfield
dddd2a4111
🐛 Fixed copy/paste of HR cards between editor and beta editor
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
2023-06-06 15:14:22 +01:00
Michael Barrett
a1b08f15b2
Fixed flaky frontend members test (#16947)
closes https://github.com/TryGhost/Team/issues/3325

Awaited `DomainEvents.allSettled()` to ensure domain event is fully
processed before asserting member was successfully updated
2023-06-06 14:57:46 +01:00
Sanne de Vries
d9a20b0e00 Fixed form embed settings overflowing in x direction
Closes https://github.com/TryGhost/Team/issues/3384
2023-06-06 15:24:08 +02:00
Peter Zimon
2e2a96c741 User modal refinements in AdminX
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-06 15:17:05 +02:00
Peter Zimon
2fc3336dd2 Fixed modal padding bug
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-06 15:08:04 +02:00
Sanne de Vries
c08723b7aa
Fixed error message position to be visible on minimal form (#16946)
Closes https://github.com/TryGhost/Team/issues/3386
2023-06-06 15:05:24 +02:00
Peter Zimon
19dfd28946 Added sticky footer option to modals in AdminX
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-06 14:58:55 +02:00
Peter Zimon
f5415a25ad Added backDropClick param. to modals in AdminX
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-06 14:58:55 +02:00
Rishabh Garg
5c209abdc0
Updated default value for image editor integration setting (#16897)
refs https://github.com/TryGhost/Team/issues/3145

Updates pintura integration to be switched on by default for all sites by adding a migration to update the default value for the setting.
2023-06-06 18:15:01 +05:30
Kevin Ansfield
c11c842b1e
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 13:35:07 +01:00
Kevin Ansfield
48defc4000
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 12:56:33 +01:00
Sanne de Vries
9c9eae1c11 Updated signup embed modal responsiveness
Refs https://github.com/TryGhost/Team/issues/3340
2023-06-06 12:21:11 +02:00
Daniel Lockyer
73ba799d17
Fixed generating sodo-search CSS in dev mode
refs https://ghost.slack.com/archives/CFH10N79S/p1686042479311309?thread_ts=1679079897.164069&cid=CFH10N79S

- the current build workflow wasn't generating the Tailwind compiled CSS
  so we needed to amend the commands to do so
2023-06-06 12:19:40 +02:00
Rishabh
695857ae96 Wired save and error handling for user details modal
refs https://github.com/TryGhost/Team/issues/3351

- updates user state on suspend/delete actions to show the latest
- shows errors for email and url on user detail screen
2023-06-06 15:08:44 +05:30
Simon Backx
31549933a1 Removed 200% width in signup form minimal preview
no issue

This change wasn't needed after all
2023-06-06 10:43:32 +02:00
Simon Backx
0ae1dad2d2 Removed signup form preview flickering in Safari and improved responsiveness
no issue

- In Safari, we'll poll longer before animating to the new iframe
- Update the iframe immediately if the last change was a while ago, to improve responsiveness
2023-06-06 10:43:06 +02:00
Sodbileg Gansukh
feac482859 Fixed loading screen flash issue in dark mode
closes https://github.com/TryGhost/Team/issues/3344
2023-06-06 16:21:15 +08:00
Simon Backx
f0518bc76a Increased signup form embed icon resolution to 192px
no issue

Optimal resolution for @3x devices
2023-06-06 09:42:42 +02:00
Simon Backx
fc89ad22fc Prevented setting signup form embed locale when feature flag is disabled
fixes https://github.com/TryGhost/Team/issues/3385
2023-06-06 09:40:47 +02:00
Naz
5a8eec402f
Restricted built-in collection init to run once
refs https://github.com/TryGhost/Team/issues/3376
fixes b4a97d084f

- The in-memory stores are not cleaned up when the Ghost instance is "shallow restarted" between test suite runs, causing the initialization of built-in collections to run multiple times. The initialization should ever add the collections once.
2023-06-06 13:35:06 +07:00
Naz
b4a97d084f
Fixed snapshot for failing collections test
refs bdbd9327d9

- The "build" command was not run for the @tryghost/collecitons package and caused outdated response
2023-06-06 12:50:55 +07:00
Naz
bdbd9327d9
Added built-in automatic featured collection
refs https://github.com/TryGhost/Team/issues/3376

- When the Ghost instance is initialized it has to have a set of built-in collections. With these changes Ghost starts with a "featured posts" collection - available to be used right away.
2023-06-06 12:41:37 +07:00
Rishabh
fbfb1d0008 Fixed user cover and profile image upload issues
refs https://github.com/TryGhost/Team/issues/3351

Uploading cover and profile images for user was having a weird behavior where one was getting removed when the other was uploaded or deleted. This was due to how the state was being updated on image change, which ended up using the old user state while setting the new one. This change uses react's setState method that uses the latest state to set the new one so the changes don't get overridden.
2023-06-06 09:43:36 +05:30
Rishabh
c243b48629 Wired user invite actions on adminX
refs https://github.com/TryGhost/Team/issues/3351

- wires resend and revoke actions for a user invite in staff settings
2023-06-06 09:20:45 +05:30
Rishabh
c88a073a5c Wired delete and owner actions for staff users in adminX
refs https://github.com/TryGhost/Team/issues/3351

- allows owners/admins to delete users based on their permission level
- allows admins to be made owner users only if owner is logged in
2023-06-06 09:20:45 +05:30
Jono Mingard
885531b345 Added e2e tests for most simple AdminX settings 2023-06-06 15:50:07 +12:00
Jono M
089a3f7aaf
Added playwright config to admin-x-settings (#16941)
no issue
2023-06-06 11:29:28 +12:00
Simon Backx
ab0c33346d Fixed signup form minimal width in preview
no issue
2023-06-05 18:10:19 +02:00
Simon Backx
1e7b658148 Updated sign up form to use resized version of icon
fixes https://github.com/TryGhost/Team/issues/3345

The icon is now served as a 128x128px version
2023-06-05 17:59:18 +02:00
Peter Zimon
ae6a2ba0cc Added notification to user invitations
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-05 17:54:53 +02:00
Simon Backx
9aef897936 Increased virtual iframe width of minimal signup form preview
no issue

Because the signup form is responsive, it is displayed too small in the preview. To counteract this, the width of the iframe is increased to 200%, and clipped to make it larger.
2023-06-05 17:37:43 +02:00
Peter Zimon
e0dca2e0c7 Cleanup test code from AdminX
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-05 17:33:20 +02:00
Peter Zimon
5ad8e71cba Added toasters to AdminX Design System
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-05 17:31:25 +02:00
Daniel Lockyer
6c3517f67a
Removed unused top-gh-contribs dependency
- this is currently unused so we can clean it up
2023-06-05 15:58:51 +02:00
Simon Backx
b641859242 Released Signup Form v0.0.2 2023-06-05 15:30:05 +02:00
Daniel Lockyer
2b488945da
Fixed missing newline 2023-06-05 15:25:54 +02:00
Simon Backx
22f4d55f75 Added throttling and animation when updating signup form preview
fixes https://github.com/TryGhost/Team/issues/3378
2023-06-05 15:24:59 +02:00
Daniel Lockyer
c2c6e54578
Fixed line endings in Croatian translation files
- these should be LF and not CRLF
2023-06-05 15:22:39 +02:00
May Kittens Devour Your Soul
dbac82dd36
Added Croatian translations (#16928)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-05 14:40:46 +02:00
renovate[bot]
4834f77f0f Update dependency mailgun.js to v9 2023-06-05 14:34:16 +02:00
Ronald Langeveld
acb309679d Updated Afrikaans translations for Portal
no issue
2023-06-05 14:01:47 +02:00
Ronald Langeveld
b3c270e7ed Updated Afrikaans translations for ghost 2023-06-05 14:00:56 +02:00
Ronald Langeveld
3984dc2b11 Updated Afrikaans translations for Signup-form
no issue
2023-06-05 14:00:56 +02:00
Mysterious_Dev
7720ac6b10
Updated French translations for signup-form
refs https://github.com/TryGhost/Team/issues/2795
2023-06-05 13:51:18 +02:00
Naz
2390afc6f1
Added automatic collection recalculation
closes https://github.com/TryGhost/Team/issues/3170

- When resources that are related to automatic collection filter are updated the posts in collections should be updated as well.
- This change adds a super-basic way to track changes in post/tag/author resources and updated all automatic collections when any of those resources change. In the future we can optimize the update process to be more performant, but it's good enough for current needs
2023-06-05 18:33:39 +07:00
Keegan Sand
4d3c7d3177
Updated Spanish Portal translations
refs https://github.com/TryGhost/Team/issues/2795
2023-06-05 13:18:23 +02:00
Raka Afp
793ab34c81
Updated Bahasa Indonesia translations for signup-form (#16932)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-05 13:09:41 +02:00
EchoBilisim
8133360020
Updated Turkish translations for signup-form
refs https://github.com/TryGhost/Team/issues/2795
2023-06-05 13:04:07 +02:00
Gary Lai
04e76eced4
Added traditional Chinese translatinos for signup-form (#16926)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-05 13:01:45 +02:00
Sodbileg Gansukh
f4c109cfb2 Added small improvements to the image editor UI
refs https://github.com/TryGhost/Team/issues/3208

- added maximum width limit to the editor stage, so the image doesn't get under the editor controls
- made the crop indicator a bit bigger
- fixed image alignment for the vertical layout
2023-06-05 18:27:31 +08:00
Ronald Langeveld
52150d5ffb
Fixed Signup Embed iFrame not loading in Safari (#16935)
refs https://github.com/TryGhost/Team/issues/3375

- Fixed a safari bug that caused the signup embed iframe to be in the
`onLoad` state perpetually, causing it not to render.
2023-06-05 12:01:55 +02:00
Peter Zimon
ffe5cd765a Updated user role in AdminX settings
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-05 11:53:06 +02:00
Peter Zimon
c6a5ada5cc Updated user cover and profile image position
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-05 11:48:56 +02:00
Peter Zimon
2fe6ccbc22 Wired up user cover and profile image actions
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-05 11:45:47 +02:00
Naz
c86859d0a7
Added test coverage to automatic collections
refs https://github.com/TryGhost/Team/issues/3170

- The test confirms relational filters like `tag:kitchen-sink` filtering works for automatic collections
2023-06-05 16:37:17 +07:00
Naz
3599cfdd7a
Added test coverage for collection updates
refs https://github.com/TryGhost/Team/issues/3170

- When the collection filter is updated the collection's posts should be updated automatically.
2023-06-05 16:23:02 +07:00
Ghost CI
67fdff479b Merged v5.50.0 into main 2023-06-05 08:58:32 +00:00
Ghost CI
7170b2489e v5.50.0 2023-06-05 08:58:31 +00:00
Kevin Ansfield
bbd511b752
Added beta of the new Ghost editor (#16923)
no issue

Keep an eye on Ghost's changelog (https://ghost.org/changelog/) for the full feature announcement.
2023-06-05 09:46:31 +01:00
Kevin Ansfield
8167e7dc5e
Fixed lexical rendering bugs
closes https://github.com/TryGhost/Team/issues/3373
closes https://github.com/TryGhost/Team/issues/3374

- fixes rendering of contiguous linebreaks
- fixes rendering of multiple nested formats when using latest jsdom release
2023-06-05 10:42:15 +02:00
Naz
1968296410
Added type:post enforcement when fetching posts for collections
refs https://github.com/TryGhost/Team/issues/3148

- Collections should never ever operate on pages, so limiting them at the fetch stage is the bes possible place, so they don't enter the system when an automatic collection is created.
2023-06-05 15:04:57 +07:00
Naz
260ca0548a
Added test coverage to automatic collections
refs https://github.com/TryGhost/Team/issues/3170

- The test confirms `published_at` filtering works for automatic collections
2023-06-05 14:59:49 +07:00
Naz
bfefcfd4df
Added automatic collection creation based on filter
refs https://github.com/TryGhost/Team/issues/3170

- This implementation allows to create an automatic collection with a filter defining automatically populated posts that belong to a collection
- To populate collection using a filter the API client can send a `filter` property along with a collection request
- Filter values are compatible with the filters used in Content API (https://ghost.org/docs/content-api/#filter)
2023-06-05 13:39:52 +07:00
Naz
6e224f3702
Added automatic collection validation
refs https://github.com/TryGhost/Team/issues/3170

- When an automatic collection is created it should always have a valid filter assigned
2023-06-05 13:39:52 +07:00
Naz
f64276b26e
Added basic test an automatic collection
refs https://github.com/TryGhost/Team/issues/3170

- This test confirms we can create a collection with "automatic" type and assign a "filter" value to it
2023-06-05 13:39:49 +07:00
Rishabh
c2371b4841 Wired suspend user action on user detail modal in adminX
refs https://github.com/TryGhost/Team/issues/3351

- wires Suspend/Un-suspend user action on user detail modal
- adds running state for task buttons in modal
- adds api to delete and suspend/un-suspend users
2023-06-05 10:09:37 +05:30
Rishabh
2b0a6bc454 Wired user invite modal in admin-x
refs https://github.com/TryGhost/Team/issues/3351

Allows logged in user to send invites to new users, with allowed roles that can be invited restricted based on the role of logged in user.
2023-06-04 15:49:34 +05:30
Kevin Ansfield
2fb68ada83
Fixed lexical rendering bugs
closes https://github.com/TryGhost/Team/issues/3373
closes https://github.com/TryGhost/Team/issues/3374

- fixes rendering of contiguous linebreaks
- fixes rendering of multiple nested formats when using latest jsdom release
2023-06-02 16:33:14 +01:00
Ghost CI
6ac848195c v5.49.3 2023-06-02 15:02:42 +00:00
Simon Backx
d4f82f8b88 Added copy on click to textarea in signup form embed modal
no issue
2023-06-02 16:31:30 +02:00
Simon Backx
fc5af7e7f8 Removed notification when copying signup form embed code 2023-06-02 16:21:20 +02:00
Djordje Vlaisavljevic
187c62145c Updated Twitter and FB card edit mode spacing
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 15:15:47 +01:00
Simon Backx
ff28e1c94f Added fixed order in data attributes for signup form embed script
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685711310532969
2023-06-02 16:13:42 +02:00
Sanne de Vries
8833ec03de
Updated signup form modal (#16925)
Refs https://github.com/TryGhost/Team/issues/3340

---------

Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-02 16:07:30 +02:00
Elena Baidakova
af2e069cbe Bumped @tryghost/kg-lexical-html-renderer
no issue
2023-06-02 17:59:55 +04:00
Peter Zimon
2c0b5e61c5 Refined invites user list in AdminX Settings
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-02 15:49:09 +02:00
Djordje Vlaisavljevic
f5e81c9b16 Removed className prop from ImageUpload
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:56 +01:00
Djordje Vlaisavljevic
e9caf73175 Fixed lint error
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
d7ecc4b33e Moved CSS for ImageUpload to prop
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
449ce994f4 Moved ImageUpload labels from props to children
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
091b3acd61 Updated Twitter and FB card edit mode design
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
bbb09523ce Added bg-transparent to clearBg variants of TextField and TextArea
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
10f987ad24 Added className prop to ImageUpload
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:09 +01:00
Djordje Vlaisavljevic
8a8561fc94 Added FB and Twitter social icons
refs https://github.com/TryGhost/Team/issues/3318
2023-06-02 14:47:09 +01:00
Rishabh
b307c59d54 Wired invites list in admin-x settings
refs https://github.com/TryGhost/Team/issues/3351

- adds api to get list of all invites on the site
- wires invite list with Revoke/Resend option on the User settings group
2023-06-02 18:41:09 +05:30
Peter Zimon
1a0c1c0cd2 Minor UX fix on password change
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-02 15:09:48 +02:00
Elena Baidakova
97c3434c3d Bumped @tryghost/kg-lexical-html-renderer
no issue
2023-06-02 17:06:08 +04:00
Peter Zimon
d1c0ea6c57 Added avatar image uploader in AdminX
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-02 15:00:36 +02:00
Simon Backx
498629d9a9 Fixed encoded html character in signup form success message translation
no issue
2023-06-02 14:38:54 +02:00
Simon Backx
258dc2f8f2 Added locale data option to signup form script
refs https://github.com/TryGhost/Team/issues/3307
2023-06-02 14:36:17 +02:00
Peter Zimon
82b56c319e Added cover image interaction to user details
refs. https://github.com/TryGhost/Team/issues/3351
2023-06-02 14:32:42 +02:00
Rishabh
3090fc6067 Fixed password reset button state in admin-x
refs https://github.com/TryGhost/Team/issues/3351

- the change password button label was not getting reset on saving
2023-06-02 18:01:20 +05:30
Rishabh
94882fd6c8 Wired password reset for non-owner users
refs https://github.com/TryGhost/Team/issues/3351

- adds password validation and reset for non-owner users
- password validation uses basic checks for now and will include more checks from current admin in future
2023-06-02 17:57:28 +05:30
Daniel Lockyer
8098f8c53e Updated Admin extensions script functionality
fixes https://github.com/TryGhost/Toolbox/issues/587

- this commit changes two things surrounding the extensions script:
  - moves the script tag from the nav menu to the application template
    so we always load the script irregardless of if the current page has
    a nav menu
  - opens up showing the script to all logged-in users and not just
    Owners as previous
2023-06-02 14:05:40 +02:00
Simon Backx
c27b488f3d Added async attribute to signup form script tag 2023-06-02 13:59:49 +02:00
Kevin Ansfield
ba6ae472c3
Renamed editor beta route
closes https://github.com/TryGhost/Team/issues/3369

- removes `lexical` from user-visible URL
- only renames path rather than renaming all associated files to keep changeset minimal prior to beta launch
2023-06-02 12:52:57 +01:00
Daniel Lockyer
cca81daa30
Updated Portal to v2.33
refs https://github.com/TryGhost/Team/issues/2795

- includes new locales and wrapping of more public-facing strings
2023-06-02 13:24:51 +02:00
Daniel Lockyer
a535f0f80b
Released Portal v2.33.0 2023-06-02 13:23:07 +02:00