Naz
1530cb28a5
Simplified Notification's service constructor
...
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners
- There's no need to pass a whole "version object" when all we need it a string in a full version format inside the module
2021-10-11 16:04:48 +02:00
Naz
c0d59db5be
Added filtering of outdated custom notifications
...
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners
refs https://github.com/TryGhost/Team/issues/754
refs https://github.com/TryGhost/Team/issues/204
refs https://github.com/TryGhost/Ghost/issues/10236
- Custom notifications coming form the update check service should not be shown beyond instance's update. Once the notification is received it's marked with the current version number. With an instance upgrade all notification with older version should be hidden.
- This improvement should also resolve the problem of major version notifications with next major update (the code associated with https://github.com/TryGhost/Ghost/issues/10236 can then be removed after 5.0.1)
2021-10-11 16:04:48 +02:00
Naz
d948be5bcb
Grouped "browse" unit tests together
...
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners
- Before making changes + adding more tests to the notifications test suite grouped related "browse" tests into a describe block. Housekeeping :)
2021-10-11 16:04:48 +02:00
Naz
8737ec8888
Added createdAtVersion property to newly created notifications
...
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners
- The property is meant to track Ghost instance version the notification was received and processed at.
- This information should be useful in the future to dismiss outdated notifications
2021-10-11 23:38:40 +13:00
Naz
53ae852a0e
Added checks for notification properties
...
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners
- Before introducing new properties made sure existing ones were well understood and tested in a basic way
2021-10-11 23:38:40 +13:00
Naz
e69fa71584
Added basic unit test to cover notifications' service add method
...
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners
- We aim for full unit test coverage in our libraries and services. The very basic method coverage was missing so adding it!
2021-10-07 18:18:28 +02:00
Hannah Wolfe
9e96b04542
Moved server unit tests into the server folder
...
- this is a small part of a bit of cleanup of our test files
- the goal is to make the existing tests clearer with a view to making it easier to write more tests
- this makes the test structure follow the codebase structure more closely
- eventually we will colocate the tests as we break the codebase down further
2021-10-06 12:01:09 +01:00
