Commit Graph

6185 Commits

Author SHA1 Message Date
Sanne de Vries
ce674169e6 Improved hover state styling of snippets in cardmenu
No issue

- Changed delete icon colour and padding
- Changed fill of snippet icon on hover
2020-10-28 13:14:25 +01:00
Daniel Lockyer
3183fe045d Bumped minimum Node 14 version to latest LTS
- 14.15.0 is the latest version of Node 14 LTS
2020-10-28 11:05:00 +00:00
Kevin Ansfield
348ffc7d05 Changed slash menu filter to match any part of a snippet title
no issue

- extracted item matching into a separate function
- modified item matching to work with arrays (existing exact match behaviour) or functions which can be defined per-item
- changed snippet item `matches` to a function that does a naive match or the typed query to any part of the snippet's title
2020-10-28 08:37:04 +00:00
Kevin Ansfield
7f537f8ba4 Fixed error when closing delete snippet confirmation dialog 2020-10-27 18:33:31 +00:00
Kevin Ansfield
f98f5000df Fixed error when clicking snippet icon from card toolbar 2020-10-27 18:32:20 +00:00
Kevin Ansfield
8f91bb2083 Fixed toolbar showing when block cards are in edit mode 2020-10-27 18:23:56 +00:00
Kevin Ansfield
ad2d6bcf52 Fixed squashed card menu display in Safari 2020-10-27 16:28:24 +00:00
Kevin Ansfield
79d9179289 Added scroll-into-view behaviour for slash menu selection
no issue

- when selecting items with arrow keys in the slash menu, scroll the selected item into view if it's not visible
2020-10-27 16:15:58 +00:00
Kevin Ansfield
1e639c2504 Added snippets feature to editor
no issue

Snippets are pieces of saved content that are given a name and made available for easy and quick insertion when editing posts or pages. They can contain rich text, cards, or a combination of both making it faster and less error-prone to re-use pieces of content across multiple posts. Snippet length is not constrained meaning they can also stand in as post type templates alleviating the need to keep drafts around as templates and copy/pasting each time they are used.

Feature changes:
- added "create snippet" icon to selection and card toolbars
- added "Snippets" section to the plus and slash menus
  - for the slash menu, continuing to type after opening the menu will filter by snippet name
- all saved snippets are available to all staff users
- snippets can be deleted by clicking the trash can icon when hovering the mouse over a snippet entry in the plus or slash menus
- creation/deletion of snippets is available to staff users with the owner, admin, or editor role

This commit:
- removed developer experiments guard around snippet UI
2020-10-27 15:01:35 +00:00
Kevin Ansfield
581b195e12 Truncated long card menu labels 2020-10-27 14:48:39 +00:00
Kevin Ansfield
c6753a0efd Hid snippet management UI from staff users without permissions
no issue

- snippets can only be created and deleted by owners/admins/editors
- added a property in the editor controller to determine if the logged in user has sufficient permissions, then only pass the appropriate save/delete snippet actions to the editor component if the check is passed
- updates koenig menus and toolbars to skip rendering of buttons if the associated action function is not available
2020-10-27 14:42:59 +00:00
Rishabh Garg
2edb7226e1 Added past_due and unpaid subscriptions for members (#1740)
refs https://github.com/TryGhost/Ghost/issues/12256, https://github.com/TryGhost/Ghost/issues/12255

Currently when listing subscriptions for Members in both the Admin and the Theme, we only show the subscriptions which have a status of trialing or active.

Based on discussion, the `unpaid` and `past_due` states on Stripe also represent owner's intention of considering a subscription as active instead of `cancelled`, so we allow any subscriptions under these 2 states to be also listed for a member and consider them as `paid`. This updates Admin to consider those subscriptions as active as well.

- Subscriptions will go into a past_due state if the payment is missed, this should be considered a grace period where the member still has access.

- After this the subscriptions will either go to the unpaid or the cancelled state - this can be configured on an account by account basis in the Stripe dashboard. `unpaid` is considered as an intention to keep the subscription to allow for re-activation later.
2020-10-27 15:27:31 +05:30
Kevin Ansfield
38fa62001a Fixed card menus closing when clicking on modal background
no issue

- when deleting a snippet we display a confirmation modal, if the background is clicked to dismiss the modal then the menus closed too which is a different behaviour to clicking the close/cancel button inside the dialog
- adjusted the "ignore click" selector in the menus to include all fullscreen modal elements
2020-10-27 08:43:46 +00:00
Kevin Ansfield
2b04a58ccc Lock file maintenance 2020-10-27 08:38:30 +00:00
renovate[bot]
70e4073117 Update dependency ember-cli-babel to v7.23.0 (#1730)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-27 08:36:10 +00:00
renovate[bot]
723caa8551 Update dependency ember-cli-terser to v4.0.1 (#1738)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-27 08:35:32 +00:00
Sanne de Vries
c0f7cbcd40 Added a "Sent to xxx members" message in content management screen for posts that have been sent out to members 2020-10-27 09:33:38 +01:00
Renovate Bot
bc4a079317 Update dependency eslint to v7.12.1 2020-10-27 05:05:31 +00:00
Kevin Ansfield
1bd4b5cda7 Added delete button with confirmation to snippets in card menus
no issue

- show a delete icon when a snippet is hovered in plus/slash menus
- show a confirmation dialog when the delete icon is clicked
- keep menus open whilst displaying the delete confirmation dialog
2020-10-26 17:09:39 +00:00
Renovate Bot
cddd977536 Update dependency eslint to v7.12.0 2020-10-26 00:06:46 +00:00
renovate[bot]
1c4ad3b59a Update dependency ember-power-select to v4.0.6 (#1737)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-23 14:50:45 +01:00
renovate[bot]
db9f97955d Update dependency ember-simple-auth to v3.0.1 (#1732)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-23 14:49:49 +01:00
Daniel Lockyer
efd631dcf4 🔥 Added support for Node 14 2020-10-23 12:42:34 +01:00
Kevin Ansfield
092a906e4f Removed Instagram embed entry from the card menu
no issue

- Facebook are changing how Facebook/Instagram embeds work meaning that they won't work in Ghost once the deprecation lands on Oct 24th
2020-10-23 11:40:31 +01:00
Kevin Ansfield
b392313df1 Changed snippet icon in menus based on snippet contents
no issue

- vary the snippet icon based on the snippet contents: text only, text and cards, cards only
2020-10-23 10:56:32 +01:00
Sanne de Vries
0ab0100567 Fixed bottom padding for card menu in Firefox 2020-10-23 11:55:41 +02:00
Kevin Ansfield
5d97c1710f Update dependency eslint-plugin-ghost to v2.0.0
no issue

- bumps eslint and eslint-plugin-ember versions
- octane rules are enabled by default
  - disabled them in our eslintrc.json so we can switch to warn/error whilst migrating to octane
- fixed a couple of linting errors from new/updated rules
2020-10-23 09:59:09 +01:00
Sanne de Vries
36dbb35eb5 Styled new row layout of the cardmenu
No issue

- Adjusted menu width and height
- Improved spacing cards
- Changed font styling
- Added snippet icons
2020-10-23 10:36:31 +02:00
Peter Zimon
6ecba355eb Moved members settings to new page (#1736)
no refs

Moves members related settings in Labs to its own page to improve the overall UX and make it more consistent with the rest of the Admin.
2020-10-22 16:09:00 +05:30
Kevin Ansfield
f1bab33296 Fixed member's location sometimes showing as ", US"
no issue

- geolocation.region is not always available but we had assumed it was. Adjusted the logic to only show "region, US" if region is available
2020-10-22 09:15:03 +01:00
Kevin Ansfield
5ae27247f7 Prevented card toolbar showing for embed/bookmark cards in input state
no issue

- it doesn't make sense to create snippets of bookmark/embed cards before they contain any content so we avoid passing the save snippet function through until content exists and the card has left it's input state
2020-10-21 18:27:26 +01:00
Kevin Ansfield
09368c2966 Changed card/plus menu layout from grid to rows
no issue

- with the addition of snippets the card menu contents height and potential label width are both growing considerably making the grid layout unworkable
2020-10-21 12:34:05 +01:00
Kevin Ansfield
489f45155d Added "Create snippet" toolbar icon when cards are selected
no issue

- show the toolbar icon for any `<KoenigCard>` instance that has the `saveAsSnippet` action passed to it
  - currently that's all cards except the HR card because that's a primitive element rather than containing any user-defined content
- add `koenigUi.inputHasFocus` so that card toolbars can be hidden when the snippet input is displayed
2020-10-21 12:16:04 +01:00
Kevin Ansfield
14755425c2 Fixed error when clicking on snippets in card menu
no issue

- click event was clearing the editor range so it's necessary to reposition the cursor before replacing with the post
2020-10-20 18:10:25 +01:00
Daniel Lockyer
bc342029d1 v3.36.0 2020-10-20 09:38:09 +01:00
Renovate Bot
c298bc7db3 Update dependency @tryghost/kg-clean-basic-html to v1.0.9 2020-10-20 08:41:19 +01:00
Renovate Bot
62d429be42 Update dependency @tryghost/kg-parser-plugins to v1.0.9 2020-10-20 08:38:06 +01:00
Renovate Bot
24f3366544 Update dependency @tryghost/timezone-data to v0.2.30 2020-10-20 08:36:57 +01:00
Renovate Bot
26a79e0edf Update dependency @tryghost/helpers to v1.1.33 2020-10-20 08:36:08 +01:00
Kevin Ansfield
3efeeac6a1 Swapped toolbar snippet icon for the new design 2020-10-19 09:55:26 +01:00
Kevin Ansfield
96bcf99332 Added Ctrl/Cmd+P shortcut in editor to open preview in new tab
no issue

- allows quick access to the preview without having to open post settings menu and click the preview link or hit Ctrl/Cmd+S and click the link in the success notification
2020-10-19 08:25:26 +01:00
Kevin Ansfield
11c16b8b4b Disabled mocked snippets API in development 2020-10-16 19:22:09 +01:00
Kevin Ansfield
95aa341468 Added max length validation to snippet's name field 2020-10-16 19:22:09 +01:00
Kevin Ansfield
3d48ce6bc4 Fixed snippets not loading in background when accessing editor
no issue

- add the missing snippets API query to the editor's background loaded
2020-10-16 19:22:09 +01:00
Renovate Bot
45bee39739 Update dependency @tryghost/helpers to v1.1.32 2020-10-16 14:35:51 +01:00
Renovate Bot
4b220ebd17 Update dependency @tryghost/string to v0.1.13 2020-10-16 14:35:34 +01:00
Peter Zimon
94077449b3 Update portal settings (#1731)
* Added auto focusing preview on the signup page while being on links and clicking on any setting in the sidebar

* Refine upload custom portal icon button

* Updated copy for sidebar and links screen

* Added grouping to links list
2020-10-16 15:34:22 +02:00
Kevin Ansfield
7e169a2a86 Renamed snippet.title to snippet.name for consistency
no issue

- all of our models which allow users to name something use `name` as the field descriptor rather than `title` so `snippet.title` was renamed for consistency
- also fixes typo in the plus-menu component that stopped clicking on snippets from working
2020-10-16 10:15:07 +01:00
Kevin Ansfield
b590ce1b95 Implemented first iteration of content snippets
closes https://github.com/TryGhost/Team/issues/411

- adds "Create snippet" icon to the editor toolbar
- uses the same link input component design for specifying snippet titles
- snippets are loaded in the background when the editor is accessed
- snippets are listed at the bottom of the card menus of the + and / menus
- clicking a snippet inserts the snippet's contents in place of the current blank section
2020-10-15 18:03:35 +01:00
Peter Zimon
bc779bb3e7 Fixed 'null' portal button text
no refs.
- fixing portal button displaying 'null' if the portal button text input field is empty
2020-10-14 14:47:08 +02:00