Commit Graph

714 Commits

Author SHA1 Message Date
Jono M
55d243f470
Replace custom data loading with react-query (#17537)
refs https://github.com/TryGhost/Product/issues/3349
2023-07-31 18:27:30 +01:00
Peter Zimon
db272bf146
AdminX various cleanup (#17522)
refs. https://github.com/TryGhost/Product/issues/3349

- fixed textfield right placeholder bug
- fixed menu highlight when settings is searched
2023-07-27 19:09:28 +02:00
Peter Zimon
0a0fcbc551
AdminX user settings related cleanup (#17520)
refs. https://github.com/TryGhost/Product/issues/3349

- added validation for user name
- added onBlur validation for fields
- changed textfield label color on focus
2023-07-27 18:29:02 +02:00
Steve Larson
e45b947d61
Updated gscan (#17521)
no refs
- add check for unknown global use in themes
- removed `@page` check until ready for release
2023-07-27 15:43:22 +00:00
Peter Zimon
2e4a483518
AdminX generic settings UX cleanup (#17517)
refs. https://github.com/TryGhost/Product/issues/3349

- highlighting current navigation item while scrolling
- highlighting current navigation in content area when clicking on the sidebar. Both are for better orientation
2023-07-27 16:01:45 +02:00
Daniel Lockyer
c97cc08455 Updated ESLint config for React+Typescript packages
refs https://github.com/TryGhost/DevOps/issues/50

- `react-app` comes from `eslint-config-react-app`, which is a CRA package
- we're moving away from that so this commit switches the linting over
  to a more recently updated plugin
- once that was removed, we started using a newer version of
  `@typescript-eslint/eslint-plugin`, so there were plenty of
  updates/exemptions to make
2023-07-27 11:40:31 +02:00
Daniel Lockyer
5875962392 Converted CRA packages to Vite
refs https://github.com/TryGhost/DevOps/issues/50

- we're moving away from CRA in favor of Vite, so this switches the last
  packages over
2023-07-27 09:43:35 +02:00
renovate[bot]
12190746c0 Update dependency @types/react to v18.2.17 2023-07-27 08:53:24 +02:00
Steve Larson
b77521ece9
Updated gscan (#17509)
no refs
2023-07-26 15:58:22 +00:00
Peter Zimon
c956561d58
Modal cleanup in AdminX settings (#17508)
refs. https://github.com/TryGhost/Product/issues/3349

- added outline to modal cancel button to avoid floating it too much in space
- added a lil' animation to modals to make it more obvious that it's a modal
- added ESC button so that it's easier to escape the modal
2023-07-26 15:45:19 +00:00
Peter Zimon
a9efd06f83
Tiers related cleanup in AdminX settings (#17504)
refs. https://github.com/TryGhost/Product/issues/3349

- added thousands separator to numbers in tiers list and preview
- added dirty state handling to edit/add tier modal
- applied sorting to tiers list
- fixed free trial toggle bug. No default was set and didn't keep the trial value and the toggle in sync
- applied a little scale down to tier preview for better proportions
2023-07-26 16:13:07 +02:00
Steve Larson
005e80b466
Updated gscan (#17507)
no refs
2023-07-26 13:06:23 +00:00
Peter Zimon
acd84fe25c
AdminX design cleanup (#17489)
refs. https://github.com/TryGhost/Product/issues/3349

- applied outline and fixed spacing for form groups
- small UI refinements for static version of Newsletter settings
- replaced textareas with textfields in site description, twitter and FB descriptions
- unified pattern for "Save & close" and "Cancel" in user detail settings
- refined checked background for logo container in Design settings
- refined spacing in Tier detail modal
- fixed gradient bug in Portal preview
- fixed UI bugs in Portal / Links
- fixed tier dropdown bug in Portal / Links. It was always showing links for the first tier
- unified form input element headings
- refined checkbox and toggle label typography and spacing
2023-07-26 12:47:52 +02:00
Daniel Lockyer
33e2b39295 Removed old versions of @typescript-eslint/{eslint-plugin,parser}
refs https://github.com/TryGhost/DevOps/issues/50

- this helps prevent old versions of the dependency from lingering
  around (especially when it's unused)
2023-07-25 16:48:54 +02:00
renovate[bot]
3830401d55 Update dependency @playwright/test to v1.36.2 2023-07-25 12:26:15 +02:00
renovate[bot]
ec46993e0f Update dependency @types/react to v18.2.16 2023-07-25 08:05:02 +02:00
renovate[bot]
7baa1b13af Update storybook monorepo to v7.1.1 2023-07-25 08:04:47 +02:00
renovate[bot]
5ca8c1f568 Update dependency vite to v4.4.7 2023-07-24 20:56:39 +02:00
renovate[bot]
ce2df20b53 Update dependency react-select to v5.7.4 2023-07-24 16:37:44 +02:00
Daniel Lockyer
d5cbb33e54 Pinned dependencies 2023-07-24 16:21:47 +02:00
Daniel Lockyer
bb4c3de992 Deduplicated ts-node and typescript dependencies
refs https://github.com/TryGhost/DevOps/issues/50

- this commit deduplicates where we define the versions of these
  packages to make them easier to maintain
2023-07-24 16:21:47 +02:00
Daniel Lockyer
d0f9c8cf0c Deduplicated eslint and eslint-plugin-ghost to top-level package.json
refs https://github.com/TryGhost/DevOps/issues/50

- this deduplicates where we define the version of `eslint` and
  `eslint-plugin-ghost` so it's easier to maintain
2023-07-24 16:21:47 +02:00
Djordje Vlaisavljevic
5d5d33b930
Changed NewsletterList to use new Table component (#17458)
refs https://github.com/TryGhost/Product/issues/3601

- `NewsletterList` now uses the new `Table` component, along with its
subcomponents `TableRow` and `TableCell` to be able to show more
relevant data
2023-07-24 09:50:02 +01:00
renovate[bot]
401c1a0d10 Update dependency postcss to v8.4.27 2023-07-21 14:42:30 +02:00
renovate[bot]
7cdc87ed99 Update dependency vite to v4.4.6 2023-07-21 12:31:29 +02:00
renovate[bot]
9a24877e7d Update dependency vite to v4.4.5 2023-07-21 09:23:51 +02:00
Peter Zimon
78a06aead3
Static Stripe Connect flow in AdminX (#17432)
refs. https://github.com/TryGhost/Product/issues/3608

- Basic static components are needed for Stripe Connect flow
- The current Stripe Connect flow has quite a lot of visual issues and
also the UX is somewhat messy
2023-07-20 17:17:17 +02:00
Djordje Vlaisavljevic
bb34683af2
Admin X newsletter settings title alignment (#17435)
refs https://github.com/TryGhost/Product/issues/3601

- Added static button group which will control newsletter title
alignment as a placeholder until we implement something like a Segmented
Control component
- Made the newsletter preview box shadow more subtle and fixed the
background color issue
2023-07-20 15:00:04 +01:00
Djordje Vlaisavljevic
abeee56dc4
Updated Admin X newsletter settings design (#17411)
refs https://github.com/TryGhost/Product/issues/3601

- Added static mock newsletter preview component
- Updated newsletter settings form design
- Fixed background color issue with PreviewModal
2023-07-19 09:48:55 +01:00
renovate[bot]
cd4a3e3773 Update storybook monorepo to v7.1.0 2023-07-18 14:33:52 +02:00
renovate[bot]
f542c86ac6 Update dependency clsx to v2 2023-07-18 14:08:27 +02:00
renovate[bot]
d546700352 Update storybook monorepo to v7.1.0 2023-07-18 13:13:31 +02:00
Djordje Vlaisavljevic
375d723878
Added static Newsletter settings to Admin X settings (#17374)
refs https://github.com/TryGhost/Product/issues/3601

- Added static design for Newsletter settings group to Admin X settings,
that shows a simple list of newsletters and opens a preview modal with a
sidebar with static form design
- Fixed issue with spacing in `Forms` when there is no title
2023-07-17 09:12:05 +01:00
renovate[bot]
d753ad4f02 Update dependency @storybook/addon-styling to v1.3.4 2023-07-17 09:51:13 +02:00
Jono M
0137f498d7
Added tests for tier edit modal (#17369)
refs https://github.com/TryGhost/Product/issues/3580
2023-07-14 13:04:34 +00:00
Peter Zimon
a463db4845
Admin X Tiers refinements (#17366)
refs. https://github.com/TryGhost/Product/issues/3580

- It was possible to archive free tier
- The form group heading wasn't discoverable enough
- The left action in modals were not working
2023-07-14 11:43:28 +02:00
renovate[bot]
2f76f07dff Update dependency vite to v4.4.4 2023-07-14 11:04:59 +02:00
renovate[bot]
b8870dec99 Update dependency tailwindcss to v3.3.3 2023-07-14 08:58:58 +02:00
renovate[bot]
25fb1c43c2 Update dependency @storybook/addon-styling to v1.3.3 2023-07-14 08:16:59 +02:00
renovate[bot]
be7723d2bd Update dependency @types/react to v18.2.15 2023-07-14 08:16:46 +02:00
renovate[bot]
fec6c294d6 Update dependency @tailwindcss/forms to v0.5.4 2023-07-14 08:16:30 +02:00
renovate[bot]
6a13e5e737 Update dependency postcss to v8.4.26 2023-07-14 08:16:06 +02:00
Jono M
2e337c4e8c
Added free tier handling and other fixes to tiers modal (#17361)
refs https://github.com/TryGhost/Product/issues/3580

- Made free trial toggle work properly
- Updated currency picker to work correctly
- Enforce format on tier prices
- Added support for editing the free tier
- Added validations to tier modal
- Updated tier modal to remove blank benefits before saving
2023-07-14 10:46:16 +09:00
Djordje Vlaisavljevic
b6a990f830 Updated spacing for form headings
refs https://github.com/TryGhost/Product/issues/3580
2023-07-13 13:31:21 +01:00
Djordje Vlaisavljevic
0a79fc8ce7 Added placeholders for Tier Preview values
refs https://github.com/TryGhost/Product/issues/3580
2023-07-13 13:31:21 +01:00
Peter Zimon
fd5b2cc0cf
Updated AdminX Tiers list to use cards (#17346)
refs. https://github.com/TryGhost/Product/issues/3580

- Using cards instead of standard rows in the Tiers list makes it much
easier to orient it. Also makes settings more playful and nicer.
2023-07-13 10:41:06 +02:00
Jono M
8f6bf61359
Fixed currency display on AdminX tiers list (#17341)
refs https://github.com/TryGhost/Product/issues/3580
2023-07-13 13:54:55 +05:30
Peter Zimon
b580355a17
Admin X Tiers refinements (#17344)
refs. https://github.com/TryGhost/Product/issues/3580

- The Tiers list had an unnecessary extra separator on top
- Spacing was a bit off in the benefits list in the Tier detail modal
2023-07-13 09:53:37 +02:00
renovate[bot]
f4f4dd512e Update storybook monorepo to v7.0.27 2023-07-13 08:28:11 +02:00
renovate[bot]
a29eadec06 Update dependency @types/react-dom to v18.2.7 2023-07-13 06:03:46 +02:00
Jono M
9dd2489000
Fixed bugs with AdminX navigation settings (#17340)
refs https://github.com/TryGhost/Product/issues/3433

- Removed Ember dirty state from AdminX to prevent extra popups
- Fixed incorrect navigation popup new item errors
2023-07-13 01:12:31 +00:00
Djordje Vlaisavljevic
6f47002f9d
Improved responsiveness of tier preview (#17338)
Improved responsiveness of tier preview

refs https://github.com/TryGhost/Product/issues/3580
2023-07-12 23:18:37 +01:00
Djordje Vlaisavljevic
168db1f196
Updated DesktopChrome component and its usage (#17330)
- Updated `DesktopChrome` component
- Refactored the existing `PreviewModal` and `ThemePreview`
components to use the new component and removed some redundant code
- Added storybook for the component
2023-07-12 21:56:59 +01:00
Peter Zimon
497d1be2ea
Admin X Tiers Fields (#17332)
refs. https://github.com/TryGhost/Product/issues/3580

- The currency dropdown needed a small version of the regular select
- The input field needed a version with a right-side placeholder text
2023-07-12 18:23:51 +02:00
Peter Zimon
a725f9d6c2
Admin X Tiers settings refinements (#17322)
refs. https://github.com/TryGhost/Product/issues/3580

Soratable list needed stylistic updates and simplifications both in navigation and benefits list.
2023-07-12 16:51:14 +02:00
Rishabh Garg
4424f25970
Wired data to tier preview in adminX (#17323)
refs https://github.com/TryGhost/Product/issues/3580
2023-07-12 18:56:28 +05:30
Jono M
36f4a72531
Added sortable tier benefit editing in AdminX (#17315)
refs https://github.com/TryGhost/Product/issues/3580
2023-07-12 14:49:32 +09:00
Jono M
57a851227c
Added AdminX navigation settings components to design system (#17312)
refs https://github.com/TryGhost/Product/issues/3349

- Moved URLTextField to AdminX design system
- Factored out sortable list into a design system component
2023-07-12 03:21:54 +00:00
Jono M
8fd9d92944
Added basic wiring to save tiers from the tier modal (#17311)
refs https://github.com/TryGhost/Product/issues/3580
2023-07-12 01:16:07 +00:00
Djordje Vlaisavljevic
5f30e935b3
Created DesktopChrome component for previews
refs https://github.com/TryGhost/Product/issues/3349

Created a component for desktop chrome for previews (similar to what we
already have - `MobileChrome`) and its storybook
2023-07-11 22:44:28 +01:00
Djordje Vlaisavljevic
9abcf9d3ed
Added AdminX tier preview static design (#17307)
refs https://github.com/TryGhost/Product/issues/3580

- Added static design for tier preview and the checkmark icon it uses
2023-07-11 19:55:28 +01:00
renovate[bot]
bef119fa0f Update dependency vite to v4.4.3 2023-07-11 17:17:23 +02:00
Peter Zimon
bf7c176f54
Added basic Tiers form (#17304)
refs. https://github.com/TryGhost/Product/issues/3580

Static version of Tiers/Basic properties form was needed so it can be
wired up.
2023-07-11 17:13:38 +02:00
Rishabh Garg
36b23b49a9
Wired archived and active tiers list in adminX (#17300)
refs https://github.com/TryGhost/Product/issues/3580
2023-07-11 19:59:35 +05:30
renovate[bot]
7dce046786 Update Test & linting packages 2023-07-11 15:26:07 +02:00
renovate[bot]
4d3272e0c0 Update react monorepo 2023-07-11 09:50:33 +02:00
renovate[bot]
93973dd9b2 Update dependency stylelint to v15.10.1 [SECURITY] 2023-07-11 06:45:05 +00:00
renovate[bot]
9dd1f97bb0 Update dependency vite to v4.4.2 2023-07-10 18:17:28 +02:00
renovate[bot]
9a5c13309e Update dependency vitest to v0.33.0 2023-07-10 16:23:32 +02:00
Peter Zimon
2135547941
AdminX Tiers static design (#17271)
refs. https://github.com/TryGhost/Product/issues/3580

- A couple of static components were needed as a starting point for
Tiers in AdminX settings.
2023-07-10 15:55:42 +02:00
renovate[bot]
0c309454cf Update dependency @vitejs/plugin-react to v4.0.3 2023-07-10 15:40:54 +02:00
renovate[bot]
5c6339efdb Update storybook monorepo to v7.0.26 2023-07-10 15:34:44 +02:00
renovate[bot]
ea9cc21a0c Update dependency @vitejs/plugin-react to v4.0.2 2023-07-10 13:48:58 +02:00
Daniel Lockyer
fb0807c8c5 Prevented git tags from being created for apps
refs https://ghost.slack.com/archives/C02G9E68C/p1688983916615989?thread_ts=1687341349.559679&cid=C02G9E68C

- these cause issues with our PR workflow because we can't push tags in
  a PR and the commit is rebased onto `main` so the hash changes
- this disables tags for now
2023-07-10 13:09:28 +02:00
Rishabh Garg
dd7670859f Released Admin-x-settings v0.0.9 2023-07-10 14:39:39 +05:30
renovate[bot]
0e5a98e43e Update dependency postcss to v8.4.25 2023-07-10 10:20:30 +02:00
Rishabh
f2b924ca96 Added hidden state for portal preview frame in adminX
refs https://github.com/TryGhost/Product/issues/3545

- hides portal frame till portal is ready and loaded
2023-07-07 21:28:26 +05:30
Peter Zimon
ca3fe7d9db
Added routing to Portal (#17240)
refs. https://github.com/TryGhost/Product/issues/3545

Routing for Portal settings in AdminX was missing
2023-07-07 13:23:36 +00:00
Peter Zimon
702c88b9ba
AdminX Portal settings refinements (#17238)
refs. https://github.com/TryGhost/Product/issues/3545

- Device selector is not needed in Portal settings' preview
- Links page was too wide
- Scrolling for preview contents was on the whole modal instead of just the preview area
2023-07-07 13:03:06 +00:00
Rishabh
26c2590923 Wired save button state for portal settings modal
refs https://github.com/TryGhost/Product/issues/3545

- adds dynamic loading state for portal modal save button
2023-07-07 16:30:59 +05:30
Rishabh
ad0e52ac39 Wired tier selection for portal links
refs https://github.com/TryGhost/Product/issues/3545

Enables tier selection on Portal links page in adminX, allowing tier specific signup links to be copied
2023-07-07 16:30:59 +05:30
Peter Zimon
2642941be6
AdminX Portal links (#17227)
refs. https://github.com/TryGhost/Product/issues/3545

Static version of links page in AdminX Portal settings.
2023-07-07 11:36:31 +02:00
Rishabh Garg
31ff544e7a
Added account page in Portal preview in adminX (#17236)
refs https://github.com/TryGhost/Product/issues/3545

- adds switch to showing account page in portal preview
2023-07-07 14:47:17 +05:30
Jono M
4ffdab3c82
Added confirmation modal after setting portal email address (#17231)
refs https://github.com/TryGhost/Product/issues/3545
2023-07-07 02:05:14 +00:00
Jono M
e397368393
Improved Lexical behaviour in AdminX portal settings (#17232)
refs https://github.com/TryGhost/Product/issues/3545

- Fixed TODOs
- Fixed koenig editor not resizing as content expands
- Fixed placeholder in html field
- Updated signup options to validate terms length
2023-07-07 02:03:46 +00:00
Rishabh
c6b8097ff9 Added portal preview frame in adminX
refs https://github.com/TryGhost/Product/issues/3545

- adds portal preview iframe in modal
- wires local settings to portal preview url to dynamically generate the Portal preview
2023-07-06 20:41:42 +05:30
Peter Zimon
4fff14fdac
Updated AdminX Portal button icons (#17223)
refs. https://github.com/TryGhost/Product/issues/3545

Portal button icons in AdminX styling was just placeholders.
2023-07-06 11:53:33 +00:00
Peter Zimon
c9f2271665
AdminX installed theme list updates (#17221)
refs. https://github.com/TryGhost/Product/issues/3349

The installed themes were not sorted and the active theme was not the
first one which made it hard to discover in the list.
2023-07-06 11:21:48 +00:00
Peter Zimon
a5b62707ef
AdminX theme navigation experiment (#17210)
refs. https://github.com/TryGhost/Product/issues/3349

It's a bit cumbersome how design and theme navigation is handled in
AdminX at the moment. On a high level, this PR applies the following
changes:

- Change theme is under Design settings
- After activating a theme, Design settings are automatically opened
2023-07-06 12:03:01 +02:00
Jono M
e1fbfd3e12
Added HTML editor using koenig-lexical (#17217)
refs https://github.com/TryGhost/Product/issues/3545

Used in portal settings for the signup message.
2023-07-06 03:05:33 +00:00
Jono M
b9158215ee
Added portal icon picker in AdminX settings (#17216)
refs https://github.com/TryGhost/Product/issues/3545
2023-07-05 23:16:52 +00:00
Rishabh
79a7f8c408 Added basic routing for adminX settings
refs https://github.com/TryGhost/Product/issues/3349

- adds basic routing in adminX settings based on hash url path
- adds new routing provider that manages hash routing across adminX
- updates sidebar navigation to update route directly
- updates theme/design settings to update route for opening edit modals
2023-07-04 20:56:55 +05:30
Rishabh
56fcba1d27 Updated global Modals to handle after close method
refs https://github.com/TryGhost/Product/issues/3349

- allows modals to call `afterClose` when removed in case the parent wants any action on modal close, like routing update
2023-07-04 20:56:55 +05:30
Daniel Lockyer
1aeac9777e Enabled parallel testing for Playwright tests of apps
- we should allow parallel test execution because it's faster than
  serial
2023-07-04 16:08:06 +02:00
Peter Zimon
47a9eaadcc
AdminX Portal setting forms (#17201)
refs. https://github.com/TryGhost/Product/issues/3545

Styles was not applied to AdminX Portal settings forms. Also a couple of new components had to be added for easer future form design and implementation.
2023-07-04 15:18:19 +02:00
renovate[bot]
1c03280223 Update dependency @storybook/addon-styling to v1.3.2 2023-07-04 13:44:25 +02:00
renovate[bot]
8e8c64c622 Update storybook monorepo to v7.0.25 2023-07-04 12:44:42 +02:00
renovate[bot]
74f2e08b16 Update dependency vitest to v0.32.4 2023-07-04 12:24:03 +02:00
Jono M
1cc55eda2e
Updated portal popup to support selecting and updating tiers (#17192)
refs https://github.com/TryGhost/Team/issues/3545
2023-07-04 19:17:42 +12:00
Jono M
7f9f467fc6
Wired up basic settings in AdminX portal settings (#17191)
refs https://github.com/TryGhost/Team/issues/3545
2023-07-04 15:47:55 +12:00
Peter Zimon
de4186ab97
AdminX Portal UI (#17185)
refs. https://github.com/TryGhost/Team/issues/3545

As the first step of Portal settings being rebuilt in AdminX, we needed a couple of static skeleton components to get started. For this we also had to extend the props of Preview modal component in the design system.
2023-07-03 16:53:40 +02:00
Peter Zimon
dda42f521b
AdminX UI refinements (#17160)
refs. https://github.com/TryGhost/Team/issues/3349

- Search field styling in AdminX sidebar was off
- Error guide was missing in AdminX
2023-07-03 14:35:35 +02:00
Jono M
3811999be7
Improved AdminX theme installation flow (#17175)
refs https://github.com/TryGhost/Team/issues/3349
2023-07-03 17:59:31 +12:00
renovate[bot]
aa8cbb9fa3 Update dependency typescript to v5.1.6 2023-06-29 08:24:30 +02:00
Jono M
c03d3ff384
Factored out theme installed modal (#17158)
refs https://github.com/TryGhost/Team/issues/3349

Will be reused in future changes, just doing a quick refactor first to
prevent conflicts
2023-06-29 18:14:53 +12:00
renovate[bot]
58b54333a5 Update dependency typescript to v5.1.5 2023-06-28 16:21:27 +02:00
Jono M
9c2553a06a
Updated theme upload modal to show gscan errors (#17148)
refs https://github.com/TryGhost/Team/issues/3349
2023-06-28 19:54:21 +12:00
Jono M
768511c7cc
Added tests for more areas of AdminX settings (themes, design, multiselect) (#17134)
refs https://github.com/TryGhost/Team/issues/3349

Tidies up the remaining major pieces which were not covered by tests.
Extends the existing test patterns, although the API mocks are getting a
bit unmanageable.
2023-06-28 14:59:05 +12:00
renovate[bot]
5bcbb2de41 Update storybook monorepo to v7.0.24 2023-06-27 16:56:47 +02:00
renovate[bot]
2c6f30b4b8 Update dependency @storybook/addon-styling to v1.3.1 2023-06-27 07:33:22 +02:00
Jono M
0d8eb203bf
Updated AdminX search to use centralised configuration (#17106)
refs https://github.com/TryGhost/Team/issues/3349
2023-06-27 08:09:12 +12:00
Jono M
fdef6a30ab
Fixed default recipients behaviour when deselecting all tiers (#17133)
refs https://github.com/TryGhost/Team/issues/3349
2023-06-27 07:56:17 +12:00
Jono M
9e325d6b38
Added tests for user management (#17128)
refs https://github.com/TryGhost/Team/issues/3349
2023-06-26 15:12:46 +12:00
Daniel Lockyer
8c5e2a53a9 Moved Admin-X-Settings to apps/ folder
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the external apps into a different folder so we can
  keep `ghost/` for internal code
2023-06-23 14:37:39 +02:00