Commit Graph

5102 Commits

Author SHA1 Message Date
Kevin Ansfield
db558e38ea Provide a more intuitive error message on sign-in for missing email
issue 4651#issuecomment-112141801
- display "Please enter an email" validation message rather than "Invalid Email" when no email is entered
2015-06-17 22:56:38 +01:00
Hannah Wolfe
4b90c3c308 Merge pull request #5442 from JohnONolan/noposts-fix
Fixes alignment bug on content management empty state
2015-06-17 22:40:06 +01:00
Hannah Wolfe
b8eaa859b9 Merge pull request #5446 from kevinansfield/fix-setup-password-placeholder
Display correct minimum character count in setup's password field
2015-06-17 22:39:47 +01:00
Kevin Ansfield
6d8bce86b8 Display correct minimum character count in setup's password field
issue #5314
- replace 7 (incorrect) with 8 (correct) in setup's password field placeholder text
2015-06-17 21:50:47 +01:00
Jason Williams
e7398b0694 Merge pull request #5445 from cobbspur/canHelper
Hide Nav Settings based on permissions
2015-06-17 14:47:15 -05:00
cobbspur
453833cd11 Hide Nav Settings based on permissions
closes #5403

- adds gh-user-can helper to group user by minimum permissions
- hide Nav settings menu for users below admin level
2015-06-17 19:20:57 +01:00
John O'Nolan
3f6b648394 Fixes alignment bug on content management empty state
When buttons changed to flexbox they lost some alignment properties. This change makes the container for the empty content state use a flexbox container and align its containing items correctly. Also removes some old media queries which are no longer needed.
2015-06-17 14:41:29 +01:00
Sebastian Gierlinger
f79a4f336b Merge pull request #5432 from ErisDS/api-pagination2
Refactor pagination count query
2015-06-17 15:35:18 +02:00
Jason Williams
cd85244991 Merge pull request #5441 from kevinansfield/settings-routes-dont-redirect-to-signin
Ensure settings routes redirect to /signin when not authenticated
2015-06-16 19:47:10 -05:00
Kevin Ansfield
42b25a00e3 Ensure settings routes redirect to /signin when not authenticated
closes #5412
- call this._super() in beforeModel hooks so that simple-auth can handle the transition before we hit any protected API endpoints
2015-06-17 00:24:01 +01:00
Hannah Wolfe
3061247a7e Merge pull request #5431 from kowsheek/5370-settings-model-events
Add events to settings model
2015-06-16 20:46:15 +01:00
Kowsheek Mahmood
33e241ab4e Add events to settings model
issue #5370
- Add emit method to settings model
- Update settings spec to test for events emitted
- Fix formatting on tags spec
2015-06-16 23:57:52 +06:00
Hannah Wolfe
70e5554129 Merge pull request #5421 from augbog/augbog-feature
Issue #5371 added support for GET endpoint `/tags/slug/:slug`
2015-06-16 18:31:38 +01:00
Augustus Yuan
05fe09293f Add support for GET /tags/slug/:slug with unit tests
closes #5371
- added new endpoint to the api routes
- created unit tests based on PostModel and PostAPI for testing slug links
2015-06-16 09:22:12 -07:00
Hannah Wolfe
e06a552bb0 Merge pull request #5437 from JohnONolan/digitalocean
Add DigitalOcean infrastructure details
2015-06-16 16:53:49 +01:00
John O'Nolan
832084f66f Add DigitalOcean infrastructure details 2015-06-16 10:50:06 +01:00
Hannah Wolfe
535b7a95c0 Merge pull request #5435 from JohnONolan/signinfix
Fix signin form width bug
2015-06-16 10:22:09 +01:00
John O'Nolan
cc571da90d Fix signin form width bug
No issue. Fixes bug where signin form was not expanding to its full width as a result of some earlier global changes. This sets an explicit fluid width with a max-width fallback so that it's always the correct size.
2015-06-16 09:58:56 +01:00
Matt Enlow
906504e43b Merge pull request #5381 from acburdine/remove-extensions
Remove function prototype extensions
2015-06-15 14:21:49 -06:00
Sebastian Gierlinger
367396a032 Merge pull request #5428 from ErisDS/api-pagination1
Move pagination formatting into a util
2015-06-15 21:48:27 +02:00
Hannah Wolfe
4cd2865021 Refactor pagination count query
refs #2896

- remove duplicate query-building code
- use the same approach for creating the count query from the main query
- restructure the code to match more closely across the 3 findPage functions (prep for further refactoring)
2015-06-15 19:24:47 +01:00
Austin Burdine
86e47ee4a9 removes usage of prototype extensions
No issue
- removes more usage of function prototype extensions in favor of Ember functions
- replaces some event calls with the direct function name
- adds comments to functions replaced with the event name
2015-06-15 14:07:25 -04:00
Hannah Wolfe
16f98ee80b Move pagination formatting into a util
refs #2896

- moves repeated code out of models
- creates a new file for unit-testable code (this should be moved in future)
- adds a default for `page` as that seems sensible
- adds 100% test coverage for the new file
2015-06-15 16:46:42 +01:00
Jason Williams
b6cbd2d4bd Merge pull request #5427 from ErisDS/api-reshuffle
API mini-cleanup + 405 errors
2015-06-15 10:26:11 -05:00
Jason Williams
225dc84367 Merge pull request #5417 from ErisDS/rss-url
Use urlJoin in RSS + test coverage
2015-06-15 10:23:41 -05:00
Hannah Wolfe
254e0f0597 Improve API error handling
close #2757, refs #5286

- moves error formatting from api/index into errors lib
- moves error handling from api/index into its own middleware
- adds extra middleware for method not allowed which captures all unsupported routes
2015-06-15 10:08:30 +01:00
Fabian Becker
b15f1daf5a Throw 405 - Method not allowed for api routes
closes #2757
- New error MethodNotAllowed
- Throw 405 if valid path but invalid method is used is apiRouter
- Adds api base tests
2015-06-15 09:43:39 +01:00
Hannah Wolfe
177cdf1eb1 Misc cleanup: moving files & naming functions 2015-06-15 09:43:19 +01:00
Jason Williams
8ae1447e78 Merge pull request #5408 from novaugust/cleanup-mobile-views
Remove legacy mobile view code
2015-06-14 17:59:44 -05:00
Jason Williams
e5a1fa7ad6 Merge pull request #5414 from novaugust/zelda-menu-continued
Zelda menu z-index and viewport transition finishes
2015-06-14 17:57:35 -05:00
Matt Enlow
df1c04b8d8 Remove legacy mobile view logic
No issue
- Move editor-base-view mixin into editor/edit view
- Also deletes mobile views and modifies files that were using it
- Helps pave the way for Ember 2.0, where views do not exist
2015-06-14 14:42:21 -07:00
Matt Enlow
6681ad4a7d Zelda menu z-index and viewport transition finishes
- [x] Mobilemenu button is missing from `content` and `editor` views
- [x] Mobilemenu pane slides entire content over, should expand over-top-of-content
- [x] Mobilemenu can't be closed
- [x] gh-view-title no longer generates an extra div; it is the h2.
- [x] gh-autonav-toggle closes the mobile menu on mobile. renamed `gh-menu-toggle`
- [ ] There is weird behaviour with mobile menu when changing from big=>small=>big viewport sizes
- ~~[ ] (Future issue) Ghost should remember (localstorage?) whether desktop menu is expanded or collapsed~~
2015-06-14 13:57:09 -07:00
Hannah Wolfe
a873456b8a Merge pull request #5426 from jaswilli/update-simple-auth
Update ember-simple-auth to 0.8.0-beta.3
2015-06-13 11:44:23 +01:00
Jason Williams
e00823626a Update ember-simple-auth to 0.8.0-beta.3 2015-06-12 16:35:40 -05:00
Hannah Wolfe
be063749f1 Merge pull request #5378 from Rovak/verify-phantom-and-casper-task
Add verify phantom and casper js task
2015-06-12 20:56:29 +01:00
Roy van Kaathoven
d23b67737b output stderror instead of stdout to show detailed errors when spawnCasperJS fails 2015-06-12 20:37:23 +02:00
Hannah Wolfe
464c16f2aa Merge pull request #5420 from hex337/move-uncapitalize
Move uncapitalize into its own file.
2015-06-11 23:41:32 +01:00
Alex Kleissner
05e49d9a96 Move uncapitalize into its own file.
refs #5286
- Moved the logic into its own file
- Added unit tests
2015-06-10 12:21:15 -07:00
Hannah Wolfe
78157078f8 Merge pull request #5419 from JohnONolan/setupfix
Fix a wholelotta setup-screen bullshit
2015-06-10 20:18:10 +01:00
John O'Nolan
596faf0009 Fix a wholelotta setup-screen bullshit
Merging setup screen into the new app wrapper had some knock-on effects due to new flexbox parent elements. As a result things were vertically collapsing in unexpected ways on narrow viewports. This is cleaned up here, with some other minor visual bugfixes.
2015-06-10 19:49:50 +01:00
Hannah Wolfe
c1e3bd0786 Merge pull request #5415 from hex337/move-decide-is-admin
Moves the decideIsAdmin into its own file.
2015-06-10 09:51:48 +01:00
Hannah Wolfe
9071d7a749 Merge pull request #5416 from jaswilli/fixup-test
Make sure done() is called from before hooks
2015-06-10 09:19:50 +01:00
Hannah Wolfe
34b22eefa2 Use urlJoin in RSS + test coverage
refs #1833

- move RSS tests to be in rss_spec.js
- improve RSS test coverage
- fix a bug with RSS title generation for tag RSS feeds
- replace custom code in processUrls with urlJoin
2015-06-10 09:18:52 +01:00
Jason Williams
6c9682cdd9 Make sure done() is called from before hooks 2015-06-09 22:46:26 -05:00
Jason Williams
9e5d9e975f Merge pull request #5359 from josephwegner/onboarding-invites
invite users after signing up during setup
2015-06-09 21:56:54 -05:00
Alex Kleissner
511684c436 Moves the decideIsAdmin into its own file.
refs #5286
- Moved the function into its own file
- Added unit tests for the function
2015-06-09 14:02:22 -07:00
Joe Wegner
75faf0109d invite users after signing up during setup
closes #5338
- moves skip link to below the submit button
- makes the submit button better represent form status
- posts notifications based on success/failure of notifications
- goes to the invite page after user creation
- actually sends invites!

functional tests passing for onboarding invitations

cleanup for linitng

remove unreachable return

access the notifications service better

use link-to instead of an anchor with an action

failed user creations get caught, and bubble as errors

a slew of other cleanup stuff via jason
2015-06-09 11:50:24 -07:00
Hannah Wolfe
3f9560f11f Merge pull request #5406 from JohnONolan/zropdowns
Refactor Zelda dropdown styles
2015-06-09 11:24:48 +01:00
John O'Nolan
2780e783dd Refactor Zelda dropdown styles
- New styles for dropdowns
- Fix minor tag-delete button bug
- Fix minor alignment bug on invite-user modal
- Update "about ghost" icon
2015-06-09 11:06:35 +01:00
Jason Williams
d5ffffb034 Merge pull request #5368 from novaugust/zelda-mobile-nav
Zelda mobile nav
2015-06-08 23:47:56 -05:00