Commit Graph

11375 Commits

Author SHA1 Message Date
Kevin Ansfield
0c24c009d2
🐛 Fixed converter bug that stopped some snippets being migrated for the editor beta
no issue

- if the converted mobiledoc started with a card and contained any text content we would hit a "can not read .length of undefined" error which could prevent snippets from being migrated when opening the beta editor and result in copy/paste from old editor to new not working
- bumped `@tryghost/kg-converters` to a fixed version
2023-06-07 18:48:19 +01:00
Steve Larson
85896287e3 Added koenig lexical package version to sentry report
closes TryGhost/Team#3381
2023-06-07 11:05:35 -05:00
Ghost CI
e1b1af38e9 Merged v5.50.3 into main 2023-06-07 16:01:00 +00:00
Ghost CI
887155938a v5.50.3 2023-06-07 16:00:59 +00:00
Peter Zimon
ed43ebaee6
Fixed editor feature image overlay bug
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:52:55 +02:00
Peter Zimon
5960fdeb53 Fixed editor feature image overlay bug
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:30:07 +02:00
Nick Moreton
c4629e0118
Added transparency grid and event tracking to Image Editor (#16959) 2023-06-07 16:05:38 +01:00
Kevin Ansfield
abc169329c
Added error logging to lexical snippet fix try/catch
no issue

- we had a `catch` with no error logging, it shouldn't be hit but it will be useful to know if it does fail
2023-06-07 09:56:18 +01:00
Rishabh
71e5d708d4 Reverted "Disabled image editor setting check"
This reverts commit 9d9e296148.

This commit was a temporary fix to load the image editor if the setting was disabled.
2023-06-07 02:10:02 +05:30
Ghost CI
80ed948bb9 Merged v5.50.2 into main 2023-06-06 19:05:20 +00:00
Ghost CI
924d73e02e v5.50.2 2023-06-06 19:05:19 +00:00
Rishabh
9d9e296148 Disabled image editor setting check
refs https://github.com/TryGhost/Team/issues/3034

Temporarily disables image editor setting check to allow it load by default
2023-06-06 23:59:43 +05:30
Rishabh
6806b88139 Fixed pintura link in image editor integration
refs https://github.com/TryGhost/Team/issues/3034
2023-06-06 23:35:56 +05:30
Steve Larson
75458cd7be Added koenig lexical version to feedback submission
refs TryGhost/Team#3381
2023-06-06 12:55:51 -05:00
Ghost CI
c8b713a679 Merged v5.50.1 into main 2023-06-06 14:40:58 +00:00
Ghost CI
6a07d63f38 v5.50.1 2023-06-06 14:40:57 +00:00
Kevin Ansfield
076c2be9aa
🐛 Fixed copy/paste of HR cards between editor and beta editor
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
2023-06-06 15:20:35 +01:00
Kevin Ansfield
d5a547b6ad
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 15:20:22 +01:00
Kevin Ansfield
ed24899fa5
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 15:20:14 +01:00
Kevin Ansfield
dddd2a4111
🐛 Fixed copy/paste of HR cards between editor and beta editor
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
2023-06-06 15:14:22 +01:00
Sanne de Vries
d9a20b0e00 Fixed form embed settings overflowing in x direction
Closes https://github.com/TryGhost/Team/issues/3384
2023-06-06 15:24:08 +02:00
Kevin Ansfield
c11c842b1e
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 13:35:07 +01:00
Kevin Ansfield
48defc4000
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 12:56:33 +01:00
Sanne de Vries
9c9eae1c11 Updated signup embed modal responsiveness
Refs https://github.com/TryGhost/Team/issues/3340
2023-06-06 12:21:11 +02:00
Simon Backx
31549933a1 Removed 200% width in signup form minimal preview
no issue

This change wasn't needed after all
2023-06-06 10:43:32 +02:00
Simon Backx
0ae1dad2d2 Removed signup form preview flickering in Safari and improved responsiveness
no issue

- In Safari, we'll poll longer before animating to the new iframe
- Update the iframe immediately if the last change was a while ago, to improve responsiveness
2023-06-06 10:43:06 +02:00
Sodbileg Gansukh
feac482859 Fixed loading screen flash issue in dark mode
closes https://github.com/TryGhost/Team/issues/3344
2023-06-06 16:21:15 +08:00
Simon Backx
f0518bc76a Increased signup form embed icon resolution to 192px
no issue

Optimal resolution for @3x devices
2023-06-06 09:42:42 +02:00
Simon Backx
fc89ad22fc Prevented setting signup form embed locale when feature flag is disabled
fixes https://github.com/TryGhost/Team/issues/3385
2023-06-06 09:40:47 +02:00
Simon Backx
ab0c33346d Fixed signup form minimal width in preview
no issue
2023-06-05 18:10:19 +02:00
Simon Backx
1e7b658148 Updated sign up form to use resized version of icon
fixes https://github.com/TryGhost/Team/issues/3345

The icon is now served as a 128x128px version
2023-06-05 17:59:18 +02:00
Simon Backx
9aef897936 Increased virtual iframe width of minimal signup form preview
no issue

Because the signup form is responsive, it is displayed too small in the preview. To counteract this, the width of the iframe is increased to 200%, and clipped to make it larger.
2023-06-05 17:37:43 +02:00
Daniel Lockyer
6c3517f67a
Removed unused top-gh-contribs dependency
- this is currently unused so we can clean it up
2023-06-05 15:58:51 +02:00
Simon Backx
22f4d55f75 Added throttling and animation when updating signup form preview
fixes https://github.com/TryGhost/Team/issues/3378
2023-06-05 15:24:59 +02:00
Sodbileg Gansukh
f4c109cfb2 Added small improvements to the image editor UI
refs https://github.com/TryGhost/Team/issues/3208

- added maximum width limit to the editor stage, so the image doesn't get under the editor controls
- made the crop indicator a bit bigger
- fixed image alignment for the vertical layout
2023-06-05 18:27:31 +08:00
Ronald Langeveld
52150d5ffb
Fixed Signup Embed iFrame not loading in Safari (#16935)
refs https://github.com/TryGhost/Team/issues/3375

- Fixed a safari bug that caused the signup embed iframe to be in the
`onLoad` state perpetually, causing it not to render.
2023-06-05 12:01:55 +02:00
Ghost CI
7170b2489e v5.50.0 2023-06-05 08:58:31 +00:00
Kevin Ansfield
bbd511b752
Added beta of the new Ghost editor (#16923)
no issue

Keep an eye on Ghost's changelog (https://ghost.org/changelog/) for the full feature announcement.
2023-06-05 09:46:31 +01:00
Ghost CI
6ac848195c v5.49.3 2023-06-02 15:02:42 +00:00
Simon Backx
d4f82f8b88 Added copy on click to textarea in signup form embed modal
no issue
2023-06-02 16:31:30 +02:00
Simon Backx
fc5af7e7f8 Removed notification when copying signup form embed code 2023-06-02 16:21:20 +02:00
Simon Backx
ff28e1c94f Added fixed order in data attributes for signup form embed script
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685711310532969
2023-06-02 16:13:42 +02:00
Sanne de Vries
8833ec03de
Updated signup form modal (#16925)
Refs https://github.com/TryGhost/Team/issues/3340

---------

Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-02 16:07:30 +02:00
Simon Backx
258dc2f8f2 Added locale data option to signup form script
refs https://github.com/TryGhost/Team/issues/3307
2023-06-02 14:36:17 +02:00
Daniel Lockyer
8098f8c53e Updated Admin extensions script functionality
fixes https://github.com/TryGhost/Toolbox/issues/587

- this commit changes two things surrounding the extensions script:
  - moves the script tag from the nav menu to the application template
    so we always load the script irregardless of if the current page has
    a nav menu
  - opens up showing the script to all logged-in users and not just
    Owners as previous
2023-06-02 14:05:40 +02:00
Simon Backx
c27b488f3d Added async attribute to signup form script tag 2023-06-02 13:59:49 +02:00
Kevin Ansfield
ba6ae472c3
Renamed editor beta route
closes https://github.com/TryGhost/Team/issues/3369

- removes `lexical` from user-visible URL
- only renames path rather than renaming all associated files to keep changeset minimal prior to beta launch
2023-06-02 12:52:57 +01:00
Michael Barrett
108c7c38f6
Removed imageEditor flag (#16921)
refs https://github.com/TryGhost/Team/issues/3337

Removed `imageEditor` flag and moved gated logic to be behind the
`lexicalEditor` flag as part of the labs clean up
2023-06-02 12:07:31 +01:00
Simon Backx
806abf28e4 Added placeholder to member label input for signup form embed modal
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 12:28:58 +02:00
renovate[bot]
a1ab6737e1 Update dependency @embroider/macros to v1.11.0 2023-06-02 11:01:47 +02:00
Djordje Vlaisavljevic
307380a29e Removed L label next to Lexical posts in post list
refs https://github.com/TryGhost/Team/issues/3370
2023-06-02 09:42:52 +01:00
Djordje Vlaisavljevic
559c1e0764 Updated feedback form copy
refs https://github.com/TryGhost/Team/issues/3370
2023-06-02 09:42:52 +01:00
Simon Backx
f00b788e6a Moved signup form embed to the membership settings
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 10:15:08 +02:00
Simon Backx
9ff9906670 Added transparent background pattern to minimal signup form preview
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 09:48:25 +02:00
Simon Backx
5152e0e042 Moved signup form embed to a modal
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 09:31:38 +02:00
renovate[bot]
7959f76f44 Update sentry-javascript monorepo to v7.54.0 2023-06-02 09:06:32 +02:00
Jono Mingard
eaa16c2f75 Added simple colour picker to change signup embed background
refs https://github.com/TryGhost/Team/issues/3338
2023-06-02 11:33:08 +12:00
Jono Mingard
024045b9e3 Update signup form text colours to be passed via attributes 2023-06-02 10:59:00 +12:00
Djordje Vlaisavljevic
1cce47482f Added link to Editor beta changelog post in Labs
refs https://github.com/TryGhost/Team/issues/3364
2023-06-01 17:20:04 +01:00
Sanne de Vries
3923b5cc88 Updated embeddable signup form to be responsive
Refs https://github.com/TryGhost/Team/issues/3334
2023-06-01 17:43:28 +02:00
Simon Backx
bcaf95f506 Updated signup form with minimal style to use automatic height and minimum height
refs https://github.com/TryGhost/Team/issues/3295
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685620939701309?thread_ts=1685614059.121599&cid=C04TMVA1D7A

- The error message of the minimal style form is not visible
- Use minimum height instead of fixed height
- Automatically update height
- Fixed issues with iframe inline style causing spacing and layout jumps
2023-06-01 14:36:00 +02:00
Michael Barrett
ef92028b22
Removed post diffing from post history feature (#16904)
refs https://github.com/TryGhost/Team/issues/3337

Removed post diffing from post history feature as this functionality is
likely to be reworked in a future cycle
2023-06-01 13:22:51 +01:00
Michael Barrett
83847bf22c
Added emailCustomization flag and removed makeItRain flag (#16903)
refs https://github.com/TryGhost/Team/issues/3337

Moved current email customization functionality that is behind the
`makeItRain` to its own flag (`emailCustomization`) and removed the now
redundant `makeItRain` flag
2023-06-01 12:32:37 +01:00
Michael Barrett
09ded37d91
Removed emailErrors flag (#16900)
refs https://github.com/TryGhost/Team/issues/3337

Removed emailErrors flag as it is no longer needed
2023-06-01 12:11:01 +01:00
Simon Backx
17e9b803e4 Added POC for resizing iframe to fit outer container
refs https://github.com/TryGhost/Team/issues/3295
2023-06-01 12:06:48 +02:00
Rishabh
4883d73a0f Updated API service for admin-x
refs https://github.com/TryGhost/Team/issues/3151

The api service in admin-x was using hardcoded `x-ghost-version` as we did not have access to version value in the app so far. This change passes the ghost version from ember Admin app to Settings-X app via props, and refactors the api util to use the app version as a common header.

- Adds new services provider to pass common services for the app
- passes API as a service via context for the App
- refactors existing API usage to use api from context
2023-06-01 14:32:38 +05:30
Sodbileg Gansukh
116e09af95 Show the mobile nav only when logged in
closes https://github.com/TryGhost/Team/issues/3134

- the mobile nav was showing for 404 pages when not logged in
- this adds an additional check, so that the nav is only shown when user is logged in, not only when the user is not contributor
2023-06-01 15:23:47 +08:00
Chris Raible
c0b3aab4f2
Removed postHistory flag and updated post history logic (#16908)
no issue

- Removed the postHistory flag from labs
- Post History will be saved and displayed for all lexical posts,
regardless of whether the lexicalEditor flag is currently set
- Post History will still not be displayed for any mobiledoc posts
- With this change, the logic is simplified as we don't have to worry
about flags, but only the content in the given post (mobiledoc vs
lexical)
- If someone toggles the lexicalEditor flag on, creates a new post, then
toggles the lexicalEditor off, we still want Post History to work for
the existing lexical post
2023-05-31 23:45:29 -07:00
Sodbileg Gansukh
3ab851e3aa Optimized Inter in the Admin
closes https://github.com/TryGhost/Team/issues/3257

- replaces the TTF with WOFF2 which is more compressed version
- adds a font file for italic style specifically so that the italic text is rendered consistently across different browsers
2023-06-01 11:56:27 +08:00
Djordje Vlaisavljevic
bbdb90f1d6 Updated feedback form copy
refs https://github.com/TryGhost/Team/issues/3264
2023-05-31 21:56:37 +01:00
Ghost CI
7e04828d45 Merged v5.49.2 into main 2023-05-30 14:57:20 +00:00
Ghost CI
e19f434781 v5.49.2 2023-05-30 14:57:17 +00:00
Simon Backx
644051e3e9 Fixed labels for signup form
fixes https://github.com/TryGhost/Team/issues/3316
fixes https://github.com/TryGhost/Team/issues/3313

Instead of using a comma separated list of labels, we now use multiple data properties: data-label-1, data-label-2, etc.
2023-05-30 14:06:25 +02:00
renovate[bot]
cb6825f1a3 Update sentry-javascript monorepo to v7.53.1 2023-05-30 10:51:52 +02:00
Ronald Langeveld
393055dd6c Bumped koenig related packages
no issue
2023-05-30 08:00:42 +02:00
Sodbileg Gansukh
7eaee22a75
Added a custom duration to the comp expirations (#16808)
refs https://github.com/TryGhost/Team/issues/1856

- adds a custom duration option with date picker to the complimentary plan when "Custom" is selected
- this allows customers to choose any date as expiration date

---------

Co-authored-by: Michael Barrett <mike@ghost.org>
2023-05-30 13:35:40 +08:00
Ronald Langeveld
5445e1d1b4 Bumped Koenig packages
no issue
2023-05-29 18:27:26 +02:00
Elena Baidakova
254de144e4
Fixed dark mode for lexical (#16888)
refs TryGhost/Team#3327
2023-05-29 17:20:25 +04:00
Sanne de Vries
08fc96a077 Refined signup card frontend styles
Refs https://github.com/TryGhost/Team/issues/3246
2023-05-29 12:28:27 +02:00
Ghost CI
a589fcd9e4 v5.49.1 2023-05-26 15:02:32 +00:00
Simon Backx
bd6b3099d8 Updated admin tests for feature helper change
refs 488aa983d0
2023-05-25 15:38:21 +02:00
Simon Backx
488aa983d0 Added signup form code generation to admin
fixes https://github.com/TryGhost/Team/issues/3296

Adds a new `signupForm` feature flag, that will enable/disable the new embeddable signup form code generation.

Since the new flag shares its name with a new config value (that contains the script location), this also fixes the feature helper to only use a config with the same name if it is a boolean.
2023-05-25 15:18:40 +02:00
Kevin Ansfield
2598097b36
Added lexical conversion when copying from mobiledoc
closes https://github.com/TryGhost/Team/issues/3311

- added event handler to the mobiledoc editor for cut and copy operations that reads mobiledoc from the event data, converts to lexical using `@tryghost/kg-converters` and stores the converted data on the event under the `application/x-lexical-editor` mimetype ready to be pasted into a lexical editor
2023-05-25 13:50:47 +01:00
Kevin Ansfield
365a143c64
Added paste support to mobiledoc when copying from lexical
refs https://github.com/TryGhost/Team/issues/3199

- when content is copied from the Lexical editor the converted mobiledoc post is placed in the clipboardData's `application/x-mobiledoc-editor` mimetype
- added custom paste handling to extract that data and place it into the html content in the same format as a typical mobiledoc copy/paste so that it can then be handled internally by mobiledoc
2023-05-25 13:50:44 +01:00
renovate[bot]
f768639102 Update sentry-javascript monorepo to v7.53.0 2023-05-25 11:41:13 +02:00
Sag
92e7c069f3 Added site title and description in the config for the Lexical editor
refs https://github.com/TryGhost/Team/issues/3282
2023-05-24 11:23:00 +02:00
Djordje Vlaisavljevic
af907b70cb Fixed condition for displaying feedback form on Post published
refs #3252
2023-05-23 22:41:01 +01:00
Steve Larson
49687f73a6 Added handling for new paragraphs when clicking under cards
closes TryGhost/Team#3064
2023-05-23 14:16:18 -05:00
Michael Barrett
81e160c8d3
🐛 Fixed member activity event filter (#16849)
closes https://github.com/TryGhost/Ghost/issues/16817

The member activity event filter was broken due to a recursion issue.
This commit changes the usage of a getter fn to a normal class method to
make the logic more performant and remove the recursion issue
2023-05-23 14:44:49 +01:00
Naz
cc4ff8c6d4 Added collections CRUD UI
refs https://github.com/TryGhost/Team/issues/3168

- This is basic scaffolding for collection resources UI in Admin. For the most part it's a copy-paste of tags code with slight modifications to fit the collections usecase
2023-05-23 17:26:47 +07:00
Sag
2526bd627e
Simplified fetchLabels to return an array of label names (#16842)
refs https://github.com/TryGhost/Team/issues/3182
2023-05-23 08:48:14 +02:00
Sodbileg Gansukh
282d385484 Added dark mode support to staff invitation modal popover
closes https://github.com/TryGhost/Team/issues/2951
2023-05-23 13:52:35 +08:00
Sodbileg Gansukh
03cded7e9e Added more context to the site description setting label
no issues
2023-05-23 12:37:06 +08:00
Djordje Vlaisavljevic
4af604a04f Updated feedback form copy
refs #3252
2023-05-22 21:37:05 +01:00
renovate[bot]
193c89ae66 Update sentry-javascript monorepo to v7.52.1 2023-05-22 13:51:09 +02:00
Djordje Vlaisavljevic
ae91be348b Updated feedback form copy
refs #3264
2023-05-22 12:21:19 +01:00
Sodbileg Gansukh
f4bb135f9c Fixed typography inconsistency in the publish flow
refs https://github.com/TryGhost/Team/issues/2812
2023-05-22 17:31:18 +08:00
Sodbileg Gansukh
50c68dc5ad Fixed background color of the update banner in dark mode
refs https://github.com/TryGhost/Ghost/issues/16819
2023-05-22 14:13:59 +08:00
Ghost CI
bba46cdb19 v5.49.0 2023-05-19 15:09:58 +00:00
Djordje Vlaisavljevic
b489986edc Updated feedback widget design on Post published
refs #3244
2023-05-19 15:06:29 +01:00