Commit Graph

220 Commits

Author SHA1 Message Date
Peter Zimon
d08e22c0e5 Addedd static values to access in AdminX Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 16:42:09 +02:00
Rishabh
05fc1ca810 Fixed lint 2023-05-19 20:10:25 +05:30
Rishabh
06ed1d70cb Wired social accounts setting to real site data
refs https://github.com/TryGhost/Team/issues/3151

- wires facebook and twitter url to real settings data in admin-x
- manages (de)serialisation of facebook/twitter users
- todo: error handling for invalid urls is
2023-05-19 20:03:55 +05:30
Rishabh
3ee39d458b Updated hint for admin-x publication language UI
refs https://github.com/TryGhost/Team/issues/3151

- updates hint to take both string and custom react node
- allows adding custom/more complex hints to text fields
2023-05-19 20:03:55 +05:30
Rishabh
2e517b9f3b Wired read/write for publication language setting
refs https://github.com/TryGhost/Team/issues/3151

- wires real setting data read/write for publication language
2023-05-19 18:46:41 +05:30
Peter Zimon
3ef4a12c8d Fixed preflight for select in AdminX DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 15:14:04 +02:00
Peter Zimon
9d84bc257b Fixed onSave method in AdminX DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 15:04:22 +02:00
Daniel Lockyer
0fb35cf236
Added test:unit command to admin-x-settings
refs https://ghost.slack.com/archives/C02G9E68C/p1684496945687519?thread_ts=1684496771.857689&cid=C02G9E68C

- this will run a build of the package upon testing, which can reveal
  issues with code if the typescript compiler isn't happy
2023-05-19 14:56:08 +02:00
Rishabh
12871e6a77 Fixed lint error for unused event type
refs https://github.com/TryGhost/Team/issues/3150
2023-05-19 18:23:56 +05:30
Rishabh
7dd8628b40 Wired Timezone settings to use real data
refs https://github.com/TryGhost/Team/issues/3150

- wires Timezone setting to read list of timezones and allow editing/saving new value
- handles read/write of real timezone setting from settings context
- uses `@tryghost/timezone-data` to fetch list of all timezones
- adds typings.d.ts to handle missing types for @tryghost/timezone-data
2023-05-19 18:23:34 +05:30
Rishabh
a420adf684 Added default option for global Dropdown component
refs https://github.com/TryGhost/Team/issues/3150

- updates Dropdown component to allow a default selected option on first render
2023-05-19 18:14:03 +05:30
Peter Zimon
9f84b6d9d4 Added static analytics inputs to AdminX Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 13:39:29 +02:00
Peter Zimon
6f4fa691ad Added static input fields to pw protection
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 13:39:29 +02:00
renovate[bot]
a1dc3d4f33 Update dependency typescript to v5.0.4 2023-05-19 12:39:23 +02:00
Peter Zimon
cce150d04e Added toggle component to AdminX design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 12:29:42 +02:00
renovate[bot]
b373c8911e Update storybook monorepo to v7.0.12 2023-05-19 12:04:46 +02:00
renovate[bot]
39453b678b Update dependency vitest to v0.31.1 2023-05-19 11:50:49 +02:00
Daniel Lockyer
58539c355b
Added --adminX functionality to yarn dev
fixes https://github.com/TryGhost/Toolbox/issues/581

- this adds support for spinning up AdminX within the `yarn dev` script
  with zero other steps needed
2023-05-19 10:34:06 +02:00
Peter Zimon
0c85012bdc Merged components in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150

Setting group values and Setting group inputs components were practically the same.
2023-05-19 09:17:26 +02:00
Peter Zimon
5800b63221 Added static values to Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 08:12:21 +02:00
Peter Zimon
25ac93e7ca Removed state variable from setting SettingGroup
refs. https://github.com/TryGhost/Team/issues/3150

The state variable in the global setting group component in Admin X was unnecessary.
2023-05-19 07:46:54 +02:00
Peter Zimon
da9c004aa6 Added static social account settings in Admin X
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 07:38:45 +02:00
Peter Zimon
ea42f97ae7 Added text based settings in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 07:18:29 +02:00
Peter Zimon
61e5068081 Fixed type antipattern in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 06:13:57 +02:00
Peter Zimon
c0be5c91f7 Re-set auto time update in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-18 13:44:37 +02:00
Peter Zimon
9285bc2e52 View/edit interaction in Admin Settings
refs. https://github.com/TryGhost/Team/issues/3150

There was an opportunity to make a reusable interaction within the Setting Group component so that switching between different states are implicitly handled. With this change it's possible to just add a Setting Group component without the need to build the logic over and over again. The component expects only the "contents" (ie. values in view state or input fields in edit state) as its children. There's a built in header with Edit/Cancel/Save buttons which is overridable with the `customButtons` parameter. A completely custom header can be used via the `customHeader` parameter.

See `TitleAndDescription.tsx` for a working example.
2023-05-18 13:06:13 +02:00
Rishabh
9bdbe92183 Released Admin-x-settings v0.0.6 2023-05-18 02:22:47 +05:30
Rishabh
9af3714d8c Wired site settings to admin-x components
refs https://github.com/TryGhost/Team/issues/3151

- wires real setting value for a site to general settings UI in admin-X
2023-05-18 02:13:07 +05:30
Rishabh
5b0eba9b1f Added new provider to manage settings for admin-x
refs https://github.com/TryGhost/Team/issues/3151

- adds new settings provider that fetches settings for a site and allows saving them
- adds new helpers for making admin api calls and fetching setting values
2023-05-18 02:03:14 +05:30
Peter Zimon
cfbcd6fc1a Added static settings in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3151
2023-05-17 19:37:52 +02:00
Peter Zimon
07919f2fbe Hide save button in setting groups in Admin X
refs. https://github.com/TryGhost/Team/issues/3150

Save button is not necessary until a value is changed.
2023-05-17 19:15:27 +02:00
Peter Zimon
ece42c7e26 Component fixes in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 19:09:09 +02:00
Peter Zimon
f0ef0cd54f Refinements in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 19:01:01 +02:00
Peter Zimon
b2cf7704d5 Added design docs to headings in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 18:50:14 +02:00
Peter Zimon
a3dc651397 Refined spacing in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 18:24:08 +02:00
Peter Zimon
2e42454f13 Fixed Storybook arg types in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150

We are using ReactNode type parameters which can't be set directly in Storybook.
2023-05-17 18:15:21 +02:00
Peter Zimon
f3886028df Removed outline from dropdowns in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 17:47:34 +02:00
Peter Zimon
9cdc31350d Added basic dropdown component to Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 17:40:20 +02:00
Peter Zimon
e6d289da4a Fixed typography in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 16:12:57 +02:00
Peter Zimon
e880cae1d2 Added auto focus to input field in Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 16:11:07 +02:00
Peter Zimon
2978b4752b Added dynamic properties to settings in AdminX DS
refs. https://github.com/TryGhost/Team/issues/3150

- Setting group values were taking their input parameters statically which meant that it didn't auto-extend as new props have been added
2023-05-17 15:42:23 +02:00
Peter Zimon
0b4fc8d591 Added button disabled state in Admin design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 15:39:44 +02:00
Peter Zimon
0bcfdbd7ce Added static state handling to Admin Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 15:39:44 +02:00
Peter Zimon
9e9200022c Fixed button bug in Admin design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 14:02:19 +02:00
Peter Zimon
d1c96dd9c8 Fixed Admin design system bug
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 13:54:07 +02:00
Peter Zimon
82999ee144 Added setting group input component to Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 13:35:54 +02:00
Peter Zimon
347f331d63 Added static input field to Admin X Design System
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 13:08:09 +02:00
Peter Zimon
d8b1a715b4 Added setting group view mode to Admin X DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 12:36:15 +02:00
Peter Zimon
f58b9d3499 Storybook cleanup in Admin X design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 12:08:33 +02:00
Peter Zimon
a789c84530 Added setting group value component to AdminX DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 12:03:18 +02:00
Rishabh
6630fd1cb4 Updated font handling for admin-x settings
refs https://github.com/TryGhost/Team/issues/3151

- splits font loading between css files that are loaded locally for storybook/demo app vs the exported App
- uses local Inter font for exported App vs local asset for demo
2023-05-17 15:23:55 +05:30
Peter Zimon
bfd6581696 Added setting value to AdminX design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 11:34:56 +02:00
Peter Zimon
83749ae181 Cleaned up headings in Admin design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 11:21:38 +02:00
Peter Zimon
9a89f4ccbc Added heading comp. to Admin design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-17 10:58:29 +02:00
Peter Zimon
d8677b4f39 Added postcss-import to Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3151
2023-05-17 08:11:02 +02:00
Peter Zimon
116408e64d Fixed linting error 2023-05-17 07:53:18 +02:00
Peter Zimon
4ab0c08bb4 Updated dev. env. setup for Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3151
2023-05-17 07:47:10 +02:00
Peter Zimon
dc3df28ff0 Added blockheading component to Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-16 17:44:40 +02:00
Rishabh
bd49a50f68 Released Admin-x-settings v0.0.5 2023-05-16 21:10:07 +05:30
Rishabh
2c1cab6c42 Updated css handling for admin-x-settings package
refs https://github.com/TryGhost/Team/issues/3151

- adds root classname for admin-x settings app so class names can be scoped inside
- adds new preflight.css for resetting admin styles for admin-x app
- moved font to assets/font so it can be picked for both demo app and Admin
2023-05-16 21:08:49 +05:30
Peter Zimon
85688ace3e Fixed inivisible sidebar in Admin X settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-16 17:24:40 +02:00
Rishabh
dc480b107a Released Admin-x-settings v0.0.4 2023-05-16 17:44:27 +05:30
Peter Zimon
9556bfbdc3 Fixed linting and added Settings stories
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-16 14:02:22 +02:00
Peter Zimon
ca97fda1a2 Added stories for Settings reusable components
refs. https://github.com/TryGhost/Team/issues/3150

Settings specific reusable components were missing storybook stories.
2023-05-16 13:46:08 +02:00
Rishabh
52b2e48313 Released Admin-x-settings v0.0.3 2023-05-16 12:51:19 +05:30
Rishabh
067766e555 Updated publish config for admin-x settings package
refs https://github.com/TryGhost/Team/issues/3151
2023-05-16 12:49:59 +05:30
Rishabh
bb8eba9f37 Released Admin-x-settings v0.0.2 2023-05-16 12:41:50 +05:30
Rishabh
cfd704d0e1 Updated publish config for admin-x settings
refs https://github.com/TryGhost/Team/issues/3151
2023-05-16 12:33:37 +05:30
Rishabh
7b42aedf74 v0.0.1 2023-05-16 12:29:32 +05:30
Rishabh
3d6fb0d6b1 Added new package for admin-x settings
refs https://github.com/TryGhost/Team/issues/3151

- adds a new vite + typescript + storybook + TW package for setting up admin settings in react with base config that works with Ghost monorepo
- includes base components/design system for new settings UI
- adds eslint rule config to the package to match rest of Ghost codebase
- this is an experimental package as we figure out the best patterns for new admin packages in Ghost monorepo

Co-authored-by: Peter Zimon <zimo@ghost.org>
2023-05-16 12:23:24 +05:30