Commit Graph

6221 Commits

Author SHA1 Message Date
Kevin Ansfield
22a7d1c374
Added animated icon for "hide title + feature image" toggle (#17220)
closes https://github.com/TryGhost/Product/issues/3577

- adds icon as a handlebars file to avoid SVGO breaking the styles needed for the toggle to work
2023-07-06 11:38:36 +00:00
Kevin Ansfield
a1d4b4cc9d
Wired up toggle for hiding page title and feature image (#17214)
closes https://github.com/TryGhost/Product/issues/3558
closes https://github.com/TryGhost/Product/issues/3559

- added property to post model
- updated post serializer to not send property when saving a post rather than a page
- added property toggle to post settings menu
- updated indicators next to title and feature image to show real property state
2023-07-06 08:51:19 +00:00
Naz
4372a7e1a8 Added feature flag for flatUrls
refs https://github.com/TryGhost/Arch/issues/24

- Enables generating Post and Page URLs in a flat `{slug}-{id}` format
2023-07-05 17:41:28 +08:00
Rishabh
79a7f8c408 Added basic routing for adminX settings
refs https://github.com/TryGhost/Product/issues/3349

- adds basic routing in adminX settings based on hash url path
- adds new routing provider that manages hash routing across adminX
- updates sidebar navigation to update route directly
- updates theme/design settings to update route for opening edit modals
2023-07-04 20:56:55 +05:30
Kevin Ansfield
ca8d8a5014
Fixed "hidden" icon for feature img/title showing on posts (#17180)
no issue

- adjusted conditional to take post type into account
- removed usage of `lexicalEditor` feature flag as the flag only adjusts
default editor rather than access to the editor (existing lexical
posts/pages will always load lexical editor)
2023-07-03 12:40:27 +01:00
Sanne de Vries
1388f1d049
Added hidden indicator to title and feature image (#17177)
No ref
2023-07-03 11:26:33 +02:00
Sanne de Vries
4a6a61b29b
Added feature flag for page improvements (#17176)
No ref
2023-07-03 09:24:57 +02:00
Sodbileg Gansukh
0281a30fb4
Merged similar history events (#16865)
closes https://github.com/TryGhost/Team/issues/2463

- it merges the similar history events by adding additional properties
to the events data
- `skip` was added to the current event when the next event is similar to
it, so that the event isn't output on the frontend
- `count` was added to the last item of the similar events and it's used
for outputting the number of repeated similar events
2023-06-26 09:29:18 +08:00
Ronald Langeveld
5247d28a80
Added beta of the new Signup Card (#17124)
no issue

Keep an eye on Ghost's changelog (https://ghost.org/changelog/) for the
full feature announcement.


<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at ee03e4d</samp>

This pull request removes the `signupCard` feature flag and enables the
signup card for all users in the Lexical editor. This is part of the
Lexical editor beta release, which is a new editor for Ghost that
provides a better writing experience and more features for content
creators.
2023-06-23 16:59:46 +02:00
Michael Barrett
6f5baca849
Add endpoint to record mail events (#16990)
refs https://github.com/TryGhost/Team/issues/3319
2023-06-23 12:22:01 +01:00
Sanne de Vries
f2d35c6a9a
Updated admin darkmode background color to be consistent with global … (#17101)
…colors

No ref
2023-06-22 16:35:03 +02:00
Michael Barrett
934ec415fc
🐛 Fixed revision save reverting newly published post to draft (#17083)
fixes https://github.com/TryGhost/Ghost/issues/17076

When a post is saved `_revisionSaveTask` gets queued to execute 10
minutes from the save. When a post is published via the publish modal
`_revisionSaveTask` does not get dequeued. When `_revisionSaveTask` gets
executed at the 10 minute mark it is assumed that it is ok to save a
revision, which will cause the post to be reverted back to a draft. This
change enforces another check during the task exection to ensure that it
is in fact still ok to save a revision (in case anything has changed in
the 10 minutes since the task queued, i.e the post being published)
2023-06-21 15:12:19 +01:00
Ronald Langeveld
bd348dc297
🎨 Improved copy on page & post revisions (#17068)
no issue

Updates the labels of the post history components to reflect the type of
content (post or page).
It modifies the `restore-revision`, `gh-post-settings-menu`, and
`modal-post-history` components.
2023-06-20 14:52:51 +02:00
Simon Backx
fd2ef61b3c 🎨 Improved copy on too many login attempts
fixes https://github.com/TryGhost/Team/issues/2391
2023-06-20 14:32:04 +02:00
Jono Mingard
f084fbd025 Added dirty state navigation blocking to AdminX settings
refs https://github.com/TryGhost/Team/issues/3349
2023-06-20 12:58:44 +10:00
Kevin Ansfield
f5c78221a6
Fixed "Beta feedback" not showing in beta editor when feature flag is switched off
no issue

- even when the editor beta is turned off, any post created in the beta will still open in the beta editor
- the "beta feedback" text in the bottom right was disabled when the beta flag was disabled which meant it was difficult to tell when you were using the beta editor vs the original editor
2023-06-19 15:22:22 +01:00
Naz
7d4b278a83
Fixed slug-based navigation in collections UI
refs https://github.com/TryGhost/Team/issues/3169

- When navigating through collections slugs did not display correctly returning "undefined" in the navigation. It was easier to fix the bug than working around it.
2023-06-19 17:07:50 +07:00
Naz
8d9d9de8d4
Added basic UI for collection posts
refs https://github.com/TryGhost/Team/issues/3169

- Added a lits to a collection view showing which posts belong to a collection.
2023-06-19 14:38:01 +07:00
Michael Barrett
721d7202a0
Added truncation to custom theme setting description (#17044)
no issue

Added truncation to custom theme setting description to prevent overly
long custom setting descriptions from diminishing the settings UX
2023-06-16 13:14:43 +01:00
Rishabh
eeabce2473 Fixed official theme image assets not loading in adminX
refs https://github.com/TryGhost/Team/issues/3432

The admin assets url are modified by ember build process by adding cache busting, so the original urls can't be used directly in adminX. This change passes the image assets from ember admin, causing the right image urls to be passed to adminX and for loading images.
2023-06-16 17:06:22 +05:30
Ronald Langeveld
77e3b3e947
🐛 Fixed page revision returning empty array on update and restore (#17042)
closes https://github.com/TryGhost/Team/issues/3491

- the `PostRevisionModel` had a `belongsTo` relation to Post which resulted in the Page model returning an empty array in the `post_revisions` property.
- Simply removing it fixed it. refs https://ghost.slack.com/archives/C02G9E68C/p1686912389383579?thread_ts=1686909240.034419&cid=C02G9E68C
2023-06-16 13:24:02 +02:00
Michael Barrett
9ce4c85905
Added custom theme setting descriptions (#17024)
refs https://github.com/TryGhost/Team/issues/3448

Added the ability to specify a description for a custom theme setting

---------

Co-authored-by: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
2023-06-15 15:10:56 +01:00
Simon Backx
885e5b7b9c 🐛 Fixed visible scrollbars in signup form preview
fixes https://github.com/TryGhost/Team/issues/3485
2023-06-15 15:04:09 +02:00
Kevin Ansfield
3e8a0c5028
🎨 Added word count to beta editor
closes https://github.com/TryGhost/Team/issues/3242

- the beta editor now provides `<WordCountPlugin>` for tracking word count so we can add the UI for it back
2023-06-14 17:56:03 +01:00
Ronald Langeveld
998708c81a
🐛 Fixed empty icon crashing signup embed preview (#17022)
closes https://github.com/TryGhost/Team/issues/3471

- after adding and removing an icon, icon settings passed an undefined
icon to the signup form's all-in-one style. The AIO conditions didn't
take that into account and caused the entire component to crash.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 9e1aea3</samp>

Fix signup form embed code generation when icon is not set. Add a check
for `this.settings.icon` in `signup-form-embed.js` before replacing
image path.
2023-06-14 15:13:49 +02:00
Simon Backx
14e05a6f0f 🐛 Disabled signup form embed menu when members are disabled
fixes https://github.com/TryGhost/Team/issues/3470

- When members are disabled or invite only, the signup form embed should be disabled
- The comments access setting is now also disabled if members are disabled
- The tiers menus are now also disabled if members are disabled
2023-06-14 14:57:08 +02:00
Simon Backx
04d04e1864
Revert "Fixed post editor items getting cut off on iOS" (#17017)
Reverts TryGhost/Ghost#16765

This commit broke the browser tests because the save button is hidden
underneath the settings menu:


![image](https://github.com/TryGhost/Ghost/assets/5277847/ec384fbb-6a39-4799-965d-768f66df3ad5)
2023-06-14 11:31:58 +02:00
Simon Backx
e680ddf14a Fixed retrying failed email without error message
refs https://ghost.slack.com/archives/CTH5NDJMS/p1686730494254149?thread_ts=1686593227.689069&cid=CTH5NDJMS
2023-06-14 10:18:50 +02:00
Jonathan Browne
d34b9b021a
Fixed post editor items getting cut off on iOS (#16765) 2023-06-14 09:45:17 +02:00
Elena Baidakova
9f1279b58e
🐛 Fixed snippet insertion in the new editor (#17003)
refs TryGhost/Team#3445
- The snippet model always expects an object as it gets serialized when
saving - if we give it a string, it gets doubly serialized. It breaks
snippet replacement and insertion in the new editor.
2023-06-13 15:51:23 +04:00
Fabien 'egg' O'Carroll
7e1efd97e8
🐛 Fixed Post History for posts sent as an email (#16999)
refs https://github.com/TryGhost/Team/issues/3458

From the discussion in slack, for all published/sent posts:
  Published only --> view history & restore
  Published & sent --> view history & restore
  Email only --> history hidden

And for all unpublished/unsent posts:
  All states --> view history & restore.
2023-06-13 12:38:39 +02:00
Ronald Langeveld
c0e638fecd Added membersEnabled config to lexical editor
refs https://github.com/TryGhost/Team/issues/3456

- adds a boolean config whether members signup is enabled so that we can
  hide the signup card option from the editor if it's not enabled.
2023-06-13 08:47:16 +02:00
Simon Backx
5e7edb9da5 Added embeddable signup form
refs https://github.com/TryGhost/Team/issues/3274

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
2023-06-09 11:30:03 +02:00
Simon Backx
ffa6c9c5f8 Added width:100% to minimal signup form CSS
no issue

Otherwise the auto margin would cause issues in a grid or flex container.
2023-06-09 11:08:14 +02:00
Simon Backx
12f7fd0153 Updated minimal signup form to be centered by default
no issue

Added `margin: 0 auto;` css by default.
2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055 Moved maximum width and centering outside minimal signup form
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999

- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
2023-06-09 10:42:24 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal (#16971)
Refs https://github.com/TryGhost/Team/issues/3407

---------

Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f Updated signup form embed settings copy
No ref
2023-06-09 08:26:21 +02:00
Simon Backx
c5fbd8bae6 Added Plausible events when copying the signup form embed code
fixes https://github.com/TryGhost/Team/issues/3389
2023-06-08 15:51:32 +02:00
Sanne de Vries
9d93d21a2d Fixed signup form modal height
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
- Previous commit broke the height as the negative margin should've only been applied horizontally
2023-06-08 14:18:16 +02:00
Sanne de Vries
7a74563e21 Fixed scrollbar position in signup form modal
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
2023-06-08 14:06:31 +02:00
Simon Backx
5949d6a8d4 🐛 Fixed closing modals in admin UI when releasing mouse outside modal
no issue

When selecting text, and releasing your mouse outside the modal, the modal would close.
2023-06-08 13:50:44 +02:00
Simon Backx
5658f4b627 Fixed admin failing tests
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
2023-06-08 13:38:13 +02:00
Simon Backx
a68ac4b688 Renamed data-logo to data-icon in signup embed attributes
fixes https://github.com/TryGhost/Team/issues/3401
2023-06-08 13:23:38 +02:00
Simon Backx
887f7385e1 Fixed label picker overflow hidde in modal in signup form modal
no issue
2023-06-08 13:17:54 +02:00
Elena Baidakova
4f1a92fb17
Fixed the ability to return to the main post page after scheduling a post in lexical (#16970)
refs TryGhost/Team#3405
- BackgroundSave option sets post status as Draft. Don't need such
behaviour as a post already can have a different status when a user
leaves the page.
2023-06-08 12:20:07 +04:00
Steve Larson
85896287e3 Added koenig lexical package version to sentry report
closes TryGhost/Team#3381
2023-06-07 11:05:35 -05:00
Peter Zimon
5960fdeb53 Fixed editor feature image overlay bug
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:30:07 +02:00
Nick Moreton
c4629e0118
Added transparency grid and event tracking to Image Editor (#16959) 2023-06-07 16:05:38 +01:00
Kevin Ansfield
abc169329c
Added error logging to lexical snippet fix try/catch
no issue

- we had a `catch` with no error logging, it shouldn't be hit but it will be useful to know if it does fail
2023-06-07 09:56:18 +01:00