3 Commits

Author	SHA1	Message	Date
Hannah Wolfe	2876178dcf	🐛 Fixed logic error in navigation for isSecondary ... closes #11772 - Ensures that isSecondary is a boolean true or false - Added tests that cover the bug, switching to using compile because the helpers have to be run together - TODO: all tests for helpers should be switched to compile, it's SO MUCH easier	2020-05-18 19:15:28 +01:00
Hannah Wolfe	22e13acd65	Updated var declarations to const/let and no lists ... - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!	2020-04-29 16:51:13 +01:00
Hannah Wolfe	7f1d3ebc07	Move tests from core to root (#11700) ... - move all test files from core/test to test/ - updated all imports and other references - all code inside of core/ is then application code - tests are correctly at the root level - consistent with other repos/projects Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>	2020-03-30 16:26:47 +01:00