6 Commits

Author	SHA1	Message	Date
Hannah Wolfe	3dcf85d5e4	Ensured correct usage of @tryghost/errors everywhere ... refs: 23b383bedf - @tryghost/error constructors take an object, not a string - the expectation is that message, context & help should all be set - This does the bare minimum and just ensures message is set correctly	2022-02-15 12:30:36 +00:00
Fabien O'Carroll	3efb2f1f04	Required OfferName to be a maximum of 40 characters ... refs https://github.com/TryGhost/Team/issues/1236 We want to be able to use the OfferName as the name property for a Stripe Coupon - which has a maximum character length of 40.	2021-11-25 12:34:33 +02:00
Fabien O'Carroll	0b9c9968d0	Added initial tests for Offers ... refs https://github.com/TryGhost/Team/issues/1198	2021-11-07 23:10:10 +02:00
Fabien O'Carroll	35f150bcf4	Moved errors to domain/errors ... no-issue More cleanup to pull files into their appropriate responsibility	2021-10-08 12:31:11 +02:00
Fabien O'Carroll	78be4b55c9	Moved ValueObject to domain/models/shared ... no-issue This is only ever used in this directory so it makes sense to be colocated.	2021-10-08 12:23:40 +02:00
Fabien O'Carroll	504fb1bfa1	Used Value Objects to validate outside of Offer factory ... no-issue This adds the concept of "Value Objects" to an Offers properties, allowing us to move validation out and ensure that an Offer will only ever have valid properties, without having to duplicate checks - or leave them to the persistent layer. This means we can fail early, as well as write unit tests for all of our validation.	2021-10-07 16:46:08 +02:00