Commit Graph

7257 Commits

Author SHA1 Message Date
Kevin Ansfield
1dcc83aad5 Removed unused code from members-payments route
no issue

- unused code was left over from settings re-jig copy and paste
2021-04-20 17:23:20 +01:00
Kevin Ansfield
04760132e9 Moved payment settings access control to route
no issue

- having owner-only access control in the template meant the route was accessible but would show a blank page
- updated access control in the `members-payments` route to redirect admins to the settings index screen and non-admins to the default home screen
2021-04-20 17:08:54 +01:00
Kevin Ansfield
4e2a7b9af5 Removed unused code from members-payments controller
no issue

- unused code was left over from settings re-jig copy and paste
2021-04-20 17:02:43 +01:00
Kevin Ansfield
5337a96074 Removed unused code from <GhMembersPaymentSettings>
no issue

- code relating to "portal settings" and "leave settings" modals was unused, presumably left over from settings re-jig copy and paste
2021-04-20 16:55:31 +01:00
Sanne de Vries
62159390fd Fixed modal overflow responsive issue 2021-04-20 15:57:14 +02:00
Kevin Ansfield
ecf82fbfe8 Fixed invite staff modal button not reflecting validation state (#1924)
no issue

- when the role selection was extracted to an external component the limit validation was also extracted but had no way of feeding back to the consumer
- added `onValidationSuccess` and `onValidationFailure` arguments to the role selection component to allow validation feedback to the consumer
- updated staff invite modal with actions to update state based on validation so the modal's buttons can update accordingly
2021-04-20 13:39:03 +01:00
Renovate Bot
140545d938 Update dependency @tryghost/limit-service to v0.4.2 2021-04-20 12:53:42 +01:00
Sanne de Vries
a4b9c1f253 Styled access settings
Refs https://github.com/TryGhost/Team/issues/579
2021-04-20 11:31:22 +02:00
Kevin Ansfield
139ba9413a Hid members data in dashboard when signup access is "Nobody"
refs https://github.com/TryGhost/Team/issues/579

Members is essentially disabled when signup access is set to "Nobody" so it doesn't make sense to show members related charts and actions in the dashboard.

- adds `showMembersData` property to the dashboard controller that returns `false` when members is disabled
- wraps members related sections of the dashboard in conditionals
2021-04-20 09:08:15 +01:00
Kevin Ansfield
a271aa53fd Compacted dashboard controller tracked property code style 2021-04-20 09:01:04 +01:00
Kevin Ansfield
889f90f494 Added "Nobody" option to members signup access
refs https://github.com/TryGhost/Team/issues/579

- adds "Nobody" option that will set `members_signup_access` setting to `'none'`
- when selected also sets `default_content_visibility` setting to `'public'`, expands it if collapsed and disables other options (that setting doesn't make sense when members is disabled, individual post access can still be set manually if needed)
2021-04-19 16:37:00 +01:00
Kevin Ansfield
4e82ea38ea Updated setting model for new members_signup_access setting
requires https://github.com/TryGhost/Ghost/pull/12886

- renamed `membersAllowFreeSignup` to `membersSignupAccess` and changed type to match new setting
- added `membersAllowFreeSignup` computed property to map to the new setting to avoid having to migrate code elsewhere that will be removed once the new options are out of developer experiments
2021-04-19 16:37:00 +01:00
Peter Zimon
6986c4f424 Added mock product assignment modal
Created modal for adding products to members with mock data
2021-04-19 14:45:14 +02:00
Peter Zimon
5af33b3f21 Updated member product list mock design 2021-04-19 10:42:53 +02:00
Daniel Lockyer
5a4603cca8 Merged v4.2.2 into main
v4.2.2
2021-04-16 17:47:19 +01:00
Daniel Lockyer
62266da9a3 v4.2.2 2021-04-16 17:44:15 +01:00
renovate[bot]
d51c199727 Update dependency @tryghost/timezone-data to v0.2.41 (#1920)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-16 16:49:28 +01:00
renovate[bot]
ec576a4666 Update dependency markdown-it to v12.0.6 (#1921)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-16 15:28:58 +01:00
renovate[bot]
464d72040c Update dependency @tryghost/string to v0.1.18 (#1919)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-16 15:28:39 +01:00
renovate[bot]
993307bcd3 Update dependency @tryghost/helpers to v1.1.43 (#1918)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-16 15:28:27 +01:00
renovate[bot]
f95400dcae Update dependency @tryghost/timezone-data to v0.2.40 (#1917)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-15 22:41:49 +01:00
renovate[bot]
bb5bdfa380 Update dependency @tryghost/helpers to v1.1.42 (#1916)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-15 18:31:14 +01:00
Peter Zimon
96faf27ba8 Added mock member details component
Prepring for custom products we'll change the overall layout of member forms. This commit has a component that's loaded when dev flag is on for the new layout with mocked product data.
2021-04-15 17:58:35 +02:00
Peter Zimon
01c2facccc Removed member count from product list mock page 2021-04-15 11:09:44 +02:00
Peter Zimon
5a5d6398fd Updated product details mock screen
Updated product details mock screen for the first version:
- removed icon and chart
- added status to price list
- changed icons to text links on price list
2021-04-15 11:08:43 +02:00
renovate[bot]
802efc91a5 Update dependency markdown-it to v12.0.5 (#1915)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-15 09:28:10 +01:00
Kevin Ansfield
82d8261a56 Added subscription access settings to Access screen
refs https://github.com/TryGhost/Team/issues/579

- moved "Allow free member signup" toggle from Payments screen to Settings screen and switched to a radio selection that allows for better description and further selection of options
2021-04-14 23:43:10 +01:00
Sanne de Vries
4f10e611b0 Moved default post access from Payments to Access screen (#1879)
refs https://github.com/TryGhost/Team/issues/579

- updated access section on Payments screen to only show when not running developer experiments
- added default post access settings to Access screen

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2021-04-14 19:02:36 +01:00
renovate[bot]
f92532d51c Update dependency broccoli-concat to v4.2.5 (#1914)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-14 18:45:44 +01:00
renovate[bot]
69097a805c Update dependency @tryghost/kg-parser-plugins to v1.1.7 (#1912)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-14 18:39:14 +01:00
renovate[bot]
c4031f498e Update dependency broccoli-funnel to v3.0.4 (#1913)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-14 18:37:17 +01:00
renovate[bot]
60fdb16f5c Update dependency @tryghost/kg-clean-basic-html to v1.0.17 (#1911)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-14 18:36:57 +01:00
Daniel Lockyer
62f08b024f Merge v4.2.1 into main
v4.2.1
2021-04-13 16:26:46 +01:00
Daniel Lockyer
b0830c0454 v4.2.1 2021-04-13 16:23:48 +01:00
Kevin Ansfield
59a37dc984 Fixed faker.random.number rename warnings
no issue

- `faker.random.number` is now `faker.datatype.number`
2021-04-12 15:32:39 +01:00
renovate[bot]
40c6cb51e6 Update dependency ember-in-viewport to v3.9.0 (#1899)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:51:07 +01:00
renovate[bot]
e1ddf1795f Update dependency ember-concurrency to v2 (#1909)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:42:58 +01:00
renovate[bot]
e05a6d1c19 Update dependency fs-extra to v9.1.0 (#1904)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:42:50 +01:00
renovate[bot]
53a8a6a0c1 Update dependency @html-next/vertical-collection to v2 (#1906)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:33:07 +01:00
renovate[bot]
16b9fb046e Update dependency faker to v5.5.3 (#1903)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:30:16 +01:00
renovate[bot]
08d2a8e7a7 Update dependency ember-cli-app-version to v5 (#1908)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:30:00 +01:00
renovate[bot]
7f71b9dd10 Update dependency @tryghost/members-csv to v1 (#1907)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:29:04 +01:00
renovate[bot]
6a9e206665 Update dependency ember-power-select to v4.1.4 (#1900)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:28:47 +01:00
renovate[bot]
d9cdca6823 Update dependency ember-svg-jar to v2.3.3 (#1902)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 13:28:30 +01:00
Kevin Ansfield
cf7a763199 Removed usage of deprecated EmberSimpleAuth mixins (#1910)
refs https://github.com/TryGhost/Admin/pull/1901

Ember has deprecated mixins in preparation for 4.0 and `ember-simple-auth` has now done the same in 3.1.0.

- removed all imports of Ember Simple Auth mixins
- moved authenticated and invalidated handling from application route to session service
- moved server-notification loading from application route to session service
- updated `AuthenticatedRoute` to use the session service directly rather than authenticated route mixin
- added `UnauthenticatedRoute` that incorporates the behaviour from our overridden `UnauthenticatedRouteMixin` and switches to using the session service directly
2021-04-12 13:21:57 +01:00
Sanne de Vries
eb28e42ad4 Updated styles for change-user-role modal 2021-04-12 14:09:24 +02:00
Kevin Ansfield
ffe5416b77 Swapped staff role selector from <select> to new role selection modal
closes https://github.com/TryGhost/Team/issues/572

Role selection when inviting users was updated to show information about each staff role. This change updates the staff edit screen to use the same UI for changing the role of an existing user.

- added `select-user-role` modal which uses `<GhRoleSelection>` to allow role selection
- replaced the `<select>` input for changing a user's role with a button that triggers the role selection modal
  - role is not set unless the "Set role" button is clicked after making a selection, cancel or close will leave the original role selected
2021-04-12 11:35:50 +01:00
Kevin Ansfield
824953d162 Fixed initial role selection and layout shift in <GhRoleSelection>
no issue

- initial role was always being set to Contributor due to incorrect argument being used when checking if the default role should be applied
- there was considerable layout shift of the `<GhRoleSelection>` container after role loading was finished, quick-fix applied by specifying a width and height to the loading spinner container that matches the final width/height
2021-04-12 11:27:37 +01:00
Kevin Ansfield
c3c383ae69 Fixed role validation when inviting new users
no issue

- the `role` argument was not being passed to the `validateRole` method when changing roles
2021-04-12 11:15:09 +01:00
renovate[bot]
519ed564b8 Update dependency ember-simple-auth to v3.1.0 (#1901)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-04-12 09:11:58 +01:00