Commit Graph

17297 Commits

Author SHA1 Message Date
Aileen Nowak
307a25f765 Moved migrate app labs flag to Beta features 2023-05-19 09:58:41 -04:00
Naz
e302f8cc1d Added DELETE /collections/id to Admin API
refs https://github.com/TryGhost/Team/issues/3167

- This is part of scaffolding for collections API. Allows to delete collection resource
2023-05-19 20:42:46 +07:00
Naz
e82fcbfc5e Added GET /collections/:id to Admin API
refs https://github.com/TryGhost/Team/issues/3167

- This is part of scaffolding for collections API. Allows to read a collection resource by id
2023-05-19 20:42:46 +07:00
Naz
735edf5f87 Fixed editing unexistent collection behavior
refs https://github.com/TryGhost/Team/issues/3167

- When editing collection that does not exist the API should be returning a 404 instead of creating a new collection
2023-05-19 20:42:46 +07:00
Naz
7d926dd30b Refactored collections unit test suite
refs https://github.com/TryGhost/Team/issues/3167

- Duplicate service initialization was getting annoying
2023-05-19 20:42:46 +07:00
Naz
f3f3d58acf Added PUT /collections/id to Admin API
refs https://github.com/TryGhost/Team/issues/3167

- This is part of scaffolding for collections API. Allows to edit collection resource
2023-05-19 20:42:46 +07:00
Naz
d3a8aad319 Added POST /collections to Admin API
refs https://github.com/TryGhost/Team/issues/3167

- This is part of scaffolding for collections API. Allows to add new collection records
2023-05-19 20:42:46 +07:00
Naz
606bd383f1 Extended getAll method with paging metadata
refs https://github.com/TryGhost/Team/issues/3167

- Having paging metadata is part of every API response and was missing from initial implementation
- The getAll method has all of the values as "static" as there's nothing to page on.
2023-05-19 20:42:46 +07:00
Naz
2d1eb881fc Extended save method to return saved collection data
refs https://github.com/TryGhost/Team/issues/3167

- The core client (API) needs a way to pass in information without an ID when creating a new entity, handling it on service/repository layer makes the most sense.
- Used "require" syntax to import tpl/errors modules, otherwise TS compiler was complaining about type compatibility issues, this works as a temporary workaround and is tracked and an issue to improve in the future.
2023-05-19 20:42:46 +07:00
Naz
36eff3a481 Added GET /collections to Admin API
refs https://github.com/TryGhost/Team/issues/3167

- This is scaffolding for collections API. Contains wiring for service wrapper, e2e test, and a browse endpoint
- Adds basic implementation of the GET /collections endpoint to build up upon
- Note, there are no permissions in this version as they will be added in later stages of development with migrations etc
2023-05-19 20:42:46 +07:00
Naz
d4a5dac758 Exposed in-memory collections repository
refs https://github.com/TryGhost/Team/issues/3167

- The repository is needed when initializing the collections service from the core
2023-05-19 20:42:46 +07:00
Sanne de Vries
6a9bd0478e Updated signup card frontent html
Refs https://github.com/TryGhost/Team/issues/3246
2023-05-19 15:19:14 +02:00
Rishabh
2e517b9f3b Wired read/write for publication language setting
refs https://github.com/TryGhost/Team/issues/3151

- wires real setting data read/write for publication language
2023-05-19 18:46:41 +05:30
Peter Zimon
3ef4a12c8d Fixed preflight for select in AdminX DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 15:14:04 +02:00
Peter Zimon
9d84bc257b Fixed onSave method in AdminX DS
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 15:04:22 +02:00
Daniel Lockyer
0fb35cf236
Added test:unit command to admin-x-settings
refs https://ghost.slack.com/archives/C02G9E68C/p1684496945687519?thread_ts=1684496771.857689&cid=C02G9E68C

- this will run a build of the package upon testing, which can reveal
  issues with code if the typescript compiler isn't happy
2023-05-19 14:56:08 +02:00
Rishabh
12871e6a77 Fixed lint error for unused event type
refs https://github.com/TryGhost/Team/issues/3150
2023-05-19 18:23:56 +05:30
Rishabh
7dd8628b40 Wired Timezone settings to use real data
refs https://github.com/TryGhost/Team/issues/3150

- wires Timezone setting to read list of timezones and allow editing/saving new value
- handles read/write of real timezone setting from settings context
- uses `@tryghost/timezone-data` to fetch list of all timezones
- adds typings.d.ts to handle missing types for @tryghost/timezone-data
2023-05-19 18:23:34 +05:30
Rishabh
a420adf684 Added default option for global Dropdown component
refs https://github.com/TryGhost/Team/issues/3150

- updates Dropdown component to allow a default selected option on first render
2023-05-19 18:14:03 +05:30
Sanne de Vries
50f5aef902 Added styles for signup card frontend html
Refs https://github.com/TryGhost/Team/issues/3246
2023-05-19 14:18:02 +02:00
Peter Zimon
9f84b6d9d4 Added static analytics inputs to AdminX Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 13:39:29 +02:00
Peter Zimon
6f4fa691ad Added static input fields to pw protection
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 13:39:29 +02:00
Djordje Vlaisavljevic
26086d7140 Added dark mode design for feedback forms
refs https://github.com/TryGhost/Team/issues/3250
2023-05-19 12:19:26 +01:00
naz
320c659a1e
Added forced debug output for EmailRecipients fetching (#16823)
refs TryGhost/Team#3229

- The issue we are observing that even though the returned amount of email recipients should not ever accede the max batch size (1000 in case of MailGun), there are rare glitches when this number is doubled and we fetch 2000 records instead.
- The fix takes it's best guess in de-duping data in the batch and then truncates it if the amount of records is still above the threshold. This ensures we at least end up sending the emails out to some of the recipients instead of none.
2023-05-19 17:57:24 +07:00
renovate[bot]
a1dc3d4f33 Update dependency typescript to v5.0.4 2023-05-19 12:39:23 +02:00
Peter Zimon
cce150d04e Added toggle component to AdminX design system
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 12:29:42 +02:00
renovate[bot]
b373c8911e Update storybook monorepo to v7.0.12 2023-05-19 12:04:46 +02:00
renovate[bot]
39453b678b Update dependency vitest to v0.31.1 2023-05-19 11:50:49 +02:00
Michael Barrett
19f3700ae8
Fixed update check due to tiers service changes (#16832)
refs https://github.com/TryGhost/Team/issues/3234

The update check was failing to run due to recent changes in the tiers
service. This service now needs initialising before the update check can
be run.
2023-05-19 10:27:33 +01:00
Elena Baidakova
ca46308abe
Added logic for showing feedback form in Labs (#16831)
refs TryGhost/Team#3247
- The feedback form UI is hidden by default
- Enabling “Lexical editor” doesn’t show the feedback form
- Disabling “Lexical editor” shows the feedback form below this lab item
and user can send the feedback
- Refreshing the page or navigating to some other page and then back to
Labs → the form is hidden again
2023-05-19 13:15:25 +04:00
Daniel Lockyer
58539c355b
Added --adminX functionality to yarn dev
fixes https://github.com/TryGhost/Toolbox/issues/581

- this adds support for spinning up AdminX within the `yarn dev` script
  with zero other steps needed
2023-05-19 10:34:06 +02:00
Peter Zimon
0c85012bdc Merged components in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150

Setting group values and Setting group inputs components were practically the same.
2023-05-19 09:17:26 +02:00
Peter Zimon
5800b63221 Added static values to Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 08:12:21 +02:00
Peter Zimon
25ac93e7ca Removed state variable from setting SettingGroup
refs. https://github.com/TryGhost/Team/issues/3150

The state variable in the global setting group component in Admin X was unnecessary.
2023-05-19 07:46:54 +02:00
Peter Zimon
da9c004aa6 Added static social account settings in Admin X
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 07:38:45 +02:00
Peter Zimon
ea42f97ae7 Added text based settings in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 07:18:29 +02:00
Sodbileg Gansukh
c7b6a72a49 Separated tiers group to active and archived
refs https://github.com/TryGhost/Team/issues/1403

- currently, all tiers are grouped together in dropdowns with list of tiers
- this separates them into active and archived groups, so that the status of the tiers is clear when making choices
2023-05-19 11:59:44 +07:00
Peter Zimon
61e5068081 Fixed type antipattern in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-19 06:13:57 +02:00
Ghost CI
1914605705 Merged v5.48.1 into main 2023-05-18 17:31:39 +00:00
Ghost CI
4511fa3996 v5.48.1 2023-05-18 17:31:38 +00:00
Kevin Ansfield
e80fb5e20f
🐛 Fixed tiers not appearing on custom signup pages (#16828)
refs https://github.com/TryGhost/Team/issues/3248

- API queries for tiers are now using the TiersRepository with internal caching
- the repository had a bug with it's `toPrimitive()` method which meant the cached tier objects had very few properties
  - the Tier object has all properties as private getters except for standard `events` property which meant the spread operator didn't have anything to spread into the object resulting in all tiers having a shape like `{events: [], active: true, type: 'paid', id: 'abcd'}`
- the `getAll()` method uses nql to match against the cached tier objects but with them not being fully populated it wasn't able to match and so returned an empty array

---

- changing the spread to use `tier.toJSON()` means we're populating all of the tier data properly allowing filter matches to work
2023-05-18 18:13:20 +01:00
Djordje Vlaisavljevic
06331a89c4 Updated feedback widget design in Labs
refs https://github.com/TryGhost/Team/issues/3245
2023-05-18 16:17:24 +01:00
Djordje Vlaisavljevic
f8f1a66d77 Updated feedback widget design on Post published
refs https://github.com/TryGhost/Team/issues/3244
2023-05-18 16:17:24 +01:00
Nick Moreton
14ce57fa2b
Added trackEvent util for sending events to Plausible (#16824) 2023-05-18 14:32:50 +01:00
Peter Zimon
c0be5c91f7 Re-set auto time update in Admin X Settings
refs. https://github.com/TryGhost/Team/issues/3150
2023-05-18 13:44:37 +02:00
Peter Zimon
9285bc2e52 View/edit interaction in Admin Settings
refs. https://github.com/TryGhost/Team/issues/3150

There was an opportunity to make a reusable interaction within the Setting Group component so that switching between different states are implicitly handled. With this change it's possible to just add a Setting Group component without the need to build the logic over and over again. The component expects only the "contents" (ie. values in view state or input fields in edit state) as its children. There's a built in header with Edit/Cancel/Save buttons which is overridable with the `customButtons` parameter. A completely custom header can be used via the `customHeader` parameter.

See `TitleAndDescription.tsx` for a working example.
2023-05-18 13:06:13 +02:00
Michael Barrett
cde30eb469
🐛 Fixed issue where single letter product slugs cause 500 error (#16821)
refs https://github.com/TryGhost/Team/issues/3224

When a product has a slug that is a single letter, checking if a user
had access to view a post associated with that product would cause a 500
error. The underlying cause of this issue is
https://github.com/TryGhost/NQL/issues/20 This fix circumvents this
issue by providing a value that the nql lexer will not error out on
2023-05-18 09:38:30 +01:00
Rishabh
9bdbe92183 Released Admin-x-settings v0.0.6 2023-05-18 02:22:47 +05:30
Rishabh
9af3714d8c Wired site settings to admin-x components
refs https://github.com/TryGhost/Team/issues/3151

- wires real setting value for a site to general settings UI in admin-X
2023-05-18 02:13:07 +05:30
Rishabh
5b0eba9b1f Added new provider to manage settings for admin-x
refs https://github.com/TryGhost/Team/issues/3151

- adds new settings provider that fetches settings for a site and allows saving them
- adds new helpers for making admin api calls and fetching setting values
2023-05-18 02:03:14 +05:30