Commit Graph

268 Commits

Author SHA1 Message Date
Kevin Ansfield
32ff18ccb0 Validate tag names don't start with commas
closes #5685
- Adds client and server-side validation for tag names starting with commas
- Trim tag names before adding in PSM (tag attributes are already trimmed before saving in TSM)
2015-08-24 16:55:30 +01:00
Hannah Wolfe
2b030c7370 Merge pull request #5694 from kevinansfield/zelda-invite-fixes
Minor UI fixes for invitations
2015-08-24 12:41:43 +01:00
Hannah Wolfe
656fbf3bbc Merge pull request #5691 from acburdine/spin-fix
Fix auto width and height of spin button
2015-08-24 12:07:39 +01:00
John O'Nolan
d1e5a8d89c Merge pull request #5702 from kevinansfield/zelda-signin-updates
Fixes for sign-in error handling
2015-08-24 08:00:13 +02:00
Hannah Wolfe
7fa468d9ea Merge pull request #5682 from kevinansfield/tags-v4
Replace the current tag input with a selectize based input
2015-08-21 21:34:06 +01:00
Hannah Wolfe
4233b68852 Merge pull request #5699 from kevinansfield/close-nav-menu-on-transition
Mobile nav menu fixes
2015-08-21 21:32:26 +01:00
Hannah Wolfe
55c07338d9 Merge pull request #5687 from kevinansfield/fix-tags-validation
Add inline error handling and tests for tag creation/editing
2015-08-21 21:31:40 +01:00
Kevin Ansfield
90d75b2189 Fixes for sign-in error handling
issue #5652, closes #5641
- removes inline errors for empty fields
- separate validation routines for sign-in and forgot password
- highlight fields with errors when trying to submit
2015-08-21 19:38:44 +01:00
Kevin Ansfield
dd9aa0f873 Add inline error handling when creating/editing tag
closes #5684
- add inline error checking and display to tag name & meta data fields
- add tests for tags screen
2015-08-21 18:06:52 +01:00
John O'Nolan
ffdc83fad1 Merge pull request #5700 from kevinansfield/inline-error-styles
Style inline-error fields and response test
2015-08-21 16:55:48 +02:00
John O'Nolan
c303a520a2 Merge pull request #5698 from kevinansfield/fix-autonav-flicker-v2
Fix flickering autonav animation
2015-08-21 15:29:05 +02:00
John O'Nolan
641de0157a Merge pull request #5697 from Gargol/a11y-improvement-for-menu-toggle
Adds 'button' role to toggle menu icon for better a11y
2015-08-21 10:23:43 +02:00
Kevin Ansfield
94c3b6d041 Style inline-error fields and response test
issue #5652
- highlight input border and response text in red
2015-08-20 17:04:37 +01:00
Kevin Ansfield
cbb106e12e Mobile nav menu fixes
issue #5483 & #5652
- trigger the close menus action every time a route transition is successful
- close nav menu when clicking "collapse sidebar" button (action chain was incomplete)
2015-08-20 16:49:33 +01:00
Sebastian Gierlinger
f1a602e3f9 Merge pull request #5689 from kevinansfield/fix-property-val-of-undefined
Fix occasional `Cannot read property 'val' of undefined` errors in console
2015-08-20 16:53:47 +02:00
Kevin Ansfield
c9d053b950 Replace the current tag input with a selectize based input
issue #3800, closes #5648
- uses ember-cli-selectize addon for the tag editing functionality in the PSM
2015-08-20 14:40:56 +01:00
Kevin Ansfield
e3f34c97a7 Fix flickering autonav animation
- use `transition: left` instead of `transform: translate3d`
- fixes issue where translate3d moves the element immediately then animates resulting in invisible hit areas that cause unexpected hover behaviour whilst animation is in progress
- translate3d is sometimes faster as it doesn't need to constantly re-calculate layout, however in this case the element is positon:absolute and we're only animating opaque elements so the benefit is marginal. Tested on Late-2012 13" retina MBP and framerate was consistently 100fps or higher.
2015-08-20 13:04:26 +01:00
Nazar Gargol
b7f180ef07 Adds 'button' role to toggle icon for better a11y
closes #5696
- adds button role to toggle icon on new zelda menu
2015-08-20 12:51:44 +02:00
Kevin Ansfield
ffb04114a2 Minor UI fixes for invitations
issue #5652
- display "Sending Invite..." text after clicking "RESEND" link
- change "Invitation sent" alert to notification
2015-08-20 10:36:36 +01:00
Austin Burdine
c7ef8b6c24 fix auto width and height of spin button component
refs #5652
- changes the spin-button so that it only sets the size when the button is submitting instead of all of the time
2015-08-19 23:39:07 -04:00
Kevin Ansfield
c07f33f5ad guard against missing $previewContent/ViewPort in gh-editor.scrollPosition
issue #5659
- fixes occasional issue with editor not rendering due to scrollPosition being requested before the relevant jquery elements have been set
2015-08-19 20:44:59 +01:00
Kevin Ansfield
22d4151e33 guard against missing editor element in editor-base-controller.save
issue #5659
- Fixes occasional issue with `Uncaught TypeError: Cannot read property 'val' of undefined` errors appearing when navigating quickly to/from the editor. I traced the `save` action calls back to the `autoSave` method - it may warrant further investigation to find out why the throttled/debounced calls are sometimes made when the editor element is non-existent.
2015-08-19 20:43:30 +01:00
John O'Mahoney
4b2d7b122a Update signup form to have profile image upload component
closes #5544
- Added profile image into `signup.hbs`
- Added image handling in `signup.js` controller
- Uses session authenticated user to upload image
2015-08-15 13:00:42 +01:00
John O'Nolan
98f140dd19 Variety of style fixes
- Modal button position tweaked, removed extraneous margin
- Fix user profile full name field and mobile profile-picture
- Added chevron to tag settings men, corrected chevron colour
- Fixed regression in delete-tag button caused by removing flexbox from buttons
- Fixed regression in button positioning on about-ghost page caused by removing flexbox from buttons

See #5652
2015-08-13 10:04:45 +02:00
John O'Nolan
7969d06057 Fixed publish menu positioning, cleaned up dropdown component
See #5652
2015-08-13 09:09:07 +02:00
John O'Nolan
5195440dbe Kill old tag styles 2015-08-13 08:55:41 +02:00
John O'Nolan
97ce6f8a0c Multiple minor visual style fixes
- Lighter dropdown shadow
- Removed display:flex from .btn because safari can't handle it on <button> elements, where it will immediately set all text-alignment to "left" with no way to change. I haven't been able to find any regressions for this change so far. Can't remember why buttons were supposed to be flexbox anyway. Maybe for icon alignment within buttons, but I can't find any such examples within the app.
- Safari thinks that user-select: all; means a single click should SELECT ALL THE THINGS. Removed/replaced with user-select: text; which makes it behave like Chrome; click and drag to select.
- Increased hit area for "?" button
- Removed :active style for post-edit button on content management screen, adjusted position
- Increased contrast on tag description, tag count, and view blog links

See #5652
2015-08-12 10:29:40 +02:00
John O'Nolan
661d27dbb3 Prevent view titles from being cut off in Safari
See #5652
2015-08-12 09:17:01 +02:00
Hannah Wolfe
ee838b0173 Merge pull request #5658 from acburdine/tag-fixes
fixed focus and duplication tag issues
2015-08-11 19:42:52 +01:00
Hannah Wolfe
a2747a7cb7 Merge pull request #5654 from cobbspur/bugfixes
Lock out email address on signup page
2015-08-11 18:06:12 +01:00
Austin Burdine
f04676eaf2 fixed focus and duplication tag issues
refs #5648
- adds default value to refocus in reloadTypeahead method to fix focus issues
- moves tag input clearing call up to avoid duplication.
2015-08-11 11:04:53 -06:00
cobbspur
e0b684e401 Fix spinner on settings page
refs #5652

- stops spinner from spinning forever on settings screen when saving
2015-08-11 15:26:24 +01:00
cobbspur
2977f5a649 Lock out email address on signup page
refs #5653

- disables email field
- pull error message from api response
2015-08-11 14:25:30 +01:00
cobbspur
1631cb8066 Fix errors for setup and signup
refs #5635

- adds enter action to signup fields
- adds validation text errors
2015-08-10 22:24:10 +01:00
Hannah Wolfe
4c96fba67f Merge pull request #5633 from acburdine/spin-buttons
Add spin buttons
2015-08-10 19:06:32 +01:00
Austin Burdine
748895ce77 add spin-button component & implement it
closes #3928
- adds spin-button component & styles
- implements spin-button in places where buttons trigger async tasks
2015-08-10 09:43:50 -06:00
Austin Burdine
2c5d2d6a2d reimplement tag editing component for posts
refs #3800
- remove old tag editor code
- reimplement tag editor as an ember component
- add tag editor component to PSM
2015-08-10 07:22:37 -06:00
Hannah Wolfe
026e3de597 Merge pull request #5640 from cobbspur/errors
Fix server errors for signin
2015-08-10 13:20:53 +01:00
Hannah Wolfe
9d1a78055e Merge pull request #5634 from acburdine/onboard-fixes
Fixes in setup/three
2015-08-10 13:17:28 +01:00
cobbspur
69d020ce44 Fix signin errors
refs #5635

- fixes format for server errors
- changes signin-api validation errors to be text rather than alerts
2015-08-10 12:26:45 +01:00
Austin Burdine
a428bfc35b setup/three fixes
refs #5315
- adds call to loadServerNotifications so that notifications are loaded after setup
- fixes user invite so that you can't invite someone with the same email as you created the owner with
2015-08-09 22:40:27 -06:00
cobbspur
560b5b693a Fix signup bug
No Issue

- fixes bug that prevents successful signup from invite
2015-08-08 16:04:28 +01:00
cobbspur
c104e7f517 Enter key submits form in setup step 2
Issue #5315

 - adds gh-input enter event to trigger setup action
 - removes html for unused password strength hint
2015-08-04 09:36:02 +01:00
Kevin Ansfield
e21d7ed1f5 WIP: review uses of notifications.showErrors
issue #5409

`notifications.showErrors` was historically used to display multiple error notifications whether from validation errors or responses form the API. This usage needs to be reviewed as inline validations should handle the validation side and we should be displaying alerts for actual errors.

Eventually `notifications.showErrors` should be left unused and therefore removed.
2015-07-28 12:27:57 +01:00
Kevin Ansfield
1bcd7fd333 Replace validation notifications with inline validations
issue #5409 & #5336

- update settings/general
- update signin
- update signup
- update edit user
- update reset password
- update setup/three
- remove `formatErrors` function from validationEngine mixin (it's no longer needed as inline validations should handle this instead)
2015-07-28 12:26:34 +01:00
Kevin Ansfield
7ac6ebb920 Refactor notifications service & components
issue #5409

- change persistent/passive notification status to alert/notification
- replace showSuccess/Info/Warn/Error with showNotification/showAlert
- fix and clean up notification/alert components
2015-07-28 12:26:11 +01:00
Jason Williams
a19000d862 Merge pull request #5565 from acburdine/profile-debounce
Refactor setup controller to only pass valid email into profile image component
2015-07-22 09:53:30 -05:00
Jason Williams
f6ca9f0b9d Merge pull request #5596 from kevinansfield/fix-missing-code-injection-auth-redirect
Fix missing redirect on settings/code-injection when not authenticated
2015-07-22 09:51:28 -05:00
Kevin Ansfield
0322de36ee Fix missing redirect on settings/code-injection when not authenticated
related issue #5412
- code-injection route was overriding `beforeModel` without calling `super` which meant the redirect handling added in `AuthenticatedRoute` was being skipped
2015-07-22 11:31:42 +01:00
Austin Burdine
04d649a224 fix setup controller to pass in only a valid email to the profile-image component
closes #5563
2015-07-21 13:19:09 -04:00