Commit Graph

7697 Commits

Author SHA1 Message Date
Rishabh
5bdef5e44e Wired success/error handling for bulk operations on filtered members
closes https://github.com/TryGhost/Team/issues/1028

Bulk operations - add/remove label, unsubscribe - were added to filtered members list behind filtering labs flag as part of introducing filtering on members list. This handles the success/error response on bulk operations and shows them in the popup similar to delete bulk operation.
2021-09-08 12:06:16 +05:30
Sanne de Vries
ad79a97071 Updated publish-menu dropdown selector 2021-09-07 15:09:34 +02:00
Sanne de Vries
947307a860 Fixed member count in side nav not being clickable 2021-09-07 14:44:56 +02:00
Peter Zimon
eb1d3c370f Added early-access modal for Tiers 2021-09-07 13:36:23 +02:00
Rishabh
0231c08fde Fixed members filter list reloading on label edit
closes https://github.com/TryGhost/Team/issues/975

Clicking on label edit in filtering menu was also causing label to be selected in the dropdown, which also caused members list to live reload. This change fixes the edit behavior by not selecting the label to be edited in the dropdown
2021-09-07 16:50:43 +05:30
Rishabh
e70e0e273d Fixed member list not loading on scroll with filtering
closes https://github.com/TryGhost/Team/issues/971
reverts abe5c6d681

We use vertical-collection to allow infinite loading + scrolling for members list instead of loading and rendering all members at once. The behavior was not working correctly with updated list for filtering feature, as we dynamically update columns. This change fixes the scroll behavior and members loading together by updating the containerSelector for vertical collection.
2021-09-07 16:50:43 +05:30
renovate[bot]
35209cd5c0 Update dependency @tryghost/members-csv to v1.1.6 (#2067)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-09-07 12:10:21 +01:00
renovate[bot]
a78523ae8f Update dependency @tryghost/timezone-data to v0.2.50 (#2079)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-09-07 12:09:55 +01:00
renovate[bot]
69799a60b6 Update dependency @tryghost/helpers to v1.1.52 (#2078)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-09-07 12:09:47 +01:00
renovate[bot]
37bf6822ce Update dependency testem to v3.5.0 (#2075)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-09-07 12:09:31 +01:00
renovate[bot]
9cd44cb9e3 Update dependency @sentry/ember to v6.12.0 (#2076)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-09-07 12:09:04 +01:00
Kevin Ansfield
a5fc45d169 🐛 Fixed crash when newly created images are dragged into a gallery
closes https://github.com/TryGhost/Team/issues/1020

- image card payloads should have a valid `src` attribute, use that instead of relying on the associated `img` element which won't be found/have an unexpected `src` when it's newly created because the image card will still be using the blob url generated for a preview whilst uploading
2021-09-06 14:30:13 +01:00
Daniel Lockyer
a0da052471 Merged v4.13.0 into main
v4.13.0
2021-09-06 12:26:24 +01:00
Daniel Lockyer
c090a2b277 v4.13.0 2021-09-06 12:21:31 +01:00
Kevin Ansfield
9993f02ffa 🎨 Added ability to drop an image card onto an empty gallery
closes https://github.com/TryGhost/Team/issues/1013

Image cards could be dropped into a gallery when at least one image was already present but there was no handling for image cards being dropped onto an empty gallery.

- added `data-gallery` attribute to the placeholder element so it gets picked up by the drag-and-drop container registration
- added drag enter/leave event handlers so we can show the same dropzone indicator as when a standard file is being dropped onto an empty gallery
- updated the drop handling to handle insertion when no images already exist by forcing insertion at index `0`
- updated the register or refresh handler to switch between different drag-and-drop container elements as needed and switched to `scheduleOnce` to prevent duplicate containers being created if the function is called twice before render occurs
2021-09-06 11:57:42 +01:00
Kevin Ansfield
95a2054bea Fixed "Post/Page access" label in post settings menu not matching content type
closes https://github.com/TryGhost/Ghost/issues/13283

- input label was not using the model's `displayName` property
2021-09-06 11:39:41 +01:00
Sanne de Vries
12036f48b3 Updated publish-menu copy for email-only posts 2021-09-06 12:35:25 +02:00
Rishabh
62fa738da3 Refined empty state for filtered members
no refs

- empty filtering state was not being detected when soft filters are applied for live-reload when filter is open
2021-09-06 12:43:17 +05:30
Rishabh
9b5cd1ac8b Refined close filter dropdown behavior
closes https://github.com/TryGhost/Team/issues/976

Dropdown's `onClose` action was previously fired from the `close` function instead of when the actual close happened when animation ended for dropdown close. Also, the `close` action of dropdown is fired irrespective of dropdown is open, as we close all dropdowns and menus whenever a new transition happens, so it caused flicker on the screen.
2021-09-06 12:42:43 +05:30
Rishabh
d691874c5f Refined live reload behavior for members filtering
refs https://github.com/TryGhost/Team/issues/963

- updates the list when either the relation or value changes for a filter row.
- only filter rows with value are used
- consistent behavior for "apply all" and "reset all"
- `Enter` and `onFocusOut` behavior for rows with text values
2021-09-06 12:14:08 +05:30
Peter Zimon
5516968936 Added empty result states to new members filtering 2021-09-03 12:18:15 +02:00
Kevin Ansfield
e9a8361687 Fixed errors when pasting non-markup into basic html fields
no issue

- the editor range was getting out of sync between pasting and the subsequent `didUpdatePost` callback which cleans up content to conform to our "basic html" expectations resulting in errors in the console and potentially lost content if the paste occurred with the cursor inside existing text
- updated `handlePaste` to perform the same parse as the default paste handler but then cleanup the post before inserting so there's no mismatch of content across the editor callbacks
2021-09-03 10:51:45 +01:00
Peter Zimon
0b7d1b1946 Fixed gallery delete icon color bug 2021-09-03 11:45:29 +02:00
Peter Zimon
0f0c44295e Added show-all button to empty members filter list 2021-09-03 11:37:26 +02:00
Kevin Ansfield
5eb817373f 🐛 Fixed captions becoming uneditable when they have a trailing space
closes https://github.com/TryGhost/Team/issues/1023
closes https://github.com/TryGhost/Ghost/issues/11424

- we were comparing the caption editor's contenteditable inner html vs the passed in html in order to reset the editor if the bound value changed upstream, this was causing problems because the editor and external html cleaning were treating trailing whitespace slightly differently which resulted in the editor being reset every time it gained focus when a trailing space was present
- removed reliance on inspecting the editor's inner html and instead switched to comparing a changed `html` value to that which was passed in during initialisation or was last passed upstream from the editor so there's no chance of unexpected deviance
2021-09-03 09:00:14 +01:00
Peter Zimon
bc48cdffd0 Fixed button alignment in edit tier modal 2021-09-02 22:37:14 +02:00
Peter Zimon
a1cd55b848 Added preview to tier edit modal 2021-09-02 16:01:50 +02:00
Kevin Ansfield
922c304e3b Added "Email call to action" card for an email-only CTA targeting free or paid members (#2080)
refs https://github.com/TryGhost/Team/issues/993

The new editor card allows you to add styled content along with an optional button that will only be visible to free or paid members when the post is emailed. Useful for encouraging free members to sign up to a paid account for example.

- removed labs flag and conditionals to make the feature is available by default
- cleaned up CSS that re-used the `.email-card` class or was referencing `labs`
2021-09-02 13:11:15 +01:00
Rishabh
9a74c59630 Refined enter behavior in Admin benefits modal
refs https://github.com/TryGhost/Team/issues/874

- when hit with focus on last non-empty benefit field, previously the new benefit automatically showed error for empty field. This change refines behavior to only show error when user tries to click "Enter" again when already on last empty benefit
- also cleans up the duplicate add benefit call
2021-09-02 15:10:58 +05:30
Kevin Ansfield
233e57071f Fixed email-cta card button input placeholder disappearing on focus
no issue

- behaviour was from copy-pasting from a different input where the placeholder was intentionally hidden on focus, that's not desirable in this case
2021-09-02 07:42:36 +01:00
Kevin Ansfield
ba5b5f7935 Fixed email-only card help text overlapping card border
no issue

- negative margin was pulling the card border up too far and causing it to run behind the grey help block
2021-09-01 17:56:29 +01:00
Peter Zimon
805873d64e Made Portal preview scrollable
- Updated Portal preview in Membership settings and Portal settings so that the preview is scrollable in all browsers.

Note: Only when Tiers is turned on.
2021-09-01 17:58:35 +02:00
Peter Zimon
c5e00d71f1 Tier modal benefit box height fix 2021-09-01 15:48:17 +02:00
Peter Zimon
e175b97c5e Updated field description for email footer 2021-09-01 14:13:42 +02:00
Peter Zimon
c462bbba3b Copy refinements
- Fixed incorrect casing on staff page
- Removed unnecessary placeholders on staff page
- Removed '...' from search site
- Added webhook URL placeholder
2021-09-01 13:02:00 +02:00
Peter Zimon
d8be0a794e Cleaned up placeholder for webhook forms 2021-09-01 12:55:40 +02:00
Peter Zimon
16aec55acf Use examples as placeholders in tier form 2021-09-01 12:53:37 +02:00
Peter Zimon
8cce7989f2 Updated tier modal copy 2021-09-01 10:14:56 +02:00
Kevin Ansfield
4e30da6c70 Added ability to update snippet contents (#2073)
refs https://github.com/TryGhost/Team/issues/1008

To update a snippet, select the content in the editor that you want as your snippet text and click the snippet icon as per creating a snippet. Once the snippet name input shows, start typing the name of an existing snippet to be able to select it for update.

- replaced main snippet input component with the labs component
- removed the feature flag and associated labs screen toggle
- removed original/labs snippet input conditional in the editor
2021-09-01 09:09:40 +01:00
Naz
f2883c3636 Fixed a routing error when a "sent" post was edited
refs https://github.com/TryGhost/Team/issues/954

- When an email-only post with a "sent" status was edited, it's status changed to "draft", which is an incorrect behavior. This change is causing the "sent" status to persist and removes the transition error.
2021-08-31 20:16:53 +04:00
Naz
c27194efc5 Added a post preview link in PSM for "sent" posts
refs https://github.com/TryGhost/Team/issues/954

- When the post has a "sent" status there needs to be a way similar to the one for "published" posts to preview the post
2021-08-31 20:16:53 +04:00
Kevin Ansfield
06e63d371c 🎨 Added ability to upload a feature image by drag and dropping an image file
refs https://github.com/TryGhost/Team/issues/884

Drop-to-upload functionality was lost in the first version of the new feature image uploader inside the main editor area, this adds it back in.

- fixed dropzone flickering issue by switching the event listeners to the capture rather than bubble phase so we can indicate a drag is occurring on the body without each individual drag/drop handler needing to know about it
- moved the event handler init/cleanup to the `ui` service
- moved the event handler init call to the application service as it no longer requires auth to have occurred for access to the labs flag setting
- removed the `featureImgDragDrop` labs flag
2021-08-31 14:21:25 +01:00
Peter Zimon
2240daec45 Updated active dropdown UI 2021-08-31 13:52:04 +02:00
Peter Zimon
cea6063715 Added hints to Tier modal
- Added hint to tier description field
- Updated benefit field placeholder
- Added global help link to modal footer
2021-08-31 13:40:13 +02:00
Peter Zimon
86bd70d4c1 Update Stripe subscription status filter grouping
Refs:
https://github.com/TryGhost/Team/issues/1017
2021-08-31 13:05:26 +02:00
Kevin Ansfield
2ded68f845 Updated tests for draft "Saved" indicator
refs e7501ece33

- save status indicator now shows "Draft - Saved" so tests needed to match
2021-08-31 10:11:40 +01:00
Kevin Ansfield
e7501ece33 🎨 Added a "saved" indicator for autosaved draft posts
refs https://github.com/TryGhost/Team/issues/779

For draft posts the editor autosaves after each change but if you didn't see the "Saving..." indicator it wasn't clear what the save status of the post was. The editor will now always show "Saved" when there are no unsaved changes.

- removed indicator from published and scheduled posts because there's no autosave there
- removed the labs flag
2021-08-31 09:57:04 +01:00
Kevin Ansfield
3bc226bef0 Removed @classic decorator from member route
no issue

- there was no need for the decorator as the class is up to date with Octane idioms after swapping `init()` for `constructor()`
- added a comment about the need for `member.get('id')`
2021-08-31 09:37:44 +01:00
renovate[bot]
0a698ec41f Update dependency @tryghost/kg-clean-basic-html to v2.0.4 (#2070)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-08-31 09:01:23 +01:00
renovate[bot]
db2f91d108 Update dependency @tryghost/kg-parser-plugins to v2.0.4 (#2071)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-08-31 08:33:03 +01:00