TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-27 04:43:12 +03:00
Code Issues Projects Releases Wiki Activity
32,187 Commits 250 Branches 1,686 Tags 400 MiB
34d99c92e0
Commit Graph

1395 Commits

Author SHA1 Message Date
Simon Backx
3cb56bad94 Added confirmation step when sending feedback 
fixes https://github.com/TryGhost/Team/issues/2161

Confirmation step is skipped when already signed in.
 2022-10-26 14:18:07 +02:00
James Morris
4c6a57c8f3 Updated the feedback copy for Portal modal based on recent feedback 
refs https://github.com/TryGhost/Team/issues/2170
 2022-10-26 11:59:57 +01:00
James Morris
7b0bf8191d Released Portal v2.18.0 2022-10-24 12:36:57 +01:00
James Morris
4f934ac94f Released Portal v2.17.0 2022-10-24 12:36:04 +01:00
James Morris
627b35aee4 Improved the error modals for audience feedback and newsletter unsubscribe 
- Main goal to improve modal when audience feedback fails
- Felt right to also improve the newsletter unsubscribe issue, too
- Makes this more pleasing to read and look at, nothing fancy

refs https://github.com/TryGhost/Team/issues/2081
 2022-10-24 12:11:30 +01:00
Fabien "egg" O'Carroll
0f03b5eddb Released Portal v2.16.0 2022-10-24 15:12:02 +07:00
Fabien "egg" O'Carroll
4f54cbc37a Supported payment URL in Portal 
refs https://github.com/TryGhost/Team/issues/2078

As part of decoupling Stripe from the members feature, we are going to be using
payment URLs rather than Stripe sepcific session ids and publick keys.

This prepares Portal to work with the new system, whilst retainign the existing
functionality
 2022-10-19 11:06:10 +07:00
Rishabh
fdff8814b1 Bumped portal package.json to latest version 
refs d381ff87b8

- portal was bumped to 2.15 but the version in package json didn't get auto-updated
 2022-10-14 22:15:02 +05:30
renovate[bot]
ab598dd7ea Update dependency minimist to v1.2.7 2022-10-12 10:16:31 +07:00
Simon Backx
c670209c82
Added audience feedback handling to Portal (#15590) 
fixes https://github.com/TryGhost/Team/issues/2048

Changes so Portal can handle feedback links and use the members API to store a vote.
 2022-10-11 17:14:43 +02:00
renovate[bot]
3b62e8c52f Update sentry-javascript monorepo to v7.15.0 2022-10-11 09:24:03 +07:00
renovate[bot]
84549838a4 Update sentry-javascript monorepo to v7.14.2 2022-10-07 08:41:20 +07:00
Daniel Lockyer
be46f8e9a8
Removed eslint-plugin-ghost from Portal package.json 
- we don't need it here anymore because it's brought in through the
  top-level repo package.json
 2022-10-07 08:36:23 +07:00
Daniel Lockyer
12aaaa6d6e
Removed Portal's .editorconfig file 
- this should no longer be needed because we have a top-level
  .editorconfig file
 2022-10-06 11:23:39 +07:00
Simon Backx
eac8fbfdfd Released Portal v2.14.0 2022-10-05 12:44:18 +02:00
Simon Backx
e7378520a0
🔒 Prevented member creation when logging in (#15526) 
fixes https://github.com/TryGhost/Ghost/issues/14508

This change requires the frontend to send an explicit `emailType` when sending a magic link. We default to `subscribe` (`signin` for invite only sites) for now to remain compatible with the existing behaviour.

**Problem:**
When a member tries to login and that member doesn't exist, we created a new member in the past.

- This caused the creation of duplicate accounts when members were guessing the email address they used.
- This caused the creation of new accounts when using an old impersonation token, login link or email change link that was sent before member deletion.

**Fixed:**
- Trying to login with an email address that doesn't exist will throw an error now.
- Added new and separate rate limiting to login (to prevent user enumeration). This rate limiting has a higher default limit of 8. I think it needs a higher default limit (because it is rate limited on every call instead of per email address. And it should be configurable independent from administrator rate limiting. It also needs a lower lifetime value because it is never reset.
- Updated error responses in the `sendMagicLink` endpoint to use the default error encoding middleware.
- The type (`signin`, `signup`, `updateEmail` or `subscribe`) is now stored in the magic link. This is used to prevent signups with a sign in token.

**Notes:**
- Between tests, we truncate the database, but this is not enough for the rate limits to be truly reset. I had to add a method to the spam prevention service to reset all the instances between tests. Not resetting them caused random failures because every login in every test was hitting those spam prevention middlewares and somehow left a trace of that in those instances (even when the brute table is reset). Maybe those instances were doing some in memory caching.
 2022-10-05 12:42:42 +02:00
Daniel Lockyer
609fcb17c0
Removed main from yarn ship 
- we might not necessarily be pushing to `main`, for example, if we're
  doing a patch release
 2022-10-05 16:47:39 +07:00
Daniel Lockyer
8b7a573a1d
Released Portal v2.13.2 2022-10-05 16:03:46 +07:00
Daniel Lockyer
e60fc167e4
Improved yarn ship for Portal 
refs https://github.com/TryGhost/Toolbox/issues/426

- with the existing `ship` command, it publishes to npm before pushing
  to GitHub
- I fear we're likely to run into a scenario where the HEAD of `main` is
  behind, so the git push fails, and then rebasing the HEAD will break
  the tags that we created
- in this scenario, I think it's better to hard reset back, git pull and
  then try again
- in that case, we need to publish to npm after GitHub
- this commit should implement that
 2022-10-05 15:48:10 +07:00
Daniel Lockyer
700a62e048
Added quotes to version-tag-prefix 
- without this, the following line does not apply for some reason
 2022-10-05 15:27:20 +07:00
Daniel Lockyer
a26886ed65
Updated Portal README and repository link 
refs https://github.com/TryGhost/Toolbox/issues/426

- these needed updating now Portal is in the monorepo
 2022-10-05 15:22:17 +07:00
Daniel Lockyer
2a40f72f36
Added yarn test:unit to Portal 
refs https://github.com/TryGhost/Toolbox/issues/426

- this ensures we provide a `test:unit` command for CI
- this probably needs changing in the future - not sure yet
 2022-10-05 15:17:01 +07:00
Daniel Lockyer
22c85df66f
Added .yarnrc config for Portal 
refs https://github.com/TryGhost/Toolbox/issues/426

- this ensures the git tag and commit message are in the expected format
 2022-10-05 15:15:14 +07:00
Daniel Lockyer
314281cf08
Removed extraneous logging from Portal dev script 
refs https://github.com/TryGhost/Toolbox/issues/426

- now Portal is in the monorepo, the dev script doesn't need to wipe the
  console output nor print instructions as that should be handled with
  setting environment variables
 2022-10-05 15:13:34 +07:00
Daniel Lockyer
181f12d2de
Cleaned up extra files in Portal package 
refs https://github.com/TryGhost/Toolbox/issues/426

- these files are no longer needed now the code is in the Ghost monorepo
 2022-10-05 15:06:36 +07:00
renovate[bot]
a5adffbcb5 Update Test & linting packages 2022-10-05 11:23:47 +07:00
Daniel Lockyer
b73a657435 Updated react-scripts and eslint-plugin-ghost dependencies 
refs https://github.com/TryGhost/Toolbox/issues/426

- this commit bumps both dependencies because it resolves various issues
  I've encountered when moving Portal to the Ghost monorepo
 2022-10-05 11:20:29 +07:00
Daniel Lockyer
8daa06a3b8 Fixed various linting issues 
- these changes were needed ahead of the upcoming bump to react-scripts,
  which bumps eslint to v8, and therefore we can update
  eslint-plugin-ghost, which introduces some new linting rules
 2022-10-05 11:11:03 +07:00
Daniel Lockyer
264e6d41a7 Updated CI Ubuntu version to latest 
- 18.04 is deprecated and getting phased out so we should switch to the latest version
 2022-10-05 10:58:24 +07:00
Daniel Lockyer
20d9256105 Updated CI Node version to 16 
refs https://github.com/TryGhost/Toolbox/issues/163

- Node 16 is our recommended version so we should test using that
 2022-10-05 10:56:39 +07:00
renovate[bot]
9608f834c3 Update sentry-javascript monorepo to v7.14.1 2022-10-04 15:59:31 +00:00
renovate[bot]
997d6896a1 Update sentry-javascript monorepo to v7.14.0 2022-09-29 19:50:44 +00:00
Rishabh
3314dafa78 v2.13.1 2022-09-28 00:17:31 +05:30
Rishabh
10e65f7fe8 Fixed incorrect import handling for data attributes 
refs c3c503632b
 2022-09-28 00:16:47 +05:30
Rishabh
d558a185de v2.13.0 2022-09-27 23:43:00 +05:30
Rishabh
c3c503632b Added attribution history to api requests via data attributes 
- we added attribution data from localstorage to api requests made via Portal UI, but was missed for requests directly from theme via data-attributes
- includes url history data for free or paid signups via theme to mark correct attribution
 2022-09-27 23:42:09 +05:30
renovate[bot]
c980865d3c Update dependency source-map-explorer to v2.5.3 2022-09-27 08:33:14 +07:00
renovate[bot]
5bec8eb2f4 Update dependency copy-webpack-plugin to v11 2022-09-20 17:48:43 +01:00
renovate[bot]
2814ea4774 Update dependency webpack-cli to v4 2022-09-20 17:35:16 +01:00
renovate[bot]
ff09129dfc Lock file maintenance 2022-09-20 15:37:59 +01:00
renovate[bot]
69a346ccd7 Update sentry-javascript monorepo to v7 2022-09-20 15:34:52 +01:00
Renovate Bot
4fb6913a8e Update dependency react-error-overlay to v6.0.11 2022-09-20 15:33:59 +01:00
renovate[bot]
965c4afcca Update actions/checkout action to v3 2022-09-20 15:33:21 +01:00
Renovate Bot
1135b0073a Update actions/setup-node action to v3 2022-09-20 14:43:22 +01:00
Renovate Bot
96e2c7d7c5 Update codecov/codecov-action action to v3 2022-09-20 14:42:59 +01:00
Ronald Langeveld
17b1141c0f v2.12.0 2022-09-09 13:44:07 +02:00
Ronald Langeveld
c397cb92f3 V2.11.2 2022-09-09 13:08:06 +02:00
Ronald Langeveld
30284909e9 Added members-autoredirect data attribute selector. (#261) 
closes https://github.com/TryGhost/Team/issues/1800
- Added data attribute selector for custom login / signup forms to optionally prevent redirects coming from the magic link.
 2022-09-06 14:39:18 +02:00
Rishabh
08cdddfb92 v2.11.1 2022-09-02 23:24:42 +05:30
Rishabh
7944e4c11d Allowed dismissing portal popup with Esc for signup page 
closes https://github.com/TryGhost/Team/issues/1034

- pressing esc to dismiss popup didn't work for signup page as it was focused on input field
- allows esc to dismiss popup if the focused input field is empty
 2022-09-02 23:11:18 +05:30
renovate[bot]
7293d008c4 Lock file maintenance 2022-08-29 05:21:04 +00:00
Rishabh
c5da3c0870 v2.11.0 2022-08-19 22:01:19 +05:30
Djordje Vlaisavljevic
3d87b02c55 Fixed error with free trial pill not showing on upgrade screen 
refs https://github.com/TryGhost/Team/issues/1728
 2022-08-19 18:13:35 +02:00
Rishabh
9bac4e680c v2.10.0 2022-08-19 21:01:28 +05:30
Rishabh
d6aae23e86 Wired expiry values for complimentary subscriptions 
refs https://github.com/TryGhost/Team/issues/1727

- adds expiry date for comp subs with expiry value
 2022-08-19 20:57:23 +05:30
Rishabh
aa1c90f60b Added flag for allowing comp member upgrade 
refs https://github.com/TryGhost/Team/issues/1728
 2022-08-19 20:57:23 +05:30
Rishabh
12bec6011b Fixed lint 2022-08-19 20:57:23 +05:30
Rishabh
8fba983e6d Allowed complimentary members to upgrade 
refs https://github.com/TryGhost/Team/issues/1728

- allows comped members to go through the upgrade flow and become a paid member
 2022-08-19 20:57:23 +05:30
Djordje Vlaisavljevic
427a5b1057 Removed the feature flag and the related logic 
refs https://github.com/TryGhost/Team/issues/1724
 2022-08-19 17:14:44 +02:00
Rishabh
2c636d16eb Cleaned up trial days display 2022-08-19 19:03:08 +05:30
Djordje Vlaisavljevic
d5dedd4765 Updated subscription info for users on free trial 
refs https://github.com/TryGhost/Team/issues/1724
 2022-08-19 14:40:35 +02:00
Djordje Vlaisavljevic
a6666eb8fd Updated the test 
refs https://github.com/TryGhost/Team/issues/1724
 2022-08-19 14:32:57 +02:00
Djordje Vlaisavljevic
006b3adc3b Updated how discounts appear when there are no tiers with trial 
refs https://github.com/TryGhost/Team/issues/1724
 2022-08-19 14:20:50 +02:00
Djordje Vlaisavljevic
4671975156 Updated the way free trial terms are shown 
refs https://github.com/TryGhost/Team/issues/1726
 2022-08-19 13:36:24 +02:00
Rishabh
b069f967e4 Added free trial message for offers 
- adds free trial info at the bottom of offer pages that have free trial
 2022-08-19 12:33:29 +05:30
Rishabh
f58011a276 Fixed product card CTA for free trials 
- product card was only showing free trial cta if there were more than one, which was incorrect
 2022-08-19 12:32:24 +05:30
Rishabh
971a0dc06c v2.9.0 2022-08-18 22:50:52 +05:30
Djordje Vlaisavljevic
d7dcef9f3a Free trial signup design (#258) 
* Added static HTML for free trial notification

refs https://github.com/TryGhost/Team/issues/1724

* Updated tier card design

refs https://github.com/TryGhost/Team/issues/1724

* Updated tier card design

refs https://github.com/TryGhost/Team/issues/1805

* Updated card design for free trial offers

refs https://github.com/TryGhost/Team/issues/1810

* Added trial days explanation

refs https://github.com/TryGhost/Team/issues/1810

* Switched class to className

refs https://github.com/TryGhost/Team/issues/1805

* Updated test

* Turned off the free trial feature flag

* Turned on the flag

Co-authored-by: Rishabh <zrishabhgarg@gmail.com>
 2022-08-18 17:55:56 +02:00
Simon Backx
54480438a6 Added urlHistory on sign in and checkout (#256) 
refs https://github.com/TryGhost/Team/issues/1797
refs https://github.com/TryGhost/Team/issues/1798

Context: we've added a new attribution script here: https://github.com/TryGhost/Ghost/pull/15242
Backend implementation: https://github.com/TryGhost/Ghost/pull/15243

- The member attribution script stores the history in the ghost-history localStorage value
- We need to pass this to the backend when signing in or checking out with Stripe
- Removed `getAnalyticsMetadata`, as this is no longer used in the backend (removed flag and implementation)

To merge after https://github.com/TryGhost/Ghost/pull/15243 (backend implementation)
 2022-08-18 17:39:24 +02:00
Simon Backx
8cb4387d2a v2.8.0 2022-08-15 11:28:05 +02:00
Simon Backx
f283425866 Added unsubscribe flow for comments (#255) 
refs https://github.com/TryGhost/Team/issues/1790

- Added `comments` query param to unsubscribe from comments
- Fixed unsubscribe all not updating comments button in unsubscribe flow
 2022-08-15 11:26:57 +02:00
Djordje Vlaisavljevic
424e98a81b Updated spacing 
refs https://github.com/TryGhost/Team/issues/1726
 2022-08-11 18:37:30 +02:00
Djordje Vlaisavljevic
34f805fcb4 Added a breakpoint for tier price 
refs https://github.com/TryGhost/Team/issues/1726
 2022-08-11 17:22:48 +02:00
Djordje Vlaisavljevic
cb35a2b532 Updated tier offer terms design 
refs https://github.com/TryGhost/Team/issues/1726
 2022-08-11 17:14:07 +02:00
Djordje Vlaisavljevic
a496c4fd19 Fixed offer title and offer terms overlap 
refs https://github.com/TryGhost/Team/issues/1726
 2022-08-11 14:17:57 +02:00
Rishabh
4d670e0fe7 v2.7.0 2022-08-11 12:06:52 +05:30
Rishabh
b392995b85 Wired offer page for free trials 
refs https://github.com/TryGhost/Team/issues/1726

- wires offer details UI for offer that includes free trial days on a tier
 2022-08-10 15:54:03 +05:30
Djordje Vlaisavljevic
6408bebb1c Added static HTML for free trial offer variant 
refs https://github.com/TryGhost/Team/issues/1726
 2022-08-10 10:22:54 +02:00
Renovate Bot
3a48caf4e4 Update dependency chokidar to v3.5.3 2022-08-09 23:23:14 +05:30
Renovate Bot
e999bf2e6e Update dependency minimist to v1.2.6 [SECURITY] 2022-08-09 23:19:09 +05:30
Rishabh
0c6abdd319 v2.6.0 2022-08-09 19:24:18 +05:30
Djordje Vlaisavljevic
2c837fa1a4 Commented out unnecessary code 
refs https://github.com/TryGhost/Team/issues/1757
 2022-08-08 15:00:59 +02:00
Djordje Vlaisavljevic
05e515ce2c Updated free trial design on account home 
refs https://github.com/TryGhost/Team/issues/1757
 2022-08-08 14:56:06 +02:00
Rishabh
2e8fa05bd9 Refined free trial UI on account home 
refs https://github.com/TryGhost/Team/issues/1757
 2022-08-08 17:21:50 +05:30
James Morris
821ec840b3 Reverted back a copy change that was made in error 
refs https://github.com/TryGhost/Team/issues/1744
 2022-08-08 11:33:38 +01:00
Rishabh
39d03c66d2 Added free trial info in plan details 
refs https://github.com/TryGhost/Team/issues/1757

- adds free trial info for a member subscription when active
 2022-08-08 15:55:41 +05:30
Rishabh
394ba3cffb v2.5.0 2022-08-05 18:17:41 +05:30
Rishabh
096aa65e58 Fixed comments enabled check 
- `comments_enabled` value is a string, one of `off`, `paid` or `all`, updates helper check to use that
 2022-08-05 18:09:45 +05:30
Rishabh
6cfa05ee58 Fixed unable to manage comment notifications with single newsletter 
closes https://github.com/TryGhost/Team/issues/1677

- for single newsletter sites we did not show email preference screen which allows managing comment notifications
- replaces newsletter toggle to use email preference screen when comments is enabled
 2022-08-05 17:44:13 +05:30
Rishabh
2310fa2416 Updated signup cta for tiers with free trial 
refs https://github.com/TryGhost/Team/issues/1724

- updates cta for tiers which include a free trial period
 2022-08-05 17:35:08 +05:30
Rishabh
3ff111291c v2.4.0 2022-08-04 20:35:37 +05:30
James Morris
b1481cd0df Small copy update for the comments notification 
refs https://github.com/TryGhost/Team/issues/1744
 2022-08-03 17:18:07 +01:00
Djordje Vlaisavljevic
58485a8d97 Added static HTML template for free trial tier card variant 
refs https://github.com/TryGhost/Team/issues/1724
 2022-08-02 14:13:55 +02:00
renovate[bot]
5c0c214d77 Lock file maintenance 2022-08-01 04:06:21 +00:00
James Morris
fa58f633af Replaced the comments notification copy 
refs https://github.com/TryGhost/Team/issues/1691
 2022-07-19 15:56:07 +01:00
Simon Backx
360962ae3a v2.3.0 2022-07-12 13:56:40 +02:00
Simon Backx
24041d2f70 Added UI to unsubscribe from comment emails (#253) 
refs https://github.com/TryGhost/Team/issues/1664
 2022-07-12 13:53:44 +02:00
Rishabh
36743dc28d v2.2.2 2022-07-04 12:38:05 +02:00
Rishabh
4981a72c9f Handled missing support address on site 
- the handling for non-existent support address for a site was missing, causing portal to not load in scenarios where support address is shown in UI
 2022-07-04 12:36:19 +02:00
renovate[bot]
16d76feb3b Lock file maintenance 2022-06-27 05:02:26 +00:00