Commit Graph

298 Commits

Author SHA1 Message Date
Brad Dougherty
ce787c6ecf Update delete all content button labels
issue #2027
2014-02-22 14:13:51 -05:00
Brad Dougherty
197b479394 Update delete post button labels
Closes #2027
2014-02-22 12:09:53 -05:00
Hannah Wolfe
ed4a330778 Merge pull request #2147 from gmurphey/master
Tweaking slug logic in post settings.
2014-02-08 22:13:03 +00:00
Hannah Wolfe
7151692c67 Merge pull request #2097 from zacgeis/publishbutton-fix
Disable publish button until deffered is resolved
2014-02-08 15:28:13 +00:00
Garrett Murphey
0b96023872 Tweaking slug logic in post settings.
Closes #2136.
- sets slug to placeholder text if slug is blank
2014-02-07 21:59:33 -05:00
Xie JinBin
95b17d9862 Tag needs escaping. Wrongly call showSuggestions.
close #2087, fix #2089
- escape tag.
- do not call showSuggestions when key is UP/DOWN. or the selected tag will
  always be clear.
2014-02-04 23:31:50 +08:00
Zach Geis
30cbfa6382 Disable publish button until deffered is resolved
closes #2040
- save post disables the publish button
- publish button remains disabled until deffered object is resolved
2014-02-01 16:38:40 -06:00
Hannah Wolfe
95dfe881df Merge branch '0.4-maintenance' 2014-01-30 13:17:58 +00:00
Hannah Wolfe
b434a04016 Post settings published_at date improvements & fixes
closes #1866, fixes #2067, fixes #2068

- Upgrade client side moment to 2.4.0 to match the server side script.
- Add a guard to pub date to fix #2067
- Add new format to close #1866
2014-01-29 22:33:43 +00:00
Hannah Wolfe
5db46c7754 Merge branch '0.4-maintenance' 2014-01-28 09:25:38 +00:00
Hannah Wolfe
810f97eaf8 Merge pull request #1972 from jgillich/character-limit
Show character limit below blog description textarea
2014-01-27 14:32:52 -08:00
Mikkel Hoegh
1a4c13a63f Refactor click handlers on upload button.
closes #2028
- Instead of binding and unbinding the click event, bind the data to the
  outer scope so we can use a standard click handler.
- Use removeProp instead of setting the property to false when enabling.
- Use the `disabled` as value when disabling.
2014-01-27 21:35:24 +00:00
Hannah Wolfe
288b09b280 Merge pull request #2049 from javorszky/iss-1841
Guard against multiple signup events
2014-01-27 13:33:55 -08:00
Hannah Wolfe
a0eb29eb87 Post settings don't render on change
fixes #1908

- each individual update function handles rendering its own item on success or failure, rather than re-rendering the whole group
- also resolved a bug where the published date didn't get reset properly on error
2014-01-27 10:55:22 +00:00
Gabor Javorszky
d02b92373e Guard against multiple signup events
Fixes #1841
* Added initial flag "no" for submission into Signup View
* Flag set to "yes" if submit button clicked
* Error thrown if flag is "yes", thus no subsequent submission sent to API
* Flag set to "no" if ajax returns with error
2014-01-26 22:38:50 +00:00
Hannah Wolfe
e81893a7ef Merge branch '0.4-maintenance'
Conflicts:
	core/server/config/paths.js
	core/test/unit/config_spec.js
2014-01-26 16:11:02 +00:00
Hannah Wolfe
9715e1994d Merge pull request #1950 from Damiya/1893-fix
Enable Escape key to close tag suggestion popup
2014-01-20 06:28:15 -08:00
Hannah Wolfe
a0ebf1198d General cleanup
- Cleanup some todos, comments, and unused variables
2014-01-19 21:08:39 +00:00
Jakob Gillich
03c16bae24 Show character limit below blog description textarea
closes #1970
2014-01-17 21:39:43 +01:00
Kate von Roeder
09b35b77d9 Prevent stacking of password mismatch notification on /reset/
closes #1902
- Missing call to clearEverything caused the new notifications to pile up on multiple failed submissions
2014-01-14 13:58:38 -08:00
Kate von Roeder
bafc27d454 Enable Escape key to close tag suggestion popup
closes #1893
- Checking the contents of search term after evaluating the keycode caused the suggestion box to be hidden and immediately reshown
- Moving the if/else to the top of the function enables us to fix the issue without complicating the suggestion update logic
2014-01-14 13:17:06 -08:00
Hannah Wolfe
2705a28da9 Publish date and time display fix
no issue

- add @ symbol to ensure date and time are clear
2014-01-13 02:39:08 +00:00
Zach Schneider
1007e8e5ad Prevented duplicate binding of upload button on debug importer
Fixes #1899
2014-01-10 18:08:24 -05:00
Hannah Wolfe
3e3e90daf5 Merge pull request #1894 from ErisDS/issue-1558
Notifications can be dismissed with ESC
2014-01-09 13:24:41 -08:00
Hannah Wolfe
ce75435865 Notifications can be dismissed with ESC
issue #1558

- this is a partial / short term fix for the problem with extra long notifications, so that there is at least one way to remove them.
2014-01-09 20:34:16 +00:00
Hannah Wolfe
cd750b11fb Merge pull request #1888 from hswolff/additional-ux
Update placeholder of published data in editor
2014-01-09 05:04:09 -08:00
Harry Wolff
1c8b96fea3 Update placeholder of published data in editor
fixes #1351

- when a post has a published_at value show a blank
placeholder

- when a post doesn’t have a published_at
value then show the required published at value
format
2014-01-07 23:13:16 -05:00
Jacob Gable
260252e511 Fix hanging loading bar on deleting a post
Closes #1869

- Added an additional event listener for destroy event, then a listener
on the model for the sync event to finish the progress bar loader
2014-01-07 18:56:00 -06:00
Harry Wolff
3213a0aa3d Extending halfdan’s work for UX settings improvements
#1351

- prevent a new post (not saved on server) from
updating its slug/date to the server

- fix jshint

- add back creation of a posts slug upon a post creation

- update for rebasing

- hide ability to ‘delete this post’ from post settings
menu when a post hasn’t yet been saved to the server
2014-01-06 21:33:24 -05:00
Fabian Becker
1b19fdb64a New Post UX behaviour.
refs #1351
- Make generateSlug a static method on base model
- Change client behaviour (unfinished)
- Add new getSlug API method
2014-01-06 21:05:17 -05:00
Sebastian Gierlinger
01f79c2921 Use ajax for import
closes #1854
- added blueimp file upload to debug.js
- changed POST /ghost/api/v0.1/db to be used with AJAX
- cache invalidation header should now work for import
- moved busboy middleware invocation to routes/api and routes/admin
- moved api.db.import to api.db.importContent (I hated the [] notation)
- moved api.db.export to api.db.exportContent (see above)
2014-01-06 22:55:43 +00:00
Devin Doolin
8d082215ca Fixes showing tag suggestions and tag container padding
fixes #1774
- Delayed showing the tag suggestions popup unless matching tags were found
- Changed the padding-left on the added tag container to 8px from 20px to fall in line with the left shadow overlay
2014-01-03 04:42:59 -05:00
Hannah Wolfe
4b491fbd6e Path, url and subdir cleanup & test
issue #1754

- remove path (it was only used once, and not needed)
- change webroot to subdir
- add unit tests for config.paths
- various other cleanup
- renamed client-side ghostRoot to subdir
- added url helper for client
2013-12-28 16:09:56 +00:00
Hannah Wolfe
13e41ed378 Adding messaging that deleting is permanent 2013-12-27 13:50:47 +00:00
Hannah Wolfe
0d188ae5dc Merge pull request #1743 from sebgie/issue#1445
Delete all content (posts and tags)
2013-12-27 04:52:58 -08:00
Sebastian Gierlinger
0c20e80f70 Delete all content (posts and tags)
closes #1445
- added delete button to ‚ugly debug tools‘
- added api call to delete all content
- added /db to cache invalidation routes
2013-12-25 01:05:20 +01:00
Matt Hughes
2e69992d9b Improved comma tag completion on international keyboard layouts
Reported in issue #1475
- `String.localeCompare` can be more reliable for keys that do not relate to cursor movement
- Adds a third key handler (`keypress`) that contains the character code rather than physical key
- `COMMA` key constant no longer required (unless `,` char should be a constant?)
2013-12-24 10:38:05 -05:00
Hannah Wolfe
12c7a571e2 Merge pull request #1716 from ErisDS/post-order
API refactor / cleanup
2013-12-21 12:46:57 -08:00
Hannah Wolfe
1565c0004b API refactor / cleanup
closes #1303

- removed where and orderBy from being passed from the API through to bookshelf, and ultimately knex
- ordering is now consistent across both front and backend, which fixes #1303
- validated / cleaned up all the API parameters
- added API tests for the status and staticPages parameters
2013-12-20 13:07:01 +00:00
Hannah Wolfe
11f57448c4 Markup & style fixes for post list statuses
fixes #1703, fixes #1712

- featured star appears immediately for both draft and published items
- featured star is never red & alignment /style is updated
- improved markup and styling of statuses in general
- added to feature tests
2013-12-20 12:29:47 +00:00
Hannah Wolfe
b62923633b Bug fixes, undefined should not be a string 2013-12-15 11:36:01 +00:00
Harry Wolff
f08633d1a6 Debounce post settings events
fixes #1582
2013-12-07 16:26:06 -05:00
Sebastian Gierlinger
56de932492 Fix error when uploading logo/cover image
closes #1616
- removed pars from model
- changed checkbox handling
2013-12-06 16:43:53 +01:00
Hannah Wolfe
b8c9128d20 Merge pull request #1577 from halfdan/527-subdir-admin
Fix Admin interface with sub directories
2013-11-28 05:14:23 -08:00
Hannah Wolfe
5165386f0d Improvements to date handling in post settings menu
issue #1350, #1351

- make sure we don't fire save if the date hasn't changed - and removes a few errors
2013-11-28 12:37:34 +00:00
Fabian Becker
62f656cc53 Subdir support for admin interface
refs #527
2013-11-27 09:57:38 +00:00
Manuel Gellfart
1fd03b846b Restructure error and success messages for the editor.
closes #1368
- merged the Maps for Error/Notification Messages into one JSON-structure
- this structure is more translation-friendly and influenced by I18n-standards.

Merged the Error and Message Map into one structure

The new JSON-structure is more translation friendly and similiar to i18n.
2013-11-26 01:00:46 +01:00
Hannah Wolfe
5ec7a95d54 Merge pull request #1533 from jgillich/permalinks
Add Customisable Permalinks
2013-11-23 14:29:02 -08:00
Jakob Gillich
a2cb218d9a Add Customisable Permalinks 2013-11-23 17:02:17 +01:00
Jacob Gable
2020c3dddb Improved Password Reset Tool
Closes #1471

- add api and User model methods for generating and validating tokens
- add routes and handlers for reset password pages
- add client styles and views for reset password form
- some basic integration tests for User model methods
2013-11-22 10:46:19 -06:00
Hannah Wolfe
7d253f20e4 Merge pull request #1353 from thgaskell/1350-static-page-checkbox
Allow user to set static page before saving
2013-11-19 03:29:35 -08:00
Hannah Wolfe
a6fcf8cac7 Merge pull request #1440 from JohnONolan/post-settings
Post settings refactor
2013-11-12 03:50:56 -08:00
Jacob Gable
38ced35054 Allow published_at times to be specified
Fixes #907

- Modified the PostSettings view to use moment.js formats that include hours and minutes
- Add 12:00 to value if it is not specified
2013-11-11 14:43:47 -06:00
Hannah Wolfe
3df01ab2c7 Preventing incorrectly shown unload alert
issue #1327

- IE9 fires an unload when using Backbone.history.navigate which meant the alert always got shown on first save when the url changes from from /editor/ to /editor/id. Not sure if other browsers do this, but this workaround fixes it
2013-11-11 09:36:29 +00:00
Hannah Wolfe
5b230d6013 Moving dirty editor handling out of uploadMgr
issue #1327

- just moved to be in editor obj, everything else is the same
2013-11-11 09:14:18 +00:00
Zach Geis
b70b712c97 Displays alert if editor is dirty before unload
closes #1327
- Prevents user from accidently losing changes
2013-11-11 09:00:15 +00:00
John O'Nolan
cf7b03bfff Kill iCheck cause Hannah says it has genital warts. 2013-11-08 14:38:23 +01:00
Fabian Becker
b5c8789c54 Properly format publish date.
fixes #1335
2013-11-05 17:44:13 +00:00
Hannah Wolfe
dfa75f0c74 Merge pull request #1345 from halfdan/944-crazy-notifications
Fix notification stacking.
2013-11-01 09:00:56 -07:00
Ben Gladwell
b809bdbe1c Remove unparam:true from jslint config in Gruntfile.js
issue #1365
- added /*jslint unparam:true*/ to functions where absolutely necessary
- added /*jslint unparam:true*/ to functions in which keeping parameter
  list added clarity to the underlying api, even when those parameters
  are not currently used
- removed unused parameters in a few places
2013-10-31 14:02:34 -04:00
Tony Gaskell
1569c46eea Allow user to set static page before saving
fixes #1350
- jQuery event.preventDefault() stops the user from selecting the checkbox
2013-10-30 02:33:58 -10:00
Fabian Becker
c4e5991687 Fix notification stacking.
fixes #944
2013-10-30 01:24:21 +00:00
Fabian Becker
83595b9ca8 Allow user to mark a post as static page
- Increased post-settings width to properly display "Static Page"
- Changed templates to display "Static Page" if set
- Added unit test for body_class helper

fixes #969
2013-10-28 22:01:03 +00:00
Fabian Becker
b0ec81d51e Prevent default drag/drop action. 2013-10-25 20:19:51 +00:00
Hannah Wolfe
6c52422777 Merge pull request #1122 from gotdibbs/Issue814
Simplify publish date checks
2013-10-24 10:53:55 -07:00
Hannah Wolfe
11da233015 Merge pull request #1258 from gotdibbs/Issue1242
Fix duplication of entries in infinite scroll
2013-10-24 08:17:41 -07:00
Hannah Wolfe
598a5ccdcd Merge pull request #1251 from sebgie/api-refactor-move
Move /api to /ghost/api
2013-10-24 07:52:49 -07:00
Hannah Wolfe
edc783f44d Merge pull request #1245 from StevenMcD/issue/1007
Issue/1007: Corrected the behaviour of the HOME and END keys on the Code...
2013-10-24 07:24:41 -07:00
Matt DuVall
5413cf0d2d Allow only images to be uploaded in the upload modal
Fixes #1221

- This changes the accepted encodings on the files upload input field to
  be only "image/*" now
-
2013-10-24 14:37:08 +01:00
Sebastian Gierlinger
f460d77307 Move /api to /ghost/api
closes #1249
- changed routes
- changed apiRoots
2013-10-24 14:50:17 +02:00
William Dibbern
4632c073ba Fix duplication of entries in infinite scroll
Fixes #1242

- Switched to render each new item as its added to the collection when
retrieving via scroll checks.
- Added check to remove all subviews whenever `render` is called on
`ContentList` as a preventative measure.
- Cached the jquery reference to the ordered list in `render`.
2013-10-24 01:19:09 -05:00
StevenMcD
59295487dc Issue/1007: Corrected the behaviour of the HOME and END keys on the CodeMirror editor by overriding their calls in the extraKeys config of the editor 2013-10-23 15:56:53 +02:00
Enrique Chavez
ec84ea1232 Validate negative numbers in the posts per page setting
issue #1236
- added validation to not allow number less than 0
2013-10-22 23:15:38 +01:00
Hannah Wolfe
db12bb2c5b Merge pull request #1119 from halfdan/featured-post-button
Posts can now be featured by clicking on the star icon
2013-10-22 12:38:43 -07:00
Hannah Wolfe
dbbb78a459 Merge pull request #1051 from nason/settingsResetOnImageUpload
Fixes #1017. Save all settings when the logo or cover is saved
2013-10-22 09:05:38 -07:00
Hannah Wolfe
30a20553ea Merge branch '0.3.3-wip'
Conflicts:
	core/client/views/blog.js
	core/server/api.js
	core/server/views/default.hbs
	package.json
2013-10-20 10:09:39 +01:00
Hannah Wolfe
a60fa5f970 Fixing URL-based image uploads on settings screen 2013-10-17 21:54:51 +01:00
Hannah Wolfe
c5431184bd Fixes for content screen
fixes #1125

- fixes an error in the console when there are no posts
- resolves the issue whereby content disappears after scroll
2013-10-17 21:06:01 +01:00
Sebastian Gierlinger
f1ef797d6b Security improvements
no issue
- added CSRF protection
- changed session handling to express.session
- changed session handling to change session id
- added config property useCookieSession
- added file extension check for /ghost/upload
- removed /ghost/debug/db/reset
2013-10-17 15:28:28 +02:00
Fabian Becker
e4ee695aa5 Posts can now be featured by clicking on the star icon
fixes #1111
2013-10-16 19:06:03 +00:00
William Dibbern
2fea2733b4 Simplify publish date checks
Fixes #814

- Changed to compare instances of `moment` using it's built in
comparison function instead of string compare with the date from the
database.
- Ensure compared date is parsed with the correct formats that we were
supporting before #1107.
- Moved date formats to variables to reduce chance for error in future.
2013-10-16 11:32:20 -05:00
Michael Nason
34e0e9c66c Save all settings when the logo or cover save button is clicked.
Fixes #1017.
- Call saveSettings for cover and blog logo photos
- Call saveUser for profile and profile cover photos
2013-10-16 08:39:24 -07:00
Karolis Dzeja
623a2362ac Fix notification bug
The date stored in the model is in a different format and needs to be converted before being checked. Otherwise, any blur event will trigger the notification that the date has been changed, even if the date is the same.
2013-10-16 00:30:25 -05:00
buddhamagnet
d3fd327d94 Cache selector in afterRender function
- cache selector in a variable to prevent recomputing it in the function.
2013-10-14 20:56:20 +01:00
Hannah Wolfe
d1d0d86d68 Merge branch '0.3.2-wip'
Conflicts:
	core/client/assets/lib/uploader.js
2013-10-11 20:56:15 +01:00
cobbspur
9ac01e02b4 fixed image upload url synchronicity and url removed on cancel
closes #988, closes #956, closes #975

- fixed multiple ids and refactored triggers
- persistence requirement overridden
- trash can now removes url in editor
- if empty url is saved http:// is inserted and dropzone initialized

Conflicts:
	core/client/assets/lib/uploader.js
2013-10-11 18:15:17 +01:00
Hannah Wolfe
c427318fdd Merge branch '0.3.2-wip'
Conflicts:
	core/test/unit/api_posts_spec.js
2013-10-10 16:37:35 +01:00
Hannah Wolfe
7d32ba8e98 Merge pull request #925 from matthojo/New-line
Added new paragraph keyboard shortcut
2013-10-09 11:32:43 -07:00
Hannah Wolfe
8c87d44b6d Swapping escape to sanitze
issue #938

- rather than using escape, use node-validatiors santize function which is designed for preventing xss vectors
- added listener for changes to both editor and settings page
- added more sanitization to the user model
- consistently use triple-braces when outputting blog post titles
2013-10-09 19:13:16 +01:00
Matthew Harrison-Jones
14818fac61 Added in functionality for a working loading bar 2013-10-08 16:39:07 +01:00
Hannah Wolfe
16cdcda475 Merge pull request #954 from jgable/fixChangePasswordEnter
Fix pressing enter key on user settings
2013-10-05 12:25:26 -07:00
Hannah Wolfe
11f7b05700 Merge pull request #918 from gotdibbs/Issue877
Fix a couple of issues when there are no posts
2013-10-03 07:40:11 -07:00
Sebastian Gierlinger
bcc7ad9a41 Disable filestorage
closes #937
- fixed bug where ![] is replaced with ![](http://) for image url
- added fileStorage setting to uploader
- added fileStorage helper (could become standard way of providing config data for frontend???)
- added data element to editor and settings
- if no config value is set fileStorage: true is default
2013-10-02 11:39:34 +02:00
Jacob Gable
ed5bd3b808 Fix pressing enter key on user settings
Specified type='button' for the buttons in the form so they don't get
pseudo clicked on enter key in inputs.  Added a keyup handler to check
for enter keys in the inputs and do the proper action based on where you
are in the form.
2013-10-01 10:05:12 -05:00
Matthew Harrison-Jones
2db73f87a1 Added new paragraph keyboard shortcut
`Ctrl / Cmd + Enter` now enters a new paragraph, but only if the user is not on a new line.
2013-09-27 14:41:38 +01:00
William Dibbern
b49473fc4a Fix couple of issues when there are no posts
Fixes #877

- Updated the blog/content view to check `collection.length` before
attempting to pull another record.
- In the event an item is removed and the collection now has zero items,
still redraw the preview pane, just with no data.
2013-09-26 23:44:01 -05:00
Hannah Wolfe
e1b1885750 Treat markdown as text in editor
closes #857

- markdown is inserted into codemirror with .text() not .html()
2013-09-26 21:06:52 +01:00
Hannah Wolfe
4c02e0d3c7 Correct validation message for short passwords
closes #833
2013-09-19 08:41:04 +01:00
Hannah Wolfe
0d4f957a57 Client & Server side validation for posts per page
closes #839

- caused a 500 error
2013-09-19 07:55:37 +01:00
William Dibbern
fc261630ef Expanded spelling of chars to characters
Fixes #834

- Updated error message for password length to use "characters" instead
of "chars".
2013-09-18 21:51:56 -05:00