Commit Graph

240 Commits

Author SHA1 Message Date
John O'Nolan
329359a6b7 Fix bug where image-delete icon was on top of floating headers 2013-10-30 14:20:44 +01:00
Fabian Becker
83595b9ca8 Allow user to mark a post as static page
- Increased post-settings width to properly display "Static Page"
- Changed templates to display "Static Page" if set
- Added unit test for body_class helper

fixes #969
2013-10-28 22:01:03 +00:00
John O'Nolan
ca224ecda4 Updated Breakpoint Sass 1.3.0 => 2.0.6 2013-10-27 16:25:26 +01:00
Will Glynn
361195dd88 <code>/<tt> elements should wrap since they're used inline 2013-10-25 08:48:57 -05:00
Fabian Becker
1f3221fc20 Fixed style of modal in preview.
fixes #1179
2013-10-23 21:13:29 +01:00
Matthew Harrison-Jones
877bddf897 Removed special character from SCSS
Replaced it with the escaped unicode version (\21AA).
2013-10-23 11:38:57 +01:00
Hannah Wolfe
9dda7e6c7b Merge pull request #1197 from halfdan/994-image-uploads
Show proper error message when image upload fails
2013-10-22 14:40:47 -07:00
andy matthews
1af54a15b8 Add tooltip text to icons in admin section
Closes #1178

* Add tooltip text to assorted icons within CMS
* Add tooltip for blog URL to Ghost logo
* Change 'Options' to 'Post Settings'

Change 'Options' to 'Post Settings'
2013-10-22 22:31:02 +01:00
Fabian Becker
8edaef35c6 Show proper error message when image upload fails
fixes #994
2013-10-22 21:08:26 +00:00
Hannah Wolfe
9bf0f5a2aa Fixing client-side jslint exclude
- Gruntfile had an exclude for all of client/assets rather than client/assets/vendor
- Fixes missed jsLint errors
2013-10-22 22:06:22 +01:00
Hannah Wolfe
584a6bfd73 Merge pull request #1121 from abe33/fix_user_image_border_in_settings
Fix style issue on user-image on Firefox and Opera
2013-10-22 12:40:07 -07:00
Hannah Wolfe
30a20553ea Merge branch '0.3.3-wip'
Conflicts:
	core/client/views/blog.js
	core/server/api.js
	core/server/views/default.hbs
	package.json
2013-10-20 10:09:39 +01:00
Hannah Wolfe
775d55bbd6 Merge pull request #4 from sebgie/sec/3
Sec/3
2013-10-17 10:49:40 -07:00
Sebastian Gierlinger
f1ef797d6b Security improvements
no issue
- added CSRF protection
- changed session handling to express.session
- changed session handling to change session id
- added config property useCookieSession
- added file extension check for /ghost/upload
- removed /ghost/debug/db/reset
2013-10-17 15:28:28 +02:00
John O'Nolan
f8bcbdb44f Fixed further firefox display bugs
See #1090

Conflicts:
	core/client/tpl/settings/user-profile.hbs
2013-10-17 14:10:49 +01:00
John O'Nolan
7009dce97c Merge pull request #1090 from bnchdrff/user-image-ff-fix
fixes firefox user image disappearance
2013-10-17 14:04:34 +01:00
Talon
db1f147dbf fixed typo in comments of manage.scss
The mage posts screen is probably supposed to be the manage posts screen.
2013-10-16 20:43:59 -06:00
John O'Nolan
e863f42491 Fixed further firefox display bugs
See #1090
2013-10-16 17:26:28 +02:00
John O'Nolan
d96686e912 Merge pull request #1090 from bnchdrff/user-image-ff-fix
fixes firefox user image disappearance
2013-10-16 07:57:56 -07:00
Benjamin Chodoroff
d7b99ba090 fixes firefox user image disappearance
take advice from @JohnONolan and subtract border-width
2013-10-16 10:47:06 -04:00
abe33
aceaf0beb7 Fix style issue on user-image on Firefox and Opera
On both Firefox and Opera (OSX) the user image badge in
the settings page wasn't displayed.
Also, on firefox the badge overlay didn't have the proper size.

I don't know if there's a specific use case requiring a `display:
table` instead of a plain `display: block` but that was failing on
Firefox and Opera.

Using a block instead seems works perfectly (at least on Opera, Chrome,
Safari, Safari Mobile IOS7 and Firefox) regarding the badge size issue.

On Opera, though, the border radius wasn't applied properly to the
image. Adding a `border-radius: 100%;`fix that.
2013-10-16 00:25:03 +02:00
Daniel Hanson
7ea112afc9 tweaked .floatingheader background for non-webkit browsers 2013-10-15 13:29:56 -06:00
Jacob Gable
adbb027306 Fix extra semi-colon in sass
Related to #1033 but needs TryGhost/Casper#32 to close

- Remove extra semi-colon
2013-10-14 12:45:46 -05:00
Hannah Wolfe
d1d0d86d68 Merge branch '0.3.2-wip'
Conflicts:
	core/client/assets/lib/uploader.js
2013-10-11 20:56:15 +01:00
cobbspur
9ac01e02b4 fixed image upload url synchronicity and url removed on cancel
closes #988, closes #956, closes #975

- fixed multiple ids and refactored triggers
- persistence requirement overridden
- trash can now removes url in editor
- if empty url is saved http:// is inserted and dropzone initialized

Conflicts:
	core/client/assets/lib/uploader.js
2013-10-11 18:15:17 +01:00
Matthew Harrison-Jones
14818fac61 Added in functionality for a working loading bar 2013-10-08 16:39:07 +01:00
Matthew Harrison-Jones
15d270840c Revert "loading bar implementation"
This reverts commit 46d37fb637cca71b169b6c61f56fd12f31450152 and 3187448867921f4de2aa9f22eca2626665226e99
2013-10-08 14:12:46 +01:00
Sebastian Gierlinger
998f28209e Fix for dropzone
no issue
- dropzone is disabled when fileStorage = false
2013-10-02 13:34:16 +02:00
Sebastian Gierlinger
bcc7ad9a41 Disable filestorage
closes #937
- fixed bug where ![] is replaced with ![](http://) for image url
- added fileStorage setting to uploader
- added fileStorage helper (could become standard way of providing config data for frontend???)
- added data element to editor and settings
- if no config value is set fileStorage: true is default
2013-10-02 11:39:34 +02:00
Matthew Harrison-Jones
73d37fc445 Refactored loading bar SCSS 2013-09-30 15:02:51 +01:00
John O'Nolan
1a2d4134e0 Initial loading bar implementation
See #726

Becomes visible when <body> has a class of `js-loading`
2013-09-30 11:17:06 +02:00
John O'Nolan
2489c60fb9 Smushed mobile app icons 2013-09-30 10:33:18 +02:00
John O'Nolan
61c4eab250 Adding support for Apple, Android, and Microsoft app icons 2013-09-28 15:54:12 +02:00
Hannah Wolfe
7a3e72e983 Merge branch '0.3.1-wip'
Conflicts:
	core/server/controllers/admin.js
2013-09-27 17:22:55 +01:00
Hannah Wolfe
a1a8df8053 Adding extra class for url uploads 2013-09-27 13:34:39 +01:00
John O'Nolan
74ed7ede58 Fix tiny alignment issue on Ghost logo 2013-09-27 11:23:24 +02:00
John O'Nolan
aae81c1232 Fixed fucked up modal padding 2013-09-27 11:21:23 +02:00
Hannah Wolfe
57bfcda78b Merge pull request #912 from cobbspur/saveposition
fixes position of save button in image uploader
2013-09-26 13:26:01 -07:00
cobbspur
40452a41ed fixes position of save button in image uploader
closes #911

- adds display block to save button centre class
2013-09-26 20:15:48 +01:00
cobbspur
a6ed49804e Increased visibility of trash can in image uploader for broken url
closes #838

- adds a min height value to pre-image-uploader scss
2013-09-26 18:33:09 +01:00
John O'Nolan
3389c8d9b8 Stripped obsolete CSS3 prefixes 2013-09-26 15:26:00 +01:00
Hannah Wolfe
8eefbf9cc7 Image upload start event fired earlier
issue #882
2013-09-26 12:35:03 +01:00
cobbspur
a4ef6c0e4d Image Upload URl saves in the right place
closes #864

- adds trigger - uploadstart to url handler
2013-09-26 12:34:59 +01:00
John O'Nolan
54316841d9 Stripped obsolete CSS3 prefixes 2013-09-24 18:44:32 +02:00
Christopher Giffard
cd58b1c896 500 Series Error Handling & Stack Traces
Fixes #825

- Changes the way the error middleware is delivered in server.js, moving
  all the logic back into errorHandling.js
- Alters error logging to use console.error (probably more appropriate) instead
  of console.log
- Changes error tests to accomodate for these alterations
- Alters user-error and error hbs templates to incorporate stack traces
- Adds additional styling for error pages to accomodate stack traces
- Added logic to parse and deliver formatted stack traces

Notes:
======

- Jslint gets in the way of the regex I've got to use to parse the stack.
  (It cites 'security reasons' which are not relevant in this case.)
  I needed to add a condition to relax it at the top of errorHandling.js
- The stack trace should probably be added as a partial, but I figured it
  was out of scope for this PR.
2013-09-19 13:01:20 +10:00
John O'Nolan
1dbe2a6a31 New default user image 2013-09-18 22:34:01 +01:00
Hannah Wolfe
2ef6464700 Default user image and cover
closes #812

- replace defaults with consistently named .png files
- change the settings saving code so that it doesn't double-save images and save the defaults to the db
2013-09-18 15:54:52 +01:00
Hannah Wolfe
9e44c6851b Merge pull request #808 from gotdibbs/Issue788
Corrected settings menu bugs
2013-09-17 19:14:59 -07:00
Hannah Wolfe
997ca58273 404 Page vertical centering
closes #791
2013-09-18 03:07:22 +01:00
William Dibbern
4501f4d5f4 Corrected settings menu bugs
Fixes #788

- Toggles now close all any other open toggles.
- Added .active class for post settings menu to ensure highlight stays
on settings icon/button until it is closed, not just on hover.
2013-09-17 20:59:35 -05:00
Hannah Wolfe
ab6012ed51 Merge pull request #803 from nicoburns/fastclick
Fastclick
2013-09-17 16:34:53 -07:00
Hannah Wolfe
116bc434d2 Clearing out images we don't use 2013-09-17 22:28:28 +01:00
nicoburns
5300af3186 Changed back button text
- Changed back button text from "Cancel" to "Back"
- Removed box-shadow from back buttons
2013-09-17 22:25:26 +01:00
nicoburns
590f2bcfb2 Replaced Hammer.js with FastClick
Issue #149 Closes #519
- Uses FastClick to speed up click events instead of using Hammer.js tap
events
2013-09-17 22:11:13 +01:00
John O'Nolan
77ba0a39d0 Merge pull request #800 from M165437/issue-149
Add back button to settings and content preview
2013-09-17 12:55:52 -07:00
Matthew Harrison-Jones
5e8a5bb460 Complete Modal Refactor
* Smoother animations
* Removed blurring in Chrome temporarily
* Centering is now done in CSS (the height is calculated in JS to work in FF and Opera)
* Modals now need close: true to be set to enable the close icon and shortcuts for closing (ESC key, background clicking)
2013-09-17 20:40:19 +01:00
Michael Schmidt-Voigt
67fb39bc69 Add back button to settings and content preview
Issue #149
- added back button to content preview and settings
- added hammer.js interactions
- needs some tweaking for mobile view
- problems with touch events (additional click event after 300ms)
2013-09-17 15:58:41 -03:00
cobbspur
f57274d528 Added url functionality for image uploads
closes #701, closes #702

- if image upload is called from editor the url icon provides a text field and a save button
- if on settings pages (general and user) the save button will capture the entered url or uploaded url
- both modes have the reset button
- fixed bug that is created by url when image is dragged onto window
2013-09-17 19:15:32 +01:00
Matthew Harrison-Jones
be2ec7234a Updated Upload Modal Icon 2013-09-17 18:36:47 +01:00
John O'Nolan
288b894c02 ONE. PIXEL. 2013-09-17 13:04:43 +01:00
John O'Nolan
626bfba168 Restyled delete post-settings menu item 2013-09-17 13:02:20 +01:00
John O'Nolan
34f44251b3 Fix wonky settings icon alignment 2013-09-17 12:32:56 +01:00
John O'Nolan
455687654f Make user profile images always fit their circle
Closes #778
2013-09-17 11:03:55 +01:00
Hannah Wolfe
da2d0c12da More trailing slashes 2013-09-17 02:52:29 +01:00
nicoburns
5443094c20 Fix notification link color
Closes #772
- Changed notification link color inherit, and added underline
2013-09-17 01:32:59 +01:00
Hannah Wolfe
0f8560759c Save image uploads in the editor
closes #295

- Maintain a list of markers for CodeMirror which reference image codes
- Upload start triggers a selection
- Upload success replaces the selection
- No ref-style image markdown handling
- Showdown image URL handling improved at the expense of titles
- Tests updated
2013-09-16 18:08:49 +01:00
Hannah Wolfe
eae3ebf3ca Merge pull request #764 from matthojo/Flash-Bar
Renamed the notifications container
2013-09-16 06:07:55 -07:00
Hannah Wolfe
482c8514da Merge pull request #710 from matthojo/Mobile-Tags
Improved Post tagging on Mobile devices
2013-09-16 02:34:28 -07:00
John O'Nolan
fb5e56a4fe Tweak icon mixin adjustments to reduce compiled filesize
See #509
2013-09-16 10:04:16 +01:00
U-nico-laptopnico
310d565642 Fixed 'extend' compile errors in SASS 3.3
closes #509
- Replaced @extend directive with a functionally equivalent mixin
2013-09-16 10:04:16 +01:00
Hannah Wolfe
bbbee1ca66 Merge pull request #730 from jgable/gruntClientFiles
Compile assets with grunt
2013-09-16 01:57:08 -07:00
Matthew Harrison-Jones
419d3f5488 Renamed the notifications container
Renamed from `#flashbar` to `#notifications`
2013-09-16 09:46:29 +01:00
Matthew Harrison-Jones
12d9d27327 Bug Fix: Clicking on a Tag on the Mobile Tag view screen will no longer shrink the view 2013-09-16 08:59:10 +01:00
Matthew Harrison-Jones
8889be149b Bug Fixes: Tags no longer overlap 'settings' icon and scroll bars have been removed 2013-09-16 08:34:38 +01:00
Matthew Harrison-Jones
40fa2c0b68 Improved Post tagging on non Mobile devices 2013-09-16 08:34:38 +01:00
Matthew Harrison-Jones
0b4d7701d7 Improved Post tagging on Mobile devices 2013-09-16 08:34:38 +01:00
Hannah Wolfe
fa62f9024f Merge pull request #754 from gotdibbs/Iss667
Publish button amendments
2013-09-15 15:16:41 -07:00
John O'Nolan
8ec110ba65 User profile refactor
Fixes #708
2013-09-15 22:42:30 +01:00
William Dibbern
ff086142d8 Publish button amendments
Fixes #667

- Removed superfluous as-of-yet-unused options in the publish menu.
- Adjusted display names of publish buttons according to differing
states the publish menu can be in (new post, saved draft, published
post).
- Added red highlight style to "important" status change options in the
publish menu (draft => published, published => unpublished).
- Added suite of functional tests around new labels and classes.
2013-09-15 14:52:09 -05:00
John O'Nolan
ac816634a6 CSS code standards cleanup 2013-09-15 20:18:37 +01:00
Jacob Gable
13ea3de742 Compile assets with grunt
- Made a helper called ghostScriptTags that will spit out the relevant
  script tags with version parameter; 4 unminified files in development,
  1 minified file in production.
- Added grunt concat and uglify tasks to build files into core/built
- Fixed some unit tests by making them native date objects
2013-09-15 14:06:42 -05:00
John O'Nolan
06ef9a0e05 Set input:focus to less extreme border / code standards cleanup 2013-09-15 19:33:40 +01:00
John O'Nolan
5ce3709d3b Introduce button active state
Fixes #740
2013-09-15 19:28:06 +01:00
John O'Nolan
b64415bd55 Tweak breakpoint 2013-09-14 23:51:49 +01:00
John O'Nolan
6a84f55763 Fix #744 2013-09-14 23:50:04 +01:00
John O'Nolan
c800ce262e Bump settings save button up to navbar 2013-09-14 23:27:34 +01:00
Gabor Javorszky
44f2cb0153 Added client side validation
Closes #581.

* Basically adds the client side of node validator, that we're already using
* Validator is plonked onto `Ghost.Validator`
* Usage is identical as to https://github.com/chriso/node-validator
* Has sanitizing values et al
* `Ghost.Validator.error` is redefined, it populates Ghost.Validator._errors (Array)
* `Ghost.Validator.handleErrors` is supposed to print out the multiple error messages, if there are multiple (this is broken due to how notifications are presented `.html` instead of `.append`), and also apply class to element
* The ajax calls are wrapped in an if to prevent network traffic if something's not right on client side
* Added validation to general settings and user settings screens.
* On validation error, optionally adds `.input-error` to whatever element you reference, see below (if `el` exists on the error object). This is the only place where usage is different to the original implementation. Redeclared `error()` function in `init.js`
* Usage: `Ghost.Validate.check(valueToCheck, {message: "the error message", el: $('#the element')}).isEmail()`
* The element above will receive the `.input-error` class. `isEmail()` is one of the stuff you can check against.
2013-09-14 10:52:27 +01:00
Hannah Wolfe
a5891c0bb7 Merge pull request #727 from sethlilly/issue-700
Replaced default user image for navbar
2013-09-13 14:32:36 -07:00
Seth Lilly
79a96d4762 Replaced default user image for navbar
Replaced default user image for navbar

closes #700
- Replaced photo of John (sorry, man) with a smaller version of the default heart user photo
2013-09-13 16:48:04 -04:00
ericterpstra
89b1ecd6f2 Added post-settings menu with edit permalink field
closes #370
- Added new Backbone view for post settings menu
- Moved sass styles to global.scss for post settings menu items
- Added field to change post slug (permalink) using existing slug
  validation
2013-09-13 12:36:38 -05:00
John O'Nolan
93bedd764c Added option for large buttons 2013-09-12 18:34:21 +02:00
Hannah Wolfe
056205839e Merge pull request #686 from matthojo/Sign-up-screen-UI
Improved Auth screen markup and validation checks
2013-09-12 06:25:27 -07:00
Hannah Wolfe
cec849a667 Merge pull request #703 from matthojo/Dashboard-Removal
Temporarily removed the Dashboard and all references
2013-09-12 06:19:59 -07:00
Matthew Harrison-Jones
1e60758877 Improved Auth screen markup and validation checks
* Signup now focuses on 'name' on load
* Fixed fade in on auth forms to work with `display: table`
* The 'name' field is required on Sign up forms
* The length check on the Signup form is in order of inputs
* Added check for password length
* Changed the auth form class names to better represent individual pages
* Updated CasperJS tests
2013-09-12 09:59:58 +01:00
Matthew Harrison-Jones
3e0fbdf184 Temporarily removed the Dashboard and all references
This also updates the CasperJS to match the new changes.
2013-09-11 15:38:09 +01:00
Hannah Wolfe
e12fdeb373 Merge pull request #681 from matthojo/Notifications-On-Mobile
Improved visibility of notifications on mobile devices
2013-09-11 06:35:51 -07:00
Michael Schmidt-Voigt
0632fdd017 Add breakpoint to switch to mobile friendly form layout
issue #149
- added breakpoint at 550px to change form layout
- labels are on top of form fiels
- form fields change to 100% width
2013-09-10 13:30:06 -03:00
cobbspur
db93a52a3a fixed loading icon bug
closes #662

- stops loading cat icon appearing by mistake
2013-09-09 20:18:35 +01:00
Matthew Harrison-Jones
90a2e36ad8 Improved visibility of notifications on mobile devices 2013-09-09 14:09:34 +01:00
John O'Nolan
3478fded10 Updated modal styles 2013-09-09 11:20:44 +02:00