5 Commits

Author	SHA1	Message	Date
Kevin Ansfield	1ad2c05d37	Bumped eslint-plugin-ghost and fixed linter errors ... no issue - new linting rules that needed fixing: - calling `super` in lifecycle hooks - no usage of String prototype extensions	2021-07-15 15:27:29 +01:00
Kevin Ansfield	352c4af1d7	Refactored usage of .get('property') with es5 getters ... no issue - ran [es5-getter-ember-codemod](https://github.com/rondale-sc/es5-getter-ember-codemod) - [es5 getters RFC](https://github.com/emberjs/rfcs/blob/master/text/0281-es5-getters.md) - updates the majority of `object.get('property')` with `object.property` with exceptions: - `.get('nested.property')` - it's not possible to determine if this is relying on "safe" path chaining for when `nested` doesn't exist - `.get('config.x')` and `.get('settings.x')` - both our `config` and `settings` services are proxy objects which do not support es5 getters - this PR is not exhaustive, there are still a number of places where `.get('service.foo')` and similar could be replaced but it gets us a long way there in a quick and automated fashion	2019-03-06 13:54:14 +00:00
Kevin Ansfield	48e3bf003d	ESLint: Consistent ember property/method ordering ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md	2018-01-12 12:17:56 +00:00
Kevin Ansfield	983110d931	Switched from ember-cli-shims to new module imports (#779) ... no issue - add eslint-plugin-ember, configure no-old-shims rule - run `eslint --fix` on `app`, `lib`, `mirage`, and `tests` to move imports to the new module imports - further cleanup of Ember globals usage - remove event-dispatcher initializer now that `canDispatchToEventManager` is deprecated	2017-08-22 14:53:26 +07:00
Kevin Ansfield	99dd49903d	🏃 improve navigation responsiveness with loading substates (#495) ... no issue - add loading substates for all routes that previously blocked transitions until their model had finished loading - enables immediate response on navigation click - loading templates include the title bar to provide immediate indication of which page is loading - loading templates include a new `{{gh-loading-spinner}}` component that will only show the spinner after 200ms to avoid flashing a spinner for users on fast connections - updated Version Mismatch tests to match new behaviour of intermediate transitions when navigating	2017-01-17 17:44:08 -06:00