TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-30 01:42:29 +03:00
Code Issues Projects Releases Wiki Activity
39,142 Commits 238 Branches 1,680 Tags 386 MiB
42009eb9ed
Commit Graph

10 Commits

Author SHA1 Message Date
Sag
98b51b666d
Fixed ember concurrency cancellation errors (#20324) 
fixes https://linear.app/tryghost/issue/SLO-121
fixes https://linear.app/tryghost/issue/SLO-138
fixes https://linear.app/tryghost/issue/SLO-139
fixes https://linear.app/tryghost/issue/SLO-140
fixes https://linear.app/tryghost/issue/SLO-141
fixes https://linear.app/tryghost/issue/SLO-142

- ember-concurrency prevents two executions of the same task from
running at the same time
- when a task is cancelled, the library raises an error by default
- however, we don't need to surface that error as the cancellation of
the second execution is intentional
 2024-06-04 16:20:49 +02:00
Simon Backx
14927ee24b
Added quotes to NQL filters with ids (#18958) 
refs https://github.com/TryGhost/Product/issues/4120

Updated some places where we don't add quotes around ids in NQL filters,
which can be an issue when the id is a number
 2023-11-13 12:00:20 +01:00
Simon Backx
05bba5135d
Cleaned up sourceAttribution flag (#16740) 
no issue

This commit removes the `sourceAttribution` feature flag from the
codebase.
 2023-05-05 10:57:26 +02:00
Kevin Ansfield
d15f740a3f Fixed TaskCancelation errors 
sentry issue: ADMIN-AY5

- added guards for cancelation errors where we're casting tasks to promises
- see http://ember-concurrency.com/docs/task-cancelation-help for full details
 2022-11-23 10:42:40 +00:00
Rishabh
dcd607ad94 Fixed jumping of links on edit in analytics 
refs https://github.com/TryGhost/Team/issues/2116

- editing a link caused it to jump in the list as its count is reset to 0
- this forces the order of links same after edit, the new order is only visible on refresh or navigating away and coming back
 2022-10-21 13:34:15 +05:30
Rishabh
71999a26b9 Updated success state for link update on Admin 
refs https://github.com/TryGhost/Team/issues/2116

- removes extra redundant success state handling
 2022-10-20 18:25:46 +05:30
Rishabh
ee145ed5b3 Wired link update api on Admin 
refs https://github.com/TryGhost/Team/issues/2116

- wires link update API on post analytics UI page to save edited links for a newsletter
- all links matching the edited link are updated by the API in the backend
 2022-10-20 17:55:02 +05:30
Rishabh
ca28ba8bae Added edited state for newsletter links 
refs https://github.com/TryGhost/Team/issues/2111

- shows edited in UI next to edited newsletter links in post analytics
 2022-10-19 20:25:58 +05:30
Rishabh
3db8fb5a1c Wired newsletter link success/error states 
refs https://github.com/TryGhost/Team/issues/2116

- wires handling of success and error messages on editing a newsletter link
- has the update api commented out temporarily to mock the changes
 2022-10-19 19:23:15 +05:30
Simon Backx
22fe1c01de
Added conversions count and separate analytics page (#15637) 
fixes https://github.com/TryGhost/Team/issues/2084

- When audience feedback is enabled, we use a single 'conversions' count instead of having separate ones for signups and paid conversions.
- The analytics component is separated so we can change it without breaking the existing page.
 2022-10-17 13:02:39 +02:00