TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-01 05:50:35 +03:00
Code Issues Projects Releases Wiki Activity
33,309 Commits 237 Branches 1,680 Tags 387 MiB
48a3159d3d
Commit Graph

33309 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sanne de Vries
48a3159d3d Added mobile feedback buttons to email template 
Refs https://github.com/TryGhost/Team/issues/2740
 2023-03-17 15:58:14 +01:00
renovate[bot]
b7a7a54b43 Update dependency react-error-overlay to v6.0.11 2023-03-17 15:21:26 +01:00
renovate[bot]
101549b3df Update asdf-vm/actions action to v2 2023-03-17 15:15:35 +01:00
Daniel Lockyer
b7a03ca765 🐛 Fixed mainEntityOfPage property within page metadata 
fixes https://github.com/TryGhost/Ghost/issues/16367
refs https://github.com/schemaorg/schemaorg/discussions/3274

- after a discussion with the schemaorg maintainers, it looks like
  `mainEntityOfPage` should refer to the entity itself vs the parent
  entity
- this commit updates the code to use the entity URL and fixes the
  associated tests
 2023-03-17 15:13:28 +01:00
Simon Backx
f67b38daf4 Fixed posts and email wrappers in worker threads 
refs https://ghost.slack.com/archives/C02G9E68C/p1679055933852679

- The posts api is used in the update-check job. This also uses the email wrapper, which needs the email-service
- The email service is not initalized in the worker threads, this causes an error
- Adds a check, because this part is optional in worker threads
 2023-03-17 14:10:33 +01:00
Simon Backx
9bdffdf89d Fixed body style dropdown overflow issue 
no issue

When opening the 'body style' dropdown in the newsletter settings, the dropdown was not completely visible. The next 'liquid' tab covered the dropdown. This makes some adjustments to the overflow of the liquid containers and z-index of the buttons and containers to fix that.

It also removes overflow-y: auto from one of the containers because it cropped the shadow if the dropdown, while that container could never scroll (parent is scrollable).
 2023-03-17 12:00:24 +01:00
Daniel Lockyer
3302f4125e
Added support to yarn dev for --search to launch Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this makes development more fluid by allowing developers to use the
  local Sodo-Search code
 2023-03-17 11:51:42 +01:00
renovate[bot]
680e3bf270 Update sentry-javascript monorepo to v7.43.0 2023-03-17 11:40:12 +01:00
Daniel Lockyer
945bae34cc
Updated Sodo-Search dependencies 
- these were the easy ones to bump, the rest require bigger changes or
  more investigation
 2023-03-17 11:30:02 +01:00
Daniel Lockyer
d1392e3b8a
Deleted superfluous .editorconfig file 
- this is not needed as we have one at the top-level
 2023-03-17 11:30:02 +01:00
Daniel Lockyer
73c1438561
Updated Sodo-Search package.json 
refs https://github.com/TryGhost/Toolbox/issues/400

- this brings it inline with Portal's, which is a similar project
 2023-03-17 11:30:02 +01:00
Sanne de Vries
0d8d5a8119 Updated typography in email design preview 
Refs https://github.com/TryGhost/Team/issues/2714
 2023-03-17 11:19:30 +01:00
Simon Backx
005b5f20fb Added E2E tests for comment CTA 
fixes https://github.com/TryGhost/Team/issues/2727

Adds some E2E tests and snapshots for comment CTA in all possible situations.
 2023-03-17 11:12:47 +01:00
Daniel Lockyer
ddc6d60927
Added missing yarn test:unit command to Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this is needed for CI tests
 2023-03-17 10:48:25 +01:00
Daniel Lockyer
8d9b8739d9
Added Sodo-Search build folders to gitignore 
refs https://github.com/TryGhost/Toolbox/issues/400

- these don't need to be tracked in git
 2023-03-17 10:44:51 +01:00
Daniel Lockyer
a18da88073
Added .yarnrc config to Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows the git tag and commit to be correctly formed for new
  Sodo-Search releases
 2023-03-17 10:41:47 +01:00
Daniel Lockyer
2c72f3c97b
Merged Sodo-Search gitignore with top-level one 
refs https://github.com/TryGhost/Toolbox/issues/400

- we don't need multiple gitignores because it can produce weird
  behaviour with some tools
 2023-03-17 10:34:21 +01:00
Daniel Lockyer
94201281e3
Updated lockfile 2023-03-17 10:32:28 +01:00
Daniel Lockyer
9cc202aae3
Imported code and history from Sodo-Search 
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows for a better dev experience by having the code in the
  monorepo
 2023-03-17 10:31:20 +01:00
Simon Backx
6058b2db22 Removed ghost comments link test 
no issue

Accidentally left when committing.
 2023-03-17 10:28:47 +01:00
Simon Backx
298e3da745 Fixed comment CTA button link 
refs https://github.com/TryGhost/Team/issues/2672

- Use #ghost-comments instead of #ghost-comments-root
- Fixed snapshots
 2023-03-17 10:27:23 +01:00
Simon Backx
423337a048 Fixed snapshots 2023-03-17 10:24:21 +01:00
Sanne de Vries
6821750a3a Fixed spacing between post title and metadata in email template 
Refs https://github.com/TryGhost/Team/issues/2740
 2023-03-17 10:17:56 +01:00
Sanne de Vries
717ed114f4 Fixed center aligned post title in emails 
Refs https://github.com/TryGhost/Team/issues/2740
 2023-03-17 10:07:17 +01:00
Daniel Lockyer
3f3cf76c37 Updated react-scripts to v5 
refs https://github.com/TryGhost/Toolbox/issues/400

- this fixes various build issues when it's moved into the Ghost
  monorepo
 2023-03-17 09:52:12 +01:00
Chris Raible
0640b9c4aa
Modified outbound link tagger to use ?ref=domain instead of ?ref=siteTitle (#16431) 
refs TryGhost/Team#2755

- Outbound link tagger will now append ?ref=example.com or ?ref=example.ghost.io instead of ?ref=siteTitle
 2023-03-17 14:18:26 +05:30
Simon Backx
25f4974846 ✨ Added comment CTA in newsletters 
fixes https://github.com/TryGhost/Team/issues/2672

- Moves the feature from behind the flag
- Also hides the comment CTA for email only posts

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
 2023-03-17 09:38:55 +01:00
Simon Backx
86446e4c86 ✨ Added option to remove post title from newsletters 
fixes https://github.com/TryGhost/Team/issues/2673

Adds a new option to hide the post title section from newsletters.

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
 2023-03-17 09:38:55 +01:00
renovate[bot]
fb69af86e2
Update dependency i18next to v22.4.12 2023-03-17 07:22:44 +00:00
Chris Raible
8d4028bbb7
🐛 Fixed editor crashing with unknown cards in mobiledoc (#16430) 
refs TryGhost/Team#2702

- adds a default handler for unknown cards: 
- logs a warning message to the console 
- removes the card from the mobiledoc
 2023-03-16 16:06:56 -07:00
Naz
74a1ab4525
Fixed root zip media/files copying during import 
refs https://github.com/TryGhost/Toolbox/issues/523

- During import process of content files the files from the root directory were also copied over. This is causing chaos in the root of content folder with files that only needed for data import. For example, the csv files needed for Revue import were also copied over by "file importer" even though those do not belong to any content.
- The approach of filtering on a "handler" level was taken over filtering in the import manager due to how our globing patterns work. See a previous commit with reverted previous fix for more context.
 2023-03-16 22:48:57 +01:00
Naz
c487b12518 Reverted zip's root file copying fix 
refs https://github.com/TryGhost/Toolbox/issues/523

- The reverted fix did not take into account the "original path" of the
files would be truncated. This path has to be full relative to the root
of the zip to later be used during importer url substitution logic.
- This reverts commit 831a76505c.
 2023-03-16 21:52:24 +01:00
Daniel Lockyer
dda1d7cf26 Removed emojis from i18n strings 
refs https://github.com/TryGhost/Ghost/issues/15502

- these aren't going to change across languages so we can exclude them
  from the strings to simplify things
 2023-03-16 20:52:39 +01:00
Kevin Ansfield
6760bc1bb0
Added darkMode passthrough to lexical editor 
closes https://github.com/TryGhost/Team/issues/2753

- dark mode styles are being added to our Lexical-based Koenig editor, this lets us test them inside of Admin
 2023-03-16 18:55:44 +00:00
Sanne de Vries
d04b2e04d6 Updated copy from "Comments" to "Comment" 
Refs https://github.com/TryGhost/Team/issues/2714
 2023-03-16 18:19:45 +01:00
Daniel Lockyer
dc0f021b99 Refactored i18n plaintext email translations to split on newline 
refs https://github.com/TryGhost/Ghost/issues/15502

- this makes the translations files a lot nicer because they only
  contain one line per key
 2023-03-16 17:25:22 +01:00
Rishabh Garg
ef538428c9
Fixed broken empty state in mentions admin url (#16419) 
fixes https://github.com/TryGhost/Team/issues/2734

With WebMentions flag on, navigating to `/ghost/#/mentions` on Admin when there are no mentions gives a 400 error page instead of the intended empty state.
 2023-03-16 21:19:56 +05:30
Steve Larson
7f223b56dd
fixed member newsletter test (#16425) 
no ref
-fixed flaky test that seemed to have sync issues with fixture data and
db
 2023-03-16 10:43:17 -05:00
renovate[bot]
a6f6b11ddf Update dependency vite to v4.2.0 2023-03-16 16:41:24 +01:00
renovate[bot]
f8730267ed Update dependency vitest to v0.29.3 2023-03-16 16:34:27 +01:00
Daniel Lockyer
327fef0ad8 Migrated Portal from CRA to Vite 
refs https://github.com/TryGhost/Ghost/issues/15502

- this commit migrates Portal from CRA to Vite, as it brings the
  package more inline with the direction we're going in terms of tooling
  for builds
- the bulk of the changes here are just config related to get things
  working with Vite, and then cleaning up all the CRA boilerplate
 2023-03-16 16:25:55 +01:00
Sanne de Vries
cdcb3dcd6f
Updated email template to include comment link in header and footer (#16423) 
Refs https://github.com/TryGhost/Team/issues/2740

---------

Co-authored-by: Steve Larson <9larsons@gmail.com>
 2023-03-16 16:10:53 +01:00
Daniel Lockyer
330e86944c Added example translation for emails within Ghost 
refs https://github.com/TryGhost/Ghost/issues/15502

- this adds the i18n translation wrapper to the titles, plaintext
  versions and one HTML version of the member emails
 2023-03-16 16:09:55 +01:00
Daniel Lockyer
9f5d4b4efe
Removed .only from Portal tests 
- I'm not sure what this was doing here, nor why it hasn't caused
  problems for us
 2023-03-16 16:00:19 +01:00
Elena Baidakova
60b3731199 Separated admin and portal tests to different projects 
refs TryGhost/Team#2667
- Portal tests are much more stable when running in the separate DB from admin tests.
 2023-03-16 18:35:09 +04:00
renovate[bot]
0ae2a79a77
Update dependency ember-template-lint to v5.7.1 2023-03-16 13:53:36 +00:00
Daniel Lockyer
21ea426794 Added i18n service to Ghost core 
refs https://github.com/TryGhost/Ghost/issues/15502

- this adds the scaffolding for enabling i18n translations within Ghost
  core
- also adds `yarn translate:ghost` as an option to the `i18n` package
- the locale is currently hardcoded to `en` so we don't utilize the
  translations until we're ready
 2023-03-16 14:50:50 +01:00
Daniel Lockyer
0273ba2066
Disabled i18next debug mode in development 
- I didn't realise how annoying this would be so this commit disables it
 2023-03-16 14:06:38 +01:00
Sodbileg Gansukh
2d7e5753d7 Fixed border color of the post analytics list in dark mode 
closes https://github.com/TryGhost/Team/issues/2620
 2023-03-16 19:55:14 +08:00
Sodbileg Gansukh
66b749ba90 Removed tabbed look from post analytics page with only one metric 
refs https://github.com/TryGhost/Team/issues/2620
 2023-03-16 19:51:04 +08:00