Commit Graph

10467 Commits

Author SHA1 Message Date
Ian Sim
6247b52367 Allowed pages to accept HTML as a source (#11422)
refs https://github.com/TryGhost/Ghost/issues/10471

- Allow page resource endpoints to accept HTML source. This behavior is the same as the post's resource introduced with e9ecf70ff7372f395b8917340805148bc764e2ef
- The functionality was most likely missed when post split into posts & pages was happening.
- Added symmetric changes to API v2.
2020-01-08 17:44:34 +01:00
Naz Gargol
97ea664d4d
🐛 Fixed empty html/plaintext fields for narrow fields parameter (#11505)
refs https://forum.ghost.org/t/plaintext-value-is-empty-using-the-api/10537

- The `plaintext`/`html` fields were empty because `visibility` attribute was not present in response body on output serialization stage. `visibility` field is always needed for content gating to work as expected 
- Added `visibility` field in the input serialization layer as it wouldn't be possible to use content gating if added on model layer through `defaultColumnsToFetch`
- Added test cases covering a bug
2020-01-08 14:43:21 +01:00
Renovate Bot
db8a598e5a Update dependency ghost-ignition to v4 2020-01-07 15:15:51 +01:00
Nazar Gargol
cb68257952 Improved logs for slow get helper
no issue

- Updated the logs to show something more useful - controller name, instead of current [object Ojbect] appearing in the log
2020-01-07 11:25:51 +01:00
Naz Gargol
c701293514
Optimized posts_meta table join when meta columns are not requested (#11300)
no issue

- This change speeds up qery execution ommiting a join with posts_meta
table when there is no need to fetch meta columns
2020-01-06 15:38:40 +01:00
Nazar Gargol
11d1acb475 🐛 Fixed plaintext field being added as empty property when member post is requested
no issue

- Tests in previous commit uncovered a bug with unwanted field attached to
the post response
2020-01-06 14:59:30 +01:00
Nazar Gargol
6fa20066f5 Added regression tests for content gating
no issue

- There was a lack of any kind of tests checking if content gating
behaves as it should. These changes create a base to expand upon when
more changes are introduced into content gating mechanism
- One thing that would be great to add in the future is imitation of
member authentication to test the content is visible for authenticated
paying/non-paying members
- Added 'members only' tests
- Added 'paid' post test case
- Added plaintext gating test case
2020-01-06 14:59:30 +01:00
Zlatan Vasović
4361a0b936 2020
refs 679fc7e1c5
2020-01-06 10:51:18 +01:00
Renovate Bot
d7f38cbedb Update dependency metascraper-description to v5.8.15 2019-12-30 01:17:13 +00:00
Renovate Bot
5874570d45 Update dependency metascraper-title to v5.8.13 2019-12-23 09:36:35 +00:00
Renovate Bot
17f8a8bfbc Update dependency oembed-parser to v1.3.7 2019-12-23 09:16:43 +00:00
Renovate Bot
52c7628a48 Update dependency metascraper-logo-favicon to v5.8.13 2019-12-23 08:17:42 +00:00
Renovate Bot
3cabd27042 Update dependency metascraper-image to v5.8.13 2019-12-23 07:16:14 +00:00
Renovate Bot
2aec73c2e2 Update dependency metascraper-publisher to v5.8.13 2019-12-23 06:16:42 +00:00
Renovate Bot
f2bba8c633 Update dependency metascraper-logo to v5.8.13 2019-12-23 05:16:43 +00:00
Renovate Bot
f49b1a8313 Update dependency metascraper-author to v5.8.13 2019-12-23 04:17:16 +00:00
Renovate Bot
7f08e0b31e Update dependency metascraper-description to v5.8.13 2019-12-23 03:17:25 +00:00
Renovate Bot
a07818f302 Update dependency metascraper to v5.8.13 2019-12-23 02:17:40 +00:00
Renovate Bot
c047232626 Update dependency @tryghost/helpers to v1.1.20 2019-12-23 01:20:52 +00:00
Nazar Gargol
7e44412568 Fixed cancel_link helper test
no issue

- We don't check for specifics of the error thrown in the other heper tests, don't see a reason to do so here. It's important to see the error was thrown at all in this case
2019-12-20 14:50:08 +07:00
Nazar Gargol
6896997984 Fixed cancel_link helper documentation link
no issue

- The documentation was decided to be published under `/members/ ` instead of general `/api/handlebars-themes/`
2019-12-20 11:39:58 +07:00
Renovate Bot
6ecc7d197b Update dependency metascraper-title to v5.8.12 2019-12-17 19:16:06 +00:00
Rish
7865d70f56 Version bump to 3.2.0 2019-12-17 21:52:51 +05:30
Rish
02cdb2e7f1 Updated Ghost-Admin to 3.2.0 2019-12-17 21:52:51 +05:30
Rishabh Garg
160ef2976a
🏗Added host config limits for member emails (#11439)
no issue

Introduces host limits config for allowing email limits with members.
2019-12-17 19:24:27 +05:30
Rishabh Garg
169daead1f
Fixed post meta migration for 3.x (#11438)
no issue

Since we added `email_subject` to `posts_meta` table in `3.1`, the migration tries to add `email_subject` column from post table, which does not exist and thus tries adding `undefined` value for column. Since sqlite expects default values while inserting new columns, this breaks any migration directly from `1.x`/`2.x` to 3.x.

The fix adds a default `null` value for any post_schema entry which doesn't has a value.
2019-12-17 17:14:53 +05:30
Rish
a3c2209420 Fixed tests
no issue
2019-12-17 16:42:30 +05:30
Rishabh Garg
fa3686bcc3
Added new brand blog setting (#11408)
no issue

Adds new `brand: {primary_color: ''}` blog setting behind dev flag for setting user-defined brand color in themes and emails.
2019-12-17 16:15:31 +05:30
Hannah Wolfe
7bf48e49a1 Update dependency analytics-node to v3.4.0-beta.1 2019-12-16 21:06:35 +00:00
Hannah Wolfe
53fdc1b090 Update dependency @tryghost/social-urls to v0.1.5 2019-12-16 20:27:50 +00:00
Hannah Wolfe
16f44e1677 Update dependency gscan to v2.3.1 2019-12-16 20:15:55 +00:00
renovate[bot]
896d4c31ae Update dependency express-hbs to v2.3.0 (#11417) 2019-12-16 20:13:17 +00:00
Nazar Gargol
e25e847f47 Removed email related fields from API v2 responses
refs  https://github.com/TryGhost/Ghost/issues/11461

- The email feature was introduced in API v3 and is not back compatible with API v2. These fields should not appear in any v2 responses.
- Added regression tests for API v2 so that cases like this are spotted
easier in the future.
2019-12-16 20:01:38 +07:00
Rish
2d9963fbd8 Allowed comment_id and uuid in post API input
refs https://github.com/TryGhost/Ghost/pull/11462

Allows `comment_id` and `uuid` to be passed in post `add`/`edit` API calls instead of failing requests with validation error, though both properties are stripped out in serializer as we don't allow editing them.
2019-12-16 18:22:48 +05:30
Renovate Bot
52e23192c0 Update dependency sqlite3 to v4.1.1 2019-12-16 11:15:42 +00:00
Renovate Bot
10a4ba306f Update dependency sharp to v0.23.4 2019-12-16 09:18:07 +00:00
Renovate Bot
a67b2d5c8a Update dependency metascraper-url to v5.8.10 2019-12-16 08:19:06 +00:00
Renovate Bot
dde5220377 Update dependency metascraper-logo-favicon to v5.8.10 2019-12-16 07:16:39 +00:00
Renovate Bot
ff9c6df418 Update dependency metascraper-image to v5.8.10 2019-12-16 06:13:46 +00:00
Renovate Bot
a54e28b962 Update dependency metascraper-publisher to v5.8.10 2019-12-16 05:15:51 +00:00
renovate[bot]
b9458475bb Update dependency juice to v6 (#11429) 2019-12-16 11:55:32 +07:00
Renovate Bot
2fe25daff4 Update dependency metascraper-logo to v5.8.10 2019-12-16 04:23:41 +00:00
Renovate Bot
a1dee8fbc8 Update dependency metascraper-author to v5.8.10 2019-12-16 03:15:12 +00:00
Renovate Bot
04e4b4d28c Update dependency metascraper-description to v5.8.10 2019-12-16 02:16:53 +00:00
Renovate Bot
c59cc557da Update dependency metascraper to v5.8.10 2019-12-16 01:16:49 +00:00
Naz Gargol
e277c6bad3
Added member's subscription cancellation helper {{cancel_link}} (#11434)
no issue

- The helper allows generating HTML needed to cancel or continue the member's subscription depending on subscription state.
- Added public members endpoint to allow updating subscription's `cancel_at_period_end` attribute available at: `PUT /api/canary/members/subscriptions/:id/`
- Added client-side hook to allow calling subscription cancellation. Allows to create elements with `data-members-cancel-subscription` / `data-members-continue-subscription` attributes which would call subscription update.
- Updated schema and added migration for `current_period_end` column
- As discussed we only add a single column to  subscriptions table to avoid preoptimizing for future cases
- Added {{cancel_link}} helper
- Added error handling for {{cancel_link}} when members are disabled
- Added test coverage for {{cancel_link}} helper
- Bumped @tryghost/members-api version to 0.10.2. Needed to use `updateSubscription` middleware
- Bumped gscan to 3.2.0. Needed to recognize new {{cancel_link}} helper
2019-12-12 19:59:15 +07:00
Fabien O'Carroll
5997343279 Installed @tryghost/members-api@0.10.1
no-issue

Fixes issue with Stripe webhooks when running on localhost url
2019-12-09 14:33:04 +02:00
Nazar Gargol
75e8caa76c Removed unexisting member endpoints from API key access whitelist
no issue

- /members endpoints are not available under API v2, removed them from the whitelist to avoid confusion
2019-12-09 13:21:38 +07:00
Naz Gargol
bcddeeadf1
Removed redundant member manipulation proxy methods (#11423)
no issue

- This includes the interface change for members-api constructor - now accepts the member's model instead of proxy methods. These methods have been moved ton @tryghost/members-api in favor of using the model directly (ref: https://github.com/TryGhost/Members/pull/105)
- Moved error handling from the service layer to controller
- Bumped @tryghost/member-api package to 0.10.0
2019-12-06 12:04:10 +07:00
Nazar Gargol
59143de19d Removed flaky test
no issue

- This test was checking for a very edge casy scenario (blog timezone change when scheduled date for a post changes at the same time). It's been hard to keep it maintaned so had to go.
2019-12-04 21:14:24 +07:00