10 Commits

Author	SHA1	Message	Date
Kevin Ansfield	151b7a2844	🐛 Fixed missing errors and confusing button text in theme upload modal ... no issue - fixed "Active with errors" button successful theme upload with no warnings/errors - fixed fatal errors not showing due to change in API error response - fixed "Retry" button not showing when there were fatal errors - fixed "Upload successful!" message after clicking "Retry" on a failed upload	2019-04-15 22:43:29 +01:00
Kevin Ansfield	d0a834b477	🐛 Fixed missing error notification when attempting to activate an invalid theme ... no issue - updates error handling to work with new v2 error response formats - `.errorType` -> `.error` - `.errorDetails` -> `.details`	2019-03-25 11:32:29 +00:00
Kevin Ansfield	352c4af1d7	Refactored usage of .get('property') with es5 getters ... no issue - ran [es5-getter-ember-codemod](https://github.com/rondale-sc/es5-getter-ember-codemod) - [es5 getters RFC](https://github.com/emberjs/rfcs/blob/master/text/0281-es5-getters.md) - updates the majority of `object.get('property')` with `object.property` with exceptions: - `.get('nested.property')` - it's not possible to determine if this is relying on "safe" path chaining for when `nested` doesn't exist - `.get('config.x')` and `.get('settings.x')` - both our `config` and `settings` services are proxy objects which do not support es5 getters - this PR is not exhaustive, there are still a number of places where `.get('service.foo')` and similar could be replaced but it gets us a long way there in a quick and automated fashion	2019-03-06 13:54:14 +00:00
Austin Burdine	ad5528b078	Remove ember-invoke-action (#978) ... closes TryGhost/Ghost#9477 - remove ember-invoke-action in favor of straight function calls	2018-03-20 14:57:59 +00:00
Kevin Ansfield	48e3bf003d	ESLint: Consistent ember property/method ordering ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md	2018-01-12 12:17:56 +00:00
Kevin Ansfield	a85f5fae35	Switch to eslint-plugin-ghost extending plugin:ghost/ember ... no issue - fix lint errors in lib/gh-koenig - fix ghost:base eslint errors - update ember plugin refs, remove ember-suave plugin refs - remove old jshint refs - add `lint:js` script - switch to `eslint-plugin-ghost` extending `plugin:ghost/ember`	2018-01-12 12:17:56 +00:00
Kevin Ansfield	f25624234f	Avoid leaking state in Ember objects ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/avoid-leaking-state-in-ember-objects.md	2017-11-25 09:49:49 +00:00
Kevin Ansfield	3864584f74	Bump ember-ajax dependency (#902) ... no issue - upgrade `ember-ajax` to 3.0.0 - `ember-ajax` [now passes the payload through directly](https://github.com/ember-cli/ember-ajax/releases/tag/v3.0.0) rather than trying to normalize it so all our error handling needed to be updated	2017-11-03 22:59:39 +00:00
Kevin Ansfield	9adbcd1fd0	Match service/controller import to ember-modules-codemod style for consistency ... no issue Automated tools, code generators, and editor integrations are increasingly standardising on the import style used in `ember-modules-codemod`. Our import style differed a little with regards to service/controller injection imports which meant we were starting to see inconsistent naming.	2017-10-30 09:38:01 +00:00
Kevin Ansfield	9ed5aad186	Flatten nested components (#854) ... no issue - the upcoming Module Unification re-organisation in Ember will no longer support nested components - this PR pre-emptively moves our usage of nested components into a flat file structure	2017-09-11 14:41:17 +07:00