4 Commits

Author	SHA1	Message	Date
Kevin Ansfield	8cbf2a5eea	Fixed transformer error when saving invalid twitter/facebook URLs ... closes https://github.com/TryGhost/Team/issues/746 - `.match()` returns `null` if there's no match which then breaks the array destructuring	2021-07-14 15:24:17 +01:00
Kevin Ansfield	ba4c53134f	Upgraded eslint-plugin-ghost and fixed new linter errors ... no issue - update imports for `@ember-data` package (https://github.com/emberjs/rfcs/blob/master/text/0395-ember-data-packages.md) - use `computed.reads` where applicable (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-computed-macros.md) - fix usage of `scheduleOnce` so that functions are only scheduled once (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-incorrect-calls-with-inline-anonymous-functions.md)	2020-01-16 17:01:12 +00:00
Kevin Ansfield	e74e2e039e	Update code to match eslint rules ... no issue - switch `jscs` and `jshint` inline config to `eslint` config - fix eslint errors, predominantly in tests where the config now the main app config more closely	2016-11-14 13:26:00 +00:00
Aileen Nowak	01e52013e7	Fixes error in validation ... closes #6826 - refactors the validation of facebook and twitter input field in `general.js` and `user.js` controller - Example validations for facebook: - `facebook.com/username` will be corrected to the full URL - `user` will show error `Your Page name is not a valid Facebook Page name' for `general.js` and `Your Username is not a valid Facebook Username` for `user.js` as the username in facebook has to be at least 5 characters long - `twitter.com/username` will be autocorrected to the valid facebook URL incl. the `username` - Example validations for twitter: - `twitter.com/user_` will be corrected to the full URL - `user:99` will show error `Your Username is not a valid Twitter Username` - `facebook.com/username` will be autocorrected to the valid twitter URL incl. the `username` - updates both acceptance tests - adds further validation for facebook pages in general settings and user. Submitting a url which incl. `/page/` or `/pages/` will now accept any username followed incl. further `/`. - adds a custom transform `facebook-url-user` which will extract the username (if it's a facebook page, incl. `pages/`) to store only this in the backend - uses the `twitter-url-user` transform now also for user	2016-05-17 17:44:23 +01:00