TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 14:43:08 +03:00
Code Issues Projects Releases Wiki Activity
359 Commits 227 Branches 1,677 Tags 368 MiB
52cfac284f
Commit Graph

359 Commits

Author SHA1 Message Date
James Morris
52cfac284f Added in some spacing to the CTA when there are comments 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 16:41:57 +01:00
Simon Backx
163367dd93 Removed transformApiSiteData import 2022-08-11 17:29:37 +02:00
Simon Backx
58d32b3c82 Implemented dark mode tests 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-11 17:28:41 +02:00
Simon Backx
ef4cfc9b9a Readded auth frame test and improved test structure 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-11 17:11:26 +02:00
James Morris
6abd6f6d03 Updated the report dialog to a nicer style 
refs https://github.com/TryGhost/Team/issues/1778
 2022-08-11 16:07:37 +01:00
Simon Backx
fd21a88d52 Added first basic comments test 2022-08-11 16:40:10 +02:00
James Morris
3b7d26154e Added in the comment border line when replying with no replies 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 15:35:04 +01:00
James Morris
91134ecb62 Pushed some changes to the profile modal for comments 
- Includes a fix to the close button when on mobile
- Has some tweaks suggested by Zimo to bring in line with Portal

refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 15:30:34 +01:00
Simon Backx
24f384b0a2 Fixed calculating if reply form is in viewport 2022-08-11 15:16:36 +02:00
James Morris
e130c2edcd Tweaked non-published comments in dark mode 
refs https://github.com/TryGhost/Team/issues/1775
 2022-08-11 13:57:35 +01:00
James Morris
1e72a267a3 Pushed a little fix to the dark mode for the comment border 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 13:53:42 +01:00
Simon Backx
ceaecf43e6 Updated form to only close when another form opens and scroll better 
fixes https://github.com/TryGhost/Team/issues/1753
refs https://github.com/TryGhost/Team/issues/1758

- Scroll only if form is not in viewport + scroll to center
- Fixes: You can’t tap reply if another reply box is open (or at least you have to tap a bunch of times)
 2022-08-11 14:46:14 +02:00
James Morris
4a0ad8c6bc Little style tweaks to comment replies border and pagination border 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 12:41:27 +01:00
James Morris
6db7d9bd2d Fixes for super long expertise in form and comments 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-11 12:35:38 +01:00
James Morris
5e8ebe44b8 Adding in a subtle border for the comments when it has replies 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 11:54:28 +01:00
James Morris
9a306a2db2 Posted a few little tweaks to the deleted/hidden comment 
refs https://github.com/TryGhost/Team/issues/1775
 2022-08-11 11:26:05 +01:00
James Morris
ba8df169ad Changed the markup layout of the comments to fix a positoning problem when expertise is too long on mobile 
- When the Expertise is too long, it can cause a broken look to comments on mobile
- Changed how the markup works to better handle the details
 2022-08-11 10:09:14 +01:00
James Morris
0cf0c5833a This seems to fix the modal zooming on iOS 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-11 09:16:55 +01:00
Simon Backx
12b224e17a v0.6.0 2022-08-11 10:03:22 +02:00
James Morris
a64f13ae2d Some attempts to fix some issues with comments on mobile 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-10 17:36:00 +01:00
James Morris
bcad43c5a4 Added back the padding so comment boxes don't open full width again on desktop 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-10 17:36:00 +01:00
James Morris
0ae689dbfb Added a small tweak to CTAs on mobile 
refs https://github.com/TryGhost/Team/issues/1754
 2022-08-10 17:36:00 +01:00
Simon Backx
94d72c2846 Wired up publication name attribute 
fixes https://github.com/TryGhost/Team/issues/1776
 2022-08-10 17:34:28 +02:00
Simon Backx
35ed0af99d Fixed releasing mouse outside modals closing it 
fixes https://github.com/TryGhost/Team/issues/1769
 2022-08-10 16:45:45 +02:00
Simon Backx
bf9e190e15 Added reply pagination (#7) 
refs https://github.com/TryGhost/Team/issues/1723

- Moved usage from likes_count to count.likes
- Implemented real reply pagination based by an ID filter
- The backend now returns the relations correctly when creating new comments, so we don't need to fix them any longer.
 2022-08-10 16:14:42 +02:00
Simon Backx
b703ddd703 Fixed C keyboard shortcut when input is focused 
fixes https://github.com/TryGhost/Team/issues/1767

- Only focus the form if there is no other input focused on the page
 2022-08-10 15:46:14 +02:00
James Morris
1640901114 Added in the accent colour to the add details modal for comments 
refs https://github.com/TryGhost/Team/issues/1768
 2022-08-09 19:12:22 +01:00
James Morris
56facd62aa Adding more tweaks to the modals to ensure works well across platforms 
refs https://github.com/TryGhost/Team/issues/1756
 2022-08-09 18:58:21 +01:00
James Morris
82cc974549 Updated the copy and logic for the CTAs 
refs https://github.com/TryGhost/Team/issues/1754
 2022-08-09 18:29:07 +01:00
Fabien "egg" O'Carroll
fbdb70330f v0.5.0 2022-08-09 15:15:41 +01:00
Fabien "egg" O'Carroll
37db4df98a Added handling for updating comment count based on local actions 
refs https://github.com/TryGhost/Team/issues/1761
 2022-08-09 13:41:14 +01:00
Fabien "egg" O'Carroll
b908db41d1 Fixed pluralisation for comment count when there is just one 2022-08-09 13:41:14 +01:00
Fabien "egg" O'Carroll
4b453a8b3a Updated comment count to use the /comments/count API 
refs https://github.com/TryGhost/Team/issues/1763

We still need to use the pagination for the other checks because these
are based on how many comments are visible, which includes deleted or
hidden comments.

By using the /comments/count API we ensure that any changes to the
calculation of comments is replicated by both the comment_count
helper, as well as the comments-ui
 2022-08-09 13:41:14 +01:00
James Morris
3a48518407 Few adjustments to the CTAs 
- Keep tweaking the spacing
- Added a plan link for paid CTAs

refs https://github.com/TryGhost/Team/issues/1754
 2022-08-09 13:12:08 +01:00
James Morris
20fe790e5d First round of improving the name and bio modal 
refs https://github.com/TryGhost/Team/issues/1756
 2022-08-09 12:40:59 +01:00
James Morris
2629c5704d Combining the two CTA boxes into one and updating the copy 
refs https://github.com/TryGhost/Team/issues/1754
 2022-08-09 08:50:10 +01:00
James Morris
ac3dd62e6e Added in a hover state for editng bio 
- Improved the affordance for editing bio
- Added a new edit icon for this

refs https://github.com/TryGhost/Team/issues/1756
 2022-08-08 16:22:46 +01:00
James Morris
2b2b7c540b First round of CTA and empty state updates based on feedback 
- Added in a new line for further explanation
- Adjusted various text sizes and spacings
- Put back in the bottom border
- Currently has a hardcoded publication name for wiring up

refs https://github.com/TryGhost/Team/issues/1754
 2022-08-08 15:12:19 +01:00
James Morris
fa9b22e2c6 Removed the left and right spacing around the textbox when there are no comments 
refs https://github.com/TryGhost/Team/issues/1752
 2022-08-05 14:57:08 +01:00
Simon Backx
a1a0bf6723 Fixed blinking when bluring reply form 
fixes https://github.com/TryGhost/Team/issues/1749

Transition syntax was not working, and unused. The transition component also caused a delay, which caused the blinking.
 2022-08-05 15:24:38 +02:00
James Morris
a84bcc3d30 Removed the bottom margin from signed out boxes 
- After some trying things out, just removed that now
- There should be no more bottom spacing apart from what's in the iFrame now

refs https://github.com/TryGhost/Team/issues/1747
 2022-08-05 14:22:24 +01:00
Simon Backx
648ecd6bae Fixed first comment of a post nos showing until a refresh 
fixes https://github.com/TryGhost/Team/issues/1748
 2022-08-05 15:04:23 +02:00
Simon Backx
5d844b2122 Updated submit keyboard shortcut 
refs https://github.com/TryGhost/Team/issues/1725

- CTRL + Enter or CMD + Enter is now supported
- Removed ESC + CMD
 2022-08-05 14:58:54 +02:00
Simon Backx
164fdcbeb2 v0.4.0 2022-08-05 11:47:52 +02:00
James Morris
5b89bd0818 Changed the padding on the iFrame to work better with themes 
- There were left over paddings that were present with old design
- Stripping back the paddings to have better placement in more themes without adjustment

refs https://github.com/TryGhost/Team/issues/1747
 2022-08-05 10:28:18 +01:00
James Morris
b3a71d8c94 Fixed the avatar icon to only show if there is no image but no name 
- This changes the behaviour of the Avatar component to show the icon properly
- This removes a parameter from the Avatar component

refs https://github.com/TryGhost/Team/issues/1746
 2022-08-05 09:59:05 +01:00
Simon Backx
1c878615a8 Fixed comments of deleted members throwing error 2022-08-05 10:15:50 +02:00
James Morris
7ecf063b42 Added an icon for when there is no member name on comment box 
- This replaces the A that showed which was a bit confusing
- Icon may still change but it feels better than what was there before
- Added new parameter for Avatar component for Blank and Anonymous

refs https://github.com/TryGhost/Team/issues/1746
 2022-08-04 17:30:33 +01:00
James Morris
e4e4c07fa0 Change the title of the modal for name and bio for comments 
- Trying out a new modal title as it's easier to read
- Also, works better on mobile for the modal

refs https://github.com/TryGhost/Team/issues/1716
 2022-08-04 16:49:39 +01:00
James Morris
758651013d Tidying up dialog calls for bio with correct autofocus 
- Removed only showing bio in modal, now showing both always
- Changed how the modal is called with parameters to focus on bio if clicked

refs https://github.com/TryGhost/Team/issues/1716
 2022-08-04 16:46:22 +01:00