TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-19 16:42:17 +03:00
Code Issues Projects Releases Wiki Activity
34,826 Commits 249 Branches 1,686 Tags 376 MiB
5bfbd5a7a0
Commit Graph

17920 Commits

Author SHA1 Message Date
Naz
34f7b77190
Fixed collections snapshot 
no issue

- The snapshot has save a wrong amount of "pages" for collections and was falsely passing after a retry. The correct amount should be 6.
 2023-06-14 14:17:23 +07:00
Peter Zimon
15ec9f0d14 Added page header component in AdminX 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-14 09:13:00 +02:00
renovate[bot]
52af10fef5 Update dependency lib0 to v0.2.78 2023-06-14 08:55:45 +02:00
renovate[bot]
77cc3aa2c0 Update dependency @storybook/addon-styling to v1.3.0 2023-06-14 08:55:26 +02:00
Peter Zimon
8820efa80b AdminX Design System component structure cleanup 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-14 08:35:51 +02:00
renovate[bot]
24ea03b3fe Update dependency @babel/plugin-proposal-decorators to v7.22.0 2023-06-14 08:24:59 +02:00
renovate[bot]
e7289e755a Update storybook monorepo to v7.0.20 2023-06-14 08:24:23 +02:00
renovate[bot]
10d60d7fe1 Update dependency ember-auto-import to v2.6.3 2023-06-14 08:12:55 +02:00
Peter Zimon
d2c78b0129 Refined official theme list in AdminX 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-14 08:04:57 +02:00
Gary Lai
a74b60a025
Updated traditional Chinese translations (#17011) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-14 07:54:44 +02:00
renovate[bot]
a086f1f680 Update dependency @embroider/macros to v1.11.1 2023-06-14 07:52:01 +02:00
Jono Mingard
899fd4d29c Updated official themes to show installed/activated in AdminX 
refs https://github.com/TryGhost/Team/issues/3432
 2023-06-14 15:59:42 +12:00
Jono Mingard
ae0989ebea Added a basic theme install API call in AdminX settings 
refs https://github.com/TryGhost/Team/issues/3432
 2023-06-14 15:52:41 +12:00
Jono Mingard
7832f5c685 Added tier selection for default post access in AdminX 
refs https://github.com/TryGhost/Team/issues/3151
 2023-06-14 12:29:11 +12:00
Rishabh
902fb999a2 Updated official themes view in adminX 
refs https://github.com/TryGhost/Team/issues/3432

- updated theme preview urls to use admin assets
- updated theme selection preview to include full theme info
 2023-06-13 22:36:54 +05:30
Rishabh
36ced958f8 Wired theme change UI in adminX 
refs https://github.com/TryGhost/Team/issues/3432

- wires list of installed themes
- allows actions on themes like upload, activate, delete and download
- cleans up theme modal content and toolbar into granular components
 2023-06-13 22:00:49 +05:30
Rishabh
3dbc2ee507 Added theme management hooks in adminX 
refs https://github.com/TryGhost/Team/issues/3432

- adds new `useRequest` hook to manage API requests
- adds new `useThemes` hook that allows fetching and updating themes
- adds models pattern to store specific type and helper info for themes
 2023-06-13 22:00:49 +05:30
Daniel Lockyer
01e90dfb65 Extracted regression tests to a separate workflow 
refs https://github.com/TryGhost/Toolbox/issues/592

- this commit extracts the regression tests into a separate workflow
- this means they run in parallel and reduce the time we have to wait
  for DB tests in general
- also fixes a test that was reliant on being run after the E2E
  tests (!)
 2023-06-13 16:47:19 +02:00
Daniel Lockyer
082ab6dc3e Refactored truncateAll util to async-await 
refs https://github.com/TryGhost/Toolbox/issues/592

- async-await makes the code easier to read
- also performs a small optimization to only load the foreign_keys
  pragma once for SQLite
 2023-06-13 14:46:57 +02:00
Elena Baidakova
9f1279b58e
🐛 Fixed snippet insertion in the new editor (#17003) 
refs TryGhost/Team#3445
- The snippet model always expects an object as it gets serialized when
saving - if we give it a string, it gets doubly serialized. It breaks
snippet replacement and insertion in the new editor.
 2023-06-13 15:51:23 +04:00
Daniel Lockyer
6a9d01c6ad
Removed superfluous GHA workflow 
- this was left here when we moved Sodo-Search into the monorepo but
  isn't needed now
 2023-06-13 13:44:49 +02:00
Peter Zimon
6023bddafc Replaced tab component in themes (AdminX) 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-13 13:11:44 +02:00
Peter Zimon
1071d4437c Updated 'upload theme' component in AdminX 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-13 13:11:44 +02:00
Daniel Lockyer
264773ccd1 Reset URL service between test boots 
refs https://github.com/TryGhost/Toolbox/issues/592

- we should reset the URL service to avoid event listeners piling up and
  slowing down CI due to the number of events it has to process
 2023-06-13 12:52:03 +02:00
Daniel Lockyer
cedfb14924 Fixed random timeouts with mysql2 library during tests 
refs https://github.com/TryGhost/Toolbox/issues/592

- heads up, I'm not really sure about this fix
- when we're wrapping `setTimeout`, time stops and mysql2 starts doing
  weird things because we then shift time and it hits timeouts
- apparently `shouldAdvanceTime` should fix this by automatically
  incrementing time along with the system clock
- given the problem is quite difficult to hit, I could just be seeing a
  lack of this due to some other factor
- also removed unnecessary sinon sandbox creation as this is superfluous
 2023-06-13 12:52:03 +02:00
Fabien 'egg' O'Carroll
7e1efd97e8
🐛 Fixed Post History for posts sent as an email (#16999) 
refs https://github.com/TryGhost/Team/issues/3458

From the discussion in slack, for all published/sent posts:
  Published only --> view history & restore
  Published & sent --> view history & restore
  Email only --> history hidden

And for all unpublished/unsent posts:
  All states --> view history & restore.
 2023-06-13 12:38:39 +02:00
Naz
7717021331 Added GET /collections/:id/posts endpoint 
refs https://github.com/TryGhost/Team/issues/3423

- The Admin API endpoint allows to browse collection posts and paginate over them
 2023-06-13 17:23:09 +07:00
Naz
ddc23b3467 Added collection's posts fetching to collections lib 
refs https://github.com/TryGhost/Team/issues/3423

- This is a building block to allow paging, querying etc. of the posts belonging to a collection
 2023-06-13 17:23:09 +07:00
Peter Zimon
db1c4e6381 Restructured components for theme mngmt in AdminX 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-13 12:20:29 +02:00
Peter Zimon
09b404acd2 Fixed modal footer bug in AdminX 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-13 12:16:19 +02:00
Peter Zimon
58f51a1838 Updated theme setting copy in AdminX 
refs. https://github.com/TryGhost/Team/issues/3432
 2023-06-13 12:05:52 +02:00
Hannah Wolfe
b80b90229f Added consistent linting pattern to all packages 
refs: https://github.com/TryGhost/Toolbox/issues/188

- some of our older packages used a pattern for linting which missed using test config for linting tests
- we need this to be consistent so that we can add more eslint rules for testing
- two packages also didn't use the lib pattern, which made the lint pattern error - so this was fixed as well
 2023-06-13 10:43:29 +01:00
Rishabh Garg
b697ca2768
Added basic theme settings design in AdminX (#17000) 
refs https://github.com/TryGhost/Team/issues/3432

- adds basic design structure for theme settings/management in adminX

---------

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
 2023-06-13 14:27:29 +05:30
Rishabh
5cc1c43257 Added theme management apis in adminX 
refs https://github.com/TryGhost/Team/issues/3432
 2023-06-13 13:24:47 +05:30
Jono Mingard
778e9a5f96 Added offers support in default recipients 2023-06-13 18:48:45 +12:00
Jono Mingard
731858e9e0 Added tier and label selection in default recipients 
refs https://github.com/TryGhost/Team/issues/3151
 2023-06-13 18:48:45 +12:00
Ronald Langeveld
c0e638fecd Added membersEnabled config to lexical editor 
refs https://github.com/TryGhost/Team/issues/3456

- adds a boolean config whether members signup is enabled so that we can
  hide the signup card option from the editor if it's not enabled.
 2023-06-13 08:47:16 +02:00
Jesús
a98f25b37a
Updated Catalan translations (#16992) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-13 08:33:15 +02:00
Yin Guobing
8bc04e9e6e
Updated Chinese translations (#16995) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-13 08:31:23 +02:00
Ghost CI
6c25f4cb08 Merged v5.51.1 into main 2023-06-13 05:52:58 +00:00
Ghost CI
e990bf5a94 v5.51.1 2023-06-13 05:52:56 +00:00
Steve Larson
d857e0ef15 Upgraded koenig lexical dependencies 
no refs
 2023-06-12 16:49:21 -05:00
Steve Larson
e742283ec8 Bumped koenig lexical dependencies 
no refs
-added a couple more fixes: callout card rendering, code editor wrapping
 2023-06-12 16:48:18 -05:00
Steve Larson
fd7b30fac0 Updated koenig lexical dependencies 
no refs
-various fixes, including renderer for embed cards
 2023-06-12 12:17:46 -05:00
Steve Larson
1345afdd71 Updated koenig lexical dependencies 
no refs
-updated to fix embed card rendering
 2023-06-12 12:08:19 -05:00
Daniel Lockyer
af8c0dc7a5 Prevented registering multiple Slack event listeners 
refs https://github.com/TryGhost/Toolbox/issues/592

- in tests, we boot Ghost over and over
- this inits all the services each time
- it turns out that the Slack event listener is registered 80+ times
- to prevent this, we can check if it has already been registered, like
  we do with webhooks: 4639396c3a/ghost/core/core/server/services/webhooks/listen.js (L67-L69)
- not sure about this pattern in general, but it's something we can
  review in coming weeks
 2023-06-12 15:04:11 +02:00
Daniel Lockyer
4639396c3a
Collected Ghost boot timing in test framework 
refs https://github.com/TryGhost/Toolbox/issues/592

- this should help us track and calculate how much time is being spent
  in the boot/DB reset process during tests
 2023-06-12 12:07:04 +02:00
Daniel Lockyer
3ac28c7a95
Fixed snapshot for settings 
- this deviated somewhere, which I am investigating
 2023-06-12 10:04:50 +02:00
Raka Afp
078aa72a2d
Updated Bahasa Indonesia translations (#16981) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-12 09:47:07 +02:00
EchoBilisim
eca84d61c4
Updated Turkish translation (#16979) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-12 09:45:13 +02:00
EchoBilisim
9d8c9cda09
Updated Turkish translation (#16982) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-12 09:44:18 +02:00
Naz
bb4e2fcadb
Added "index" built in collection 
closes https://github.com/TryGhost/Team/issues/3425

- Index collection is needed to support one of the usecases we have in the near future where we'd hold all posts that would be displayed on the "index" page.
 2023-06-12 12:57:52 +07:00
Naz
6421e202e5
Removed API endpoints adding posts to collections 
closes https://github.com/TryGhost/Team/issues/3431

- We don't currently have a clear usecase to use the new pattern of updating posts as nested resource (of a collection). To simplify the API we are sticking with the approach of controlling where the post belongs to only through the Posts Admin API.
 2023-06-12 12:08:37 +07:00
Jono Mingard
345d90bbba Added homepage/post URL selection in AdminX design settings 
refs https://github.com/TryGhost/Team/issues/3354
 2023-06-12 13:46:14 +12:00
Jono Mingard
ba2436e834 Fixed type errors in storybook 2023-06-12 11:10:53 +12:00
Jono Mingard
c3f6d77fd9 Added simple tests for design modal 
refs https://github.com/TryGhost/Team/issues/3354
 2023-06-12 11:04:19 +12:00
Jono Mingard
90c269275e Factored out useForm from useSettingGroup to be useful in more places 
refs https://github.com/TryGhost/Team/issues/3151
 2023-06-12 10:01:13 +12:00
Steve Larson
d1b5bf0a80 Updated koenig lexical dependencies 
no refs
 2023-06-09 12:22:01 -05:00
Steve Larson
88c3412cd4 Updated koenig lexical dependencies 
no refs
 2023-06-09 12:11:37 -05:00
renovate[bot]
ae3e38a14d Update dependency concurrently to v8.2.0 2023-06-09 17:39:51 +02:00
Ghost CI
2744d9a58b v5.51.0 2023-06-09 15:03:06 +00:00
Rishabh
eaf5aaade2 Updated site preview to handle theme settings 
refs https://github.com/TryGhost/Team/issues/3354

- wires theme settings to site preview frame, dynamically updating the preview when theme settings change
 2023-06-09 20:06:06 +05:30
Naz
f7e2f82089 Enabled collections permissions in controller 
refs https://github.com/TryGhost/Team/issues/3220

- With permissions in place in the database, they can be enabled on controller level.
 2023-06-09 21:13:06 +07:00
Naz
05bb82cf1a Added collections CRUD permissions 
refs https://github.com/TryGhost/Team/issues/3220

- Added permissions for collection resources
 2023-06-09 21:13:06 +07:00
Simon Backx
2a263c1024 Updated Signup Form to v0.1 
no issue
 2023-06-09 14:32:17 +02:00
Simon Backx
c3abd3a021 Released Signup Form v0.1.0 2023-06-09 14:31:32 +02:00
Peter Zimon
2d3ab08724 Experimenting with sticky footers in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:29:39 +02:00
Peter Zimon
4e5523674c Updated twitter and FB settings tests in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:16:56 +02:00
Peter Zimon
33ea5486df Updated user detail modal buttons in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:16:56 +02:00
Simon Backx
6d6da2492c Fixed showing errors when non 2XX response in signup form 
no issue
 2023-06-09 14:12:09 +02:00
Rishabh
c26f77586a Added dynamic site preview iframe 
refs https://github.com/TryGhost/Team/issues/3354

- adds dynamically loading iframe with site preview based on preview data in Admin
 2023-06-09 17:39:53 +05:30
Simon Backx
a4b24b1c7a Filled in signup form translation contexts 2023-06-09 13:54:23 +02:00
Simon Backx
08b37395cf Added translated placeholder in signup form embed 
no issue
 2023-06-09 13:48:43 +02:00
Simon Backx
381149e45b Added signup form button animation (minimal) 
no issue
 2023-06-09 12:07:57 +02:00
Sanne de Vries
afe18d54de Added email icon to signup form success page 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#de29f9cc1a364a12a4a0eeebef68f3a4
 2023-06-09 11:35:36 +02:00
Simon Backx
5e7edb9da5 ✨ Added embeddable signup form 
refs https://github.com/TryGhost/Team/issues/3274

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
 2023-06-09 11:30:03 +02:00
Peter Zimon
90b9959afc Set up showing images in brand settings (AdminX) 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 11:26:56 +02:00
Simon Backx
ffa6c9c5f8 Added width:100% to minimal signup form CSS 
no issue

Otherwise the auto margin would cause issues in a grid or flex container.
 2023-06-09 11:08:14 +02:00
Simon Backx
66840cda0a Fixed minimal form padding 
no issue

Previous change made the viewport always maximum 440px, so it always triggered the `sm` breakpoint
 2023-06-09 11:06:50 +02:00
Sanne de Vries
6cdaf04fcd Updated NL translations for Portal and Signup Form 
No ref
 2023-06-09 10:53:22 +02:00
Simon Backx
12f7fd0153 Updated minimal signup form to be centered by default 
no issue

Added `margin: 0 auto;` css by default.
 2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055 Moved maximum width and centering outside minimal signup form 
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999

- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
 2023-06-09 10:42:24 +02:00
Simon Backx
f4a822e7e0 Removed success page for minimal signup form 
no issue

Shows the success state in the button now.
 2023-06-09 10:26:05 +02:00
Naz
c507ea9600 Improved oversized batch correction logic 
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- After analyzing data dumps, the data revealed that we have extra data from a stray batch. The filtering logic manually filters out the data to the recipients that belong to a "current batch".
- Hunting down the root cause of the data mixup proved to be too expensive of an investigation, so this is a "good enough patch" to deal with the problem.
- Most likely cause is the concurrent batch sending, but reducing the concurrency would be too expensive of a performance price to pay instead of filtering the data rarely.
 2023-06-09 14:40:12 +07:00
Fabien "egg" O'Carroll
643fbbbb1f Removed collections from stable list in Admin API 
We had to add these so that they could be played with programatically
but now we have a god_mode flag, we can remove them.
 2023-06-09 09:31:44 +02:00
Fabien "egg" O'Carroll
29a403cc68 Supported a god_mode param in the Admin API 
This currently skips the not-implemented middleware and can be used to
access experimental endpoints whilst in development.
 2023-06-09 09:31:44 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal (#16971) 
Refs https://github.com/TryGhost/Team/issues/3407

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f Updated signup form embed settings copy 
No ref
 2023-06-09 08:26:21 +02:00
renovate[bot]
58f48d2e0a Update dependency @playwright/test to v1.35.0 2023-06-09 08:25:51 +02:00
Naz
efac36c36c
Removed data dump during email batching 
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- Having a data dumped in production was a one-off trick to allow us debug the error. Now that we have data it's no longer needed.
 2023-06-09 10:44:13 +07:00
Simon Backx
7e47bff92f Released Signup Form v0.0.3 2023-06-08 16:35:54 +02:00
Simon Backx
c5fbd8bae6 Added Plausible events when copying the signup form embed code 
fixes https://github.com/TryGhost/Team/issues/3389
 2023-06-08 15:51:32 +02:00
Sanne de Vries
9d93d21a2d Fixed signup form modal height 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
- Previous commit broke the height as the negative margin should've only been applied horizontally
 2023-06-08 14:18:16 +02:00
Sanne de Vries
7a74563e21 Fixed scrollbar position in signup form modal 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
 2023-06-08 14:06:31 +02:00
Simon Backx
5949d6a8d4 🐛 Fixed closing modals in admin UI when releasing mouse outside modal 
no issue

When selecting text, and releasing your mouse outside the modal, the modal would close.
 2023-06-08 13:50:44 +02:00
Simon Backx
5658f4b627 Fixed admin failing tests 
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
 2023-06-08 13:38:13 +02:00
Zabriskije
f3b60e6c6f
Updated Italian translations (#16966) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-08 13:33:18 +02:00
Markus Härnvi
bd679e0a81
Updated Swedish translations (#16964) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-08 13:32:11 +02:00
Simon Backx
a68ac4b688 Renamed data-logo to data-icon in signup embed attributes 
fixes https://github.com/TryGhost/Team/issues/3401
 2023-06-08 13:23:38 +02:00
Simon Backx
a1e632abe0 Removed page color in signup form Storybook preview component 
no issue

The Storybook did set the color, but that shouldn't be set because normally the components are always rendered in an iframe, with a default black, unchangeable color.
 2023-06-08 13:17:54 +02:00