Commit Graph

787 Commits

Author SHA1 Message Date
Rish
5cce6138e5 Added Portal links section in preview area
closes https://github.com/TryGhost/members.js/issues/80

- This adds the link/attribute switcher and chooser directly to Admin in Portal preview area
- Thinks links/attributes section was previously shown as a Portal page
2020-08-05 11:36:26 +05:30
Kevin Ansfield
970df7fba7 🐛 Fixed missing autosave indicator regression in editor
refs https://github.com/TryGhost/Ghost/issues/12098

- the component template was directly referencing `this._isSaving` which meant that the `this.isSaving` getter was never fetched and so no autotracking was set up for `this.args.isSaving` to trigger the task that updates `this._isSaving`
2020-08-03 09:51:06 +01:00
Peter Zimon
f937bf2790 Updated Portal settings preview style
no refs.
- updated preview window style for portal so that it fits with the rest of the screen
2020-07-30 16:38:47 +02:00
Peter Zimon
a199e87201 Updated single member delete design
no issue
- updated single member delete modal copy + design layout
- swapped switch to regular checkbox + applied red color to it
- set button label based on checkbox state
2020-07-27 13:32:40 +02:00
Peter Zimon
9e9dcf4d1a Updated default Portal icons
no refs.
- added a set of portal icons
- updated related CSS and mappings
2020-07-24 17:00:46 +02:00
Fabien 'egg' O'Carroll
28a2caec98 Updated delete member UI to add toggle to cancel subscriptions (#1647)
no-issue

* Supported cancellation of subscriptions on delete

This makes the cancellation of subscriptions much more obvious to the
user, and we err on the side of caution by *not* cancelling by default.

* Updated base adapter to handle urls with query params

After creating the member adapter and overriding the urlForDeleteRecord
method the flow would take the url from that and it would get passed
into the buildUrl method of the base adapter. At this point it would
append a "/" _after_ the query param.

It would ouput http://admin.com/ghost/api?query=blah/
rather than http://admin.com/ghost/api/?query=blah
2020-07-24 16:02:42 +02:00
Hannah Wolfe
1cce69a1e2 Updated host limit message to be clearer
- limits are based on total members not number of members that will be emailed
2020-07-23 18:24:33 +01:00
Rish
bb53379eb1 Updated portal preview iframe url
no issue

- Updates url to load portal preview to use more specific path by appending `/preview`  in hash path
- Allows portal script to validate preview mode easily instead of guessing based on query string
2020-07-23 21:03:42 +05:30
Kevin Ansfield
3b78973a21 Removed bulk member edit dev experiment
no issue

- we're moving forward with a simplified bulk delete and the UI would conflict if both approaches are behind the dev experiments flag
2020-07-23 15:03:18 +01:00
Kevin Ansfield
42b3e3a412 Added automatic filter of members list after CSV import
requires 8ceabbcfba

- if the API responds with `meta.import_label` after an import, use it to reset and apply the filter across the members list so that it's quick to see the results of the import and perform further bulk actions (coming later)
- added ability to pass arguments through `<GhFullscreenModal>`'s `@confirm` action
- added a `console.error()` call to the members csv import so that any underlying error is not completely lost by the custom error handling
2020-07-23 14:15:07 +01:00
Rish
b9e9265c45 Updated default icon handling for portal settings
no issue

- Adds mapping for default svg icons to keys
- Updates custom icon check to not include default icons
- Updated settings update to save default icon key on update
2020-07-22 16:16:29 +05:30
Rish
c6a42a925c Updated portal preview setting for free plan selection
no issue

- Portal preview's free plan selection for Signup in settings was disabled because of old setting check
- Updates the disabled check to use correct self signup property
2020-07-22 13:19:37 +05:30
Peter Zimon
369cdf9fa2 Updated Stripe connect disconnect error UI
no refs.
- added logic to show either the disconnect error or the connected status to make the UI less dense
2020-07-17 19:07:20 +02:00
Rish
59ce29e19a Added custom error message handling for newsletter email failures
refs https://github.com/TryGhost/Ghost/issues/11971

- Newsletter preview email request has been using hardcoded fixed error message
- Reads custom error message from server's API response to show when available
2020-07-17 13:54:31 +05:30
Peter Zimon
42240c8be0 Refined Portal settings main area topbar
no refs.
- changed preview tab style to buttons for better discoverability
2020-07-17 09:53:15 +02:00
Peter Zimon
41daa5fada Moved Portal settings button to top
no refs.
- moved cancel and save buttons to top to save space and resolve conflict with Portal button
2020-07-17 09:19:47 +02:00
Peter Zimon
c30ba921d5 Renamed "Modal settings" to "Portal settings"
no refs.
2020-07-16 16:55:00 +02:00
Peter Zimon
dba7522470 Resized Portal preview iframe
no refs.
- made Portal preview iframe a bit smaller to make sure users get the UI context
2020-07-16 16:51:45 +02:00
Peter Zimon
058193f9e4 Updated Portal preview area tabs
no refs.
- added active style to Portal settings preview area
2020-07-16 16:37:54 +02:00
Peter Zimon
9102f3d51a Styled links section in Portal settings
no refs.
- applied basic styles to link section in sidebar of Portal settings
2020-07-16 16:01:39 +02:00
Peter Zimon
aba652ec56 Portal settings sidebar refinements
no refs.
- refined typography, colors and layout
- using built in admin icons for portal button icon temporarily
- styled icons for future usage with inline svgs
2020-07-16 15:25:09 +02:00
Peter Zimon
7ff098aae6 Basic design cleanup of Portal preview area
no refs.
- applied basic spacing and typography to Portal preview area
2020-07-16 15:25:09 +02:00
Fabien 'egg' O'Carroll
97feab1002 🐛 Fixed email newsletter settings (#1641)
closes https://github.com/TryGhost/Ghost/issues/12052

* Added breaking test for mailgun settings

* 🐛 Fixed mailgun settings to always set a baseUrl

This matches the functionality seen before the bulk_email_settings were
split, where the baseUrl was set when any of the mailgun settings were.
2020-07-16 11:13:36 +02:00
Rish
4b0f1a18d6 Fixed incorrect self-signup setting for portal modal
no issue

- Portal modal was using incorrect `allowSelfSignup` value post settings refactor
- Updated to use correct setting for free signup to correctly disable/enable checkbox
2020-07-16 11:12:00 +05:30
Peter Zimon
9e3a935bd7 Basic Portal sidebar stylings
no refs.
- cleaned up `style` attributes
- applied basic styles to sidebar UI elements
2020-07-15 13:18:58 +02:00
Rish
a38d7ddb19 🐛 Fixed broken structured data previews
closes https://github.com/TryGhost/Ghost/issues/11385

- Updates og and twitter description to use correct fallbacks for posts/pages
- Updates og and twitter description to use correct fallback for tags
- Updates og and twitter title to use correct name format for tags
2020-07-15 12:06:03 +05:30
Fabien 'egg' O'Carroll
ed1aa5262c Fixed typo in tag settings 2020-07-14 15:48:31 +02:00
Peter Zimon
a409a3464e Fixed typos in tag meta data
no refs.
- fixed capitalisation on tag meta data properties
2020-07-13 15:42:34 +02:00
Fabien 'egg' O'Carroll
ffdde799b8 Added UI for setting tag metadata (#1632)
no-issue

* Updated tag model with new metadata fields
* Updated Tag setting UI to handle metadata

Co-authored-by: Peter Zimon <zimo@ghost.org>
2020-07-13 14:58:13 +02:00
Nazar Gargol
2bf69f94e7 Removed developerExperiments flag from behind updated members importer
no issue

- Removes redesigned members importer features from behind `enableDeveloperExperiments` flag enabling it by default for everyone
- Had to disable some of the tests for future investigation to unblock the release
2020-07-13 23:55:07 +12:00
Nazar Gargol
caf08b1021 Fixed members CSV uploader for non-devExperiments version 2020-07-13 20:30:32 +12:00
Nazar Gargol
21a5b2ad38 Updated mapping validation error copy 2020-07-13 17:29:10 +12:00
Nazar Gargol
1465eb7045 Added import validation message when no "Email" mapping selected
no issue

- Ensures the "email" field required to create a member is always present with the mapping
- If the field is not mapped, import would fail for all members
2020-07-13 17:25:56 +12:00
Peter Zimon
f74ca902c2 Added sample CSV link to members import
no refs.
- added link to a sample CSV in members import start screen
2020-07-09 17:30:24 +02:00
Peter Zimon
59ed8d718d Members import refinements
no refs.
- updated and removed copy on mapping screen
2020-07-09 14:42:29 +02:00
Peter Zimon
c611f65f53 Refined members import modal
no refs.
- fixed title logic
- fixed stripe validation message
2020-07-09 12:12:53 +02:00
Nazar Gargol
cf2f12e046 Fixed error message substitutions for members-importer summary 2020-07-09 22:10:38 +12:00
Nazar Gargol
4f56e77db5 Updated members uploader mapper logic to map all known types 2020-07-09 20:52:12 +12:00
Nazar Gargol
21a0bc7aa9 Made more readable two most common member validation errors
no issue

- Because returned validation errors are too technical some of the most common ones were mapped for better human readibility.
- This is a patchwork on the client instead of introducing a lot bigger changes on the server side
2020-07-09 18:39:42 +12:00
Nazar Gargol
3086ac1439 Added upload progress stage to members importer
no issue

- As the number of states for the component has become larger introduced a concept of "stages" on component level to easier track UI changes.
2020-07-09 17:31:28 +12:00
Rish
dc82014283 Fixed check for empty portal button icon
no issue

- Members modal missed check for null portal button icon in initial state for dummy icons
2020-07-08 20:53:29 +05:30
Peter Zimon
3f0f3f1b68 Added number formatting to members import
no refs.
- added number formatting to all the screens of members import
2020-07-08 15:51:12 +02:00
Nazar Gargol
2da05338dd Fixed failure to render gh-members-import-table compontent
refs 4ee30dc5bd

- The tests were failing because there was no protective code to check for empty parameters.
2020-07-08 23:11:07 +12:00
Peter Zimon
5d261bfde8 Added pluralisation to members import
no refs.
- added correct pluralisation to pre- and post-validation copy of members import
2020-07-08 13:09:23 +02:00
Peter Zimon
4ee30dc5bd Added table header data to member import mapping
no refs.
- added counter ("x of y") to "Data" header for member import mapping table
- set disabled style to prev/next buttons in "Data" header for first/last records
2020-07-08 12:23:02 +02:00
Peter Zimon
1b98800bfb Updated members import mapping fields
no refs.
- made mapping fields ("Import as") human readable in members import
2020-07-08 10:18:56 +02:00
Peter Zimon
6511a47524 Fixed tests
no refs.
2020-07-07 18:18:00 +02:00
Peter Zimon
1dd2a3db07 Updated styles for members import
no refs.
- added spinner to validation state
- applied styles to pre-validation step
- applied styles to import results
2020-07-07 17:53:59 +02:00
Peter Zimon
7cc49b4b70 Added long data handling to member import UI
no refs.
- added styles to handle long data for field and data cells in members import mapping table
2020-07-07 13:29:44 +02:00
Peter Zimon
a819837bd4 Refined members import modal dropdown
no refs.
- updated style of members import modal field dropdown
2020-07-07 13:07:21 +02:00