2 Commits

Author	SHA1	Message	Date
Kevin Ansfield	060d791a63	Removed need for .get() with settings service ... no issue The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods. - removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object - updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()` - removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly	2022-10-07 16:14:57 +01:00
Kevin Ansfield	473831ac2b	Added image fallback and site icon/title to <GhPostBookmark> (#2401) ... no issue - adds `{{get-setting "key"}}` helper to make settings available in templates without needing a backing class - updated `<GhPostBookmark>` component - if post feature image isn't present, fall back to site cover image - add site icon (if present) and title to the details line - removed author image Co-authored-by: Sanne de Vries <sannedv@protonmail.com>	2022-05-18 19:05:27 +01:00